Revert "Roll src/third_party/googletest/src/ 0062e4869..ea31cb15f (76 commits)"
This reverts commit 8acd3f23dc70b01733294df652170269cf34fa7b.
Reason for revert: crashes net_unittests in debug Windows builds.
GoogleTest now uses ContainsUnprintableControlCodes() in src/gtest-printers.cc
to check if a test's name contains unprintable characters. Unfortunately, the
ContainsUnprintableControlCodes() is vulnerable to undefined behavior -- it
calls std::iscntrl() on each character in the test name, but processes the
characters as "char", not as "unsigned char". This triggers undefined
behavior.
This was introduced in
https://github.com/google/googletest/commit/e29805aa5d233efca1fc102efcc7bce53cecaa12
The undefined behavior in ContainsUnprintableControlCodes() is triggered by a
parametrized test in net/base/url_util_unittest.cc. The test is
UrlUtilNonUniqueNameTest, and is parametrized on
testing::ValuesIn(kNonUniqueNameTestData).
kNonUniqueNameTestData is an array of structs, and one of the structs is
{ true, "junk)(£)$*!@~#" }. The string gets passed to
ContainsUnprintableControlCodes(), which breaks on £.
Original change's description:
> Roll src/third_party/googletest/src/ 0062e4869..ea31cb15f (76 commits)
>
> https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/0062e4869f07..ea31cb15f0c2
>
> This CL also removes the GTEST_UNSUPPORTED_DEATH_TEST definition from
> //base/test/gtest_util.h. Google Test moved the definition from an
> internal header to the public API, so we don't need to carry a copy
> anymore.
>
> $ git log 0062e4869..ea31cb15f --date=short --no-merges --format='%ad %ae %s'
> 2018-01-31 misterg Merges and also adding new bazel build mode
> 2018-01-30 misterg Code merges
> 2018-01-30 misterg Ability to optionally depend on Abseil plus upstream of 183716547
> 2018-01-26 misterg Adding tests to googlemock bazel
> 2018-01-26 misterg Code merges
> 2018-01-26 lidaobing Update Documentation.md
> 2018-01-25 stefano.soffia.it Fix test build issue with GCC7.2.
> 2018-01-25 gennadiycivil Update README.md
> 2018-01-25 gennadiycivil Remove Visual Studio 10,11,12 from build matrix
> 2018-01-24 misterg placating gcc and its overzeauls size comparison warnings
> 2018-01-24 misterg upstream cl 182543808
> 2018-01-24 misterg revert, lets get this compiled
> 2018-01-23 misterg Many code merge/upstream changes
> 2018-01-23 misterg Merging, upstream http://cl/182836545
> 2018-01-22 misterg more code merge
> 2018-01-22 misterg merges, cl/155419551 and other
> 2018-01-22 misterg more merging
> 2018-01-22 misterg merging
> 2018-01-22 misterg code merge
> 2018-01-18 misterg Adding python tests to Bazel build file.
> 2018-01-18 ftrushkin Use fully qualified in examples
> 2018-01-18 ftrushkin Document ScopedTrace utility
> 2018-01-11 pcc Check whether _MSC_VER is defined when detecting presence of cxxabi.h under libc++.
> 2018-01-17 ftrushkin Expose ScopedTrace utility in public interface
> 2018-01-15 misterg Reverting some changes, need to make the merge compile
> 2018-01-15 misterg Reverting some changes, need to make the merge compile
> 2018-01-15 misterg Reverting some changes, need to make the merge compile
> 2018-01-15 misterg Reverting some changes, need to make the merge compile
> 2018-01-15 misterg Test files for corresponding changes
> 2018-01-15 misterg Test files for corresponding changes
> 2018-01-15 misterg Test files for corresponding changes
> 2018-01-15 misterg Test files for corresponding changes
> 2018-01-15 misterg More code merges
> 2018-01-15 misterg Code merging
> 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
> 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
> 2018-01-11 misterg continue upstream/merge, etc
> 2018-01-11 gennadiycivil Update .travis.yml
> 2018-01-11 gennadiycivil Update .travis.yml
> 2018-01-11 gennadiycivil Update .travis.yml
> 2018-01-11 gennadiycivil Update .travis.yml
> 2018-01-11 misterg Trying to fix travis
> 2018-01-11 misterg Upstream cl 103120214
> 2018-01-10 misterg More merge, cleanup
> 2018-01-10 misterg More merge, cleanup
> 2018-01-10 misterg Code merge, upstreaming accumulated changes, cleanup
> 2018-01-10 misterg revert
> 2018-01-10 misterg code merges, cleanup
> 2018-01-10 misterg revert googletest/test/gtest-param-test_test.cc
> 2018-01-10 gennadiycivil Update .travis.yml
> 2018-01-09 misterg code merge, cleanups
> 2018-01-09 misterg Upstream of cl 129104714
> 2018-01-09 misterg Revert one file
> 2018-01-09 misterg wip, cleanups/merge
> 2018-01-09 misterg cleanup, merge
> 2018-01-07 loorongjie [Bazel] Detect Windows with cpu value x64_windows and x64_windows_msvc
> 2018-01-08 misterg Small cleanups, merge
> 2018-01-05 coryan Use correct name for build event types.
> 2018-01-05 misterg Revert one file for now
> 2018-01-05 coryan Fixed test for pull request.
> 2018-01-05 coryan Fixed output and test for 'enabled_on_pr'
> 2018-01-04 misterg code cleanup in preparation for merges, cl 180857299
> 2018-01-04 coryan Optimize build matrix (#1)
> 2018-01-03 gennadiycivil upstreaming cl 124976692
> 2018-01-03 davidben Also define GTEST_ATTRIBUTE_PRINTF_ in clang-cl.
> 2017-02-10 davidben Pass the -Wmissing-declarations warning.
> 2018-01-02 misterg OSS Sync, cl 163329677
> 2018-01-02 davidben Fix testing::Combine on MSVC 2017.
> 2017-05-06 davidben Avoid warning C4619 in MSVC 2017.
> 2017-12-24 coryan Build both googletest and googlemock.
> 2017-12-24 coryan Create a autotools-based build for Travis.
> 2016-05-18 gregory.pakosz Re-enable MSVC++ C4389 warning in CmdHelperEq()
> 2017-12-03 coryan Run autoconf from top-level directory.
> 2017-12-02 romain.geissler Fix double free when building Gtest/GMock in shared libraries and linking a test executable with both.
> 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
> 2017-01-20 davidben Pass MSVC's C4826 warning.
>
> Created with:
> roll-dep src/third_party/googletest/src
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Icd43abc02683c2398f9e1033509382b9f3000022
> Reviewed-on: https://chromium-review.googlesource.com/900544
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534610}
TBR=thakis@chromium.org,haraken@chromium.org,piman@chromium.org,pwnall@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I6313281011fd9e016384bc7175a033d887b941fc
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Bug: 810347
Reviewed-on: https://chromium-review.googlesource.com/914509
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536244}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6660b93e6d1ab64cf861f3215628254716bb10921 file changed
