| commit | 130031a3b1112502f5b2fc062a74c571dc4e7af1 | [log] [tgz] |
|---|---|---|
| author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Sun Feb 02 16:43:05 2025 |
| committer | Copybara-Service <copybara-worker@google.com> | Sun Feb 02 16:48:13 2025 |
| tree | b39b148b871bbc1bda97a4012d9433dd798c49b6 | |
| parent | 0baff9e0fa321d63b1bf12cf74b92bd0e1ee83be [diff] |
Revert "[iOS][OR] Refactor omnibox popup mediator before move" This reverts commit 28356a9e2e64a86737881d9b84cb92663e0adcc5. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4872134217170944 Sample build with failed test: https://ci.chromium.org/b/8724206892391156065 Affected test(s): [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsAllVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsAllVisible?q=VHash%3Ae6fcf249de8f1255) [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsAllVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsAllVisible?q=VHash%3Af313067e1c194d65) [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsPartVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsPartVisible?q=VHash%3Ae6fcf249de8f1255) [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SuggestionsPartVisible](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SuggestionsPartVisible?q=VHash%3Af313067e1c194d65) [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.UpdateMatchesCount](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.UpdateMatchesCount?q=VHash%3Ae6fcf249de8f1255) and 3 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4872134217170944&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6218548&type=BUG Original change's description: > [iOS][OR] Refactor omnibox popup mediator before move > > Refactor some omnibox popup mediator logic before moving it to the popup > and autocomplete controllers. > This CL: > - inlines updateMatches in updateWithResults. > - removes some references to self.autocompleteResult. > > Bug: 390409870 > Change-Id: I5f45563c70d0babe706bbcab2ea3514dcf84c9bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218548 > Commit-Queue: Christian Xu <christianxu@chromium.org> > Reviewed-by: Ameur Hosni <ameurhosni@google.com> > Cr-Commit-Position: refs/heads/main@{#1414179} > Bug: 390409870 Change-Id: Ia6bd7c07829b0c8e807a29d2028ad17026b9a194 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221425 Commit-Queue: Christian Xu <christianxu@chromium.org> Reviewed-by: Christian Xu <christianxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1414682} NOKEYCHECK=True GitOrigin-RevId: bfded6ee049a7e90d915119146d0acb53ead882d
This directory holds code related to Chrome for iOS. See this document for a description of the structure underneath this directory.