| commit | 414f6358a1dbbf8273bd26e017878f10115fdb02 | [log] [tgz] |
|---|---|---|
| author | Arthur Milchior <arthurmilchior@chromium.org> | Fri Feb 07 15:13:53 2025 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Feb 07 15:43:23 2025 |
| tree | 43ccdeffaf2a9657e5a864c40c238091efcccd2f | |
| parent | 841a75c32812bd366832ea6162836fa2e90c32d6 [diff] |
[iOS][Feed]Reuse a variable As far as I can tell, there was no reason to have two distinct feed_top_section_view_controller_. On the contrary, this created two issues: * the consumer became nil during the test execution at some non- deterministic time. Indeed, the consumer is weakly retained and no variable retained the argument sent as consumer. * the tests were calling methods to a view controller the consumer could not access. This mean that we could not really test the interaction between both objects. Bug: 315992978 Change-Id: I12e17d6c2960b50629e52e3adefae680e41e4391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6239778 Reviewed-by: Adam Arcaro <adamta@google.com> Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org> Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org> Cr-Commit-Position: refs/heads/main@{#1417324} NOKEYCHECK=True GitOrigin-RevId: 675fa9c2f6ceef101f10efef5e541a8f3339dfdc
This directory holds code related to Chrome for iOS. See this document for a description of the structure underneath this directory.