commit | 48485157620e97cd8bb2c5c610a26dc05bb64b62 | [log] [tgz] |
---|---|---|
author | ginnnnnnny <ginnyhuang@chromium.org> | Thu Feb 06 16:55:35 2025 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 06 17:25:42 2025 |
tree | 0d90fa0ea7373a97fb76e9121ecf4a7aa1f91472 | |
parent | 58080743eed760bf023e6756f2ce9ee1844b5ea8 [diff] |
[iOS][discover] Replace CHECK statements with histogram logging This CL and its follow up (crrev.com/i/8008688) do two things: 1. Replace CHECK statements by histogram loggings. This is because that the actions are asynchronous, and are also triggered by Discover commands, so Chromium engineers do not have total control over the behavior. Yet we still want to monitor these errors. 2. Always attach sign-in delegate to the discover feed; the check for users that are already signed-in is moved to the delegate method implementation. This is to bring parity with other associated dependencies. Bug: 379923105,379916209,391443737,380626171 Change-Id: I1061a8ed19e80d807d7542b8063c5e47fd986954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237275 Auto-Submit: Ginny Huang <ginnyhuang@chromium.org> Reviewed-by: Adam Arcaro <adamta@google.com> Commit-Queue: Ginny Huang <ginnyhuang@chromium.org> Reviewed-by: Federica Germinario <fedegermi@google.com> Cr-Commit-Position: refs/heads/main@{#1416834} NOKEYCHECK=True GitOrigin-RevId: 5a031db69822315685d34145a0b24419af386a01
This directory holds code related to Chrome for iOS. See this document for a description of the structure underneath this directory.