[iOS][discover] Replace CHECK statements with histogram logging

This CL and its follow up (crrev.com/i/8008688) do two things:

1. Replace CHECK statements by histogram loggings. This is because
that the actions are asynchronous, and are also triggered by Discover
commands, so Chromium engineers do not have total control over the
behavior. Yet we still want to monitor these errors.

2. Always attach sign-in delegate to the discover feed; the check for
users that are already signed-in is moved to the delegate method
implementation. This is to bring parity with other associated
dependencies.

Bug: 379923105,379916209,391443737,380626171
Change-Id: I1061a8ed19e80d807d7542b8063c5e47fd986954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237275
Auto-Submit: Ginny Huang <ginnyhuang@chromium.org>
Reviewed-by: Adam Arcaro <adamta@google.com>
Commit-Queue: Ginny Huang <ginnyhuang@chromium.org>
Reviewed-by: Federica Germinario <fedegermi@google.com>
Cr-Commit-Position: refs/heads/main@{#1416834}
NOKEYCHECK=True
GitOrigin-RevId: 5a031db69822315685d34145a0b24419af386a01
5 files changed
tree: 0d90fa0ea7373a97fb76e9121ecf4a7aa1f91472
  1. build/
  2. chrome/
  3. components/
  4. google_internal/
  5. intents/
  6. net/
  7. public/
  8. testing/
  9. third_party/
  10. tools/
  11. web/
  12. web_view/
  13. .swift-format
  14. BUILD.gn
  15. COMMON_METADATA
  16. DEPS
  17. DIR_METADATA
  18. features.gni
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. README.md
README.md

This directory holds code related to Chrome for iOS. See this document for a description of the structure underneath this directory.