commit 4a802dc0ac858868910f27198b1d356e57ba24a9
author Benjamin Williams <bwwilliams@google.com> Wed Feb 05 19:36:02 2025
committer Copybara-Service <copybara-worker@google.com> Wed Feb 05 20:45:43 2025
tree ca6beb70db2e76964059919f517083fd1f71ed46
parent 8802e56b3808551720b622ff63e4f4e8e7d1f653

[iOS] Improve UI command names

This change updates UI command names across the codebase to conform to
Chrome iOS best practices, enhancing code clarity and consistency.
Command names now use clear imperative verbs that accurately describe
their intended UI actions (e.g., -showShareSheet and -addBookmarks:).
Additionally, for some commands, the redundant -maybe prefix has been
removed, as UI commands are inherently conditional.

ActivityServiceCommands (activity_service_commands.h)

    Old: -sharePage
    New: -showShareSheet

    Old: -shareChromeApp
    New: -showShareSheetForChromeApp

    Old: -shareHighlight:
    New: -showShareSheetForHighlight:

    Old: -shareURLFromContextMenu:
    New: -showShareSheetForURL:

BookmarksCommands (bookmarks_commands.h)

    Old: -bookmarkWithFolderChooser:
    New: -addBookmarksAndShowFolderChooser:

    Old: -bookmarkWithWebState:
    New: -addBookmarkForWebState:

    Old: -bulkCreateBookmarksWithURLs:
    New: -addBookmarks:

    Old: -createOrEditBookmarkWithURL:
    New: -addOrEditBookmark:

    Old: -openToExternalBookmark:
    New: -showBookmarkInBookmarksUI:

ContextualPanelEntrypointCommands
(contextual_panel_entrypoint_commands.h)

    Old: -contextualPanelEntrypointIPHWasDismissed
    New: -notifyContextualPanelEntrypointIPHDismissed

ContextualPanelEntrypointIPHCommands
(contextual_panel_entrypoint_iph_commands.h)

    Old: -maybeShowContextualPanelEntrypointIPHWithConfig:
    New: -showContextualPanelEntrypointIPHWithConfig:

    Old: -dismissContextualPanelEntrypointIPHAnimated:(BOOL)animated
    New: -dismissContextualPanelEntrypointIPH:(BOOL)animated

PromosManagerCommands (promos_manager_commands.h)

    Old: -maybeDisplayPromo
    New: -displayPromo

    Old: -requestAppStoreReview
    New: -showAppStoreReviewPrompt

    Old: -maybeDisplayDefaultBrowserPromo
    New: -displayDefaultBrowserPromo

QRGenerationCommands (qr_generation_commands.h)

    Old: -generateQRCode:
    New: -showQRCode:

Fixed: 394284386
Change-Id: I8b7513b7592dd28594a44a3452425612bd86f693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6229349
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Nicolas MacBeth <nicolasmacbeth@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1416360}
NOKEYCHECK=True
GitOrigin-RevId: 94a5598aaa8ca10ef442128c26721fc2078889ac