commit a4418cd54f83e4f36155827629185f4d51aee2d5
author Peter Kasting <pkasting@chromium.org> Mon Feb 03 18:26:02 2025
committer Copybara-Service <copybara-worker@google.com> Mon Feb 03 18:52:36 2025
tree 9f2251a6ae2b2cf326ae4bbaa0638bb478621ed9
parent dc7ef83a525049e69e8aafff87b0c929306918f9

Reland "Make VectorIcon null constructor private."

This reverts commit 7eef3739c38107d4489546763fef91cf94f73d57.

Reason for revert: Fixed component build issues, see Patchset 2

Original change's description:
> Revert "Make VectorIcon null constructor private."
>
> This reverts commit 5243880b6babea5956782ee69f7873fd3db3d66a.
>
> Reason for revert: Suspecting this CL for consistent test failures starting with https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38900/overview
>
> Original change's description:
> > Make VectorIcon null constructor private.
> >
> > VectorIcon is meant to always point to a static object, including for
> > the null case, and be comparable by pointer.
> >
> > This requires changing `kNoneIcon`, since it can't live outside the
> > class anymore.
> >
> > Bug: 364987728
> > Change-Id: I54b80f7026793b07de85f911e8e2cf3389b98d3b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219807
> > Commit-Queue: Peter Kasting <pkasting@chromium.org>
> > Owners-Override: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1414006}
>
> Bug: 364987728
> Change-Id: I11d811c2a37391f2e18949f20674cb054f5242e9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219353
> Owners-Override: Kevin McNee <mcnee@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Kevin McNee <mcnee@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1414165}

Bug: 364987728
Change-Id: I57e1fa5d2629dfe877f3f5214e613c963d51bcef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221356
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Owners-Override: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415035}
NOKEYCHECK=True
GitOrigin-RevId: 25b169ef7fb0f78f8197dfc83db4f27dbdc9bd28