commit | e56af0d338caf5c2a0851cc5cdfee9a87d912c73 | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Wed Feb 05 23:48:35 2025 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 06 02:07:45 2025 |
tree | b59c69075ec7b478e78c2dc5529680837a814b9e | |
parent | 223948fbd2255daa590abdc5d2f21f31ca022e89 [diff] |
Revert "[iOS][OR] Move suggestions grouping from mediator to controller" This reverts commit 749e32fd8d9a0b935c67d819966473b662fddbac. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4893563436400640 Sample build with failed test: https://ci.chromium.org/b/8723760508912670065 Affected test(s): [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SelectManagePasswordSuggestionMetricLogged](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SelectManagePasswordSuggestionMetricLogged?q=VHash%3Ae6fcf249de8f1255) [ninja://ios/chrome/test:ios_chrome_unittests/OmniboxPopupMediatorTest.SelectManagePasswordSuggestionMetricLogged](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fios%2Fchrome%2Ftest:ios_chrome_unittests%2FOmniboxPopupMediatorTest.SelectManagePasswordSuggestionMetricLogged?q=VHash%3Af313067e1c194d65) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4893563436400640&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6225805&type=BUG Original change's description: > [iOS][OR] Move suggestions grouping from mediator to controller > > This CL moves suggestions grouping from OmniboxPopupMediator to > OmniboxAutocompleteController. This follows the effort of removing > AutocompleteController interactions from the mediator. > > The popup mediator requests suggestions to the OmniboxPopupController > who fetches them through the OmniboxAutocompleteController. Future CLs > will move the suggestions wrapping from the mediator to the popup > controller. > > Unit tests are simplified with the use of these CLs: > - https://chromium-review.googlesource.com/c/chromium/src/+/6221316 > - https://chromium-review.googlesource.com/c/chromium/src/+/6218940 > > Fixed: 394319253 > Change-Id: Iea297e8b16f2bed1d074e0379731968cff79f354 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6225805 > Auto-Submit: Christian Xu <christianxu@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1416133} > Change-Id: I8c1fe021197853cb22f750edf58a6453453cf6f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6236740 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Owners-Override: Yoshisato Yanagisawa <yyanagisawa@google.com> Owners-Override: Allen Bauer <kylixrd@google.com> Cr-Commit-Position: refs/heads/main@{#1416508} NOKEYCHECK=True GitOrigin-RevId: ce51cf2e7483e1abda7120f57010b4cfcd1c4b82
This directory holds code related to Chrome for iOS. See this document for a description of the structure underneath this directory.