tree 788cd60668840aa8a8c2da5c7d0c59fe2d88c259
parent 04751ce2147e81d22cceb1f6601b413a1a52802a
author Michael Spang <spang@chromium.org> 1529901687 +0000
committer Commit Bot <commit-bot@chromium.org> 1529901687 +0000

ozone: drm: Fix dangling fences (gfx::GpuFence*) after page flip

There's a number of places that overlay stacks are copied inside the DRM
code. Previously this was safe because overlay plane stacks were
self-contained, but now they include unowned pointers to fences. Those
fences are freed immediately after submitting a frame and left dangling
in any copies of the overlay plane stack.

Fix the code to duplicate the fences when copying planes. We should
reduce the number of places we are copying overlay stacks, but that is
not done here; this patch only makes copying safe again. It also
makes copying an explicit call; the copy constructor is gone.

TBR: dcastagna@chromium.org
Bug: 851997
Test: Ran chrome & ozone_demo --use-gpu-fences on eve
Change-Id: Ib21033aaf43a6765c3c46fce60991ada941ef343
Reviewed-on: https://chromium-review.googlesource.com/1097209
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#569965}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6bdc36e8a7b4fa8f9ba00e5ad851cfbb483d0acf