)]}' { "log": [ { "commit": "daf5796acceaeea8fe9f63c2ec019cef05e82314", "tree": "c5b7980aafb5d8433f9c615cbd2297bcffcce7f6", "parents": [ "b08125b738d6a770b1127f7ffca968b94c940435" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Jul 16 15:46:15 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 16 15:48:38 2025" }, "message": "Reland \"Move GN enable_plugins variable out of //ppapi\"\n\nThis is a reland of commit 0234539437a5596ef2c5bc9d45629b1d66305ce2\n\nFix the Chromecast build failure by wrapping enable_plugins in a\ndeclare_args() block, like how it was prior to this CL.\n\nOriginal change\u0027s description:\n\u003e Move GN enable_plugins variable out of //ppapi\n\u003e\n\u003e Move the GN enable_plugins variable to //content/public/common, so it\n\u003e lives in the same directory as the C++ ENABLE_PLUGINS buildflag.\n\u003e\n\u003e Bug: 40511450\n\u003e Change-Id: Ic73f19e510b5b5cc94ecda37519de764abd03fba\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757897\n\u003e Commit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Reviewed-by: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Owners-Override: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1487258}\n\nBug: 40511450\nCq-Include-Trybots: luci.chromium.try:linux-cast-arm-rel\nChange-Id: I1ef677b6281278d7af18bcafdea1378098272102\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6758510\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nOwners-Override: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487670}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 48ef5791f5d1a0a80734436272d12cb9d10137b1\n" }, { "commit": "b08125b738d6a770b1127f7ffca968b94c940435", "tree": "4fc3d0b56ed60b521af0c57370ff73e1fa66d54c", "parents": [ "652946bfbfc50d6dbbbf1b8c4a03fc8d8012e54d" ], "author": { "name": "Matt Reynolds", "email": "mattreynolds@chromium.org", "time": "Tue Jul 15 23:27:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 23:34:46 2025" }, "message": "Revert \"Move GN enable_plugins variable out of //ppapi\"\n\nThis reverts commit 0234539437a5596ef2c5bc9d45629b1d66305ce2.\n\nReason for revert: linux-cast-arm-rel build failures https://cr-buildbucket.appspot.com/build/8709237076730407729\n\nBug: 40511450\nOriginal change\u0027s description:\n\u003e Move GN enable_plugins variable out of //ppapi\n\u003e\n\u003e Move the GN enable_plugins variable to //content/public/common, so it\n\u003e lives in the same directory as the C++ ENABLE_PLUGINS buildflag.\n\u003e\n\u003e Bug: 40511450\n\u003e Change-Id: Ic73f19e510b5b5cc94ecda37519de764abd03fba\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757897\n\u003e Commit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Reviewed-by: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Owners-Override: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1487258}\n\nBug: 40511450\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I65088d72dab82d99d720ab4c68e823bb7bc389b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6756624\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Matt Reynolds \u003cmattreynolds@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487268}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 192a03ca8014335b19b92398bc414f671a923850\n" }, { "commit": "652946bfbfc50d6dbbbf1b8c4a03fc8d8012e54d", "tree": "c5b7980aafb5d8433f9c615cbd2297bcffcce7f6", "parents": [ "6f7a0ff493402b55ca32a9077b11a262539ec4fe" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Jul 15 23:12:10 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 23:18:29 2025" }, "message": "Move GN enable_plugins variable out of //ppapi\n\nMove the GN enable_plugins variable to //content/public/common, so it\nlives in the same directory as the C++ ENABLE_PLUGINS buildflag.\n\nBug: 40511450\nChange-Id: Ic73f19e510b5b5cc94ecda37519de764abd03fba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757897\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nOwners-Override: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487258}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0234539437a5596ef2c5bc9d45629b1d66305ce2\n" }, { "commit": "6f7a0ff493402b55ca32a9077b11a262539ec4fe", "tree": "4fc3d0b56ed60b521af0c57370ff73e1fa66d54c", "parents": [ "97a031058b95ce772a19544730a6301587a1a6d6" ], "author": { "name": "Derek Schuff", "email": "dschuff@chromium.org", "time": "Tue Jul 15 20:59:58 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 21:02:13 2025" }, "message": "Remove ppapi/generators\n\nThis is a reland of https://crrev.com/c/6729535\n\nIt was reverted in https://crrev.com/c/6729435 because there was\na dependency on these files from the extensions API schema compiler. The\nrelevant files have now been copied over to //tools/json_schema_compiler\nin https://crrev.com/c/6730496, so this change can reland.\n\nBug: 40511454\nChange-Id: I63e74ae58fc43108b67436df281f33bb5228fa67\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757842\nReviewed-by: Tim \u003ctjudkins@chromium.org\u003e\nAuto-Submit: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487220}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 47940ab8bb9439cf20299d54a7f70fe584d9c73b\n" }, { "commit": "97a031058b95ce772a19544730a6301587a1a6d6", "tree": "e7a318ede113ddd14f858c42ac7623f4f3a51707", "parents": [ "633c5af761f7b384c32839c05af1b548f5e61d5c" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Jul 15 20:28:42 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 15 20:31:40 2025" }, "message": "Delete ppapi/buildflags/buildflags.h\n\nTransition ENABLE_PLUGINS users to content/public/common/buildflags.h.\nThen delete ppapi/buildflags/buildflags.h and its GN target.\n\nBug: 40511450\nChange-Id: I97d19a2a8a20c24ab95d0aec91f9903b6d5c8088\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6690442\nReviewed-by: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nOwners-Override: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1487200}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ae572bef3647189819f1371c5da4841b25afa124\n" }, { "commit": "633c5af761f7b384c32839c05af1b548f5e61d5c", "tree": "495962db95d9ea995457279ffd9d12b2f0711794", "parents": [ "6a73982ce1460851056da9cf2c20ece45d91a613" ], "author": { "name": "Wenyu Fu", "email": "wenyufu@chromium.org", "time": "Fri Jul 11 18:49:19 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 11 18:51:05 2025" }, "message": "Revert \"Remove ppapi/generators\"\n\nThis reverts commit 58084f46f6fa40d3dd10b4abf638e1c9615392be.\n\nReason for revert: Causing build failure:\nhttps://ci.chromium.org/ui/p/chromium/builders/ci/win-archive-rel/55034/overview\n\nBug: 40511454\nOriginal change\u0027s description:\n\u003e Remove ppapi/generators\n\u003e\n\u003e Bug: 40511454\n\u003e Change-Id: I16664da6b70a4eda1a5eaf495cf8f5db896d72de\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6729535\n\u003e Auto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Commit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1485713}\n\nBug: 40511454\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I78a67805fcb17515e7e2e2a6322cc225c04343e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6729435\nOwners-Override: Wenyu Fu \u003cwenyufu@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nAuto-Submit: Wenyu Fu \u003cwenyufu@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1485720}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0bc4bd4c472d56118db9bf89b4894a45de382c24\n" }, { "commit": "6a73982ce1460851056da9cf2c20ece45d91a613", "tree": "10280fcb282def5ce58b60ac33148fb51baf62e6", "parents": [ "8bcdedc74fabd6c600c68c18ae6b780bb3317d25" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Jul 11 18:25:09 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 11 18:27:45 2025" }, "message": "Remove ppapi/generators\n\nBug: 40511454\nChange-Id: I16664da6b70a4eda1a5eaf495cf8f5db896d72de\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6729535\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1485713}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 58084f46f6fa40d3dd10b4abf638e1c9615392be\n" }, { "commit": "8bcdedc74fabd6c600c68c18ae6b780bb3317d25", "tree": "495962db95d9ea995457279ffd9d12b2f0711794", "parents": [ "b59bb8167639d04f7ac7fb9c20f4421dc8e9181c" ], "author": { "name": "Eugene Zemtsov", "email": "eugene@chromium.org", "time": "Mon Jul 07 17:03:40 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 07 17:05:38 2025" }, "message": "Reland \"Remove unused source code in PPAPI\"\n\nThis reverts commit d32590d50c3c3b0f4a2146f04051a5ca2525c9f3.\n\nReason for revert: The original revert issue has been addressed\nby https://crrev.com/1481330\n\nBug: 40511450\nOriginal change\u0027s description:\n\u003e Revert \"Remove unused source code in PPAPI\"\n\u003e\n\u003e This reverts commit b54fb3d12a612c8cba47c8928f52ae873da1071f.\n\u003e\n\u003e Reason for revert: gles2/gles2.c is missing\n\u003e\n\u003e FileNotFoundError: [Errno 2] No such file or directory: \u0027/b/s/w/ir/cache/builder/linux_presubmit/src/ppapi/lib/gl/gles2/gles2.c\u0027\n\u003e\n\u003e Bug: 40511450, chromium:428926701\n\u003e Original change\u0027s description:\n\u003e \u003e Remove unused source code in PPAPI\n\u003e \u003e\n\u003e \u003e Bug: 40511450\n\u003e \u003e Change-Id: Id469003594da402cb4cdb3e83f257830dc9e353c\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6696273\n\u003e \u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e \u003e Commit-Queue: Eugene Zemtsov \u003ceugene@chromium.org\u003e\n\u003e \u003e Reviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/main@{#1481245}\n\u003e\n\u003e Bug: 40511450\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Change-Id: Icd2ccba65d7b0fee6f3cf6f5f4a7b1633c962ca6\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6697998\n\u003e Owners-Override: Solomon Kinard \u003csolomonkinard@google.com\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Commit-Queue: Solomon Kinard \u003csolomonkinard@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1481305}\n\nBug: 40511450, chromium:428926701\nBug: 40511450\nChange-Id: Id34a9cde6b9874d912c04180209c1b1ea24b9af0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6698095\nCommit-Queue: Eugene Zemtsov \u003ceugene@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1483225}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 062d6961ae859e0293491caf1cdb97ba501022f7\n" }, { "commit": "b59bb8167639d04f7ac7fb9c20f4421dc8e9181c", "tree": "35de3ed6202f690471c1e4af118c79f27820997b", "parents": [ "c6e9ecf6b7ad36f703ffcd60dc79f5fb0265c8e8" ], "author": { "name": "Solomon Kinard", "email": "solomonkinard@chromium.org", "time": "Tue Jul 01 23:15:07 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 01 23:17:09 2025" }, "message": "Revert \"Remove unused source code in PPAPI\"\n\nThis reverts commit b54fb3d12a612c8cba47c8928f52ae873da1071f.\n\nReason for revert: gles2/gles2.c is missing\n\nFileNotFoundError: [Errno 2] No such file or directory: \u0027/b/s/w/ir/cache/builder/linux_presubmit/src/ppapi/lib/gl/gles2/gles2.c\u0027\n\nBug: 40511450, chromium:428926701\nOriginal change\u0027s description:\n\u003e Remove unused source code in PPAPI\n\u003e\n\u003e Bug: 40511450\n\u003e Change-Id: Id469003594da402cb4cdb3e83f257830dc9e353c\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6696273\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Commit-Queue: Eugene Zemtsov \u003ceugene@chromium.org\u003e\n\u003e Reviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1481245}\n\nBug: 40511450\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: Icd2ccba65d7b0fee6f3cf6f5f4a7b1633c962ca6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6697998\nOwners-Override: Solomon Kinard \u003csolomonkinard@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Solomon Kinard \u003csolomonkinard@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1481305}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d32590d50c3c3b0f4a2146f04051a5ca2525c9f3\n" }, { "commit": "c6e9ecf6b7ad36f703ffcd60dc79f5fb0265c8e8", "tree": "495962db95d9ea995457279ffd9d12b2f0711794", "parents": [ "d49de26b4b13e1f286952dad9b06b4682e6d4f73" ], "author": { "name": "Eugene Zemtsov", "email": "eugene@chromium.org", "time": "Tue Jul 01 20:46:43 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 01 20:49:28 2025" }, "message": "Remove unused source code in PPAPI\n\nBug: 40511450\nChange-Id: Id469003594da402cb4cdb3e83f257830dc9e353c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6696273\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Eugene Zemtsov \u003ceugene@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1481245}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b54fb3d12a612c8cba47c8928f52ae873da1071f\n" }, { "commit": "d49de26b4b13e1f286952dad9b06b4682e6d4f73", "tree": "35de3ed6202f690471c1e4af118c79f27820997b", "parents": [ "f27e6d35d85b50c6431af80b0ae3c14f23e5eb72" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Sat Jun 28 00:02:44 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jun 28 00:08:58 2025" }, "message": "[ppapi] Prep moving ENABLE_PLUGINS into content/public/common\n\nThis will allow us to remove a bunch of #include ppapi inside\ncontent without breaking the build everywhere.\n\nBug: 40511450\nChange-Id: I1386dbcada5c4589c55af408bf2995080f6aa633\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6685852\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nAuto-Submit: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1480158}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9cf63231e10aa5abc4479f063b33545bf986cfff\n" }, { "commit": "f27e6d35d85b50c6431af80b0ae3c14f23e5eb72", "tree": "749539d2910f48edf0dd428b735577827c744044", "parents": [ "f40332c63797b8bb8060bda2935734e5f00e2531" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Jun 27 11:48:58 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 27 11:54:44 2025" }, "message": "Remove components/nacl/common/buildflags.h\n\nBug: 40511454\nChange-Id: I7ed78333b31fe1900e820989438489e607a037e8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680050\nCommit-Queue: Hans Wennborg \u003chans@chromium.org\u003e\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1479738}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 17b6ff136ca5030f7df8123fde60ea5cd2346d93\n" }, { "commit": "f40332c63797b8bb8060bda2935734e5f00e2531", "tree": "b9fd6c686f0afee41088feefcf0d0d657ade9f21", "parents": [ "cb85839341dca55ea7b0f9ad4b0666f666ab74e9" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Thu Jun 26 19:56:59 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 26 19:59:53 2025" }, "message": "Remove IS_MINIMAL_TOOLCHAIN\n\nThis was only set in (some) nacl builds, it\u0027s always false now.\n\nBug: 423859723\nChange-Id: Ic7e13a939f23c6f50c1ce27221056aeb325538c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6678414\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1479393}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 755e965d7c5fab4767934c37bcd524b0cc07adc1\n" }, { "commit": "cb85839341dca55ea7b0f9ad4b0666f666ab74e9", "tree": "d42be9f3e229fe8eb6dfe0949420956957658b9f", "parents": [ "0c464e7d4823b9663310eda3956bfbf68f6e1e34" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Wed Jun 25 15:51:49 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 25 15:58:11 2025" }, "message": "Delete PPAPI testing code\n\nBug: 40511450\nChange-Id: Ia9dde260b1dfe9d9e2273cb5e5326ebac4ce7bac\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6670296\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1478595}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6420f71a85eb194385f757036ab2c84d0ff831cc\n" }, { "commit": "0c464e7d4823b9663310eda3956bfbf68f6e1e34", "tree": "29d907428823feb2c0e0e1f49b6d4c61cb612969", "parents": [ "75aa8ccda7d33f291c8658ef96331ddc68651180" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Wed Jun 25 12:52:27 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 25 12:54:58 2025" }, "message": "Remove //ppapi/examples\n\nThis is fairly standalone so go ahead and delete this now.\n\nBug: 40511450\nChange-Id: I4ddd352ec44f3fb4f3d2246de96ca7653f951ca6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6670783\nAuto-Submit: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1478492}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 144ce8ab6db114f4966000037dc4da48008c8732\n" }, { "commit": "75aa8ccda7d33f291c8658ef96331ddc68651180", "tree": "ba94177eeefa0823aeeadd3a296cb49804ea91f7", "parents": [ "cfd423759e6250d21b225268384ec4b016412a4b" ], "author": { "name": "Derek Schuff", "email": "dschuff@chromium.org", "time": "Wed Jun 25 00:47:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 25 00:52:41 2025" }, "message": "Delete ppapi/native_client, ppapi/nacl_irt and references to it.\n\nBUG\u003d40511454\n\nChange-Id: Ib68b518c0706a35d8d2dda585a505c8fb3aa8791\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6669673\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Zijie He \u003czijiehe@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1478292}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1b0188911ce436dd3dd50476c42b60fbc43c66c4\n" }, { "commit": "cfd423759e6250d21b225268384ec4b016412a4b", "tree": "de15a9950180eadd39eed196c5cd34d623fbc909", "parents": [ "f6b2dbbae23748aaa2eddb5fb2a609d4cb7cf3ce" ], "author": { "name": "Fabian Sommer", "email": "fabiansommer@chromium.org", "time": "Tue Jun 24 16:51:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 24 16:54:21 2025" }, "message": "Set enable_ppapi to false\n\nenable_nacl is always false, so enable_ppapi is also false now.\n\nR\u003ddschuff@chromium.org\n\nBug: 40511450\nChange-Id: Icdeb1b2fde81589461b32e3d743b99d68acf04a5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6668113\nAuto-Submit: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1477996}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bb6bbf7cee8a560530f71d80ba9edfc3cd737f67\n" }, { "commit": "f6b2dbbae23748aaa2eddb5fb2a609d4cb7cf3ce", "tree": "84250115b2129f660728fb04e0cdb85f34d98ad3", "parents": [ "8cbf4dd79a61bc2fc5e527e6019c4f4b84707b45" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Thu Jun 19 21:47:14 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 19 21:52:52 2025" }, "message": "IWYU for NOTIMPLEMENTED() in the leftover files\n\nAdd the include for NOTIMPLEMENTED() to all files that use the macro:\n\ntools/add_header.py --header \"\\\"base/notimplemented.h\\\"\" \\\n $(git gs NOTIMPLEMENTED --name-only | grep -v base/notimplemented.h)\n\nThen remove the include for NOTREACHED() from any changed files that do\nnot use the macro:\n\ntools/add_header.py --remove --header \"\\\"base/notreached.h\\\"\" \\\n $(grep -L NOTREACHED $(git diff --name-only))\n\nManual fixes:\n- restore a JNI include and a ChromeOS media include to the correct\n location.\n- revert changes in partition_alloc\n- revert changes in base/check.cc\n\nBug: 41493641\nChange-Id: Id0031233147cc897ac7329dcf1061944c699d2ee\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6657184\nReviewed-by: Elly FJ \u003cellyjones@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1476295}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3dd1b27a7cb34cc30ee4d8ddc2146972b5254201\n" }, { "commit": "8cbf4dd79a61bc2fc5e527e6019c4f4b84707b45", "tree": "a8c48a19f1722991455ed299ae605ce13809cde7", "parents": [ "ac4412f649949c91308be49bf0e94792a27feaa3" ], "author": { "name": "David Sanders", "email": "dsanders11@ucsbalum.com", "time": "Wed Jun 11 01:09:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 11 01:12:22 2025" }, "message": "Add some missing includes of //media/base/audio_sample_types.h\n\nBug: 40216326\nChange-Id: Ib56ec06afdbeb95713e9c0f3ee00fcefb2f69fea\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6631595\nCommit-Queue: David Sanders \u003cdsanders11@ucsbalum.com\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1472165}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d9088476153a6d3651233482d1c5b189ba6ba265\n" }, { "commit": "ac4412f649949c91308be49bf0e94792a27feaa3", "tree": "9263bba5f3a5e3cf0793f804dbf330b1fe9aa0f6", "parents": [ "69d714d8e5a68990b012ab8a225f49d9c8fd05b4" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Mon Jun 09 20:53:01 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 09 20:55:54 2025" }, "message": "Remove vector use in base/containers/span.h\n\nconstexpr evaluation disallows comparing pointers from\ntwo different objects, but `copy_from()` uses pointer comparisons to\ndetermine which, if any parts, of the source and destination range\noverlap.\n\nThe initial workaround copied the elements to a local std::vector to\nguarantee no overlap; efficiency-wise, this doesn\u0027t matter, since it\u0027s\njust accounting at compile-time. However, \u003cvector\u003e is quite large and\nno other part of the span implementation needs std::vector.\n\nInstead, just \"allocate\" a buffer for storing the copied elements and\nmanage it manually.\n\nBug: 423048781\nChange-Id: I369b11a9d13f35b437b1f8ffcc0d3076ddcde118\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6628957\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1471422}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1302b70d084de89f64a4380605eaa9deccb44e94\n" }, { "commit": "69d714d8e5a68990b012ab8a225f49d9c8fd05b4", "tree": "eab32d5e046501fb3973b7459e1f2547874e4e59", "parents": [ "57a4e16f401d7aeff363bd7b7aacd2cbda6ee73e" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Wed Jun 04 17:11:01 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 04 17:14:56 2025" }, "message": "Do IWYU for base/strings/string_util.h in misc directories\n\nFiles that use base::JoinString(), base::StartsWith(), and others should\ninclude string_util.h directly instead of depending on transitive\nincludes from far away.\n\nBug: 40216326\nChange-Id: I7e3e0cbacacc846b8f457a5d7f30d505276f0db8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6607088\nCommit-Queue: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nOwners-Override: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1469415}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 03a95d114baa0025fe361b5634fa2388af35a49a\n" }, { "commit": "57a4e16f401d7aeff363bd7b7aacd2cbda6ee73e", "tree": "9fc19010d2fb0b6530e484049adeaf1ab84d42f4", "parents": [ "7ebca2fbdc89171f200e9cb91a235f54a251f6f0" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Mon May 26 22:59:12 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 26 23:05:19 2025" }, "message": "Remove base::NotFatalUntil::M130 usage\n\nAs of May 2025, this is always fatal.\nAutogenerated with base/tools/clean-up-not-fatal-until.py -m 130\n\nBug: 419922502\nChange-Id: I6de2094c1779e047252e2bb24e665113913721bc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579713\nReviewed-by: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Kyle Charbonneau \u003ckylechar@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1465680}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4d54f0a8e47abbf6d5d401c7d09a43ec2994d130\n" }, { "commit": "7ebca2fbdc89171f200e9cb91a235f54a251f6f0", "tree": "0dbdacdfd87188f6df59679b54f90730b907cafc", "parents": [ "dc4a0da82b02eb4ad06874d5e1b99441f735f2cf" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Tue May 06 21:23:23 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue May 06 21:31:36 2025" }, "message": "Exported things should always be visible\n\nThis changes our COMPONENT_EXPORT macros to make the things they export\nvisible all the time on non-windows, rather than making them visible in\nthe named component only. This avoids subtle bugs where things defined\nin multiple components end up with one copy per component, only one of\nwhich is visible, and so the linker doesn\u0027t know it\u0027s supposed to dedup\nthem.\n\nSome, but not all, of these issues are detected by the new clang warning\n-Wunique-object-duplication. This change addresses some instances of that\nwarning firing on chromium code, but not all. Conversely, there are likely\ninstances which the warning does not catch, which are fixed by this CL.\n\nBug: 368047728\nChange-Id: I829a9bd84e57e3c7d80ec33aea0408951019bde7\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6264795\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Devon Loehr \u003cdloehr@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1456614}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: edf57482697bfb2777c28ab56977f5c448fa5c2d\n" }, { "commit": "dc4a0da82b02eb4ad06874d5e1b99441f735f2cf", "tree": "67199dba01a8db4c9c226bdadb08a1f142fca403", "parents": [ "f0e965c61c3ccd54159a9fb1f0e1d3ac9d18716c" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Mar 18 01:12:42 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 18 01:19:55 2025" }, "message": "Mark libc calls UNSAFE_TODO in non-base/\n\nChange-Id: I8647303a28cd27a6ca44bd8e5d25c9cab094ab98\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6354281\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1433917}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2f63d594a511598038fee9589195b49a64847e20\n" }, { "commit": "f0e965c61c3ccd54159a9fb1f0e1d3ac9d18716c", "tree": "38360ddc620fcc2bf91aea25f60e8ae61691abb4", "parents": [ "2b014e10d6439f18f85b4eddd696927d5a97daad" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Mon Mar 17 23:02:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Mar 17 23:10:33 2025" }, "message": "Mark unsafe libc calls in next batch of files\n\nIterative process to reduce the initial set of warnings. Use\nUNSAFE_TODO() unless include rules preclude compiler_spcific.h,\nin which case use the file-wide pragma.\n\nBug: 390223051\nChange-Id: I0b4d6020dd30a5184ebd8178996d047205476d39\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6362954\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nOwners-Override: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1433839}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a20bb6a8dca060615716ce9c432f18de6732c7c2\n" }, { "commit": "2b014e10d6439f18f85b4eddd696927d5a97daad", "tree": "0ed84426aaef7fdf011eac9cbfc21c4a24ffee22", "parents": [ "f41b59662267a75c1e4c668ae0e2fcadbc55c286" ], "author": { "name": "Yuta Hijikata", "email": "ythjkt@google.com", "time": "Thu Mar 06 15:30:26 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 06 15:36:00 2025" }, "message": "Replace IS_CHROMEOS_ASH with IS_CHROMEOS in ppapi.\n\nThis is part of Lacros sunset. Since Lacros is gone, the two macros\nmean the same thing.\n\nBug: 354842935\nChange-Id: I9d0776ae66dce1879fac746109168148f9262102\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332250\nCommit-Queue: Yuta Hijikata \u003cythjkt@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1428907}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b60395a06a1f3e99f150361bfff4a36b863c147\n" }, { "commit": "f41b59662267a75c1e4c668ae0e2fcadbc55c286", "tree": "d7bd9dbaeec236fa3832b68ce3e518286d938d56", "parents": [ "cb3a3a42f862f195851d70efc9c1b5fc14d7bae9" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Feb 06 22:09:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 06 22:18:35 2025" }, "message": "Suppress unsafe libc calls warnings in ppapi/ headers.\n\nRather than suppressing the entire ppapi/ directory in the\nunsafe_buffers_paths.txt file, add a few per-file suppressions\nas was previously done for the unsafe_buffer_unsage warnings.\n\nHopefully this code will all be deleted later this year.\n\nBug: 390223051\nChange-Id: I2fd2191d53f19be794b4dd7d0ea5abd41be40ce4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6235117\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1417015}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b8c2f26a0a47b8926f288673e5d7cde2bd958750\n" }, { "commit": "cb3a3a42f862f195851d70efc9c1b5fc14d7bae9", "tree": "a6db70f26fdaa720fa3191cd8907131dc3979427", "parents": [ "9f221c8cd43979af5f73e373511d050c3121ecbc" ], "author": { "name": "Leszek Swirski", "email": "leszeks@google.com", "time": "Thu Feb 06 12:16:57 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 06 12:20:30 2025" }, "message": "[base] Use wrapper type for PlatformThreadId\n\nIntroduce a wrapper class (similar to base::StrongAlias) for\nPlatformThreadId, whose API assumes that the value can be 64-bit. It\nforces explicit conversion to integers with various bitness, and makes\nconversion to 32-bit be explicit about truncation.\n\nThe values are currently all still 32-bit -- follow-up work will make\nthread id values on macOS 64-bit.\n\nBug: 40187449\nChange-Id: Ic635c346be1c3a0d62fd573572f4fcdc642a734f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6206469\nReviewed-by: Peter McNeeley \u003cpetermcneeley@google.com\u003e\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nOwners-Override: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Leszek Swirski \u003cleszeks@chromium.org\u003e\nReviewed-by: Victor Vianna \u003cvictorvianna@google.com\u003e\nCommit-Queue: Leszek Swirski \u003cleszeks@chromium.org\u003e\nReviewed-by: Mikhail Khokhlov \u003ckhokhlov@google.com\u003e\nReviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1416712}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b3fb42320c2b4354477bf76aab232336f2961eee\n" }, { "commit": "9f221c8cd43979af5f73e373511d050c3121ecbc", "tree": "8cac85d23dfec14bd5abf0473a3ffeebf77ba7da", "parents": [ "04fa6b0861c8371954e121868393fa57abde8324" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Jan 27 21:34:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 27 21:36:55 2025" }, "message": "[cleanup] Replace base::ranges with std::ranges: ppapi/\n\nDone entirely with `git grep` and `sed` + `git cl format`, no\nhand-editing.\n\nBug: 386918226\nChange-Id: Ibf9797f307dee42cf8faf910b26260c993764d6e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203962\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1411867}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 729227f795850bac602cd3994b1a171aa904fc45\n" }, { "commit": "04fa6b0861c8371954e121868393fa57abde8324", "tree": "fecbf22d98ea5ac60ea1978c0d0cd5e9f32b4fe5", "parents": [ "568b8ce955a45c034d57af069114fd07633cd0b0" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Thu Jan 09 16:51:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 09 16:56:08 2025" }, "message": "Reland \"[tracing] Cleanup up trace_log\"\n\nThis is a reland of commit 235af4663543443c2af5913df46b8ba984b0e078\nReason for revert:\nLUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5650878292819968\n\nFix: initialize TraceEventHandle to 0 to avoid\nMemorySanitizer: use-of-uninitialized-value error\n\nOriginal change\u0027s description:\n\u003e [tracing] Cleanup up trace_log\n\u003e\n\u003e This CL cleans up some of the unused functionalities in trace_log\n\u003e - legacy metadata\n\u003e - member AddTraceEvent* function: replaced by static ones\n\u003e - SetTrackDescriptor: covered by TrackNameRecorder\n\u003e We no longer update SetTrackDescriptor on UpdateProcessLabel;\n\u003e this is unnecessary because TrackNameRecorder calls\n\u003e SetTrackDescriptor when the session ends.\n\u003e\n\u003e Bug: 343404899\n\u003e Change-Id: Ia3c4524cd3b3dd4d4ad12a0348e60480b5d03f67\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120057\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e Reviewed-by: Alexander Timin \u003caltimin@chromium.org\u003e\n\u003e Commit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n\u003e Reviewed-by: Mikhail Khokhlov \u003ckhokhlov@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1403710}\n\nBug: 343404899\nChange-Id: Icb14722297b39f3b8fc7be0985452182a7b5846f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163823\nReviewed-by: Alexander Timin \u003caltimin@chromium.org\u003e\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Mikhail Khokhlov \u003ckhokhlov@google.com\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1404225}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4898bbcd46397da2f0fb57ed605c172970cd8534\n" }, { "commit": "568b8ce955a45c034d57af069114fd07633cd0b0", "tree": "7400529e620ce9e0ecbc9911776789a18d1422b1", "parents": [ "ba5eef7780968e7b13e7e14f825f6a326dd808ed" ], "author": { "name": "luci-bisection@appspot.gserviceaccount.com", "email": "luci-bisection@appspot.gserviceaccount.com", "time": "Thu Jan 09 00:13:53 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 09 00:16:58 2025" }, "message": "Revert \"[tracing] Cleanup up trace_log\"\n\nThis reverts commit 235af4663543443c2af5913df46b8ba984b0e078.\n\nReason for revert:\nLUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5650878292819968\n\nSample build with failed test: https://ci.chromium.org/b/8726281365613516081\nAffected test(s):\n[ninja://components/viz:viz_unittests/YUVReadbackTest.YUVReadbackOptTest](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcomponents%2Fviz:viz_unittests%2FYUVReadbackTest.YUVReadbackOptTest?q\u003dVHash%3Ac51c420b0ffd64f9)\n[ninja://content/test:content_browsertests/EmergencyStopTracingTest.StopOnThreadPool/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FEmergencyStopTracingTest.StopOnThreadPool%2FAll.0?q\u003dVHash%3Abba65c387ca28365)\n[ninja://content/test:content_browsertests/EmergencyStopTracingTest.StopOnThreadPoolTwice/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FEmergencyStopTracingTest.StopOnThreadPoolTwice%2FAll.0?q\u003dVHash%3Abba65c387ca28365)\n[ninja://content/test:content_browsertests/StartupTracingTest.TestEnableTracing/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FStartupTracingTest.TestEnableTracing%2FAll.0?q\u003dVHash%3Abba65c387ca28365)\n[ninja://content/test:content_browsertests/StartupTracingTest.TestEnableTracing/All.1](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FStartupTracingTest.TestEnableTracing%2FAll.1?q\u003dVHash%3Abba65c387ca28365)\nand 5 more ...\n\nIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component\u003d1199205\u0026description\u003dAnalysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5650878292819968\u0026format\u003dPLAIN\u0026priority\u003dP3\u0026title\u003dWrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6120057\u0026type\u003dBUG\n\nOriginal change\u0027s description:\n\u003e [tracing] Cleanup up trace_log\n\u003e\n\u003e This CL cleans up some of the unused functionalities in trace_log\n\u003e - legacy metadata\n\u003e - member AddTraceEvent* function: replaced by static ones\n\u003e - SetTrackDescriptor: covered by TrackNameRecorder\n\u003e We no longer update SetTrackDescriptor on UpdateProcessLabel;\n\u003e this is unnecessary because TrackNameRecorder calls\n\u003e SetTrackDescriptor when the session ends.\n\u003e\n\u003e Bug: 343404899\n\u003e Change-Id: Ia3c4524cd3b3dd4d4ad12a0348e60480b5d03f67\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120057\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Reviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\n\u003e Reviewed-by: Alexander Timin \u003caltimin@chromium.org\u003e\n\u003e Commit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n\u003e Reviewed-by: Mikhail Khokhlov \u003ckhokhlov@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1403710}\n\u003e\n\nBug: 343404899\nChange-Id: I31fb4bd8e2e195e2f58f7805ee4ddb4aafcada27\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6160654\nReviewed-by: Rebekah Potter \u003crbpotter@chromium.org\u003e\nCommit-Queue: Rebekah Potter \u003crbpotter@chromium.org\u003e\nOwners-Override: Rebekah Potter \u003crbpotter@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1403913}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 88740bf833402973515615be13864e7eb84fab50\n" }, { "commit": "ba5eef7780968e7b13e7e14f825f6a326dd808ed", "tree": "fecbf22d98ea5ac60ea1978c0d0cd5e9f32b4fe5", "parents": [ "8dc022b58d16d84ddfa21cb89fc9c7a545af01ab" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Wed Jan 08 19:08:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 08 19:14:54 2025" }, "message": "[tracing] Cleanup up trace_log\n\nThis CL cleans up some of the unused functionalities in trace_log\n- legacy metadata\n- member AddTraceEvent* function: replaced by static ones\n- SetTrackDescriptor: covered by TrackNameRecorder\n We no longer update SetTrackDescriptor on UpdateProcessLabel;\n this is unnecessary because TrackNameRecorder calls\n SetTrackDescriptor when the session ends.\n\nBug: 343404899\nChange-Id: Ia3c4524cd3b3dd4d4ad12a0348e60480b5d03f67\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120057\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Alexander Timin \u003caltimin@chromium.org\u003e\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Mikhail Khokhlov \u003ckhokhlov@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1403710}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 235af4663543443c2af5913df46b8ba984b0e078\n" }, { "commit": "8dc022b58d16d84ddfa21cb89fc9c7a545af01ab", "tree": "7400529e620ce9e0ecbc9911776789a18d1422b1", "parents": [ "b156a7e8fe74aa4170d78943141197c2f015f7b1" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Wed Dec 04 18:03:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Dec 04 18:06:40 2024" }, "message": "Style: Fix array initializations with size mismatches [8/8] #cleanup\n\nSplit 8/8 from:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6055399\n\nThis patch addresses inconsistencies in array initialization where the\ndeclared array size does not match the number of elements provided in\nthe initializer list. This can lead to confusion and potential errors,\nas the remaining elements are implicitly initialized to zero. For\nexample, initializing with \u003d {2} might mislead developers into thinking\nthe entire array is filled with 2s, when in fact only the first element\nis assigned that value.\nhttps://godbolt.org/z/4sbd9nreT\n\nThe changes ensure that:\n- Array sizes accurately reflect the number of elements being explicitly\n initialized.\n- Zero-initialization is explicitly expressed using {} when intended.\n\nThis improves code clarity and maintainability by making the\ninitialization intent clear and consistent.\n\nThis change also aims to allow the std::array rewriter to \"crash\" when\nencountering a mismatching size where it would be difficult to rewrite.\nNot having any occurrences of this pattern in the codebase will avoid the issue.\n\nBug: 356643982\nChange-Id: Ie2df5a02a5a2e96a117b5ae4bc86df2b031da972\nAX-Relnotes: n/a.\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063246\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1391754}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fe7eb63751378c830736721a8ad7a5f5b2be6065\n" }, { "commit": "b156a7e8fe74aa4170d78943141197c2f015f7b1", "tree": "d1c8f8f735af0041df4d7db96ba5ca34fd790b36", "parents": [ "2df32f9003a086b9c2284b198d365b5c2bcaaa12" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Mon Dec 02 18:15:15 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 02 18:18:58 2024" }, "message": "Remove usage of base::make_span(): ppapi/\n\nReplace with span() CTAD use, or more targeted helpers.\n\nBug: 341907909\nChange-Id: If26e3397f8b9022185bb18f4930dbbc9ef33e3ca\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6058258\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1390456}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e51e0cb73bab983e950417cf0361452813a5c91f\n" }, { "commit": "2df32f9003a086b9c2284b198d365b5c2bcaaa12", "tree": "00618c174d12a2575c7ed0040d1471601402df7f", "parents": [ "7ba86f339573f8ef5fed33df056a72ff342616ec" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri Nov 22 10:42:01 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 22 10:45:13 2024" }, "message": "Remove most remaining CHECK(false)s\n\nIn most cases NOTREACHED() is now a better option. Also performs\ndead-code removal.\n\nBug: 40122554\nChange-Id: Ia0479bc9b347f8f60a3932ef16c8b99b87f34a71\nLow-Coverage-Reason: OTHER Should-be-unreachable code\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038981\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1386708}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c922632dc6a0ef1916d376a16b91351846283d6f\n" }, { "commit": "7ba86f339573f8ef5fed33df056a72ff342616ec", "tree": "9dd7b01abca2cf9dda3f3ce926572e006586bd1f", "parents": [ "890fb5803730eeb3dcb1c73092aa6426d898e810" ], "author": { "name": "Devlin Cronin", "email": "rdevlin.cronin@chromium.org", "time": "Wed Nov 13 21:57:21 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 22:00:30 2024" }, "message": "Reland \"[Extensions] Move frame registration to document commit time\"\n\nThis relands commit d362fb38ef311f77884149ac6de85e517b0870f7.\n\nThis was reverted due to failures in\nExtensionCrashRecoveryBrowsertest, which were caused by reloading an\nextension and not properly waiting for the background context to be\nactive, and then asserting that it was registered in the\nProcessManager. This is fixed by properly waiting for the background\ncontext (when possible) in ExtensionBrowserTest::ReloadExtension().\n\nOriginal change\u0027s description:\n\u003e [Extensions] Move frame registration to document commit time\n\u003e\n\u003e Based on nasko@\u0027s CL at\n\u003e https://chromium-review.googlesource.com/c/chromium/src/+/5525999\n\u003e\n\u003e When a navigation requires a new RenderFrameHost to be created for it,\n\u003e the RenderFrameCreated observer method is called earlier in the\n\u003e navigation process. There is potentially state that is incorrect at that\n\u003e time, for example the SiteInstance for the navigation. When initializing\n\u003e state related to the new document, a better point in time to do so is\n\u003e the ReadyToCommitNavigation point in the timeline.\n\u003e\n\u003e This CL moves the extensions WebContents observer code to use the\n\u003e ReadyToCommit signal and does so behind a flag to ensure we can quickly\n\u003e revert in case of regressions.\n\u003e\n\u003e This also required a number of test updates, including:\n\u003e * Properly waiting for a background page when installing an extension.\n\u003e Previously, we relied on the extension background page being\n\u003e registered in the process manager by the time the extension was added,\n\u003e which wasn\u0027t really guaranteed, but happened because we registered it\n\u003e earlier.\n\u003e * Updating a BackgroundContents test to also wait for a hosted app\u0027s\n\u003e background contents to fully initialize.\n\u003e * Updating a NaCl test to keep an extension background page alive long\n\u003e enough for a tab to load (which then keeps it alive indefinitely).\n\u003e\n\u003e Bug: 334991035\n\u003e Change-Id: Icc858c5c3b35970a4ead322c94f79c0f955afe46\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6005549\n\u003e Reviewed-by: Nasko Oskov \u003cnasko@chromium.org\u003e\n\u003e Commit-Queue: Devlin Cronin \u003crdevlin.cronin@chromium.org\u003e\n\u003e Reviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1381961}\n\nBug: 334991035\nChange-Id: I1b123fb0bdd5f6fd9a76bd1313162de5bc3f9b58\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6014682\nReviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\nCommit-Queue: Devlin Cronin \u003crdevlin.cronin@chromium.org\u003e\nReviewed-by: Tim \u003ctjudkins@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1382603}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 693c0aac6647e9ac2d9634d48e50eeab6b726824\n" }, { "commit": "890fb5803730eeb3dcb1c73092aa6426d898e810", "tree": "8b97e0ec1fc68c8b8dc91640ae538a15f9a62781", "parents": [ "57d62fef6d04d5739efc99c544a7324d9250e109" ], "author": { "name": "Tim", "email": "tjudkins@chromium.org", "time": "Tue Nov 12 21:57:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 12 21:59:58 2024" }, "message": "Revert \"[Extensions] Move frame registration to document commit time\"\n\nThis reverts commit d362fb38ef311f77884149ac6de85e517b0870f7.\n\nReason for revert: Causing test failures on several bots e.g. https://ci.chromium.org/ui/p/chrome/builders/ci/mac-rel-ready/28218/overview\n\nOriginal change\u0027s description:\n\u003e [Extensions] Move frame registration to document commit time\n\u003e\n\u003e Based on nasko@\u0027s CL at\n\u003e https://chromium-review.googlesource.com/c/chromium/src/+/5525999\n\u003e\n\u003e When a navigation requires a new RenderFrameHost to be created for it,\n\u003e the RenderFrameCreated observer method is called earlier in the\n\u003e navigation process. There is potentially state that is incorrect at that\n\u003e time, for example the SiteInstance for the navigation. When initializing\n\u003e state related to the new document, a better point in time to do so is\n\u003e the ReadyToCommitNavigation point in the timeline.\n\u003e\n\u003e This CL moves the extensions WebContents observer code to use the\n\u003e ReadyToCommit signal and does so behind a flag to ensure we can quickly\n\u003e revert in case of regressions.\n\u003e\n\u003e This also required a number of test updates, including:\n\u003e * Properly waiting for a background page when installing an extension.\n\u003e Previously, we relied on the extension background page being\n\u003e registered in the process manager by the time the extension was added,\n\u003e which wasn\u0027t really guaranteed, but happened because we registered it\n\u003e earlier.\n\u003e * Updating a BackgroundContents test to also wait for a hosted app\u0027s\n\u003e background contents to fully initialize.\n\u003e * Updating a NaCl test to keep an extension background page alive long\n\u003e enough for a tab to load (which then keeps it alive indefinitely).\n\u003e\n\u003e Bug: 334991035\n\u003e Change-Id: Icc858c5c3b35970a4ead322c94f79c0f955afe46\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6005549\n\u003e Reviewed-by: Nasko Oskov \u003cnasko@chromium.org\u003e\n\u003e Commit-Queue: Devlin Cronin \u003crdevlin.cronin@chromium.org\u003e\n\u003e Reviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\n\u003e Reviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1381961}\n\nBug: 334991035\nChange-Id: Ic4bd3e3746e39b41fc1b7947f8e24788e538568b\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6014784\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Tim \u003ctjudkins@chromium.org\u003e\nOwners-Override: Kelvin Jiang \u003ckelvinjiang@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1381986}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 471a74a4e1972e238128b5fdeb3d24323f90b440\n" }, { "commit": "57d62fef6d04d5739efc99c544a7324d9250e109", "tree": "9dd7b01abca2cf9dda3f3ce926572e006586bd1f", "parents": [ "9676e4965385356b1be71259b69ac72b52ba553d" ], "author": { "name": "Devlin Cronin", "email": "rdevlin.cronin@chromium.org", "time": "Tue Nov 12 21:09:34 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 12 21:14:26 2024" }, "message": "[Extensions] Move frame registration to document commit time\n\nBased on nasko@\u0027s CL at\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5525999\n\nWhen a navigation requires a new RenderFrameHost to be created for it,\nthe RenderFrameCreated observer method is called earlier in the\nnavigation process. There is potentially state that is incorrect at that\ntime, for example the SiteInstance for the navigation. When initializing\nstate related to the new document, a better point in time to do so is\nthe ReadyToCommitNavigation point in the timeline.\n\nThis CL moves the extensions WebContents observer code to use the\nReadyToCommit signal and does so behind a flag to ensure we can quickly\nrevert in case of regressions.\n\nThis also required a number of test updates, including:\n* Properly waiting for a background page when installing an extension.\n Previously, we relied on the extension background page being\n registered in the process manager by the time the extension was added,\n which wasn\u0027t really guaranteed, but happened because we registered it\n earlier.\n* Updating a BackgroundContents test to also wait for a hosted app\u0027s\n background contents to fully initialize.\n* Updating a NaCl test to keep an extension background page alive long\n enough for a tab to load (which then keeps it alive indefinitely).\n\nBug: 334991035\nChange-Id: Icc858c5c3b35970a4ead322c94f79c0f955afe46\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6005549\nReviewed-by: Nasko Oskov \u003cnasko@chromium.org\u003e\nCommit-Queue: Devlin Cronin \u003crdevlin.cronin@chromium.org\u003e\nReviewed-by: Ahmed Fakhry \u003cafakhry@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1381961}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d362fb38ef311f77884149ac6de85e517b0870f7\n" }, { "commit": "9676e4965385356b1be71259b69ac72b52ba553d", "tree": "8b97e0ec1fc68c8b8dc91640ae538a15f9a62781", "parents": [ "cd65f7f8a6ab3c461b85fa74bd149363eab598f0" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Oct 23 23:14:39 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 23 23:22:04 2024" }, "message": "More deep-const-correctness for base::SharedMemoryMapping subtypes.\n\nThe code touched here wasn\u0027t consistent in its use of const, but\ngenerally used it in a shallow-const fashion where even vending write\naccess to a block of memory could be done via a const method.\n\nThis causes problems when trying to enforce stricter lifetime checks on\nwritable spans, because either the code gets confused about whether the\naccesses are read-only (it tries to look for the constness of the\nreturned pointers and can\u0027t figure out what to do if things don\u0027t\nmatch everywhere) or it thinks something unsafe or non-sane is happening\n(write access to rvalues makes no sense, for example, but read access\nmight in the context of a short-lived call).\n\nInstead consistently model deep constness, which is compliant with\nChrome\u0027s style rules on const and fixes all these issues. Mostly, this\nmeans changing const members/ref args to non-const ones.\n\nBug: 372381413\nChange-Id: I2735c52fbf0f32b813055cbb46f7c15b09eb025f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939406\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Fred Shih \u003cffred@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1373012}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 294250dd48d5912a585f64aceba142845df1f568\n" }, { "commit": "cd65f7f8a6ab3c461b85fa74bd149363eab598f0", "tree": "1530009e7d896774c1de584b845035d85e554caa", "parents": [ "594a87483b6e4a94beebe852907eda88adee7b9f" ], "author": { "name": "Sorin Jianu", "email": "sorin@chromium.org", "time": "Fri Oct 18 17:17:13 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Oct 18 17:25:57 2024" }, "message": "inclusive language: remove the word stupid from the codebase\n\nI need an owner\u0027s approval please for changes under:\nppapi/proxy\n\nThis CL was uploaded by git cl split.\n\nR\u003dfabiansommer@chromium.org\n\nBug: 374110115\nChange-Id: Ib5171b9f30dca23de09b71853082ff404634430f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937988\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCommit-Queue: Sorin Jianu \u003csorin@chromium.org\u003e\nAuto-Submit: Sorin Jianu \u003csorin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1370681}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dfdb61041aa16c0abf56c0b9dc41fb5e4703c368\n" }, { "commit": "594a87483b6e4a94beebe852907eda88adee7b9f", "tree": "2852792e6f82a7c955354343383fb18d502cfbde", "parents": [ "c7cd688fa4031d122dab175af49a7e383083984f" ], "author": { "name": "Sorin Jianu", "email": "sorin@chromium.org", "time": "Thu Oct 17 19:11:06 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Oct 17 19:19:19 2024" }, "message": "inclusive language: remove the word stupid from the codebase\n\nI need an owner\u0027s approval please for changes under:\nppapi/native_client\n\nThis CL was uploaded by git cl split.\n\nR\u003dbradnelson@chromium.org\n\nBug: 374110115\nChange-Id: I293e32989dd174830edc7aadf7572e9e4b707cdb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938416\nReviewed-by: Brad Nelson \u003cbradnelson@chromium.org\u003e\nAuto-Submit: Sorin Jianu \u003csorin@chromium.org\u003e\nCommit-Queue: Brad Nelson \u003cbradnelson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1370184}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 57ed4f19d4dd25fd9926a99dfdc9be3b212ae260\n" }, { "commit": "c7cd688fa4031d122dab175af49a7e383083984f", "tree": "f1dd879ff27539fd93ac4ffc6ff1f5276e970905", "parents": [ "53deea54c7ff0639660dfa348716c083d6108f36" ], "author": { "name": "Yuzhu Shen", "email": "yzshen@chromium.org", "time": "Tue Oct 08 04:39:02 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 08 04:49:47 2024" }, "message": "CommandBufferStub: update usage of SyncPointClientState.\n\nSwitch to use SyncPointClientState through gpu::Scheduler.\n\nThis CL also fixes a bug in PPAPI graphics where AsyncFlush doesn\u0027t forward the release count information from PPAPI process to renderer process. This fix is needed because with this CL there is DFATAL check to ensure that tasks of CommandBufferStub cannot release fence sync exceeding the count declared at task registration.\n\nBug: 324276400\nChange-Id: I3552c294f397ae1959fce6eb83a4f7caae2aaf9a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861524\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Yuzhu Shen \u003cyzshen@chromium.org\u003e\nReviewed-by: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1365327}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b152e7d49ccf79e665f90baf28c6afee8a1670db\n" }, { "commit": "53deea54c7ff0639660dfa348716c083d6108f36", "tree": "94d0a37ead715c52cb35e66d1dc089c1a6d3ecef", "parents": [ "da985459c3a5c29019067806b4d47d8edff41ca8" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Tue Sep 24 08:37:45 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 24 08:41:01 2024" }, "message": "Drop Windows support for PPAPI sandbox type\n\nThis sandbox type is not used in any released version of\nChrome and is not tested on the CQ so we cannot be\ncertain going forward that the sandbox is effective.\n\nIf developers use `enable_ppapi\u003dtrue` the ppapi host\nprocess will now be unsandboxed. This is not a security\nregression as the flag is not intended for use in\nreleased versions of Chrome.\n\nA guard is added to ppapi/build.gn to ensure this configuration\ncannot be enabled in official Chrome builds.\n\nBug: 40511450, b/303417958\nChange-Id: Iefbd866727da02aa1baf3ab08b5b20d2d62c7279\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840808\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Nasko Oskov \u003cnasko@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1359238}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 28df8180bb721538d85bce5f133999935ebcedce\n" }, { "commit": "da985459c3a5c29019067806b4d47d8edff41ca8", "tree": "f05fb18b14836b2ec888d0b84afbb8e9fbe4cd6a", "parents": [ "7402306a11fa8215833f258e11bd38572af064dd" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Sep 18 00:56:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 18 01:04:20 2024" }, "message": "Replace ABSL_ATTRIBUTE_* with base/ macros.\n\nApproved on\nhttps://groups.google.com/a/chromium.org/g/cxx/c/lVQOJTng1RU.\n\nBug: none\nChange-Id: Ibe0f8f16bce55b3ede4c1e1d2720e83e8dd4faf0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5852373\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nOwners-Override: danakj \u003cdanakj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1356840}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4b18d0c047503e82fdfc53c8b57a397458b18958\n" }, { "commit": "7402306a11fa8215833f258e11bd38572af064dd", "tree": "92dd4367b6e81ee2312d42ac315737365dbe1c59", "parents": [ "e078cbd20db7ee4a31b1d3cd0a5d13d1d353415e" ], "author": { "name": "Adam Rice", "email": "ricea@chromium.org", "time": "Tue Sep 03 16:16:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 03 16:20:54 2024" }, "message": "Replace if () NOTREACHED() with CHECK() in [\u0027ppapi/proxy\u0027, \u0027ppapi\u0027]\n\nReplace simple cases of if (foo) NOTREACHED(); and if (!bar)\nNOTREACHED() with CHECK(!foo); and CHECK(bar) in\n[\u0027ppapi/proxy\u0027, \u0027ppapi\u0027].\n\nThis aligns with current guidance:\nhttps://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/checks.md#:~:text\u003dUse%20CHECK(bar)%3B%20instead\n\nMost changes were automated with regular expression substitutions.\n\nIn some cases the expression in the condition could have side effects.\nIn these cases, a temporary variable was manually added to hold the\nreturn value and then CHECK()d separately, ensuring that the side-effect\nstill happens if the CHECK is removed.\n\nThis CL was uploaded by git cl split.\n\nR\u003ddschuff@chromium.org\n\nChange-Id: If760799c4793fddfb3395271b5111b66e70658f0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5831667\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nAuto-Submit: Adam Rice \u003cricea@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1350203}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 36af41796c2b7e2eac0b28d84778b9fd9fa0dc2e\n" }, { "commit": "e078cbd20db7ee4a31b1d3cd0a5d13d1d353415e", "tree": "d2ed08b8341a1ed8f242c910b11990ab36bedafd", "parents": [ "89bec5c23e1ff22dead9b678868c4e59e9b3f02b" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Wed Aug 28 01:31:32 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 28 01:34:51 2024" }, "message": "Migrate to NOTREACHED() in ppapi/\n\nNOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.\nThe former is [[noreturn]] so this CL also performs dead-code removal\nafter the NOTREACHED().\n\nThis CL does not attempt to do additional rewrites of any surrounding\ncode, like:\n\nif (!foo) {\n NOTREACHED();\n}\n\nto CHECK(foo);\n\nThose transforms take a non-trivial amount of time (and there are\nthousands of instances). Cleanup can be left as an exercise for the\nreader.\n\nBug: 40580068\nLow-Coverage-Reason: OTHER Should-be-unreachable code\nChange-Id: I5cc3842d53e2f64bd738e2c911a4778dcaf9dcc8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5815717\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1347762}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7e02e59c558bf533334d92d305e3c6a19b9113a8\n" }, { "commit": "89bec5c23e1ff22dead9b678868c4e59e9b3f02b", "tree": "a49ae3e47ed8a02a3b5cfd6d6aba0ec264729fb9", "parents": [ "451fb8177106bc7dbb7fb13d9084a8c0e3a01512" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Aug 15 15:59:16 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 15 16:06:32 2024" }, "message": "Comment some functions that should be UNSAFE_BUFFER_USAGE.\n\nWhenever \"passing the buck\" to the caller to provide safe arguments\nused in an UNSAFE_BUFFERS() region of the code, enforcement must also\nbe passed to the caller via UNSAFE_BUFFER_USAGE. Note places where\nthis is not happening, but do not enforce as it would cause breakage.\n\nNo code changes.\n\n-- Upcase one SAFETY comment found along the way.\n\nChange-Id: I5f5d0b877faf1ee289772efcc7a35cb7d04f4b4a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789370\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1342288}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 590a856c7cd9bfde626bc7c49ee27e86c74b0045\n" }, { "commit": "451fb8177106bc7dbb7fb13d9084a8c0e3a01512", "tree": "1ce28a0907ffb433ed951091d7372a47e3c9c713", "parents": [ "391f3a32ae3af1e817a8a2e0576d958850eaaed8" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Thu Aug 15 02:46:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 15 02:52:32 2024" }, "message": "Convert non-conforming UNSAFE_BUFFERS() usage to UNSAFE_TODO().\n\nPer the updated unsafe_buffers.md, UNSAFE_BUFFERS() should only\nbe used for cases where subsequent spanification is not possible, and\nthat other cases should use the UNSAFE_TODO() macro.\n\nThen update existing usage to conform to this convention. Code lacking\nsafety comments is converted to UNSAFE_TODO() as well.\n\nDocument some functions that should propagate unsafety to their\ncallers via UNSAFE_BUFFER_USAGE but do not enforce this.\n\nChange-Id: Ieb6472102a2e245d040b4d4ad50317c2358d9783\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786346\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1342098}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5faa765c54924de23c29fd2c29d7a7c0489d8871\n" }, { "commit": "391f3a32ae3af1e817a8a2e0576d958850eaaed8", "tree": "b78e2bf9a82a4c322bce0d768ecd6418b21fb3e4", "parents": [ "ec215d57f02706362aa5aa96fad303abd81d75e9" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Aug 14 22:44:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 14 22:52:24 2024" }, "message": "Prepare to mark UNSAFE_BUFFER_USAGE for unsafe methods in file.h.\n\nFind the existing callers and tag them with UNSAFE_TODO() rather than\ntrying to re-write them all to safer forms in a large patch such as\nthis. They can be addressed individually later on.\n\nStop short of marking these unsafe in file.h. This should happen in\na single-file patch to ease reversion should it be necessary.\n\n-- Mark file.cc implementation as UNSAFE_BUFFERS() and justify safety.\n\nChange-Id: Iea0763a950944cd0601dc55aeb1f2d1d4ab58201\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5787102\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1342002}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e9b4dd552351e919384c67cb47a2bcf83d3116b8\n" }, { "commit": "ec215d57f02706362aa5aa96fad303abd81d75e9", "tree": "2a697bc3d1ea8bf71056e1d79fd7357b10c632bf", "parents": [ "9885b1c62d5c7e6c5135da81d73bb304c287ba47" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Aug 14 15:31:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 14 15:41:31 2024" }, "message": "Convert span::copy_from() to copy_prefix_from() where possible.\n\nUse copy_prefix_from() to avoid cases where the exact same length\nargument must appear in a prior first() or subspan() call, or where\nwe would obtain the size() of the container for the same.\n\n-- Do the same for HeapArray\u003c\u003e::copy_from() calls as well.\n\nChange-Id: If88a38a0657de8774e72f13ed746ea19fff688cd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5785548\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1341678}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ce8db96c3d470b51f5be6ca9444220a22bcf192e\n" }, { "commit": "9885b1c62d5c7e6c5135da81d73bb304c287ba47", "tree": "929050bd09b7551a5037c77d4b8ddb739216cfcc", "parents": [ "5bc716181a2e6f00d8855e2cfed75122185e39a4" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Mon Aug 12 13:30:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 12 13:38:45 2024" }, "message": "Use spanified version of SyncSocket in //ppapi/\n\nBug: 40284755\nChange-Id: Iadd2481835dccd88a58ad73b2074ec35cbb3df6a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776843\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nAuto-Submit: Jan Keitel \u003cjkeitel@google.com\u003e\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1340345}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bc99dcc75e347e05834dd815ec403fc003138ddc\n" }, { "commit": "5bc716181a2e6f00d8855e2cfed75122185e39a4", "tree": "4d44b4abc52de930fa81d232e0920fa0bd859596", "parents": [ "f2533d09bfd050bccb57c65aacd17560c09e6269" ], "author": { "name": "Marijn Kruisselbrink", "email": "mek@chromium.org", "time": "Tue Aug 06 19:35:03 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 06 19:56:27 2024" }, "message": "Revert \"Remove deprecated SyncSocket::Receive overload.\"\n\nThis reverts commit 53e46965d0e37d3ef4574965ef70fa50e473e415.\n\nReason for revert: Appears to be causing test failures in\nhttps://ci.chromium.org/ui/p/chromium/builders/ci/win11-arm64-rel-tests/2022/overview\nin WinAudioTest.SyncSocketBasic\n\nOriginal change\u0027s description:\n\u003e Remove deprecated SyncSocket::Receive overload.\n\u003e\n\u003e Bug: 40284755\n\u003e Change-Id: I8ec04c78dbf1c4afb8b86383f510290fec690a6f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756485\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Reviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\n\u003e Reviewed-by: Dale Curtis \u003cdalecurtis@chromium.org\u003e\n\u003e Commit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1337703}\n\nBug: 40284755\nChange-Id: Ib289784abfcae1badeccd1042e0a9a5c851cf557\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5766535\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Marijn Kruisselbrink \u003cmek@chromium.org\u003e\nAuto-Submit: Marijn Kruisselbrink \u003cmek@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1338045}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2d3d580dcb74d8bfcb2698c3ace7efa2b8a9ce94\n" }, { "commit": "f2533d09bfd050bccb57c65aacd17560c09e6269", "tree": "9e286f615044b51fb37677e1342d62e98ac2c5a8", "parents": [ "ce18c1afdf6fe7d9f7a28081039e5037212a5e59" ], "author": { "name": "Jan Keitel", "email": "jkeitel@google.com", "time": "Tue Aug 06 06:58:38 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 06 07:08:58 2024" }, "message": "Remove deprecated SyncSocket::Receive overload.\n\nBug: 40284755\nChange-Id: I8ec04c78dbf1c4afb8b86383f510290fec690a6f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756485\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Dale Curtis \u003cdalecurtis@chromium.org\u003e\nCommit-Queue: Jan Keitel \u003cjkeitel@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1337703}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 53e46965d0e37d3ef4574965ef70fa50e473e415\n" }, { "commit": "ce18c1afdf6fe7d9f7a28081039e5037212a5e59", "tree": "4d44b4abc52de930fa81d232e0920fa0bd859596", "parents": [ "92c5a8e28414463acb6a2d558c8ef70933283a2d" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Tue Jul 23 11:44:02 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 23 11:50:08 2024" }, "message": "spanification: Add `#pragma allow_unsafe_buffers` to ppapi/*\n\nThis is a preparation to fix each files.\nThis CL has no behavior changes.\n\nThis patch was fully automated using script:\nhttps://paste.googleplex.com/5614491201175552\n\nNote that in patchset2, change to:\n/build/config/unsafe_buffers_paths.txt\nwas reverted. Indeed, running too many (~3) CQ run touching this file is\nmaking the builder cache much slower. I will bundle every change to this\nfile in a subsequent CL. I will limit myself to 1-2 CQ run per day.\n\nSee internal doc about it:\nhttps://docs.google.com/document/d/1erdcokeh6rfBqs_h0drHqSLtbDbB61j7j3O2Pz8NH78/edit?resourcekey\u003d0-hNe6w1hYAYyVXGEpWI7HVA\u0026tab\u003dt.0\n\nBug: 40285824\nChange-Id: I197d58af5a64e5e431804aff326ce69ff367a94b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5718350\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nAuto-Submit: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1331670}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 71bed2b10d8825d8b7310c12271381ec3665f536\n" }, { "commit": "92c5a8e28414463acb6a2d558c8ef70933283a2d", "tree": "a8a3cdf006af9b73335e73e084b4373bd8f43099", "parents": [ "397878e178a0ace14adc7326cd3bf4ff9d4f302e" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Thu Jul 18 14:13:43 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 18 14:32:42 2024" }, "message": "[Code Health] Remove a use of base::SupportsWeakPtr. (ppapi)\n\nBug: 40485134\nChange-Id: Ib5111cb92482c1dd8a673d16646b12b306b35aae\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5716904\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1329508}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f4f27b4ab3e3ae80ae0073732e350050531fe1b9\n" }, { "commit": "397878e178a0ace14adc7326cd3bf4ff9d4f302e", "tree": "295bdf912ec14633c6ef72b2c52a6763f2787d3c", "parents": [ "5005c99e115e16654b5c5f236e85f33d25be9473" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Mon Jul 15 17:27:08 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 15 17:35:21 2024" }, "message": "Turn iterator _!\u003d_.end() DCHECK() into CHECK() for ppapi\n\nAccessing an invalid iterator can sometimes be a security\nissue and these checks are cheap, so upgrade to CHECKs.\nGenerally these DCHECKS precede a use or erase of the\nchecked iterator, which if the check is invalid (ie. the\niterator \u003d\u003d .end()) is UB.\n\nAdded checks are NotFatalUntil::M130.\n\n`base/not_fatal_until.h` is added using tools/add_header.py,\nthis may result in some main-file (foo.h for foo.cc) headers\nbeing re-sorted to be first as part `git cl format` of this CL.\n\nFor this CL instances were located with a weggli query:\n\n```\nweggli --verbose\u003d1 --cpp \\\n \u0027DCHECK(_ !\u003d _.end());\u0027 \\\n -p \u0027DCHECK(_.end() !\u003d _);\u0027 \\\n -p \u0027DCHECK_NE(_, _.end());\u0027 \\\n -p \u0027DCHECK_NE(_.end(), _);\u0027\n```\n\nwhich should avoid any potentially expensive calculations\nof the thing to be matched against .end().\n\nThis CL was uploaded by git cl split.\n\nR\u003ddschuff@chromium.org\n\nBug: 351745839\nChange-Id: Idf9a2d1c453c6f160ea93a7380a86eff6de37410\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5706543\nAuto-Submit: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1327588}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 24755334f790e60f291a367b2d270e273a401400\n" }, { "commit": "5005c99e115e16654b5c5f236e85f33d25be9473", "tree": "5b54f4bb8da67212ff646b79230e19186066aeb9", "parents": [ "a2b595c5e8dddb27d60bd48b68e9b758fa221a9d" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Tue Jul 09 18:50:17 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 15 17:34:57 2024" }, "message": "Turn iterator $var!\u003d.end() DCHECK() into CHECK() for ppapi\n\nAccessing an invalid iterator can sometimes be a security\nissue and these checks are cheap, so upgrade to CHECKs.\n\nAdded checks are NotFatalUntil::M130.\n\n`base/not_fatal_until.h` is added using tools/add_header.py,\nthis may result in some main-file (foo.h for foo.cc) headers\nbeing re-sorted to be first as part `git cl format` of this CL.\n\nFor this CL instances were located with a weggli query:\n\n```\nweggli --verbose\u003d1 --cpp \\\n \u0027DCHECK($var !\u003d _.end());\u0027 \\\n -p \u0027DCHECK(_.end() !\u003d $var);\u0027 \\\n -p \u0027DCHECK_NE($var, _.end());\u0027 \\\n -p \u0027DCHECK_NE(_.end(), $var);\u0027\n```\n\nwhich should avoid any potentially expensive calculations\nof the thing to be matched against .end().\n\nThis CL was uploaded by git cl split.\n\nR\u003ddschuff@chromium.org\n\nBug: 351745839\nChange-Id: Ice0f641a66dbfa1123b4c79f2f79d575d3582d45\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689810\nAuto-Submit: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1325021}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 39e28c4fcfbf41dda83cb4d08d2c9f99e3228f22\n" }, { "commit": "a2b595c5e8dddb27d60bd48b68e9b758fa221a9d", "tree": "7efb337e677cfdd58bdda1c37a483b608f074ded", "parents": [ "0228dd7fc4b87c6ed1025aaf16da3e06c639c83f" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Mon Jul 08 23:23:06 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 08 23:42:29 2024" }, "message": "Turn iterator .end() DCHECK() into CHECK() for ppapi\n\nAccessing an invalid iterator can sometimes be a security\nissue and these checks are cheap, so upgrade to CHECKs.\n\nFor this CL instances were located with a weggli query\nof `DCHECK(_ !\u003d _.end());` and some filtering of paths.\n\nThis CL was uploaded by git cl split.\n\nR\u003ddschuff@chromium.org\n\nBug: 351745839\nChange-Id: I58efec05840dae8b3d64b77ab08f8020e918562c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5685835\nAuto-Submit: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1324565}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eab05c5c69fecd38eabc806e5b7935b6f85ddce2\n" }, { "commit": "0228dd7fc4b87c6ed1025aaf16da3e06c639c83f", "tree": "435e4d29079fe07f5ffc1b64f5d07fd58fc7ff80", "parents": [ "5d07082960ef4419da1c258adbdb9dc02fb95648" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Wed Jun 19 14:39:26 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 19 15:16:59 2024" }, "message": "[Code Health] Remove a use of base::SupportsWeakPtr. (ppapi)\n\nBug: 40485134\nChange-Id: I8f0a24a364ca6f6cb81c072f297af6ca55018794\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639216\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1317027}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0b0bee3828bc68a05a87e268368d9562c70cda49\n" }, { "commit": "5d07082960ef4419da1c258adbdb9dc02fb95648", "tree": "17b118b0d431258beca28dd169da01064950e217", "parents": [ "748251c5cb7749319172b55b43d012019ebd9751" ], "author": { "name": "Nan Lin", "email": "linnan@chromium.org", "time": "Mon Jun 17 17:13:36 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 17 17:50:18 2024" }, "message": "[Code Health] Use base::HeapArray in ppapi/proxy/file_io_resource.cc\n\nBug: 326458693, 326459114\nChange-Id: I2b6db6980c4fea1dd94dc8364c7602546dc51d55\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5626931\nCommit-Queue: Nan Lin \u003clinnan@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1315946}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c8d265c23bf030d1ef2415ea0dacd4a35dc579b8\n" }, { "commit": "748251c5cb7749319172b55b43d012019ebd9751", "tree": "e176c44d7edfccd26dabf158b225a69fab2f77c9", "parents": [ "031d4e071373d7b212b3f6e58f96da83fa6d8f1e" ], "author": { "name": "Maria Kazinova", "email": "kazinova@google.com", "time": "Tue Jun 11 13:30:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 11 13:47:58 2024" }, "message": "[CodeHealth] Use base::HeapArray in video_capture_resource.cc\n\nReplace std::unique_ptr\u003cT[]\u003e pattern with a base::HeapArray.\n\nFixed: 326458736\nChange-Id: If4cfc23e0971ae4116815553efa83af6f049cba6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5621070\nCommit-Queue: Maria Kazinova \u003ckazinova@google.com\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1313366}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fb408e30cff17e27e5b03ee7142c0a911dc71b5b\n" }, { "commit": "031d4e071373d7b212b3f6e58f96da83fa6d8f1e", "tree": "3fa2cf576e2822deaea06b583f38d313f1ce7f7c", "parents": [ "0dede6942e1708890dea40d237d07d92ed4c2252" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Tue Jun 11 13:05:35 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 11 13:47:36 2024" }, "message": "Convert base::StringPiece to std::string_view left overs.\n\nThe changes of this CL are made using the following script.\nScript: https://issues.chromium.org/issues/40506050#comment343\n\nBug: 40506050\nChange-Id: I768b3590141a698385319a615f2aefb71215ec84\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601472\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Helmut Januschka \u003chelmut@januschka.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1313356}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1dce9dcaeaa1b6b2a278869566f7554c62b10dc7\n" }, { "commit": "0dede6942e1708890dea40d237d07d92ed4c2252", "tree": "bf1cfe8b26040bbf2ee92e972c9a84095f3bdb95", "parents": [ "99eb5b287436bce7719ce98bc7bbe34b6018415a" ], "author": { "name": "Colin Blundell", "email": "blundell@chromium.org", "time": "Wed May 22 11:09:56 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 22 11:21:26 2024" }, "message": "[//ppapi] Convert to Mailbox::Generate()\n\nNo functional change, as Mailbox::GenerateForSharedImage() is now an\nalias for Mailbox::Generate().\n\nBug: 337538024, 40057997\nChange-Id: I5b3637ea4c69a6775d209b720864c3dd4ff2ef13\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5557181\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCommit-Queue: Colin Blundell \u003cblundell@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1304344}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d923c84f1e9624e3c9518100888d02ecfe96ff58\n" }, { "commit": "99eb5b287436bce7719ce98bc7bbe34b6018415a", "tree": "f952ea2e5d33148fbcdb941254d7483c04f09e7e", "parents": [ "23f73c7de2338303c2e3adb6f55e7134611a6256" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Fri May 17 21:35:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri May 17 21:52:01 2024" }, "message": "Migrate most remaining NOTREACHED()\n\nThis s/NOTREACHED()/NOTREACHED_IN_MIGRATION() for most of remaining\nsrc/. Then I went through all changes and made sure that we didn\u0027t do\nthis for comments or \"NOTREACHED(): \" log strings.\n\nRolling in the corresponding change for remaining third_party/crashpad\nis separately up for review.\n\nBug: 40580068\nLow-Coverage-Reason: TRIVIAL_CHANGE Unreachable code is not reachable.\nChange-Id: I707e582b710bf65474db2e3477fa06f5b8d8ea06\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545807\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1302866}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 188188db8b3f38a3ab1526b1e831dc60e5d7ca56\n" }, { "commit": "23f73c7de2338303c2e3adb6f55e7134611a6256", "tree": "188a63bcad2f8f3ef82c443f754acac07b824b7b", "parents": [ "7d06a49bbf670b6388f20e0fb0c461052969ad7d" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Thu May 16 23:41:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 16 23:50:20 2024" }, "message": "Use NOTREACHED_IN_MIGRATION() in the rest of src/\n\nThis was generated by replacing \" NOTREACHED()\" with\n\" NOTREACHED_IN_MIGRATION()\" and running git cl format.\n\nThis prepares for making NOTREACHED() [[noreturn]] alongside\nNotReachedIsFatal migration of existing inventory.\n\nthird_party/crashpad is still excluded, needs to be changed upstream.\n\nBug: 40580068\nChange-Id: Ia5dbaddf53dba2fedefb67f1d428e8b24e9edffe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545021\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1302314}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7843eba21442cc636a76d546ca6ea69aacfd621f\n" }, { "commit": "7d06a49bbf670b6388f20e0fb0c461052969ad7d", "tree": "a05b3fe2f4c9b61459fca48f4db7912383be4ffa", "parents": [ "7387f9176ccf83cabcd715231fd054c77d302783" ], "author": { "name": "danakj", "email": "danakj@chromium.org", "time": "Thu May 09 20:38:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 09 20:45:25 2024" }, "message": "Remove use of the pointer version of RandBytes, use span always\n\nThe pointer-based crypto::RandBytes() overload can\u0027t be removed until\nnearby stops using it: https://crrev.com/c/5529443 will do this.\n\nThe pointer-based base::RandBytes() will be removed next.\n\nBug: 40284755\nChange-Id: I72c79e23e120f988b091dd2576de180a1c60d2b7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5514816\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1298850}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 95305d27de8b9314150d6c1637d979809cfbb08c\n" }, { "commit": "7387f9176ccf83cabcd715231fd054c77d302783", "tree": "025f6d79d7666ff6a53c4094059e394b0b38a581", "parents": [ "f73eca2c6ad0dd7d1721f5149dae2b2bb51c1922" ], "author": { "name": "Alison Gale", "email": "agale@chromium.org", "time": "Fri Apr 19 21:31:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 19 21:45:18 2024" }, "message": "Migrate TODOs referencing old crbug IDs to the new issue tracker IDs\n\nThe canonical bug format is TODO(crbug.com/\u003cid\u003e). TODOs of the\nfollowing forms will all be migrated to the new format:\n\n- TODO(crbug.com/\u003cold id\u003e)\n- TODO(https://crbug.com/\u003cold id\u003e)\n- TODO(crbug/\u003cold id\u003e)\n- TODO(crbug/monorail/\u003cold id\u003e)\n- TODO(\u003cold id\u003e)\n- TODO(issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/\u003cold id\u003e)\n- TODO(https://issues.chromium.org/u/1/issues/\u003cold id\u003e)\n- TODO(bugs.chromium.org/\u003cold id\u003e)\n\nBug id mapping is sourced from go/chrome-on-buganizer-prod-issues.\nSee go/crbug-todo-migration for details.\n\n#crbug-todo-migration\n\nBug: b/321899722\nChange-Id: Ieeb461e2d489e86fd50b87a2a0721a2be34520c3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467317\nOwners-Override: Alison Gale \u003cagale@chromium.org\u003e\nCommit-Queue: Darryl James \u003cdljames@chromium.org\u003e\nCommit-Queue: Alison Gale \u003cagale@chromium.org\u003e\nReviewed-by: Darryl James \u003cdljames@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1290198}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 47d1537de78d69eb441b4cad8c441f0291faca9a\n" }, { "commit": "f73eca2c6ad0dd7d1721f5149dae2b2bb51c1922", "tree": "2335dbd2ba6cd8f80dbbe3088185bae9f4f2b964", "parents": [ "a4d27b0a2a54e271fcdec88129830470c73962a6" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Apr 15 16:59:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 17:05:57 2024" }, "message": "format windows headers using new config.\n\nTest new config:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5197064\n\nby applying clang-format on every problematic windows headers.\n\nThis CL is cloned from https://crrev.com/c/5366045.\n\nScript:\n-------\n\n```\nfunction replace {\n echo \"Replacing $1 by $2\"\n git grep -l \"$1\" \\\n | cut -f1 -d: \\\n | grep \\\n -e \"\\.h\" \\\n -e \"\\.cc\" \\\n | grep -v \"third_party/[^b]\" \\\n | sort \\\n | uniq \\\n | xargs sed -i \"s/$1/$2/gi\"\n}\n\ngit checkout origin/main\ngit branch -D change-5197064 || true\n\ngit new-branch change-5197064\nreplace \"#include \u003c\\(initguid|mmdeviceapi\\|windows\\|winsock2\\|ws2tcpip\\|shobjidl\\|atlbase\\|ole2\\|unknwn\\|objbase\\|tchar\\).h\u003e\" \"\"\nreplace \"#include \\\"base\\\\/win\\\\/atl.h\\\"\" \"\"\nreplace \"#include \u003cuiautomation.*\u003e\" \"\"\ngit add -u\ngit commit -m \"remove problematic windows headers\"\ngit revert HEAD --no-commit\ngit add -u\ngit commit -m \"add problematic windows headers\"\ngit cl format --upstream\u003dHEAD~\ngit add -u\ngit commit -m \"format\"\n\ngit cl issue 5367127\ngit cl upload -df --bypass-hook\n```\n\nAlso removed some unnecessary comments.\n\nBug: 329138753\nChange-Id: I161c28ea2d27c569825e0c789a4c143530937f58\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367127\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287420}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c8d6b16f02bc9013db2354b8649d2e0d97829a1a\n" }, { "commit": "a4d27b0a2a54e271fcdec88129830470c73962a6", "tree": "d16d85c05b53b21b02fb47969f892cd91f227ac6", "parents": [ "9b3eaa320667408a06b5b74f9aa57081c95402c5" ], "author": { "name": "Nathaniel Manista", "email": "nathaniel@google.com", "time": "Fri Apr 12 06:52:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Apr 12 06:59:08 2024" }, "message": "[base] Drop unused deps on dynamic_annotations\n\nBug: 1282422\nChange-Id: Id5e94e53ddb08ae95eee22deb2e5c61b75ce9264\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3398908\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nCommit-Queue: Nathaniel Manista \u003cnathaniel@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1286330}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 38102e08434b53d587a73e9b381fd37c24d4efc3\n" }, { "commit": "9b3eaa320667408a06b5b74f9aa57081c95402c5", "tree": "cfa46f3e5e8aa204be114ea4451ebcf9cad9de3b", "parents": [ "dd0e855fe9d67975314a87268e1627847aa5ed7c" ], "author": { "name": "Tripta Gupta", "email": "triptagupta19@gmail.com", "time": "Tue Mar 05 13:13:35 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 05 13:24:14 2024" }, "message": "Correcting spelling mistake for word \u0027namespace\u0027\n\nChange-Id: I5f8f81e360bf2ae2336e7ef5ac561a83d4dedde5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340471\nReviewed-by: Reilly Grant \u003creillyg@chromium.org\u003e\nReviewed-by: Yuki Shiino \u003cyukishiino@chromium.org\u003e\nReviewed-by: Brad Nelson \u003cbradnelson@chromium.org\u003e\nCommit-Queue: Alex Ilin \u003calexilin@chromium.org\u003e\nReviewed-by: Solomon Kinard \u003csolomonkinard@chromium.org\u003e\nReviewed-by: Peter Beverloo \u003cpeter@chromium.org\u003e\nReviewed-by: Alex Ilin \u003calexilin@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1268398}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: eca79c79a85706b96b30dde590bd04743c2cbcd5\n" }, { "commit": "dd0e855fe9d67975314a87268e1627847aa5ed7c", "tree": "a8bbe4e7c0fd94b013858c72e4e30f3c22b8cecd", "parents": [ "aff7edafd282e33f861beff7441a1df23b004e35" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Fri Mar 01 18:16:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 01 18:26:34 2024" }, "message": "Spanify net::IPAddress\n\nBug: 40284755\nChange-Id: I5d34df24f83989376f5ef362de835d12728598d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5328526\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: mmenke \u003cmmenke@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Crisrael Lucero \u003ccrisrael@google.com\u003e\nReviewed-by: Danil Somsikov \u003cdsv@chromium.org\u003e\nReviewed-by: Mark Foltz \u003cmfoltz@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1267447}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 159f09337afa1996b45afb4389cbd79f92f6475a\n" }, { "commit": "aff7edafd282e33f861beff7441a1df23b004e35", "tree": "b1ba028db27dc85565b78ae3000ec2b406fe5cc5", "parents": [ "11356f4024e32b1452b58ea2c6eedeee4fc0886b" ], "author": { "name": "Jeff Yoon", "email": "jeffyoon@google.com", "time": "Fri Feb 02 21:26:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 02 21:36:54 2024" }, "message": "[buganizer] Migrate DIR_METADATA for ppapi/\n\nMigrate all metadata files for ppapi and mixins\nused by metadata files under ppapi.\n\nVerify components with http://b/components/{id} or at\ngo/chrome-on-buganizer-prod-components.\n\nBug: chromium:1518875\nChange-Id: Ifabde04097bc22c7d1fa81884daf037bdbdc8d27\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263004\nAuto-Submit: Jeff Yoon \u003cjeffyoon@google.com\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1255767}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 08396b8a9cea8c12a443478f5c1a01be4a276f04\n" }, { "commit": "11356f4024e32b1452b58ea2c6eedeee4fc0886b", "tree": "0b0b174a4416070944147164fa0b606b1e21dded", "parents": [ "4d051811bb9c282632961fe41b01b4aba37b538e" ], "author": { "name": "Vasiliy Telezhnikov", "email": "vasilyt@chromium.org", "time": "Thu Jan 25 16:26:06 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jan 25 16:33:44 2024" }, "message": "Cleanup after UseSharedImagesForPepperVideo\n\nBug: 986480\nChange-Id: I11b293460f482e64383a560ae4e11026ce1de541\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190891\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Dominic Farolino \u003cdom@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1252134}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 11731ea78b508d71cc28d5641effa2f632839d46\n" }, { "commit": "4d051811bb9c282632961fe41b01b4aba37b538e", "tree": "ddbaa146c6b6180b413d8d2aafb2916b2fb1b491", "parents": [ "890e522951ee96976015d2c8ef92ec4948c6a16a" ], "author": { "name": "Lukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Sat Jan 20 16:10:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 20 16:15:42 2024" }, "message": "Remove 1 overload of deprecated `base::Hash` function.\n\nThis CL replaces the callers of the removed overload with calls to\neither `base::FastHash` or `base::PersistentHash`:\n\n* `base/hash/hash_unittest.cc` - calling `PersistentHash` to preserve\n the old behavior (`Hash` forwards to `PersistentHash`).\n* `components/services/heap_profiling/allocation.cc` - calling\n `FastHash`. `AllocationSite::Hash` is used as a hasher of\n `std::unordered_map`.\n* `components/viz/service/display/overlay_candidate_factory.cc` -\n calling `FastHash`:\n * This is consistent with another, preexisting setter of the\n `tracking_id` field in the same source file\n * It seems that this hash is not persisted and is only used\n for comparison operators in `ProposedCandidateKey`\n * A narrowing conversion has been made explicit in this CL\n (this conversion already existed in one of the preexisting setters\n of the `tracking_id` field)\n* `components/viz/service/display/overlay_proposed_candidate.h` -\n calling `FastHash`. `ProposedCandidateKeyHasher` is only used\n as a hasher of `std::unordered_map`.\n* `gpu/command_buffer/service/gr_shader_cache.cc` - calling `FastHash`.\n It seems that `CacheKeyHash` is only used as a hasher of\n `base::HashingLRUCache`.\n* `ppapi/tools/pepper_hash_for_uma.cc` - calling `PersistentHash` to\n preserve the old behavior, because the comment in that file suggests\n that the hash may be compared with data in `histograms.xml` files.\n\nBug: 1025358\nChange-Id: I16691f3115e4098cea1f0d820bc0df8f3a11aaf6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5206108\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249833}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 32f5da52ffe59244a7613ca36c9e8e78ae9ba799\n" }, { "commit": "890e522951ee96976015d2c8ef92ec4948c6a16a", "tree": "0785e68af7f72f43c75f213ee0c31bed17b3c0eb", "parents": [ "abaa6f5f724f19cc633feb04849cfb39411d7b8a" ], "author": { "name": "Lukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Sat Jan 20 03:37:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 20 03:42:58 2024" }, "message": "Use `span` instead of ptr+len pair as param of `base::Hash` function.\n\n`base::Hash` has the following 2 overloads:\n\n ```\n BASE_EXPORT uint32_t Hash(const void* data, size_t length);\n BASE_EXPORT uint32_t Hash(const std::string\u0026 str);\n ```\n\nThis CL replaces the 1st overload with:\n\n ```\n BASE_EXPORT uint32_t Hash(base::span\u003cconst uint8_t\u003e data);\n ```\n\n`base::Hash` is a deprecated function that in the long-term should be\nreplaced with either 1) `base::FastHash` (result can vary when launching\nChrome or tests another time) or 2) `base::PersistentHash` (same result\nevery time forever). Deprecation is tracked in\nhttps://crbug.com/1025358. To minimize risk and amount of changes this\nCL preserves the old behavior (i.e. continues to use the deprecated\n`base::Hash`) and the removal will be attempted in a separate WIP CL at\nhttps://crrev.com/c/5206108.\n\nBug: 1490484\nChange-Id: I79bb4da4da1e1cd1d344c0cff89a08256def6fc5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202747\nCommit-Queue: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: Siddhartha S \u003cssid@chromium.org\u003e\nReviewed-by: Victor Miura \u003cvmiura@chromium.org\u003e\nReviewed-by: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Vladimir Levin \u003cvmpstr@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nAuto-Submit: Łukasz Anforowicz \u003clukasza@chromium.org\u003e\nReviewed-by: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1249778}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 8d657430b73999e667d47be26b94c93f8ddbb8ae\n" }, { "commit": "abaa6f5f724f19cc633feb04849cfb39411d7b8a", "tree": "8aacbbde5a258f75e0cc805250e0d108840819e7", "parents": [ "431ce71e86a2fc9099104f70f01c6c626a098731" ], "author": { "name": "Helmut Januschka", "email": "helmut@januschka.com", "time": "Wed Jan 17 14:30:56 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 17 14:42:01 2024" }, "message": "ppapi: Quit.*Deprecated() runloop refactoring\n\nBug: 922118\nChange-Id: Ia221157ffd16cffc9a9b892d10bb98cff790ec06\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5148230\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1248116}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 417357f866a2a406b4e84b6c32c9efaec8335c25\n" }, { "commit": "431ce71e86a2fc9099104f70f01c6c626a098731", "tree": "b9117ff12aa4db0efbef5c6bf5bc9e5befc73f5a", "parents": [ "d848b882c850887accb765e63232cae9d6399536" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Sat Jan 13 05:46:29 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 13 05:53:14 2024" }, "message": "Land invariants from crrev.com/c/5191363\n\nThis splits out rewrites of LOG(FATAL)s to use invariants where it\u0027s\nreasonably obvious that they should\u0027ve been CHECKs and NOTREACHEDs in\nthe first place.\n\nThis makes the larger [[noreturn]] CL easier to review as it\u0027s just\nremoving obviously-dead code.\n\nBug: 1409729\nChange-Id: I3bf899c7d475f705089c983a8b10425a4f478bbe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195484\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nOwners-Override: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1246827}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f5d51556858a395c3e897bb09e415a100ea69895\n" }, { "commit": "d848b882c850887accb765e63232cae9d6399536", "tree": "5233de7f89d6c97acb576a42f3470b8844b7a700", "parents": [ "c9516d6f6ce576829243f6b973d71dddda3e0f04" ], "author": { "name": "Derek Schuff", "email": "dschuff@chromium.org", "time": "Mon Dec 11 19:46:09 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 11 19:57:10 2023" }, "message": "Remove remaining uses of NACL_WIN64 ifdef\n\nSince revision 517bec58eb, this define is never set anymore.\n\nBug: b/303417958\nChange-Id: Ic0b23fc64b323f3e64d5b70c455c807c59afd93b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5105506\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Robert Sesek \u003crsesek@chromium.org\u003e\nReviewed-by: Mustafa Emre Acer \u003cmeacer@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Kai Ninomiya \u003ckainino@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1235893}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 767eaa5193f34b990ebef8e0cc5d61e33036e725\n" }, { "commit": "c9516d6f6ce576829243f6b973d71dddda3e0f04", "tree": "42840355febbdd43e8682185310ecd0b0f73e5f8", "parents": [ "0009b0ac00692a4e97afbabaf9d4b25cbf974a13" ], "author": { "name": "Gabriel Gauthier-Shalom", "email": "gabrielgs@google.com", "time": "Wed Nov 29 22:11:19 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 29 22:21:15 2023" }, "message": "Replace feature_list\u0027s Initialize* methods with Init*.\n\nThis is for consistency with scoped_feature_list\u0027s equivalent functions.\n\nBUG\u003d659848\n\nChange-Id: I03dd36368023dfff678fb37a4437285d8f6fd488\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037591\nReviewed-by: Richard (Torne) Coles \u003ctorne@chromium.org\u003e\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Rakina Zata Amni \u003crakina@chromium.org\u003e\nReviewed-by: Cait Phillips \u003ccaitkp@chromium.org\u003e\nReviewed-by: John Rummell \u003cjrummell@chromium.org\u003e\nReviewed-by: Roger McFarlane \u003crogerm@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Victor Tan \u003cvictortan@chromium.org\u003e\nCommit-Queue: Gabriel Gauthier-Shalom \u003cgabrielgs@google.com\u003e\nReviewed-by: Luc Nguyen \u003clucnguyen@google.com\u003e\nReviewed-by: Peng Huang \u003cpenghuang@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Luke Halliwell \u003challiwell@chromium.org\u003e\nReviewed-by: Alexei Svitkine \u003casvitkine@chromium.org\u003e\nReviewed-by: Vasilii Sukhanov \u003cvasilii@chromium.org\u003e\nReviewed-by: ccameron chromium \u003cccameron@chromium.org\u003e\nBot-Commit: Gabriel Gauthier-Shalom \u003cgabrielgs@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1230945}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 89627a67a07c706ee1295fcd013731a29d0fc420\n" }, { "commit": "0009b0ac00692a4e97afbabaf9d4b25cbf974a13", "tree": "1bdcacf3b52ef6946b1f759664bfcbc00585dd73", "parents": [ "2d46a74dd41c8264aa3aa6af994a4918fa7e6507" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Mon Nov 27 13:52:18 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 27 14:01:04 2023" }, "message": "Avoid memcpy(NULL, 0) in VarTracker\n\nDue to a C language bug, memcpy(NULL, 0) is forbidden, even though\n(NULL, 0) is a fine representation of the empty slice.\n\nhttps://luci-milo.appspot.com/ui/inv/build-8764165598299826001/test-results?q\u003dOutOfProcessPPAPITest.MessageHandler\u0026sortby\u003d\u0026groupby\u003d\n\nThe STL functions don\u0027t have this bug, so use that instead. Though it\ndoes require a slightly annoying cast.\n\nBug: 1394755\nChange-Id: If33611737fa716b1494364cbcc9ad802409c8b47\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041339\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1229286}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9619da16989dcc4c826f99d725dc91c387d11b69\n" }, { "commit": "2d46a74dd41c8264aa3aa6af994a4918fa7e6507", "tree": "757bf8434b2380f841643138c5ac7938d6c6d760", "parents": [ "07dd59cf25f0e1853e7c912b4d1d2bf96861abd9" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Wed Nov 22 19:47:38 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 22 20:00:54 2023" }, "message": "Reland \"Remove PPAPI if NaCl is disabled\"\n\nThis is a reland of commit 45c5328582baa317fe827f5c568047810bea3277\n\nIt was previously reverted due to archiving still present on the\nbots. This was removed in https://chromium-review.googlesource.com/c/chromium/src/+/5049267 so it should be\nhopefully good to land again.\n\nOriginal change\u0027s description:\n\u003e Remove PPAPI if NaCl is disabled\n\u003e\n\u003e PPAPI\u0027s only consumer was NaCl. With it disabled we should disable\n\u003e PPAPI as well.\n\u003e\n\u003e Decreases Window\u0027s chrome.dll by 1422k.\n\u003e\n\u003e Bug: b:303417958, 702990\n\u003e Change-Id: Ibe4c9fb10de47d74d131547ea0f87e5702b4aff6\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017518\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Commit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1227581}\n\nBug: b:303417958, 702990\nChange-Id: I4ae025304072beb204eff3d8a2713fd755f1c5c9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054457\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1228144}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a1486453e2e4c3560e5f9288d2153b93a8bf531\n" }, { "commit": "07dd59cf25f0e1853e7c912b4d1d2bf96861abd9", "tree": "5efeec465033ff76ac5cdaa8e22378bf4c446955", "parents": [ "682b68d86670a99d41ddb56498b105833005e182" ], "author": { "name": "Maggie Cai", "email": "mxcai@chromium.org", "time": "Wed Nov 22 00:41:30 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 22 00:48:52 2023" }, "message": "Revert \"Remove PPAPI if NaCl is disabled\"\n\nThis reverts commit 45c5328582baa317fe827f5c568047810bea3277.\n\nReason for revert: This CL seems to be the reason that causes some archive bots failures. There are three bot failures: https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-archive-rel, https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel and https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel. Both failed because missing blink_test_plugin and blink_deprecated_test_plugin, which seems to be part of ppapi. First failures on: https://ci.chromium.org/ui/b/8763785537596666865, https://ci.chromium.org/ui/b/8763784707698597681, and https://ci.chromium.org/ui/b/8763784745244932353\n\nOriginal change\u0027s description:\n\u003e Remove PPAPI if NaCl is disabled\n\u003e\n\u003e PPAPI\u0027s only consumer was NaCl. With it disabled we should disable\n\u003e PPAPI as well.\n\u003e\n\u003e Decreases Window\u0027s chrome.dll by 1422k.\n\u003e\n\u003e Bug: b:303417958, 702990\n\u003e Change-Id: Ibe4c9fb10de47d74d131547ea0f87e5702b4aff6\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017518\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Commit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1227581}\n\nBug: b:303417958, 702990\nChange-Id: I5c74e1e3aea0282083b9ca7d5a07f66d5b068f75\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5052002\nCommit-Queue: Maggie Cai \u003cmxcai@chromium.org\u003e\nOwners-Override: Maggie Cai \u003cmxcai@chromium.org\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1227713}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 67e9c9f5903a3dc2c9b6e0655792ee994aa0251e\n" }, { "commit": "682b68d86670a99d41ddb56498b105833005e182", "tree": "757bf8434b2380f841643138c5ac7938d6c6d760", "parents": [ "f0b2f011297f2fe76923533c49366c0a2dab6094" ], "author": { "name": "Dave Tapuska", "email": "dtapuska@chromium.org", "time": "Tue Nov 21 20:48:08 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 21 20:59:08 2023" }, "message": "Remove PPAPI if NaCl is disabled\n\nPPAPI\u0027s only consumer was NaCl. With it disabled we should disable\nPPAPI as well.\n\nDecreases Window\u0027s chrome.dll by 1422k.\n\nBug: b:303417958, 702990\nChange-Id: Ibe4c9fb10de47d74d131547ea0f87e5702b4aff6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017518\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Dave Tapuska \u003cdtapuska@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1227581}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 45c5328582baa317fe827f5c568047810bea3277\n" }, { "commit": "f0b2f011297f2fe76923533c49366c0a2dab6094", "tree": "5efeec465033ff76ac5cdaa8e22378bf4c446955", "parents": [ "7ceb448d3b9711c84c1e6da04e4c0ce49cfc4a85" ], "author": { "name": "mark a. foltz", "email": "mfoltz@chromium.org", "time": "Mon Nov 06 21:21:20 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 06 21:31:28 2023" }, "message": "Rename chromecast_build.gni to cast.gni.\n\nAfter the Cast convergence project, the file is generic to all Cast\nimplementations, not just Chromecast.\n\nGenerated with:\n\ntools/git/mffr.py -g \"*.gn\" -g \"*.gni\" -g BUILDCONFIG \\\n\u0027build/config/chromecast_build\\.gni\u0027 \u0027build/config/cast.gni\u0027\n\nNo-Presubmit: True\nBug: 1294964\nChange-Id: Ia50a6287a4eb7c822eec78361ce9e5ccbc8035e1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002469\nReviewed-by: Andrew Grieve \u003cagrieve@chromium.org\u003e\nOwners-Override: Andrew Grieve \u003cagrieve@chromium.org\u003e\nCommit-Queue: Mark Foltz \u003cmfoltz@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1220521}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e185ab2fab864e4cae30c50484a3b4d897e16eea\n" }, { "commit": "7ceb448d3b9711c84c1e6da04e4c0ce49cfc4a85", "tree": "6ffa9f56a10afb82aceaaab45519f80ca7a7fccb", "parents": [ "30cfb338491d5b2c458570dd4672bd4e1a5c601e" ], "author": { "name": "Fabian Sommer", "email": "fabiansommer@chromium.org", "time": "Thu Nov 02 17:09:51 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 02 17:15:26 2023" }, "message": "Add UMA for PPP pepper apis.\n\nWe have UMA stats for PPB APIs.\nAdd them for PPP APIs too so we have the full picture.\n\nBug: 111542\nChange-Id: I7ce387b7a4ff68db61afc2f76fd843cf92b301e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994385\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1218911}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1863bde97f0574135260e83846612e7ba426becb\n" }, { "commit": "30cfb338491d5b2c458570dd4672bd4e1a5c601e", "tree": "1fda41ee0c46e8984743e4deb01ddf4ff18924b6", "parents": [ "5b1b28a737be8a5f83fcd6c9e751c90d6a16d965" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Sat Oct 21 03:46:09 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Oct 21 03:50:53 2023" }, "message": "Rename many Time functions:\n\n* `FromDoubleT()` -\u003e `FromSecondsSinceUnixEpoch()`\n* `ToDoubleT()` -\u003e `InSecondsFSinceUnixEpoch()`\n* `FromJsTime()` -\u003e `FromMillisecondsSinceUnixEpoch()`\n* `ToJsTime*()` -\u003e `InMillisecondsFSinceUnixEpoch*()`\n* `FromJavaTime()` -\u003e `FromMillisecondsSinceUnixEpoch()`\n* `ToJavaTime()` -\u003e `InMillisecondsSinceUnixEpoch()`\n\nThese are more descriptive of the functionality.\n\nNo other changes, aside from typecasting fixes in the following files:\n\n* chrome/browser/ash/arc/fileapi/arc_documents_provider_root.cc\n* third_party/blink/renderer/modules/notifications/notification_data.cc\n* third_party/blink/renderer/modules/notifications/notification_data_test.cc\n\nFurther cleanup will happen separately, since this CL as-is isn\u0027t really\nreviewable, only stampable.\n\nBug: none\nNo-Try: True\nChange-Id: I9ba11d4a5ff0692e6060e3aa47327a6dfc37bbe5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956111\nOwners-Override: Gabriel Charette \u003cgab@chromium.org\u003e\nCommit-Queue: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1213083}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 08b91b49531894cbe9061a1148fd535155c2554b\n" }, { "commit": "5b1b28a737be8a5f83fcd6c9e751c90d6a16d965", "tree": "ce62927afd6eb3bcbb52f4ac8bddb33aab47879a", "parents": [ "e4287cb0a44f74c606fe939796bba72a91fb6851" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Wed Oct 18 13:50:01 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 18 14:06:13 2023" }, "message": "Make StringPrintf() calls use constexpr format strings: ppapi/\n\nBug: 1371963\nChange-Id: I81a3ea7bbe645a855b819b3fa12e9dda6086f4e1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4950503\nReviewed-by: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: Fabian Sommer \u003cfabiansommer@chromium.org\u003e\nCode-Coverage: findit-for-me@appspot.gserviceaccount.com \u003cfindit-for-me@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1211467}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d292c25f54b8c55ac975378fb3c70f9a6b3e57e6\n" }, { "commit": "e4287cb0a44f74c606fe939796bba72a91fb6851", "tree": "bcd8ebae503f55782c5523f7450c8328a9fbfc31", "parents": [ "c917bde2d88defdd3aced36b39fd1ee932fce0a6" ], "author": { "name": "Saifuddin Hitawala", "email": "hitawala@chromium.org", "time": "Wed Oct 04 15:36:46 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 04 15:47:38 2023" }, "message": "Multiplanar: Move GL specific Capabilities\n\nThis change create a new gpu::GLCapabilities which will be moving out\nparams from gpu::Capabilities that are used only with\nGles2Implementation. The idea is to have Capabilities common between\nraster and gles decoders which can be filled in together from a common\nutility whereas GLCapabilities are only set for gles decoders.\n\nThis will help with clarifying changes needed for switching to\nRasterDecoder for VideoResourceUpdater; which will in turn enable us\nto use WritePixelsYUV through the RasterDecoder enabling software\ndecode launch with multiplanar shared images.\n\nBug: 1465939\nChange-Id: I4af5163e69d8db2ff3c51d0c3c24e6d0d11d7175\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864266\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCommit-Queue: Saifuddin Hitawala \u003chitawala@chromium.org\u003e\nReviewed-by: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Dale Curtis \u003cdalecurtis@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1205274}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b2da4f01e3577cf2e7888b7abc235f9a4f645f8c\n" }, { "commit": "c917bde2d88defdd3aced36b39fd1ee932fce0a6", "tree": "07101720a266ab9543ebfe1beb91c3c62f7cc891", "parents": [ "aa499b2b1830fa99f824a0b14da5cd8bf85286a6" ], "author": { "name": "Vasiliy Telezhnikov", "email": "vasilyt@chromium.org", "time": "Mon Oct 02 20:40:19 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Oct 02 20:49:27 2023" }, "message": "Use SharedImages for PPAPI video decode\n\nBefore this CL VideoDecoderResource and VideoDecoderShim (via\nPepperVideoDecoderHost) would exchange textures using legacy mailbox\nsystem. With this CL we replace it with SharedImages.\n\nOld flow:\n* Renderer sends RequestTextures()\n* Plugin allocates textures, puts them in a legacy mailbox and sends\n back AssignTextures.\n* Renderer will pick a free texture, copy video frame into it and send\n texture id with PictureReady.\n* After plugin used texture and don\u0027t need it anymore it sends texture\n back with RecyclePicture.\n* When renderer doesn\u0027t need textures anymore it sends DismissPicture.\n\nNew flow:\n* Renderer allocates SharedImages whenever it needs them\n* Renderer picks free SI, copy video frame into it and sends mailbox\n with SharedImageReady.\n* Plugin gets texture id from it using CreateAndTexStorageSharedImage\n* After plugin is done with the texture, it deletes it (this deletes\n only plugin view of the texture, SharedImage still exists) and sends\n mailbox back.\n* When renderer doesn\u0027t need SI anymore it either Destroys it right\n away or waits for plugin to return it first.\n\nChange-Id: I1500de3a2254acf013ef715349df2e2ecb191322\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4741796\nReviewed-by: Ken Buchanan \u003ckenrb@chromium.org\u003e\nReviewed-by: Pilar Molina Lopez \u003cpmolinalopez@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Andres Calderon Jaramillo \u003candrescj@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1204238}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 86436ef01ed486003d19a460bef0a241b3d3e36c\n" }, { "commit": "aa499b2b1830fa99f824a0b14da5cd8bf85286a6", "tree": "6881cc3cfc8611f610aa6d39d89d2bfa7e60bfa0", "parents": [ "d7e03924e5d5c5612423fe8fef1465d7f9e3b8f3" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Aug 04 23:09:52 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 04 23:18:50 2023" }, "message": "Ban [w]ctype.h: ppapi/\n\nBug: 1361094\nChange-Id: I308905037bed0b2403da6dc5f589b86d2c30f9b4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4749599\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nCommit-Queue: John Abd-El-Malek \u003cjam@chromium.org\u003e\nOwners-Override: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1179913}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 192c07cdd60cf53311f36ce47d00bfbe782412b3\n" }, { "commit": "d7e03924e5d5c5612423fe8fef1465d7f9e3b8f3", "tree": "5587b38012551231a0fab9f5511d911d70eeb01d", "parents": [ "af4309911c143f08c42101099a6ee0eeb0d82b1d" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Aug 04 22:56:01 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 04 23:04:34 2023" }, "message": "Add another ppapi/ OWNER.\n\nBug: 1469952\nChange-Id: I10c749ce07ce902d2ac14e585cd0c22441ef334f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4752713\nAuto-Submit: Peter Kasting \u003cpkasting@chromium.org\u003e\nOwners-Override: John Abd-El-Malek \u003cjam@chromium.org\u003e\nOwners-Override: Peter Kasting \u003cpkasting@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCommit-Queue: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1179902}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cd64ff3c120ecfced9475e82b40ed10bc450933a\n" }, { "commit": "af4309911c143f08c42101099a6ee0eeb0d82b1d", "tree": "512ac7d1ac45eaacbc5941c4eb35f7223220f024", "parents": [ "3b28e09e44c4ec9e2987a4320601e1af39df5b60" ], "author": { "name": "Daniel Vogelheim", "email": "vogelheim@chromium.org", "time": "Tue Jul 18 15:36:51 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 18 15:46:11 2023" }, "message": "Remove ORB \"v0.1\" virtual test suite; use \"v0.2\" instead.\n\nORB \"v0.1\" has been launched. Now prepare for \"v0.2\". This\nmostly deletes files related to tbe orb-v01 virtual suite.\nIt also updated test variations to use \"v0.2\" instead.\n\nBug: 1463725\nChange-Id: I11aecad147156aab507f0dc55b5d69946d53e8fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4505958\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Titouan Rigoudy \u003ctitouan@chromium.org\u003e\nReviewed-by: Noam Rosenthal \u003cnrosenthal@chromium.org\u003e\nCommit-Queue: Daniel Vogelheim \u003cvogelheim@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1171764}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 80544bb59f51b8fa8c2928a1577974065807d6f5\n" }, { "commit": "3b28e09e44c4ec9e2987a4320601e1af39df5b60", "tree": "0b2f8c9be29e64be5b4610883d1116e8f1c6e7d9", "parents": [ "d26213daee95610d0b24a4701f1879dd69d84ae3" ], "author": { "name": "Gabriel Charette", "email": "gab@chromium.org", "time": "Tue Jul 11 14:56:53 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jul 11 15:02:17 2023" }, "message": "[metrics] Address gab\u0027s long-expired histograms\n\nOBSOLETE_HISTOGRAMS\u003dSettings.HashesDictionaryTrusted\n\nFixed: 1460153,1460049,1460057,1460056\nChange-Id: Id9559f17a1d59819bd51f24ad58b755adae11f3a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4660985\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nReviewed-by: Dominic Battre \u003cbattre@chromium.org\u003e\nReviewed-by: Rachel Blum \u003cgroby@chromium.org\u003e\nReviewed-by: Sean Harrison \u003charrisonsean@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1168704}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: bc52b48457e999257111fc724927938a0a8d8723\n" }, { "commit": "d26213daee95610d0b24a4701f1879dd69d84ae3", "tree": "4b6e39f9f6dafa90ed660cd151ce8eacdb05e932", "parents": [ "840553f83b13efef0310f0743e4606d75b96fb9a" ], "author": { "name": "Jeffrey Cohen", "email": "jeffreycohen@google.com", "time": "Mon Jul 10 19:56:18 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 10 20:05:22 2023" }, "message": "[CodeHealth] Resolve destruction order dangling pointer\n\nAdd a CancelAllQueries function to GpuControl to ensure that\nall callbacks can be destroyed before the relevant pointers are\nattempted to be accessed.\n\nBug: 1417181\nChange-Id: I59212f01d6a2c792b9123104002cb49962f56d84\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4664245\nCommit-Queue: Jeffrey Cohen \u003cjeffreycohen@chromium.org\u003e\nReviewed-by: Vasiliy Telezhnikov \u003cvasilyt@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1168269}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 11a6cad5302f5332aa9ec509017304027446fb1a\n" }, { "commit": "840553f83b13efef0310f0743e4606d75b96fb9a", "tree": "8cc291f77f3807dcae32178d64e9f201ed7705af", "parents": [ "dab0fde6790582b464bfef59407b1f56757b1853" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Fri Jul 07 15:52:33 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 07 16:00:14 2023" }, "message": "Remove dead files\n\nThese files have not been compiled since 2020. They were removed\nfrom the BUILD file with https://crrev.com/c/2446369 but were not\ndeleted at that time.\n\nBug: none\nChange-Id: I74ea269b2bf48543c3c79e3b4a40ef6ee6554bd4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4672227\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1167463}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 21fc00b78a613acb5f414dbe4b9eb13a7e3268c9\n" }, { "commit": "dab0fde6790582b464bfef59407b1f56757b1853", "tree": "ce3aa3391cde264e775241204eaee5cc993493d7", "parents": [ "a950c11b3f1bef7979e3ec8eea09127fb7830ee4" ], "author": { "name": "K. Moon", "email": "kmoon@chromium.org", "time": "Fri Jun 16 22:46:57 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 16 22:56:20 2023" }, "message": "Revert \"Derive enable_ppapi from enable_nacl\"\n\nThis reverts commit 902a4b58184bfd8e34b6e7f40b859f1bd85a3dc3.\n\nThis is a partial revert that leaves the testing/buildbot changes alone.\n\nBug: 702990\nChange-Id: I36ca6830a0a97ae7554d17724455670b099fce25\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621912\nReviewed-by: Kevin McNee \u003cmcnee@chromium.org\u003e\nOwners-Override: Kevin McNee \u003cmcnee@google.com\u003e\nAuto-Submit: K. Moon \u003ckmoon@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Kevin McNee \u003cmcnee@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1159151}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 5358001da8403faa6029769a092abbef3c523bb6\n" }, { "commit": "a950c11b3f1bef7979e3ec8eea09127fb7830ee4", "tree": "b77d801e34e2a3aa450aa063d3b192a8d144d8ed", "parents": [ "cc655f45d65038807bd0a493f69d9d7d857ebc66" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Fri Jun 16 21:04:01 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 16 21:12:56 2023" }, "message": "[PPAPI] Remove assertions on plugin behavior.\n\nThe browser is not in control of plugin behavior so should not be\nasserting based on it.\n\nThis converts the assertions in ppapi/host that are dependent on plugin\nbehavior to DLOG(WARNING).\n\nBug: 1454928\nChange-Id: I93be0e668579acff8a66145fb4047c0021717039\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615554\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1159068}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1d34a8f74234042c6c30c088b819dcbc584e6289\n" }, { "commit": "cc655f45d65038807bd0a493f69d9d7d857ebc66", "tree": "85ebe53d4d00815a1b3da8d64bdc88b65b401cc2", "parents": [ "8a3419d29252d44d0858d2cefe2e65cd9c080d78" ], "author": { "name": "K. Moon", "email": "kmoon@chromium.org", "time": "Fri Jun 16 19:00:34 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 16 19:11:36 2023" }, "message": "Derive enable_ppapi from enable_nacl\n\nEnables PPAPI by default only if NaCl is enabled, as NaCl is the only\nPPAPI user left.\n\nThis requires removing the ppapi_unittests step on bots configured with\nenable_nacl\u003dfalse; removes ppapi_unittests from the same configurations\nthat remove nacl_loader_unittests.\n\nBug: 702990\nChange-Id: I7c2c13a8dbb282329cdce7aa85b33bba9bf4a12a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835046\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: K. Moon \u003ckmoon@chromium.org\u003e\nReviewed-by: Wanda Mora \u003cmorawand@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1159004}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 902a4b58184bfd8e34b6e7f40b859f1bd85a3dc3\n" }, { "commit": "8a3419d29252d44d0858d2cefe2e65cd9c080d78", "tree": "3961d427f868d401e26de408365f43d6216a56a8", "parents": [ "32204f90eaeea66f5d9c7282fc526e9066e1bf29" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Mon Jun 12 20:31:29 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 12 20:40:22 2023" }, "message": "Remove spurious STL header includes from ppapi\n\nRemove a bunch of unused includes. Then add includes as needed to fix\nthe build.\n\nChange-Id: Id30743cfb6db3473b30c5357f359a6e92f687057\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582744\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1156401}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c282611501666a6e1f44bcf6a8cc1a19687974e4\n" }, { "commit": "32204f90eaeea66f5d9c7282fc526e9066e1bf29", "tree": "137215516c95bcdfce222d6e4bddeae1bcef2737", "parents": [ "c55b8a0ce84880b882c67ac2fab31d5dc9dff2c0" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Thu Jun 08 17:52:01 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 08 17:59:31 2023" }, "message": "Enable libc++ hardening for NaCl.\n\nSome parts of Chrome are built twice: once as part of the regular Chrome\nbinary, and another time as part of the NaCl IRT. The latter was not\nusing libc++ hardening; however, since the saigo toolchain is controlled\nby the Chrome team, libc++ hardening can be used there as well.\n\nThe compiler configs have been refactored to account for this:\n- enable_safe_libcxx allows configurability of the libc++ hardening\n checks for code that builds against the bundled custom libc++.\n- use_safe_libcxx is calculated based off of the value of\n enable_safe_libcxx except when buildling using the saigo toolchain: in\n that case it is unconditionally enabled.\n\nSince use_safe_libcxx is now relevant even when not using a custom\nlibcxx, the relevant defines have been moved out of the runtime_library\nconfig and into the compiler config.\n\nFinally, to allow the assert failures to be tested, add a new toolchain\nthat is based off the IRT toolchain but using the regular linker. This\nallows the saigo toolchain to build a regular nexe that can be tested in\nthe same way as other nacl tests.\n\nBug: 1335422\nChange-Id: Ib9109ae02491e7e40fd550328316ad96ab920cd3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544053\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Derek Schuff \u003cdschuff@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1154984}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 073353a1593c52bf6988703fb916aad50f4ee188\n" } ], "next": "c55b8a0ce84880b882c67ac2fab31d5dc9dff2c0" }