tree 0a382e73745f8a72e358174c12449c7fdb233b03
parent 88278517be90e7034d083203d2a234319cea5d57
author Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com> 1638222441 +0000
committer Copybara-Service <copybara-worker@google.com> 1638223254 -0800

Linux sandbox: fix glibc 2.33 caused assertion failure

Starting with glibc 2.33, the system() function changed its
return value leading to an assertion failure. To fix the test
for both newer and older glibcs, check the retval is != 0.
The EPERM error is the same, so this should be safe.

For more details see glibc commit:
42dda89dcb ("posix: Fix return value of system if shell can
not be executed")

BUG=b:187795909,b:206128425
TEST=Manually run sandbox unit test on ChromeOS with glibc 2.33

Change-Id: I3c37c049bbe060f79615cecae4d07d37236c1427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296023
Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946159}
NOKEYCHECK=True
GitOrigin-RevId: 53ec0369255fbd0fafcfe94fa10d58e20a327647