tree 4efbe0257e7fd95a727f6bf1cce3051a761b2182
parent f484bc0842f7b42074abcb414f34c838499a36b8
author Erik Luo <luoe@chromium.org> 1555712866 +0000
committer Commit Bot <commit-bot@chromium.org> 1555712866 +0000

DevTools: remove section editing state, manual height in SSP

A) SSP used to manually set height, 'contain: strict' during edits
   for performance. This CL removes them, since there is no
   noticeable gain. See crbug.com/684341

B) Removes unnecessary 'editing state tracking', once used to
   manually focus sections before ShadowDOM-delegatesFocus.
   See also crbug.com/791494

Pre-keyboard navigation) SSP has tabIndex 0. On editingCommitted,
we ensure focus goes back to the pane.

After-keynav) Individual sections have tabIndex -1. On stopEditing,
parent pane has focus, but we manually move focus to the section.

After ShadowDOM V1) parent pane no longer has tabIndex, but uses
'delegatesFocus'. This makes moving focus around unnecessary.
However, it also introduces 'blue flickering' when users 'Tab'
navigate through properties, since focus is first delegated to
the section. This bug is not addressed in this CL.

Bug: 931145
Change-Id: If24177344ec975478fd91937daea58630b396069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574366
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#652667}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a281343ffbccad662f6d3dce487f40bc926de1a