Google Git
Sign in
chromium / chromium / src / third_party / android_deps / 05738da13b14dd58c99019060a6981ee21794d39
commit05738da13b14dd58c99019060a6981ee21794d39[log] [tgz]
authorPeter Wen <wnwen@chromium.org>Mon Nov 22 18:36:05 2021
committerCopybara-Service <copybara-worker@google.com>Mon Nov 22 18:45:01 2021
tree810c54246ac035a372ffdaa892b01a075bdd674f
parentebda32698579c0e59f4302bf0f259e1f925c1e9d [diff]
Android: Update android_deps kotlin version

This is a follow-up to CL: https://crrev.com/c/3288835

Bug: None
Change-Id: Id72b528a94879b9dddf12464a18dbb89778eba01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296204
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944163}
NOKEYCHECK=True
GitOrigin-RevId: 5106f1b6ebeffac44875e7508ded543610d1a833
5 files changed
tree: 810c54246ac035a372ffdaa892b01a075bdd674f
  1. buildSrc/
  2. libs/
  3. licenses/
  4. local_modifications/
  5. util/
  6. utils/
  7. .gitignore
  8. .style.yapf
  9. additional_readme_paths.json
  10. BUILD.gn
  11. build.gradle
  12. DIR_METADATA
  13. fetch_all.py
  14. material_design.flags
  15. OWNERS
  16. README.chromium
  17. README.md
  18. settings.gradle.template
  19. subprojects.txt
  20. vulnerability_supressions.xml
README.md

Android Deps Repository Generator

Tool to generate a gradle-specified repository for Android and Java dependencies.

Usage

fetch_all.py [--help]

This script creates a temporary build directory, where it will, for each of the dependencies specified in build.gradle, take care of the following:

  • Download the library
  • Generate a README.chromium file
  • Download the LICENSE
  • Generate a GN target in BUILD.gn
  • Generate .info files for AAR libraries
  • Generate 3pp subdirectories describing the CIPD packages
  • Generate a deps entry in DEPS.

It will then compare the build directory with your current workspace, and print the differences (i.e. new/updated/deleted packages names).

Adding a new library or updating existing libraries.

Full steps to add a new third party library or update existing libraries:

  1. Update build.gradle with the new dependency or the new versions.

  2. Run fetch_all.py to update your current workspace with the changes. This will update, among other things, your top-level DEPS file.

  3. git add all the 3pp related changes and create a CL for review. Keep the 3pp/, .gradle, OWNERS, .groovy changes in the CL and revert the other files. The other files should be committed in a follow up CL. Example git commands:

    • git add third_party/android_deps{*.gradle,*.groovy,*3pp*,*OWNERS,*README.md}
    • git commit -m commit_message
    • git restore third_party/android_deps DEPS
    • git clean -id

  4. Land the first CL in step 3 and wait for the corresponding 3pp packager to create the new CIPD packages. The 3pp packager runs every 6 hours. You can see the latest runs here. See //docs/cipd_and_3pp.md for how it works. Anyone on the Clank build core team and any trooper can trigger the bot on demand for you.

  5. If your follow up CL takes more than a day please revert the original CL. Once the bot uploads to cipd there is no need to keep the modified 3pp files. The bot runs 4 times a day. When you are ready to land the follow up CL, you can land everything together since the cipd packages have already been uploaded.

  6. Run fetch_all.py again. There should not be any 3pp related changes. Create a commit.

    If the CL is doing more than upgrading existing packages or adding packages from the same source and license (e.g. gms) follow //docs/adding_to_third_party.md for the review.

If you are updating any of the gms dependencies, please ensure that the license file that they use, explained in the README.chromium is up-to-date with the one on android's website, last updated date is at the bottom.

Implementation notes:

The script invokes a Gradle plugin to leverage its dependency resolution features. An alternative way to implement it is to mix gradle to purely fetch dependencies and their pom.xml files, and use Python to process and generate the files. This approach was not as successful, as some information about the dependencies does not seem to be available purely from the POM file, which resulted in expecting dependencies that gradle considered unnecessary. This is especially true nowadays that pom.xml files for many dependencies are no longer maintained by the package authors.

Groovy Style Guide

The groovy code in //third_party/android_deps/buildSrc/src/main/groovy loosely follows the Groovy Style Guide, and can be linted by each dev with npm-groovy-lint via either:

  • Command Line npm-groovy-lint -p third_party/android_deps/buildSrc/src/main/groovy/ --config ~/.groovylintrc.json npm-groovy-lint can be installed via npm install -g npm-groovy-lint.
  • VS Code extension.

The line length limit for groovy is 120 characters.

Here is a sample .groovylintrc.json file:

{
    "extends": "recommended",
    "rules": {
        "CatchException": "off",
        "CompileStatic": "off",
        "DuplicateMapLiteral": "off",
        "DuplicateNumberLiteral": "off",
        "DuplicateStringLiteral": "off",
        "FactoryMethodName": "off",
        "JUnitPublicProperty": "off",
        "JavaIoPackageAccess": "off",
        "MethodCount": "off",
        "NestedForLoop": "off",
        "ThrowRuntimeException": "off",
        "formatting.Indentation": {
            "spacesPerIndentLevel": 4
        }
    }
}

This is a list of rule names: Groovy Rule Index by Name.