)]}' { "log": [ { "commit": "f86dad27e3644d578f683fad8d4b88324e2a44bb", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [ "b159c8c2545366ab1fb538e57ceecbd611e2c0e5" ], "author": { "name": "Yang Guo", "email": "yangguo@chromium.org", "time": "Mon Nov 04 08:43:09 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 04 08:43:09 2019" }, "message": "Remove bundled DevTools frontend\n\nWe now use the external version pulled via DEPS.\n\nTBR\u003dagrieve@chromium.org\n\nBug: 1011259\nChange-Id: If34101d2f9a1fe82e3e96fb3b616a082cd2abaca\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893272\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nReviewed-by: Ben Mason \u003cbenmason@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#712057}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f5b160acfe5dfdaacc020bd0922d5eeb65ef0a7c\n" }, { "commit": "b159c8c2545366ab1fb538e57ceecbd611e2c0e5", "tree": "fce7efab035f9fbad7e4952c7ce4806ddcefe702", "parents": [ "d638d21ae7e6d2ec9d06122ebe18cdbac6cb30f2" ], "author": { "name": "Jan Scheffler", "email": "janscheffler@chromium.org", "time": "Mon Oct 21 09:36:08 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 21 09:36:08 2019" }, "message": "Reland \"[devtools] Add Url and Path Column to Network Log\"\n\nThis is a reland of 12915a6957ebe9ca20ef30c0e5141ad1dee87a7d\n\nOriginal change\u0027s description:\n\u003e [devtools] Add Url and Path Column to Network Log\n\u003e\n\u003e This patch adds url and path as available columns to\n\u003e the network log view and allows the name to be removed\n\u003e because it is not needed if the user decides to show\n\u003e the path or the whole url.\n\u003e\n\u003e Bug: chromium:993366\n\u003e Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161\n\u003e Reviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\n\u003e Commit-Queue: Jan Scheffler \u003cjanscheffler@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#698891}\n\nBug: chromium:993366\nChange-Id: I0061afbb7bdbc03cf3a7bd567530d21b66fa6d30\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823859\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707746}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 923cd866fb089619bbbd971ff16cd7d766c1fb67\n" }, { "commit": "d638d21ae7e6d2ec9d06122ebe18cdbac6cb30f2", "tree": "d7aaf25134e4e925127515795fb03a2103e58f72", "parents": [ "af59516a468f375b4f953af71e46bbae90122a4a" ], "author": { "name": "Christy Chen", "email": "chrche@microsoft.com", "time": "Fri Oct 18 22:45:52 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 22:45:52 2019" }, "message": "DevTools: Update localization error message to warn about placeholder \u003cex\u003e\n\nThe presubmit script did not warn about the missing example tag for placeholders.\nThis Cl added more details to the error message.\nhttps://imgur.com/a/9I7hXfx\n\nBug: 941561\nChange-Id: I2a950e4dd1fecc0a4dfea7467216c71c964c97b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845580\nCommit-Queue: Christy Chen \u003cchrche@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Mandy Chen \u003cmandy.chen@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707569}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 21c1a43916ce6b405246e60c5c21613f372fdb68\n" }, { "commit": "af59516a468f375b4f953af71e46bbae90122a4a", "tree": "1c3ceebca19f796631220817fd5536d6da30ec38", "parents": [ "331f9ef258e79f05b435a3dea130a72718b52da0" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Fri Oct 18 21:56:48 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 21:56:48 2019" }, "message": "DevTools: Make Settings Throttling Pane Accessible screen reader accessible\n\nThis change adds aria-label and aria-describedby to inputs.\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1648916 which has been split into small changes.\n\nBug: 963183\nChange-Id: Ia9c29f1aeb4d95b2535d755d0b7772bbaff161cf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817413\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707547}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 37b9c403534ee7d30043559cfd927160ff1278a0\n" }, { "commit": "331f9ef258e79f05b435a3dea130a72718b52da0", "tree": "4b5386a4bd642e4a7922b42747c0668757f30efd", "parents": [ "6bf99a7a6e4107d3e3d7ee3faa2f0050767473af" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Fri Oct 18 21:05:03 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 21:05:03 2019" }, "message": "Devtools: A11y (Screen Reader) improvements for Coverage tool\n\nThis change adds accessible text to columns in the coverage tool\nthat were not previously screen reader accessible. It adds accessible text\nfor the Total bytes column to prevent the numbers from being read separately\ndue to the spaces. It adds a label to the Unused Bytes column to prevent\nscreen readers from interpreting the column as 1 large percentage\ninstead of separate bytes value and percentage values.\nAnd it adds accessible text to describe the bars\nin the last column. Text reads\n\"X% of file unused. Y% of file used.\"\n\nBefore: https://imgur.com/qpAwxVF\n\nAfter: https://imgur.com/GTqrstQ\n\nBug: 963183\nChange-Id: I2b69cc32e935f94d2138f7964f449a4f0472182a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710753\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Peter Marshall \u003cpetermarshall@chromium.org\u003e\nReviewed-by: Sigurd Schneider \u003csigurds@chromium.org\u003e\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707530}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c7b23afaf3b42c471cd6a30b6f8d40759e617591\n" }, { "commit": "6bf99a7a6e4107d3e3d7ee3faa2f0050767473af", "tree": "d00535946513a7ff4386918e0562b44d090c5660", "parents": [ "a22f67b92f8423772f97bef881e7f29241bbf129" ], "author": { "name": "Junyi Xiao", "email": "juxiao@microsoft.com", "time": "Fri Oct 18 20:18:06 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 20:18:06 2019" }, "message": "Devtools: fix js exception in SDK.NetworkLog._initiatorChain\n\nIssue: In SDK.NetworkLog._initiatorChain, we potential run into the case where\n[initiatorDataSymbol] is not defined yet when we recursively walk up the\ninitiator chain for the request.\n\nThis changes adds initializeInitiatorSymbolIfNeeded in the walking process\nand also fix a \"typo\" in initiatorGraphForRequest networkManager checking.\n\nChange-Id: Ibaa1deec6c2548e149554aa526abf27a61711621\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867412\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Junyi Xiao \u003cjuxiao@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707502}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a75fc7267808c0e667261083919d2c86003c7eb5\n" }, { "commit": "a22f67b92f8423772f97bef881e7f29241bbf129", "tree": "c269da67e71ff39afc8897709cbb4a48bc7d336d", "parents": [ "86fd301826b0b1badc3e49186bea1a9cabdf111c" ], "author": { "name": "Mathias Bynens", "email": "mathias@chromium.org", "time": "Fri Oct 18 12:00:01 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 12:00:01 2019" }, "message": "[DevTools] Accept empty-string timezone IDs\n\nThis patch loosens up the timezone ID validation so the form accepts\nempty-string inputs.\n\nBug: chromium:993628, chromium:1015770\nChange-Id: I2c0d552dcbc2a3cdf2c31cc129a7ad43b7240955\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868996\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Mathias Bynens \u003cmathias@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707335}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 855b9ddd4e7c59e92f9fb30f0cf70586e4da934e\n" }, { "commit": "86fd301826b0b1badc3e49186bea1a9cabdf111c", "tree": "61d7e2c3033c8a45ab01b7a3bd3e81f88f0ca72d", "parents": [ "7a7b368492c258f68f88854203d4e8c47c8609fb" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Fri Oct 18 09:22:50 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 18 09:22:50 2019" }, "message": "Remove SplitInDrawer experiment\n\nWith the removal of the terminal, we no longer need this experiment.\n\nBUG\u003d1011466\n\nChange-Id: I0c097d33d09329eae41079504d825041f082e1fd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866930\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Paul Irish \u003cpaulirish@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nAuto-Submit: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707292}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 07c61c55da2cd2510517651443cf40f68b2a2c89\n" }, { "commit": "7a7b368492c258f68f88854203d4e8c47c8609fb", "tree": "0438159b244a4c8b24af286f13421262e9a99ec1", "parents": [ "6decb1aaf70c98115c6434be0159d1db0e185ecc" ], "author": { "name": "Eric Lawrence", "email": "ericlaw@microsoft.com", "time": "Thu Oct 17 23:06:36 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 23:06:36 2019" }, "message": "[DevTools] Omit |Accept-Encoding| header from cURL commands\n\nThe |Accept-Encoding| request header should be omitted from the cURL\ncommand line to avoid problems decompressing responses on platforms\nwhere cURL does not support the same set of decompressors as Chrome\nitself.\n\nBug: 1015321\nChange-Id: I2948affb89ff46ad1b9869b2532f75efb4acf6f9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865608\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Eric Lawrence [MSFT] \u003cericlaw@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707146}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: da43e8c1b14a694cb77842e992a02a4c68e3df60\n" }, { "commit": "6decb1aaf70c98115c6434be0159d1db0e185ecc", "tree": "2f631e9944c3a47d141d5ae81b8b4c493c4773f6", "parents": [ "0044a7f756fa9b9163bdec06e3a075b047bbb6d3" ], "author": { "name": "Connor Clark", "email": "cjamcl@google.com", "time": "Thu Oct 17 21:37:40 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 21:37:40 2019" }, "message": "DevTools: [Audits] Roll Lighthouse 5.6.0\n\nAlso cherry-picked:\n\nhttps://github.com/GoogleChrome/lighthouse/pull/9377\nhttps://github.com/GoogleChrome/lighthouse/pull/9783\n\nBug: 772558\nBug: 1011228\n\nChange-Id: Ibe9e4b3849940bf86c666bf55698a9ced4253fd3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867249\nReviewed-by: Erik Luo \u003cluoe@chromium.org\u003e\nCommit-Queue: Connor Clark \u003ccjamcl@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707110}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5f16f693662c78467b8ae531a3f03e37ccf94c69\n" }, { "commit": "0044a7f756fa9b9163bdec06e3a075b047bbb6d3", "tree": "dc6a1c02df43c3764cfc870b007cd9006e4ea5ba", "parents": [ "614f5bc1347a41206ccbb88b4050efac95741d84" ], "author": { "name": "Connor Clark", "email": "cjamcl@google.com", "time": "Thu Oct 17 21:10:54 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 21:10:54 2019" }, "message": "DevTools: Warn on multiple proxy connections on registration.\n\nInstead of in _onMessage.\n\nBug: 1011228\nChange-Id: I56699d605ed2cae36361031f1ecf071ee3110e91\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854642\nCommit-Queue: Connor Clark \u003ccjamcl@google.com\u003e\nReviewed-by: Paul Irish \u003cpaulirish@chromium.org\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707097}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5648a3eb962d84a65a626cf88ddea7b5f80c0eb0\n" }, { "commit": "614f5bc1347a41206ccbb88b4050efac95741d84", "tree": "e6ecbcad6a13b1680afcf3454cc08efb200d41be", "parents": [ "6b80080315b1d35c19f901ed44e42bc8e62acff3" ], "author": { "name": "Anubha Mathur", "email": "anubmat@microsoft.com", "time": "Thu Oct 17 20:33:13 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 20:33:13 2019" }, "message": "DevTools: Add alert to read out updates to device orientation in sensors tool\n\nFix accessibility bug: In the sensors tool, when the reset button under Device orientation was clicked, the screen reader did not read anything out to inform user that the orientation was changed.\n\nNow whenever the device orientation updates, the new setting is read out. If the update was only read out when reset button was pressed, the experience would not be consistent, and the alert wouldn\u0027t be read out for subsequent resets, which is why the update is read out on every change.\n\nGif: https://imgur.com/a/1YeTX2l\n\nBug: 963183\nChange-Id: Id4f82c4af8db1857af832d4b221d60cd1eea578c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750194\nCommit-Queue: Anubha Mathur \u003canubmat@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707069}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2dd1593f9389ec609ffb8c454426ab80aff83a98\n" }, { "commit": "6b80080315b1d35c19f901ed44e42bc8e62acff3", "tree": "9ed0cfac2d2eb5cc7871a5a097912168d1969138", "parents": [ "202351cc805c6a4c36199f6b144ee8acc1f4668d" ], "author": { "name": "John Emau", "email": "John.Emau@microsoft.com", "time": "Thu Oct 17 20:12:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 20:12:14 2019" }, "message": "DevTools: give errors and warnings counter an accessible name\n\nWithout this change screen readers in browse mode [1] will incorrectly\nread errors and warnings that have a tooltip of \"42 errors, 99 warnings\"\nas \"4299\".\n\nAfter this change screen readers will announce the same content as the\nshown in the tooltip: \"42 errors, 99 warnings\".\n\nBecause errors and warnings are indicated with icons this change will\nfix the screen reader bug and helps meet success criteria for\nWCAG 1.1.1 Non-text Content [2].\n\nRoot cause:\nThe icons do not have accessible names and screen readers will combine\nthe content of the spans:\n\n \u003cspan\u003e\u003cerror-icon/\u003e42\u003cspan\u003e\u003cspan\u003e\u003cwarning-icon/\u003e99\u003c/span\u003e\n is announced as 4299\n\nThe fix:\n* Set the accessible name of counter element (title alone is insufficient [3]).\n* Make the children of the counter hidden otherwise NVDA (and JAWs)\n screen readers will ignore the aria-label [4].\n\n[1]: https://www.nvaccess.org/files/nvda/documentation/userGuide.html#BrowseMode\n[2]: https://www.w3.org/WAI/WCAG21/quickref/#non-text-content\n[3]: https://crrev.com/18d41172/third_party/blink/renderer/devtools/front_end/ui/Tooltip.js#190\n[4]: https://github.com/nvaccess/nvda/issues/1354#issuecomment-155287285\n\nScreenshot (NVDA speech viewer): https://i.imgur.com/KznR7O7.png\n screen reader should announce the number of errors and warnings.\n\nTest: Navigate to the counter in NVDA browse mode on Win10 and the\nBug: 963183\nChange-Id: I46985e223a6f8bac5cd1dbdf597a4b0c9ab71567\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861214\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#707031}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5814dabc5bfa705994cea056b539243789e481c9\n" }, { "commit": "202351cc805c6a4c36199f6b144ee8acc1f4668d", "tree": "a97f84cee087447b3fe9ba1eaad8068a2fc46ace", "parents": [ "039ac407e9dfa3e809bd7716d67eeb4d71e170a5" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Thu Oct 17 18:31:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 18:31:15 2019" }, "message": "DevTools: Fix ExpandableContainerWidget Screen Reader Text\n\nExpandable container widgets with toolbar buttons, such as the Global\nlisteners pane [1], are being read out incorrectly by screen readers.\nFor example, the Global listeners header is read by NVDA as\n\u003e Refresh global listeners Global Listeners link expanded\nwhen it should really just be \"Global Listeners link expanded.\"\n\nThis CL sets an aria-label on each ExpandableContainerWidget so that\nchild buttons are not read out.\n\n[1] https://gyazo.com/3f9d3131f050c924eab597618ee50230\n\nBug: 963183\nChange-Id: I11aab756c787406c7ce786a009f78caa7da12e2f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864567\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706997}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 71d9b7d63772339506b7dabc22f0588f648d0512\n" }, { "commit": "039ac407e9dfa3e809bd7716d67eeb4d71e170a5", "tree": "ef741446be4e5ac19a43f602fb3b1ad4cf1ec0b7", "parents": [ "4e9cd76f0e9248ae4f370698e15ce9ed0c853a74" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Thu Oct 17 17:33:26 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 17:33:26 2019" }, "message": "DevTools: Make swatches screen reader accessible\n\nScreen-reader accessibility: Each palette is assigned a role button so, when user navigates to each palette it reads e.g. \u0027Color #3F51B5 button\u0027\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 which has been broken down\n1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344\n2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875\n3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873\n4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874\n\nGif showing keyboard navigation which has been split out from this change https://imgur.com/m3iVkOj\n\nBug: 963183\nChange-Id: I244edc0cabf5aa5d6df51d3cf31efa00f64a666c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816875\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706983}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 77e5b8057fc2e31439f22c0018ad7213961f5646\n" }, { "commit": "4e9cd76f0e9248ae4f370698e15ce9ed0c853a74", "tree": "a2fb6c43f9216b25fbee1db7286ebe00172d7174", "parents": [ "1562de9bb873beb6797b2712803d2ab0ff7343fd" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Thu Oct 17 17:25:17 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 17:25:17 2019" }, "message": "DevTools: Make close button keyboard accessible\n\nClose button in color picker appears when user presses button rightmost arrow button to launch palette panel.\nThis change updates focus from palette panel to close button. This is because earlier user had to press extra tab to reach to control.\n\nThis change handles close button on ENTER, SPACEBAR and ESC key events.\nESC key is for user to escape from the palette panel and return back to earlier state.\nEarlier, pressing ENTER would close the color picker this change handles it by consuming the event.\n\nGif showing the change https://imgur.com/vt2saeT\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down\n1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344\n2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875\n3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873\n4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874\n\nBug: 963183\nChange-Id: I573e74a0e6adb5130f524f34016760233e14f5ad\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816874\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706977}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2786e314f3f3e2fefcb08aaec607a096d56fa610\n" }, { "commit": "1562de9bb873beb6797b2712803d2ab0ff7343fd", "tree": "492dab1017f1ba02567a567ed529e0c6333060fe", "parents": [ "cb8321822daca6358bc5d452bbe32971bbf3c481" ], "author": { "name": "Jan Scheffler", "email": "janscheffler@chromium.org", "time": "Thu Oct 17 08:43:26 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 17 08:43:26 2019" }, "message": "[devtools] Add find next with Ctrl+G and F3\n\nThis cl adds Ctrl+G and F3 as keyboard shortcuts\nfor windows and linux to find the next occurrence\nwhile a search is open (not necessarily focused).\nThe default behaviour of Ctrl+G opening the goto\nline popup still works as long as the search is not\nopened.\n\nBug: chromium:887586\nChange-Id: I8164786778e0b8cb99f7d6ca9d37a61cc34b622b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817887\nReviewed-by: Sigurd Schneider \u003csigurds@chromium.org\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706828}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 40294377601150bd8c37ee375a6cfcdbd01b9630\n" }, { "commit": "cb8321822daca6358bc5d452bbe32971bbf3c481", "tree": "6da810aa2fa2881b91417a06629c5b827eeca36c", "parents": [ "5b69ca571d6f9c7acf3932185c62cd75cd7d7dc6" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Wed Oct 16 23:13:00 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 23:13:00 2019" }, "message": "DevTools: Service Worker URLs are not read by screen readers\n\nWhen a screen reader user is tabbing through the registered\nservice workers, the screen reader fails to announce the origins\nfrom which the service workers are registered. By default, the\nreader just announces \"Update\", as the Update button is the first\nfocusable element within each individual Service Worker view.\n\nThis change adds a new API to ReportView.Section. Because Section\nis a generic control which may not always follow this paradigm,\nthe new API seems to be the best choice for how to implement. The\nAPI is opt-in by call sites as demonstrated by this use of it.\nThe API sets the role\u003d\"group\" on the containing element, and\napplies a label to the containing element. Upon focus entering the\ncontaining element, the full title is read aloud.\n\n\"After\" screencap: https://imgur.com/a/XfMg2SA\n\nBug: 963183\nChange-Id: I5ef631d24d9f2df9f610a21c84fd5a9d6ae26b48\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864721\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706688}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e1961cc7bcaddd8cc0fc6cf86bfea5ff1998c989\n" }, { "commit": "5b69ca571d6f9c7acf3932185c62cd75cd7d7dc6", "tree": "72a0e27a583ddfa8766592fce2647b5b0eb11cbb", "parents": [ "d0dcc9aa3b56240a195e6d9967e6c50d616a4c94" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 16 22:27:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 22:27:53 2019" }, "message": "Devtools: Add Focus and Keyboard navigation to Memory allocation stack\n\nThis change adds the ability to navigate to the allocation stacks in\nthe memory tool from a keyboard. It uses arrow keys to navigate the stack,\nand the links can be accessed from pressing enter when the item has focus,\nor from a context menu for consistency with other callstacks with links.\n\nBefore: https://imgur.com/gz1mCyY\n\n**Note context menu text has been updated since recording After gif. It now\nreads \u0027Reveal in Sources panel\u0027\nAfter: https://imgur.com/aJJgco0\n\nBug: 963183\nChange-Id: I0babaab431c60913f94eca7f0fee9bb0e8c25532\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696400\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Jeff Fisher \u003cjeffish@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706660}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b43d0d5f0f3158d4495da716f8f8ecc6ae46af87\n" }, { "commit": "d0dcc9aa3b56240a195e6d9967e6c50d616a4c94", "tree": "aa3fa23627c0d0147047b9bf0fbb470e72cad69b", "parents": [ "82c8fb315947bd3e12b844af719cb862bcb4ffe6" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Wed Oct 16 21:35:28 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 21:35:28 2019" }, "message": "DevTools: Make swatches in color palette keyboard accessible\n\nKeyboard accessiblity: In this change user can navigate through swatches using LEFT AND RIGHT arrow keys.\nPressing ENTER or SPACEBAR selects focused color.\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down\n1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344\n2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875\n3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873\n4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874\n\nBug: 963183\nChange-Id: I4877d89c49c1c1072deb2da7f6a811af7cd5c21d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817344\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706634}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ea3e8b05422b985837388089942f614dda9f8f10\n" }, { "commit": "82c8fb315947bd3e12b844af719cb862bcb4ffe6", "tree": "0492490530958006220674cf0263b16d0ba06823", "parents": [ "bb29a5395dbfde2729e7b35ea3973535c2657af8" ], "author": { "name": "Kayce Basques", "email": "kayce@google.com", "time": "Wed Oct 16 21:18:02 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 21:18:02 2019" }, "message": "DevTools: Update What\u0027s New UI for Chrome 79\n\nScreenshot: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d986998#c8\n\nBug: 986998\nChange-Id: Ie9755d7820f8743a03ee6664e7bb70667e3bced9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865012\nCommit-Queue: Kayce Basques \u003ckayce@google.com\u003e\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nAuto-Submit: Kayce Basques \u003ckayce@google.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706626}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d0ae1add6a57e74e3111d6dda17801d4f762b274\n" }, { "commit": "bb29a5395dbfde2729e7b35ea3973535c2657af8", "tree": "52226f9c3154be2ea25ba56baea1a6f07e55584e", "parents": [ "020ed5e974e3e93c5141b1b7f78bc97e2653c312" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 16 20:54:19 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 20:54:19 2019" }, "message": "Devtools: DataGrid Edits start on first column when using CtxMenuKey\n\nThis change builds off of\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1729554\nto allow the context menu key press inside a datagrid to add an\n\u0027Edit \"\u003ccolName\u003e\" option that starts at\nthe first editable column instead of the center column\nthat is shown when using the mouse to right click on a dataGrid cell.\nThis fixes the issue where the editing context menu would always show\n\"Edit \u003cmiddle Column\u003e\" due to how the event would assume the target\nis the visible center of the datagrid.\n\nBefore: https://imgur.com/QE7VAKf\n\nAfter: https://imgur.com/a/iiKI2dk\n\nBug: 963183\nChange-Id: I20468e895a5df0cba368ad7ff954e34de17ac0e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752769\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Jeff Fisher \u003cjeffish@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706604}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a508ec53aa03326f092797a74688f9a921dce773\n" }, { "commit": "020ed5e974e3e93c5141b1b7f78bc97e2653c312", "tree": "77a5f1b71410b0341f51b78754684cb4cc6b1a39", "parents": [ "bfe54a6e0f94dc45cdf07164ee2b5946d334b404" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 16 20:53:17 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 20:53:17 2019" }, "message": "Devtools: IndexedDB ContextMenu Expand and Collapse Value Objects\n\nThis change adds 2 context menu entries for the IndexedDB datagrid\nto allow for expanding and collapsing the value objects from the keyboard.\n\nNote: This change does not currently work with the contextMenuKey\ndue to an existing issue where contextMenuKey on\nthe data grid will not target the selected\nnode, but on whichever row happens to be in the center\nof the currently visible section of data grid. This issue will be\nresolved with this change:\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1729554\n\n\nBefore: https://imgur.com/8Iz96jv\n\nAfter: https://imgur.com/UwSUVOh\n\nBug: 963183\nChange-Id: Iefb563dc744b524d3282b62141a9da12230e9911\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725990\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706603}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d0bf0d06e4239335f5cbe022724ac3ae29ea2563\n" }, { "commit": "bfe54a6e0f94dc45cdf07164ee2b5946d334b404", "tree": "8f7f0ae211d459ad5b8fe8c19f5f47a45a619152", "parents": [ "16879b94d8ff51e7f303a136726f333bc87557a2" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 16 20:52:08 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 20:52:08 2019" }, "message": "Devtools: Context Menu for links in Profiler (Memory and CPU) Datagrid\n\nThis change adds a context menu entry for the links that appear\nin the \u0027Functions\u0027 column in Heavy (bottom-up) and Top Down views in\nthe Memory Allocation Sample and Javascript CPU Profiler tools.\n\nThis allows the keyboard users to access these links with the context\nmenu key.\n\nNote that this change is dependent on\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1729554\nfor the context menu key in the DataGrid to target the\ncurrently selected node.\n\nBefore: https://imgur.com/ErkPbIc\n\nAfter: https://imgur.com/a3R3rDB\nBug: 963183\nChange-Id: I3d5068b0efff0c31a46aeb6ee11ff5feb85bc58b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832479\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706600}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3c2cce4f6e1f915688b4b4b203448f966bc9adf2\n" }, { "commit": "16879b94d8ff51e7f303a136726f333bc87557a2", "tree": "294e3732b8954dd5eb50b063b5646b706ce0b964", "parents": [ "236a6e99779b9c16a95b13992a01caf38f84c3bb" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Wed Oct 16 19:38:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 19:38:15 2019" }, "message": "DevTools: Make event listener breakpoints keyboard-navigable\n\nThis change makes the event listeners pane navigable by keyboard and\naccessible to screen readers.\n\nStandard treeoutline keyboard focus is the only visible change:\nhttps://gyazo.com/0098dd06216f58575468fcf7c5902cbc\n\nKeyboard navigation video: https://i.imgur.com/Hq73jum.mp4\n\nBug: 963183\nChange-Id: Ia32451e29b16a63e20de0a1e6c351e38568c13ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649732\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706565}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: df40959919b858acf825d39eff2a73bed87c8ddb\n" }, { "commit": "236a6e99779b9c16a95b13992a01caf38f84c3bb", "tree": "60a46f93010e6d85814b8cb789f74c8cf7c64392", "parents": [ "49ef6f1c4fedb2143bd47b0ee7ab833d457e1924" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Wed Oct 16 19:16:44 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 19:16:44 2019" }, "message": "DevTools: Make global listeners view keyboard-navigable\n\nThis PR enables keyboard navigation of the event listeners tree view and\nadds a more descriptive aria-label for the refresh button.\n\nKeyboard navigation gif: https://i.imgur.com/QlKjnEf.mp4\nEmpty pane focused screenshot: https://gyazo.com/d494f4ab0b2f9d550192f9920838b6a0\n\nBug: 963183\nChange-Id: I6f7c1fa304606238c1bf23d7a663560cc2c75718\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665298\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706560}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0c6fbc2d36499207e1695e0acf04e4f69e7934be\n" }, { "commit": "49ef6f1c4fedb2143bd47b0ee7ab833d457e1924", "tree": "98e40be379beccf21a41b33dc48472d9049b545a", "parents": [ "93f3f206e871bf9ebbc3289a528e7a75adfa434f" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 16 18:50:13 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 18:50:13 2019" }, "message": "Devtools: ContextMenu key press on dataGrid targets currently selected Node\n\nThis change addresses an issue in Datagrids where pressing the context menu\nkey while the data grid has focus does brings up actions for whatever node\nis in the center of the grid instead of whichever node is currently selected.\n\nNotice how in the before clip, the center rows with primary keys 14-16 get\ndeleted, but in the after clip, the selected rows get deleted as expected:\n\nBefore: https://imgur.com/pcijlqq\n\nAfter: https://imgur.com/TBLokOy\n\nLonger Explanation:\nSince the data grid itself retains focus, it uses CSS classes to indicate the\ncurrently selected item in the grid. When using a mouse right-click to bring\nup the context menu, the event.target in the context menu handler points to\nwhatever cell was clicked on, and the data grid can determine\nthe corresponding node from the target.\n\nHowever, when the context menu key is pressed, the event.target refers to\nwhichever cell is directly in the visible center of the grid, which is often\nnot the \"selected\" row. This causes the unexpected behavior of\nperforming actions on the center row instead of the selected row.\n\nThe fix uses event.button to detect the case where the context menu handler\nwas reached but no mouse buttons where used (either the context menu key\nor Shift+F10) and then grabs the currently selected node\ninstead of the node from the event.target\n\nhttps://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button\n\nBug: 963183\nChange-Id: Ib501178f0075b0ccf536b20d12f602fc174f325c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729554\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Jeff Fisher \u003cjeffish@microsoft.com\u003e\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706551}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7fb1464ddd8cb23c3ebf5692d56b0ef809a8cb1e\n" }, { "commit": "93f3f206e871bf9ebbc3289a528e7a75adfa434f", "tree": "8ad48232ef94640442a781601bc2b62bd5623b60", "parents": [ "53de057112fe193c2dc285e4249987f11294583c" ], "author": { "name": "Paul Lewis", "email": "aerotwist@chromium.org", "time": "Wed Oct 16 16:14:18 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 16:14:18 2019" }, "message": "DevTools: Warn when revealed node is detached from the document.\n\nIf a user right clicks on an element in the console and chooses to reveal it in\nthe elements panel, and the element is not in the document, the operation fails\nbut it is not communicated to the user. This patch adds a warning if the node\nappears to be detached from the document; it is done through checking the\nparentNode property, which is the most suitable means in lieu of having the\nisConnected property available in the Node object.\n\nBug: 967156\nChange-Id: I58228facb54e9afc87215d68176f473121121db4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681891\nCommit-Queue: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: Erik Luo \u003cluoe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706474}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6dfd32cb092cbc0982cee754ca793a84e6b66b63\n" }, { "commit": "53de057112fe193c2dc285e4249987f11294583c", "tree": "d02126fb57c4ccd401a1004b781907c0f83c46b7", "parents": [ "873becb1bdba357ceb166ca489a1a5c470a8a8c0" ], "author": { "name": "Jan Scheffler", "email": "janscheffler@chromium.org", "time": "Wed Oct 16 12:31:18 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 12:31:18 2019" }, "message": "[devtools] Fix focus when docking devtools\n\nThis patch keeps the focus on the main menu\nwhen changing from undocked back to docked again.\n\nBug: chromium:1002424\nChange-Id: Ic36f3e6852cb4e0a43ced6387dfeb3e2491d1d8b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798344\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Jan Scheffler \u003cjanscheffler@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706405}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 99545773204be3df417cef1e1de3562416bdd124\n" }, { "commit": "873becb1bdba357ceb166ca489a1a5c470a8a8c0", "tree": "74648fcf4de6f7a6f15148a02be540b111636409", "parents": [ "bf173ca5a2f6b0a8a3a641a64d15a8d727050069" ], "author": { "name": "Jan Scheffler", "email": "janscheffler@chromium.org", "time": "Wed Oct 16 12:30:49 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 12:30:49 2019" }, "message": "[devtools] Fix compositing reasons for layers\n\nThis patch uses the descriptions from composititing_reasons.cc\nwhen tracing layers but transfers the reason via their short\nname to make it compatible with LayerTree.compositingReasons\nfrom the devtools protocol.\n\nBug: chromium:737838\nChange-Id: Id019d725d51ae7b740ab10bd94a470c8a053bc0f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800410\nReviewed-by: Philip Rogers \u003cpdr@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Jan Scheffler \u003cjanscheffler@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706404}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0eba3f5eb4b1caccf38dda8f02134f4d17894de5\n" }, { "commit": "bf173ca5a2f6b0a8a3a641a64d15a8d727050069", "tree": "49a32c70c900b84bab3206368a819f2b30389f18", "parents": [ "a5a38877a71dd4b7e5b3ed2037a3ec554813bbd6" ], "author": { "name": "Sigurd Schneider", "email": "sigurds@chromium.org", "time": "Wed Oct 16 09:59:54 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 09:59:54 2019" }, "message": "[devtools] Report addition of new files as coverage update\n\nWe report the \u003cscript\u003efunction foo() {}\u003c/script\u003e as completely\nuncovered, and this caused the CoverageModel to determine that the\ncoverage report from the back-end did not change anything (used bytes\ndid not increase). However, the coverage report from the back-end might\nhave added the script to the CoverageModel\u0027s entries in the first place.\nIn such cases, the coverage list view was not properly updated.\n\nThis CL adds an update notification whenever a CoverageURLInfo is first\ncreated as well (independent of whether used bytes are zero).\n\nBug: chromium:1004203\nChange-Id: I458e14725a10a25087e443b2c509dc444d4bf997\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864675\nCommit-Queue: Sigurd Schneider \u003csigurds@chromium.org\u003e\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706363}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e297bcc5b74c7c1ae9cd314f9337ed0aeef0a02d\n" }, { "commit": "a5a38877a71dd4b7e5b3ed2037a3ec554813bbd6", "tree": "66bea0ada42b3b6c0734c285709e7ac47fc5e486", "parents": [ "f56bb3b01355c10a05a439a57574b9e00d353e08" ], "author": { "name": "Mathias Bynens", "email": "mathias@chromium.org", "time": "Wed Oct 16 08:23:51 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 08:23:51 2019" }, "message": "[DevTools] Enable emulating timezones\n\nThis patch adds support for emulating timezones through the Sensors\ndrawer. It’s based on the idea that emulating geolocation without\nalso emulating the local timezone (and vice versa) is detectable,\nand therefore the two should be tied together for more robust\nemulation.\n\nBoring but useful test/demo page:\nhttps://mathiasbynens.be/demo/timezone\n\nVideo: https://www.youtube.com/watch?v\u003dpIpN_AuV4AI\n\nDesign doc: https://goo.gle/devtools-timezone-emulation\n\nBug: chromium:993628\nChange-Id: I5ef867ac2723a341444ab1ee04a26c0fa9a9d62d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860014\nCommit-Queue: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: Sigurd Schneider \u003csigurds@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706349}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e607ccc0157d6ed9934d5cb216794243cf92b189\n" }, { "commit": "f56bb3b01355c10a05a439a57574b9e00d353e08", "tree": "68ce6491ede3b0603e499abd1bba4fed684efe31", "parents": [ "1049483ed89cb24e260d33556503ceb1f6f96a1d" ], "author": { "name": "Yang Guo", "email": "yangguo@chromium.org", "time": "Wed Oct 16 08:20:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 08:20:15 2019" }, "message": "DevTools: Fix typo in CookieItemsView\n\nBug: chromium:1014840\nChange-Id: Idb98dcf0888fdecb74dad6f43163daa7a81c2302\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864670\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nAuto-Submit: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706346}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cf378515b6b1824fbe0f2c1fc72a4a02a3b0d68b\n" }, { "commit": "1049483ed89cb24e260d33556503ceb1f6f96a1d", "tree": "76790f0d282f98b2e1a139dbd5014397ac1f5fdf", "parents": [ "7f07b6f40dcc7a687686e4ead22cf96d3e7b61a5" ], "author": { "name": "John Emau", "email": "johnemau@microsoft.com", "time": "Wed Oct 16 01:10:38 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 01:10:38 2019" }, "message": "DevTools: make setAutocomplete interaction model a closure compiler enum\n\nThis change will harden the setAutocomplete API making programming\nerrors less likely.\n\nPreviously the interactionModel parameter was stringly typed, now it is\ntyped as a enum so API misuse will be caught by closure\u0027s type checker.\n\nThis change was motivated by the thread on line 256 of the following CR:\nhttps://crrev.com/c/1737872/3/third_party/blink/renderer/devtools/front_end/ui/ARIAUtils.js\n\nScreenshot (proof the api still works): https://i.imgur.com/0geTYIg.png\n\nChange-Id: I7f4fdd6009f182219db16c2e0ed3d9bfe4c663d1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832247\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706254}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9f5a4106020332d5eb135544c561605d6173bd0e\n" }, { "commit": "7f07b6f40dcc7a687686e4ead22cf96d3e7b61a5", "tree": "c25255a2a25476e02ab61640cd31091bd9cf4bcc", "parents": [ "62fdceed5fac31e19abeb5cb4663295415ad988e" ], "author": { "name": "Anubha Mathur", "email": "anubmat@microsoft.com", "time": "Wed Oct 16 00:32:34 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 00:32:34 2019" }, "message": "DevTools: Fix ariaHasPopup attribute for a menu button in sources panel navigator pane\n\nIn the sources panel, the \"More options\"button should be marked with aria-haspopup\u003d\"true\" since the menu that opens is a popup which must be closed/escaped before the rest of the content in the page can be accessed.\nMAS 1.3.1\n\nBug: 963183\n\nChange-Id: I20183e6d35aa85b9705763de4a4c433ae1325505\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665299\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Anubha Mathur \u003canubmat@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706238}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f1b86a1c82d4865d3b1352063ecb5308d804ed21\n" }, { "commit": "62fdceed5fac31e19abeb5cb4663295415ad988e", "tree": "bb9fbbeef46cc883bd20eecfd729abaac853d1c2", "parents": [ "c3e104f6958260f81816b807b878a4cce76cf4ee" ], "author": { "name": "John Emau", "email": "johnemau@microsoft.com", "time": "Wed Oct 16 00:08:52 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 16 00:08:52 2019" }, "message": "DevTools: Add labeled group to audit checkboxes\n\nMarking the checkbox container as a group role and labeling it meets the\nfollowing WAI WCAG 2.1 success criteria and allows for screen readers to\nannounce the group label when focusing on a checkbox.\n\n1.3.1 Info and Relationships - Level A\nhttps://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships\n\n3.3.2 - Labels or Instructions - Level A\nhttps://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions\n\nScreenshot (NVDA Speech Viewer): https://i.imgur.com/ptmRGzu.png\nScreenshot (Accessibility Tree): https://i.imgur.com/EUTyhTV.png\n\nBug: 963183\nChange-Id: Ia801a9a74ca897b6bc94705d72109bd231b00653\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695853\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Alice Boxhall \u003caboxhall@chromium.org\u003e\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706228}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 96ee5aba6c5fbb4bb4130cc1a4e865c36d782421\n" }, { "commit": "c3e104f6958260f81816b807b878a4cce76cf4ee", "tree": "af7064c0131a77fcb0ab0eec75fb84d2e1afbc9f", "parents": [ "17054b4647e0c56c477b5443c1dbf6e6c5050617" ], "author": { "name": "John Emau", "email": "John.Emau@microsoft.com", "time": "Tue Oct 15 23:53:41 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 15 23:53:41 2019" }, "message": "DevTools: Put audio context name in drop down label\n\nPreviously the accessible name for the audio context selector was \u0027BaseAudioContext\u0027.\n\nWith this change the accessible name becomes `Audio context: ${content title}`\nand if no context is selected: `Audio context: (no recording)`.\n\nThis is a much better experience for screen reader users and meets success\ncriteria for WCAG 2.5.3 Label in Name https://www.w3.org/WAI/WCAG21/quickref/#label-in-name\n\nTest page: https://mdn.github.io/webaudio-examples/audiocontext-states/\n\nScreenshot (NVDA Speech Viewer): https://i.imgur.com/m5pKYnx.png (NOTE: This screenshot was taken with https://crrev.com/c/1626643 applied to better screen reader support)\nScreenshot (Accessibility Tree): https://i.imgur.com/e04n8m9.png\n\nBug: 963183\nChange-Id: I89e14599313766e7bd2be8a6a953df28c648dbe2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711008\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706226}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 54812ad6e7ac07825dd351e79c354c07b10a1be5\n" }, { "commit": "17054b4647e0c56c477b5443c1dbf6e6c5050617", "tree": "0b3890c53ebed54be66bbe6de71fb44d255428f7", "parents": [ "712bbc24c89f79d263ec0b4dfd01fa163d8f1121" ], "author": { "name": "John Emau", "email": "johnemau@microsoft.com", "time": "Tue Oct 15 23:05:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 15 23:05:14 2019" }, "message": "DevTools: make quick open dialog announce screen reader options\n\nThis change expands existing screen reader capabilities of the quick\nopen dialog by replacing the use of aria alert with standard ARIA attributes:\nrole\u003dcombobox/listbox/option, aria-activedescendant, and aria-autocomplete.\n\nThe effect is the screen reader announces the selected options and their\nposition in the results, giving the user the total result count.\n\nThis change follows the WAI ARIA guidance:\nhttps://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete\n\nScreenshot (NVDA Speech Viewer): https://i.imgur.com/4vJkHfq.png\n\nBug: 963183\nChange-Id: I5c3b1b1f80c0a11defdfd66a4b6860df75e5e717\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737872\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706211}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3d75e8ac2a1827d6d9c95b2d06e78a667cc54e0e\n" }, { "commit": "712bbc24c89f79d263ec0b4dfd01fa163d8f1121", "tree": "bfdfd6a8ae419bba04fa666b7cef8e55aeb26036", "parents": [ "d584b90e8594033ea43775a719cc4fb506cfefe0" ], "author": { "name": "Michael Liao", "email": "michael.liao@microsoft.com", "time": "Tue Oct 15 19:21:51 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 15 19:21:51 2019" }, "message": "DevTools [Common - Flame Chart]: Making flame chart keyboard accessible in memory and javaScript profiler tool\n\nChanges:\n- Adding keyboard navigability to JavaScript and Memory profiling flame charts\n- CPUProfileNodes with source links are enter-clickable\n- Flamechart\u0027s focused CPUProfileNodes will turn gray (from blue) when flamechart loses focus\n\nCPUProfileNode selected (with and without focus):\nhttps://imgur.com/a/e6JkqYW\n\nBug: 963183\n\nChange-Id: Icb00d5b53dab6cd5f83e5602a7d3834afdb7eab3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663021\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Peter Marshall \u003cpetermarshall@chromium.org\u003e\nCommit-Queue: Michael Liao \u003cmichael.liao@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#706043}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a1aacaa1986acbc5a4fe46ef129c6c4dcfeaf28f\n" }, { "commit": "d584b90e8594033ea43775a719cc4fb506cfefe0", "tree": "aec8cc08c9131263e5738b199dab7530e011d9cc", "parents": [ "a4797c8609effb89b082441fd5d956d04b05c052" ], "author": { "name": "Yang Guo", "email": "yangguo@chromium.org", "time": "Mon Oct 14 12:17:30 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 14 12:17:30 2019" }, "message": "Move unit tests to test/unittests\n\nChange-Id: I4dd89cae3441f1da5ae4b2a393a3ff66a67f6451\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859787\nAuto-Submit: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705524}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 94a941ed8494e3751c04db857a8f0513b98258a5\n" }, { "commit": "a4797c8609effb89b082441fd5d956d04b05c052", "tree": "f1ff13667f0552d269259370781e84a4db26847f", "parents": [ "2eb8c1450577e6b1bad927f0439ffd69f5f40119" ], "author": { "name": "Ingvar Stepanyan", "email": "rreverser@google.com", "time": "Mon Oct 14 11:32:18 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 14 11:32:18 2019" }, "message": "Enhance auto-stepping behaviour\n\nPreviously, auto-stepping experiment would only work when mapping is not\nfound at all, that is, there is no source file associated with a\nparticular byte offset.\n\nThis is not ideal in situations where a file exists, but underlying\nJavaScript / Wasm instructions don\u0027t map 1:1 to the source language,\nwhich is usually the case for compiled languages. In this case trying to\nperform step-by-step debugging would lead to user visibly staying on the\nsame line and column in the source file, while V8 is stepping over\nindividual instructions / statements.\n\nThe reason for this is that SourceMap.findEntry doesn\u0027t look for an\nexact match, but rather for a most suitable position in the source it\ncan map a byte offset to. This is what you usually want when stopping on\nan exception, but not what you want when trying to step over some\nstatement in the source code.\n\nThis change enhances auto-stepping to detect such situations and\ncontinue until a precise match is found.\n\nChange-Id: I69ced14f0bdb219ec8f6b58864dbf23616a6230b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855967\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCommit-Queue: Ingvar Stepanyan \u003crreverser@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705515}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6411844977f839675e37fb7d90a59e164aaa9432\n" }, { "commit": "2eb8c1450577e6b1bad927f0439ffd69f5f40119", "tree": "6e7fcacc30a6a7aa997385ba97f7e9e1be2144d5", "parents": [ "41d3f01332acb45c9ad69014ae9d635a27ee00d9" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Sun Oct 13 18:02:38 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sun Oct 13 18:02:38 2019" }, "message": "DevTools: Display error when source file can\u0027t load\n\nThe source editor, when it cannot load a particular file, will simply\ndisplay a blank file instead. At the bottom, this is because the APIs\nused to load the files do not have a way to propagate an error up to\nthe call site. Rather, the callback either is never called, or is\ncalled with just an empty string.\n\nThis refactor changes the way the project system loads file contents\nby replacing the callback model with a Promise-based model. However,\nin this version, rather than propagating an error (handled via\ncatch), the error is exposed as a property on the object passed via\nthe the load functions. Although it might be preferable to use\nasync throw/catch, because there are ~4-5 layers of redirection\nthrough the project system, the added complexity seems to not really\njustify that work. I\u0027m open to reconsidering this design, though.\n\nAttempting to load a file via file:// which does not exist previously\nproduced no error because the DevToolsUIBindings handler would just\nalways resolve with no content and HTTP status 200. I had previously\naddressed that bug in this changeset, but I\u0027ve split it out to\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1847833 .\n\nSample \"after\" screenshot: https://imgur.com/a/tlm90sg\n\nBug: 961940\nBug: 941035\n\nChange-Id: If121611090e9c35eeb1de162b59f8a9f72f696d9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817677\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Jeff Fisher \u003cjeffish@microsoft.com\u003e\nCommit-Queue: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705438}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 61ec2a233d9a7bf4bb4b3e610de6fc233ae0d46e\n" }, { "commit": "41d3f01332acb45c9ad69014ae9d635a27ee00d9", "tree": "71a3d8408fef8dd7e14684b5dcbf5465bc2fe3ba", "parents": [ "0618680dbb956df19402cad0d964834eff447766" ], "author": { "name": "Mike Jackson", "email": "mjackson@microsoft.com", "time": "Fri Oct 11 21:54:37 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 21:54:37 2019" }, "message": "DevTools: Update axe-core rules\n\nThis change ensures that we only run best-practice\nand wcag2a rules, and disables low value or performance\nimpacting rules.\n\nThese are the net new rules enabled:\n- duplicate-id-active\n- duplicate-id-aria\n- input-button-name\n- role-img-alt\n\nThis change does not disable any rules that were\npreviously running prior to the axe-core upgrade.\n\nChange-Id: I3b1942e09b29aed6e1055e5159d2d52eb2aa260d\nBug: 1013391\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854561\nCommit-Queue: Mike Jackson \u003cmjackson@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705295}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fc58987805e100b6f52b00efc11a7640c8d47697\n" }, { "commit": "0618680dbb956df19402cad0d964834eff447766", "tree": "00c8800928a25783259e05c717083aab33ef919b", "parents": [ "62b64d2b32e41aaac92a64d4911b005fb87f9355" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Fri Oct 11 17:38:45 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 17:38:45 2019" }, "message": "Devtools: Screen Reader fix for Profiler (Memory and CPU) Datagrid\n\nThis change contains a small fix for the Profiler Datagrid, which is\nused in the Top down and bottom up views for Memory Panel Allocation\nsamples and the Javascript Profiler tool.\n\nIt adds an aria label to the percentage columns to separate the raw\nnumber from the percentage of the Heap/CPU\n(uses a comma in the aria label,\nwhich causes screen readers to separate the 2 numbers when reading)\n\nBefore:\nScreen Reader: https://imgur.com/OA0scyB\n\nAfter:\nScreen Reader: https://imgur.com/a/Ke7m76C\n\nBug: 963183\nChange-Id: I6e8f9fe59cbe17b90d581a52fc08d0024fe09107\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730595\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Jeff Fisher \u003cjeffish@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705173}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: dcb71d8c283649eb3f9ef2a587ff5192d35536c5\n" }, { "commit": "62b64d2b32e41aaac92a64d4911b005fb87f9355", "tree": "5aeb0f81b97b08fdf9a2db296a6ee5f7faab8628", "parents": [ "a1e9bbe4408ca0a13cb5877b8454dcf11fd4a43c" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Fri Oct 11 17:19:35 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 17:19:35 2019" }, "message": "Remove terminal/ and the corresponding experiment\n\nThe terminal experiment was initially proposed in 2016 [1]. Since then,\nno maintenance work was performed on promoting the experiment to a\nstable feature.\n\nCloser inspection of the feature shows that it does not work. After\nenabling the experiment, issueing the command \"Show Terminal\" results in\nan internal error in xterm.\n\nIf we want to reconsider this experiment, we should re-evaluate the\napproach and come up with a proper design for the feature. For now, I\nwould propose on removing the dead code.\n\n[1]: https://codereview.chromium.org/2372303003\n\nBug: 1006759,1011466\nChange-Id: Ib433b44924d9ccb1f5665afba9affcccd04c2bd8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855923\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nAuto-Submit: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705165}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: da5f866faa7e93ca75874023017fb6ff8aa5b75b\n" }, { "commit": "a1e9bbe4408ca0a13cb5877b8454dcf11fd4a43c", "tree": "442b6a72cb2b4051ea658443a5a6254b24ff7a7b", "parents": [ "f2b52af746e70f5fb9fafb79c62871d832ca558f" ], "author": { "name": "Ingvar Stepanyan", "email": "rreverser@google.com", "time": "Fri Oct 11 12:26:30 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 12:26:30 2019" }, "message": "Include source URL in source map cache key\n\nIt\u0027s not safe to cache source map object by just source map URL, because source map is always constructed with and associated with specific source URL, too, so reusing same source map object for various source URLs can end up resolving invalid locations, pointing to the first source URL it was constructed with.\n\nThis change creates an aggregate source map ID, similar to the one in SDK.DebuggerModel, by concatenating source URL, \":\" and source map URL. Such ID can then be used for caching and tracking purposes.\n\nThere are more things that could be simplified here, but for now tried to make this change minimal and pretty much 1:1 replacement.\n\nAlso removed obsolete applySourceMapEdit which doesn\u0027t seem to be used anywhere.\n\nBug: 1012360\nChange-Id: I131927a9f960526ba01412a39f22f036b1023caf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848697\nCommit-Queue: Ingvar Stepanyan \u003crreverser@google.com\u003e\nAuto-Submit: Ingvar Stepanyan \u003crreverser@google.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#705070}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 747f7f51cf1f1c6d4f8c1fe1045251032ff8b8c9\n" }, { "commit": "f2b52af746e70f5fb9fafb79c62871d832ca558f", "tree": "b71b5c620549e27a1d29838c39a443dd3402c127", "parents": [ "d5c0969e5e09eed16e4deb5ed8d3a3cbb0dc5c15" ], "author": { "name": "Mandy Chen", "email": "mandy.chen@microsoft.com", "time": "Fri Oct 11 02:54:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 02:54:14 2019" }, "message": "DevTools: Fix missing braces for a single line if statement\n\nChange-Id: Ie80d2017d76133359eedf50218a88fe60266c6a3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854788\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Mandy Chen \u003cmandy.chen@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704960}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a510d14ca2f1253c52a487951f13a472d9edd1c9\n" }, { "commit": "d5c0969e5e09eed16e4deb5ed8d3a3cbb0dc5c15", "tree": "593d5dd465048443e8aebca2b71b5ce4d6ae734c", "parents": [ "7b2a11b956fc1872e3de20b5b0d607ca1d6f46af" ], "author": { "name": "Brian Cui", "email": "brcui@microsoft.com", "time": "Fri Oct 11 01:00:12 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Oct 11 01:00:12 2019" }, "message": "DevTools: Fix NVDA screen reader Enter keypress hiding settings pane\n\nThis PR addresses an interaction bug with the NVDA screen reader.\nWhen the NVDA screen reader is in \"scan\" mode (instead of \"focus\" mode),\npressing the Enter key when focused on a button element in the Settings\npane causes the Settings pane to close unexpectedly.\n\nBefore: https://i.imgur.com/GNRvdyW.gif\n\nThis is because NVDA is simulating a click event triggered on the\nUI.Dialog element that wraps the Settings pane, which is not supposed to\nbe clickable by the user. The default behavior for click events on the\nUI.Dialog is to hide the dialog. Our hypothesis is that NVDA is\nincorrectly targeting the UI.Dialog element in the accessibility tree,\nwhich is not meant to be directly interacted with.\n\nThe fix in this PR simply disables the default behavior of clicking on\nthe UI.Dialog for the Settings screen. This should have no side effects\non existing behavior as the UI.Dialog element was never intended to be\ninteracted with. With the hide behavior disabled, NVDA interaction\nacts as expected (button is pressed), and normal usage is unaffected.\n\nAfter: https://i.imgur.com/Gas1ydF.gif\n\nBug: 963183\nChange-Id: Ie1773ed8987dd6d42f8c9cb897fea3de5a091bcb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848114\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Brian Cui \u003cbrcui@microsoft.com\u003e\nAuto-Submit: Brian Cui \u003cbrcui@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704914}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6bc241b3f76ed10f29ec108cdc0f260cdfedc8e9\n" }, { "commit": "7b2a11b956fc1872e3de20b5b0d607ca1d6f46af", "tree": "3efc7269b000e51acceb2d89a5113e38d23d0bcb", "parents": [ "84d4144a39fa09a901d636168a23c9ba3389070b" ], "author": { "name": "Michael Liao", "email": "michael.liao@microsoft.com", "time": "Thu Oct 10 23:31:32 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 23:31:32 2019" }, "message": "DevTools [Common - Overview Grid]: Implement keyboard navigation for overview grids\n\nRe-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1636250\n\nThis is a shared control between Timeline, Network, Memory, JS Profiler and Layers tools\n\n1. This PR adds the ability to use keyboard to navigate sliders in the Overview grid.\n- Can tab into the sliders\n- Can use left and right arrow keys to navigate the grid sliders (step by 2 pixels)\n- Can use Ctrl + left and right arrow keys to navigate the grid sliders faster (step by 10 pixels)\n\nGif: https://imgur.com/Im7m6su\n\nBug: 963183\nChange-Id: I64ec60864165d9cca6e7a76c6849ed1cf1beee61\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676677\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Michael Liao \u003cmichael.liao@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704888}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4dac460364bbd73fcfb4cbff72b98761410a20a3\n" }, { "commit": "84d4144a39fa09a901d636168a23c9ba3389070b", "tree": "e31fd206a1af5ed7e9b7e4143cfc56b383d61393", "parents": [ "8f462fb490b4c87076457641a3b8725cdc4fea1b" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Thu Oct 10 23:01:09 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 23:01:09 2019" }, "message": "DevTools: a11y of Elements/Accessibility Computed Properties pane\n\nThis change enables keyboard selection and navigation, as well as\nscreen reader, for the Computed Properties pane of the Accessibility\ntool. Related nodes can now also be navigated-to by pressing the\n\u003center\u003e key while these nodes are selected.\n\nThis change is a break-out and continuation of CL 1603344.\n\nScreencap: https://imgur.com/a/tcipWNX\nChange-Id: Id7702aa8c2d32cc0afe5215006db7f16b80af195\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812105\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704869}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cb0d667aaab29b78a94c4cea047eaa4e4d234e29\n" }, { "commit": "8f462fb490b4c87076457641a3b8725cdc4fea1b", "tree": "a73f12c774710cf1fe4c8714077edeb6f5cf4b64", "parents": [ "b402d2f2ec8684f82092a0e0b885fc00d8fd6b54" ], "author": { "name": "John Emau", "email": "John.Emau@microsoft.com", "time": "Thu Oct 10 22:20:24 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 22:20:24 2019" }, "message": "DevTools: skip audio context selector empty list state with _items.replace\n\nProblem:\nWhen a web audio context change event occurs the \"changed to\" context is\nfirst removed from the context selector list then added back.\n\nIf the list only contains 1 items then the list contents goes 1 -\u003e 0 -\u003e 1\nand the event listener AudioContextSelector._onListItemReplaced will\nintermediately disable the context menu during the change event when the\nempty state list is reached.\n\nThis can cause side-effects and is extra cycles we don\u0027t need to spend.\n\nSolution:\nThe UI.ListModel.replace method does the same operation without the intermediary\nempty list state.\n\nChange-Id: Ide76e2281c6c7224c22e77f3e7a5766fb2ef0a24\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823730\nCommit-Queue: John Emau \u003cJohn.Emau@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Mandy Chen \u003cmandy.chen@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704856}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f5009cb04315bb13e2798c9b1eaa2233bac51e9a\n" }, { "commit": "b402d2f2ec8684f82092a0e0b885fc00d8fd6b54", "tree": "1608237e73140271f9304a415910aab6aa9d53ce", "parents": [ "ff13b94ea660b74e91c7da920edb5d462f18970b" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Thu Oct 10 21:38:03 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 21:38:03 2019" }, "message": "DevTools: Accessibility issues with Elements - Properties\n\nThe Elements tool Properties pane is inaccessible via keyboard\nonly. It can\u0027t be tabbed into, and even if a user clicks into\nit, the current selection top level tree branch can\u0027t be escaped.\n\nThis change addresses this issue by replacing the use of individual\nObjectPropertiesSection trees with an overarching\nObjectPropertiesSectionsTreeOutline, and then creating roots\nfor each of the objects being displayed. It also gives the OPSTO\na read-only mode (matching existing behavior) and enables tabbing\ninto the properties list.\n\nGIF of after change: https://imgur.com/a/5Fi7W3h\n\nBug: 963183\nChange-Id: I9c178c1d9758450196dd0596241047c9ea2dd813\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757080\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704844}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3180a714317d2a69c9e520a12d4ef9836e27ba12\n" }, { "commit": "ff13b94ea660b74e91c7da920edb5d462f18970b", "tree": "484ac883afcc18984803fdb9673cd9aa3e4903e3", "parents": [ "a33299e789058d4f6046f1a6a1f291a532714b99" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Thu Oct 10 21:30:46 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 21:30:46 2019" }, "message": "DevTools: Make add button in color-picker accessible\n\nEarlier, when user pressed Enter when focus was in Add button it used to close color-picker because keydown event used to\nget bubbled up to inline_editor_module.js which was hiding the element. This inline_editor_module hides\nthe suggested list of items when user presses enter in one of them.\n\nThis change adds keydown handler in UI.Toolbar which consumes the keydown event similar to click handler in it which prevents hiding up color-picker when user presses enter.\nAlso, this change gives focus to recently added item when add button is clicked which has a lightblue border color.\n\nGif showing this change: https://imgur.com/2aaF4Y2\n\nBug: 963183\n\nChange-Id: Ia4594adbb802fdf2fada7ebf62be9a8d1c148f1e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688337\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704841}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e055b0b2c6abd1e0508665ef96638824359b24dd\n" }, { "commit": "a33299e789058d4f6046f1a6a1f291a532714b99", "tree": "cc24db880e2f97b4950f96cd468b83eeea62fb2f", "parents": [ "9ee036d37348502dfc21dbbd634f010b5df89a10" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Thu Oct 10 18:38:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 18:38:15 2019" }, "message": "DevTools: Add axe test for the Global listeners pane\n\nThis adds an axe tests for the Sources panel global listeners pane.\n\n\nBug: 963183\nChange-Id: Iba5ef2bdc927439604f01d91c1e8b9966c43fdf8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666329\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704732}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a6f52934a7d601c1ecbf0d17721402789ba48b9f\n" }, { "commit": "9ee036d37348502dfc21dbbd634f010b5df89a10", "tree": "0f0568ec93dec6ddb0c78d23fe6581376ddb8853", "parents": [ "e05a19d13d7f7081b6db01c5eadacccab2b3268f" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Thu Oct 10 18:33:38 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 18:33:38 2019" }, "message": "DevTools: Improve event listener context menus\n\nThis CL adds context menu items to each listener to reveal its source\ncode, remove it, or toggle whether it is passive or blocking (when\napplicable). This improves the accessibility of the event listeners view\nin the Elements panel as well as the global listeners view in the\nSources panel, as previously the passive toggle and delete buttons were\navailable only on hover.\n\nPreviously reviewed at\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1665298, split\ninto this CL as it impacts multiple parts of the UI.\n\nScreenshot: https://gyazo.com/dc1b54b5e0ae1f9b67f89b0400a168a8\nBug: 963183\nChange-Id: I497e96ee3eb5d58358f904dd7e9ac92b15840baf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716462\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704730}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: dc71d70da0965981b1c8e6bf45d63c75d0d3d00a\n" }, { "commit": "e05a19d13d7f7081b6db01c5eadacccab2b3268f", "tree": "1f3498adbf6ff01c3f429dbb54d9d2ec8f3134d1", "parents": [ "a4d448c312954a1b53bb935e830686cd081d5dec" ], "author": { "name": "Jack Lynch", "email": "jalyn@microsoft.com", "time": "Thu Oct 10 18:04:19 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 18:04:19 2019" }, "message": "DevTools: Allow multiple ObjectPropertiesSections in one tree\n\nIn response to feedback on [1], this CL refactors the Watch expressions\nand Scope pane to keep all of their respective objects in one tree each\ninstead of one tree per object. This allows simple keyboard navigation\nbetween watch expressions or scopes and creates more clarity for screen\nreader users. This change also allows users to edit watch expressions\nand editable object properties by pressing the enter key in order to\nmake that functionality keyboard-accessible.\n\nThere is still an issue where data-keyboard-focus is not applied when\nthe tree element is selected after exiting a text prompt or context\nmenu, but I believe that is an unrelated issue with treeoutline or\nUIUtils that can be fixed separately.\n\nBefore: https://gyazo.com/656714c5e92b268e8a8a988d155bd592\nAfter: https://gyazo.com/02e0df16e66c188c3c8f8d5b38dd3b42\n\nNavigation gif: https://i.imgur.com/I5qT0UW.mp4\n\n[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646644/9/third_party/blink/renderer/devtools/front_end/sources/WatchExpressionsSidebarPane.js#463\n\nBug: 963183\nChange-Id: Iedb6d941364c457cef7614dae6a75ca6b8165c56\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719852\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Jack Lynch \u003cjalyn@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704709}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0f0a0c865b3720d3c59a874ec90dd40617d141ef\n" }, { "commit": "a4d448c312954a1b53bb935e830686cd081d5dec", "tree": "7cfe56de02b514a23160fe29f079710e1cb98259", "parents": [ "08a14a5d264c1294630fc6788737e7fd5fb2bbde" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Thu Oct 10 13:38:29 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 13:38:29 2019" }, "message": "Migrate console_counters/ to ESM\n\n- Also upgrade the refactor script to automatically add the\nextensionpoint to the BUILD.gn to save myself some typing.\n\nBug: 1006759\nChange-Id: I3f789f96122569141194ce26ac288f01af68f6e2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852209\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704600}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e55e98bc0ca76229380e3bca5a78e15d953da0c5\n" }, { "commit": "08a14a5d264c1294630fc6788737e7fd5fb2bbde", "tree": "d591673028a112693d97a354cb72eea33d18c3da", "parents": [ "226fc2224b962719c9923220d5857c07a9672f65" ], "author": { "name": "Al Muthanna Athamina", "email": "almuthanna@google.com", "time": "Thu Oct 10 12:58:44 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 12:58:44 2019" }, "message": "Write tests for ParsedURL.js\n\nThis CL attempts to cover ParsedURL.js\nwith Karma tests. Note that some of the\ncode was not covered because the it threw\nan error when trying to call Root but the\ncoverage ended up being above 90%\n\nChange-Id: Iede3cda2a520f0a8a9a3c1378e48caecc11d183d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852287\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@google.com\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCommit-Queue: Almothana Athamneh \u003calmuthanna@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704585}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 72bb7d44cf66a171057bee45ec228a90736a440b\n" }, { "commit": "226fc2224b962719c9923220d5857c07a9672f65", "tree": "bf8d2cb2b60c30d294081aa907cf52826fd706e8", "parents": [ "8db3fa83eda9f23867e6ceb6c841cc62c139232a" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Thu Oct 10 12:17:12 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 12:17:12 2019" }, "message": "Migrate extensions/ to ESM\n\nBug: 1006759\nChange-Id: I55ff55840cbf00a108cb0f3630cf5b489bf3aac2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849386\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704574}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a332bbea8c8a4c485dc20685b810c082c14a7b70\n" }, { "commit": "8db3fa83eda9f23867e6ceb6c841cc62c139232a", "tree": "0b4326dbbb6e4cb12adca80e6444d7822a706293", "parents": [ "718eebb6a0ff60fa63bb7390f0e79b4071427011" ], "author": { "name": "Paul Lewis", "email": "aerotwist@chromium.org", "time": "Thu Oct 10 11:55:53 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 11:55:53 2019" }, "message": "[DevTools] Sorts colors descending by luminance\n\nChange-Id: Ibe628e70b3d53db9ca132378c2da2ac42cd7746c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847337\nCommit-Queue: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704570}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a755f70431371a3f37046067253f33758d4b4ed5\n" }, { "commit": "718eebb6a0ff60fa63bb7390f0e79b4071427011", "tree": "1639f3c1d15fbc463afcbd6b6c5973602167a5f4", "parents": [ "dd1b0b9235e52dbffcaa49872d23ffa94bcc4003" ], "author": { "name": "Sigurd Schneider", "email": "sigurds@chromium.org", "time": "Thu Oct 10 10:14:57 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 10:14:57 2019" }, "message": "[devtools] Report end position for CSS scripts to DevTools front-end\n\nThis simplifies determining whether a location is inside a CSS header\nin the front-end (the front-end doesn\u0027t have to request the source\nto determine the end line:column from the start line:column and the\nsize).\n\nBefore/After: https://imgur.com/a/OFdQBNL\n\nBug: chromium:1005789, chromium:1005708, chromium:1004203\nChange-Id: I4c660c2a5f901cfe24d022b2636926ecf99254ec\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821721\nCommit-Queue: Sigurd Schneider \u003csigurds@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Andrey Kosyakov \u003ccaseq@chromium.org\u003e\nReviewed-by: Rune Lillesveen \u003cfuthark@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704542}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 96b62150b53277fdadcf13264379f4de9b47a2da\n" }, { "commit": "dd1b0b9235e52dbffcaa49872d23ffa94bcc4003", "tree": "069d87d2f4c72c76ca23aa512dff2aad9c2b0b37", "parents": [ "30df048fc728243f7a3b0e311fdbe836bec071a0" ], "author": { "name": "cjamcl@google.com", "email": "cjamcl@google.com", "time": "Thu Oct 10 02:31:00 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Oct 10 02:31:00 2019" }, "message": "DevTools: [Audits] Send messages from child targets to proxy connections.\n\nRelated: https://github.com/GoogleChrome/lighthouse/pull/9783\n\nBug: 1011228\nChange-Id: I8c232c8f440df72d3780dc66a03166cddc9f5287\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838310\nCommit-Queue: Connor Clark \u003ccjamcl@google.com\u003e\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704425}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1079b28e253fa321c8d9379fed1e69b5b5c6fbbb\n" }, { "commit": "30df048fc728243f7a3b0e311fdbe836bec071a0", "tree": "886308ac8c7b33c9bb416dba4cf9ca533013660f", "parents": [ "5365ead26a67d570ababc538f469d43dfe1eac1b" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Wed Oct 09 23:15:49 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 23:15:49 2019" }, "message": "DevTools: Hide not-found sourcemap refs\n\nWhen a JS source file refers to a sourcemap, which then refers to a file\nthat is not found on the file system (file://), the underlying request\nhandler doesn\u0027t return any headers. With no headers, the DevTools UI\nbindings component presumes that the response is equivalent to a 200 OK\nand returns a blank file. Instead, we\u0027re going to return a 404, which\nwill then prevent DevTools from surfacing the not-found file altogether.\n\nBug: 941035\nChange-Id: Icf92bdcfb415f0381217547dac9037d53915e3fe\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847833\nReviewed-by: Andrey Kosyakov \u003ccaseq@chromium.org\u003e\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704396}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9cfe83f2a243896b4db9bc463ce6c9b69e4f59e8\n" }, { "commit": "5365ead26a67d570ababc538f469d43dfe1eac1b", "tree": "96968fc1d5989895f2e15ed7eb6f93308957e5b7", "parents": [ "475ea50a864d9263abfc512ba41bab58e118e6a5" ], "author": { "name": "Anubha Mathur", "email": "anubmat@microsoft.com", "time": "Wed Oct 09 22:09:07 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 22:09:07 2019" }, "message": "DevTools: Add context menu to computed styles tab to navigate to styles source\n\nThis PR enables navigation to the source of the computed styles using keyboard.\n\n1. Adds a context menu item to navigate to the style in styles pane\n2. Adds a context menu item to navigate to the style source in the sources panel\n\nGif: https://imgur.com/a/E2KGmrv\n\nBug: 963183\nChange-Id: Iea561af075fcb89b0cd5ebe7a63fb8afbdb2aa05\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825790\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Anubha Mathur \u003canubmat@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704362}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 62b32f4e845ed7bbe34b8ce40769cbb45922cd9d\n" }, { "commit": "475ea50a864d9263abfc512ba41bab58e118e6a5", "tree": "23a9de45c5e74432ab818587e03d86f41502a130", "parents": [ "d65e09c1fc6af8b8dd9b8ce8fbe995cd82757e55" ], "author": { "name": "Brandon Goddard", "email": "brgoddar@microsoft.com", "time": "Wed Oct 09 17:44:09 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 17:44:09 2019" }, "message": "Devtools: Fix Keyboard Navigation of Network Group Framed Nodes\n\nIn the network tool, selecting the \"Group by Frame\" option will\ngroup several requests under their parent iframe. When navigating\nthe network data grid using a keyboard, reaching a group frame node\nwith the arrow keys will cause the node to expand and collapse instead\nof select. This prevents navigation to the children or the rest of the\nrequests under the table.\n\nThis CL addresses the issue by allowing selection of group frame nodes.\nSince selection \u003d\u003d\u003d open the sidepane, the group frame node defaults\nto displaying the first child request in the sidepane when selected,\nSimilar to how the waterfall column displays\n\nAlso, Clicking on a group frame node name now selects instead of expanding.\nThe node can be expanded by clicking in the \"disclosure\" triangle to\nthe left of the name, which is the behavior in the rest of the datagrids\nin the devtools.\n\nBefore: https://imgur.com/gMGgTkd\n\nAfter: https://imgur.com/AyMHnba\n\nBug: 1007508\nChange-Id: Ibb4063e90aefde96129108e7e44b76cac611741e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823721\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Brandon Goddard \u003cbrgoddar@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704244}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a2505767acc4b596ea6785b26a53514f1a1d5403\n" }, { "commit": "d65e09c1fc6af8b8dd9b8ce8fbe995cd82757e55", "tree": "3370e36202def30b8bbcb4915968daf2b8dc4c77", "parents": [ "fba61ef1aed980a2b7a325685fe24357c0544115" ], "author": { "name": "Lorne Mitchell", "email": "lomitch@microsoft.com", "time": "Wed Oct 09 17:34:50 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 17:34:50 2019" }, "message": "DevTools: Fixed duplicate call to ls() for Action title.\n\nModified Action.title() to only call ls() on the options title property. Previously it would call ls() on the title property of Extension.title(), which already calls ls(). This resulted in a duplicate call.\n\nBug: 941561\nChange-Id: Idc8d5da56c2ddd219234beb148d3eddd8fb6edd0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838700\nCommit-Queue: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704239}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fc933cc240812364a34d10152b2047cebef9916d\n" }, { "commit": "fba61ef1aed980a2b7a325685fe24357c0544115", "tree": "8db17661b2be910016ca40934241b1c800a117c1", "parents": [ "daf16278b1017823efb98195717c23175fdd9c0b" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Wed Oct 09 16:31:48 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 16:31:48 2019" }, "message": "Migrate browser_sdk/ to ESM\n\nBug: 1006759\nChange-Id: I2aa0c1df1f4d2ae12c328782d2aa4de63c57161a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845716\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704214}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 78180291619540d527aa5cdfe3e44ebfa21ef11c\n" }, { "commit": "daf16278b1017823efb98195717c23175fdd9c0b", "tree": "0659016c643f23b6f04126d0100ed3f678dd78b2", "parents": [ "ebc4719819d53256ddf2e74c42c39eb0f8694c2c" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Wed Oct 09 15:43:43 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 15:43:43 2019" }, "message": "Migrate persistence/ to ESM\n\n- Rename Persistence.js to PersistenceImpl to avoid a name clash with\nthe namespace\n\nBug: 1006759\nChange-Id: I330bd680c8a92984c4a75a0614efa78b4f1e1ea2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845715\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704200}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c68c13c0d5c1a780340192be5d722dc7715b4bbc\n" }, { "commit": "ebc4719819d53256ddf2e74c42c39eb0f8694c2c", "tree": "9b6fe4708141e250d71be4761ccbe3a96714272a", "parents": [ "6db39209035092e4f51f85bcf664510312a313a0" ], "author": { "name": "Paul Lewis", "email": "aerotwist@chromium.org", "time": "Wed Oct 09 15:06:41 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 15:06:41 2019" }, "message": "[DevTools] Adds media queries to CSS Overview\n\nBug: 1007284\nChange-Id: I8c24adddf91da3bd621b61db6eac49233b8a1db4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849671\nCommit-Queue: Paul Lewis \u003caerotwist@chromium.org\u003e\nReviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704192}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 193ed603a6eaec431f9d0f339f697ab03f99c838\n" }, { "commit": "6db39209035092e4f51f85bcf664510312a313a0", "tree": "7507e302bd70e1ad94c1718d2ce8e7aaecc51a1d", "parents": [ "32a3b29462d2e3a4fc1ca71bb690647f4f64f1e2" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Wed Oct 09 14:50:54 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 14:50:54 2019" }, "message": "Migrate components/ to ESM\n\nBug: 1006759\nChange-Id: Ifa7e245a9bbdfc02a5885efb6907e488afdca6e6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847912\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704189}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6a275c8489110bacc08ec22496de42c01159e1a4\n" }, { "commit": "32a3b29462d2e3a4fc1ca71bb690647f4f64f1e2", "tree": "36dac37c5a264383234a98387f10186f1af6beda", "parents": [ "57e7b609df1d3eddb122d41e78892815e5cb2ee4" ], "author": { "name": "Al Muthanna Athamina", "email": "almuthanna@google.com", "time": "Wed Oct 09 14:12:03 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 14:12:03 2019" }, "message": "Write tests for TextDictionary.js\n\nThis CL attempts to cover TextDictionary.js\nwith tests to help with debugging and releases\n\nChange-Id: If733cc1c2baa2ab3006a40605ecb983b154c3e87\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841634\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\nCommit-Queue: Almothana Athamneh \u003calmuthanna@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704179}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a529449a72a495cc5ea7a40b37e70da996ede29b\n" }, { "commit": "57e7b609df1d3eddb122d41e78892815e5cb2ee4", "tree": "42b2c35770da51f0372dbfde248ecdd5165782a0", "parents": [ "ba8654a0ee82219bb3e19fa168da7ccdf3f1f6cf" ], "author": { "name": "Yang Guo", "email": "yangguo@chromium.org", "time": "Wed Oct 09 13:42:16 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 13:42:16 2019" }, "message": "DevTools: prepare build config for externally hosted frontend\n\nThis change introduces the GN arg \u0027external_devtools_frontend\u0027, which\nfor now defaults to false. Follow up changes will implement the true case.\n\nBug: 1011259\nChange-Id: I07afe85f1552516a02184c430fb6e54d3928f04b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838192\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704166}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1a576130ba5df6928867c4897c19a76b9dec355c\n" }, { "commit": "ba8654a0ee82219bb3e19fa168da7ccdf3f1f6cf", "tree": "5a5d7e9b996e814ed9fd0340cbdecf2ffa9dd4d6", "parents": [ "6a3cc740d747b230faca40a5f0d56a6148c70da5" ], "author": { "name": "Junyi Xiao", "email": "juxiao@microsoft.com", "time": "Wed Oct 09 05:37:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 05:37:59 2019" }, "message": "Devtools: change \"more tabs\" dropdown button focus color\n\nIssue: the \"more tabs\" dropdown button doesn\u0027t have enough contrast when\nhover/keyboard focused in dark theme\n\nThis change changes the hover/focused color to match the rest tool bar button\n\nScreenshots: https://imgur.com/a/TBoOlzR\n\nBug: 963183\n\nChange-Id: I9ff66c3be732cf598d18d71af643d01a7de5ce54\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841580\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Junyi Xiao \u003cjuxiao@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704080}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8bac5feed6dc25d972dfe2d38a33574f0e7b3ce6\n" }, { "commit": "6a3cc740d747b230faca40a5f0d56a6148c70da5", "tree": "0ea05eb813b75b64ddf8d804a8b2f1516f26c672", "parents": [ "7d28181e7d4f07bfb1f887702590f50f8ea8172b" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Wed Oct 09 02:06:39 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 02:06:39 2019" }, "message": "DevTools: Styles focus problem after an interstitial dialog\n\nBy presenting an interstitial dialog (like Ctrl+P), keyboarding\nusers might get to a point where they can\u0027t put focus back into\nthe styles pane. This is because tabIndex is set to -1 for all\nof the style blocks. Typically, losing focus causes the styles\nlist to reset the first style block to tabIndex\u003d0, but only if\nthe style container doesn\u0027t already have focus. Because of an\nevent ordering issue, the styles still have focus before the\ninterstitials receive focus. This change allows the styles tree\nelements to reset the styles when they lose focus.\n\nBug: 963183\nChange-Id: I227c48fd88dbe46bbebc982b0c6e10232769d860\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842521\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#704038}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 861c5ebd949d009975ded5e35ea5c4b710171d32\n" }, { "commit": "7d28181e7d4f07bfb1f887702590f50f8ea8172b", "tree": "16d34d6e03607866ef97b7fea94b0dae4b94e76d", "parents": [ "c891ec67a1209426b37dce79890459425be56d14" ], "author": { "name": "Rob Paveza", "email": "Rob.Paveza@microsoft.com", "time": "Wed Oct 09 00:41:08 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 00:41:08 2019" }, "message": "DevTools: Network preview for HTML frame-title rule violation\n\nAccessibility Insights identifies an issue in which the iframe\nwhich contains the HTML preview of network requests does not have\na title, which could present a difficulty for assistive technology.\nBecause, particularly among HTML content, it\u0027s highly likely that\nthe HTML content is going to be presented on the web application,\nand the preview itself is not intended to be interactive, this\nchange adds a role\u003d\"presentation\" attribute. This is intended to\nmake the element semantically meaningless to assistive tech [1].\n\n[1] https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_presentation_role\n\nBug: 963183\nChange-Id: I0f0fd02b13595f4787ebf0919abe8cf5a721884e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841940\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Robert Paveza \u003cRob.Paveza@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703997}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6a8b79105be56245a0cf8c1a1fc779a728ecad1d\n" }, { "commit": "c891ec67a1209426b37dce79890459425be56d14", "tree": "c7c886a7ded4ac788fa99e38b4d348d127f0edc5", "parents": [ "7a133d262994ff0e4cb74a5c00783991317cc0e8" ], "author": { "name": "Christy Chen", "email": "chrche@microsoft.com", "time": "Wed Oct 09 00:31:07 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 00:31:07 2019" }, "message": "DevTools: Avoid concatenations of Console sidebar messages for localization\n\nIn the Console sidebar, the message titles are using concatenation depending\non the number of the messages. This would cause the issue where the strings\ncan not be properly translated since concatenation assumes word order,\nwhich can vary depending on the language, and the white spaces between words\nmight not be needed in other languages.\n\nhttps://imgur.com/a/nC1Dbmt\n\nThis change creates string maps for different cases (No message, 1 message, or\nmore than one messages) to avoid concatenations.\n\nGrdp changes are generated automatically, with manually written descriptions\n\n\n\nBug: 941561\nChange-Id: Iad1803c3d3fadd76e9af3f7407a609e17cd708ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819648\nCommit-Queue: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Christy Chen \u003cchrche@microsoft.com\u003e\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703979}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 40f5d8ca8a069ebf1633665535b61819a706431d\n" }, { "commit": "7a133d262994ff0e4cb74a5c00783991317cc0e8", "tree": "96a4694f10eb92374e7915d4e0bc0bfa87b7d0ed", "parents": [ "6a711a9577a672c09cc8fcf1447cb8fc1a36bee8" ], "author": { "name": "Adithya Srinivasan", "email": "adithyas@chromium.org", "time": "Wed Oct 09 00:27:48 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Oct 09 00:27:48 2019" }, "message": "Portals: Keep DevTools open across activation\n\nTo implement this, we reattach the DevToolsUIBindings for the current\nDevToolsWindow to the RenderFrameDevToolsAgentHost for the activated\nWebContents and reset the main connection in the frontend to reconnect\nwith and enable the new agents.\n\nBug: 992887\nChange-Id: I0ca4e6cc7a6c633680bfd03d574a4030ab65d7b1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788122\nReviewed-by: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nReviewed-by: Lucas Gadani \u003clfg@chromium.org\u003e\nCommit-Queue: Adithya Srinivasan \u003cadithyas@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703973}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5d50d1e0bf22d0474cfc31f63b867706a3e7590f\n" }, { "commit": "6a711a9577a672c09cc8fcf1447cb8fc1a36bee8", "tree": "9bf2d6ddbb1bf136cd6b8501086af3107cff5bc0", "parents": [ "3b65ee495ab7e86b3d47be89675f677495c47440" ], "author": { "name": "Mandy Chen", "email": "mandy.chen@microsoft.com", "time": "Tue Oct 08 22:58:18 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 22:58:18 2019" }, "message": "DevTools: Convert add pattern link to a keyboard accessible button\n\nCurrently the \u0027Add pattern\u0027 link in the Request blocking tool is not\nkeyboard accessible. Pressing enter or space doesn\u0027t open the add\npattern box. See the bug for more info. This CL converts the link to\na button that\u0027s more consistent with rest of the DT\n(examples: https://imgur.com/a/ZU2Xr0P) and makes it keyboard\naccessible.\n\nGIF of how it works now: https://imgur.com/HjDKRoo\n\nBug: 1006125\nChange-Id: Iff77cfeb744c6a0da87ea0182512deb7ba1f4bad\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817332\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Mandy Chen \u003cmandy.chen@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703955}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 13e719933c83c60ff33815859095eb63f15f49f1\n" }, { "commit": "3b65ee495ab7e86b3d47be89675f677495c47440", "tree": "af9a01f913e615747f3cc8cb4ebeef2dff33fabe", "parents": [ "ed9488631f844ad1b7ddf87aab7f3e9cd2285f25" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Tue Oct 08 19:56:19 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 19:56:19 2019" }, "message": "DevTools: Make copy color in color picker screen-reader accessible\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1686452 was broken down as below\n1. Make copy color in color picker keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817416\n2. Make copy color in color picker screen-reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1818297\n\nGif showing UI with this change split from original change https://imgur.com/faSS7PO\n\nBug: 963183\nChange-Id: If06b18bb640c8171343d60a743a65d062895cdde\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818297\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703879}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 81257f8c54c370237d1f7ab3fd68f32c3623b98d\n" }, { "commit": "ed9488631f844ad1b7ddf87aab7f3e9cd2285f25", "tree": "52c239716daee05fd3cbbc46128d55f6f90e80d5", "parents": [ "79b022fc932952280e257822a6f18d2345d3ffd8" ], "author": { "name": "Michael Liao", "email": "michael.liao@microsoft.com", "time": "Tue Oct 08 19:38:40 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 19:38:40 2019" }, "message": "DevTools [Memory]: Making containment source links context menu accessible\n\nChanges:\n - Added context menu option for \"Reveal in Sources Panel\" on data grid entries that contain source links\n\nContext menu on entry with source link:\nhttps://imgur.com/PnIQF7z\n\nContext menu on entry without source link:\nhttps://imgur.com/xoNwSIX\n\nBug: 963183\n\nChange-Id: I4c94ab2d3115704d1a8740b81161633b25b547e1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717317\nCommit-Queue: Michael Liao \u003cmichael.liao@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703871}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7a113c3347b4911139ea02b5ed0b44bda81c0c06\n" }, { "commit": "79b022fc932952280e257822a6f18d2345d3ffd8", "tree": "74cbf8d257d3b8c4cbafbdbc7edb8cdc58d08ae6", "parents": [ "218413b440abc95f6c8b5ecdfe2482dc8eb06138" ], "author": { "name": "Ted Meyer", "email": "tmathmeyer@chromium.org", "time": "Tue Oct 08 18:24:30 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 18:24:30 2019" }, "message": "Preliminary UI for media log inspecting.\n\nNew UI allows the selection and viewing of events and properties for\neach media player open on the tab being inspected.\n\nThis feature depends on enabling the InspectorMediaLogging flag to get\nany data.\n\nWhat\u0027s missing:\n - A timeline view for events\n - A right click menu on a media player to inspect it\n\nDesign Doc: https://docs.google.com/document/d/1NMTjKc-Q99UDTS0QFoftVwhmzZTEh0fsHGQJ6I82IRY/edit#heading\u003dh.vhj3t4rsmjte\nUX discussion: https://docs.google.com/document/d/1EKuv_KNFFIclJOEx6k70WMUOPgsXJs7DmMHNQayKSuI/edit?ts\u003d5d7c04d2\n\nScreenshots:\nhttps://files.tedm.io/dtss/5.png\nhttps://files.tedm.io/dtss/6.png\n\nBug: 794255\nChange-Id: Iff2d4f057168e7f20829ef4752f6dfcdea75a293\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755008\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Ted Meyer \u003ctmathmeyer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703831}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6601991536b94cd07ef39515fc401e72baa176bd\n" }, { "commit": "218413b440abc95f6c8b5ecdfe2482dc8eb06138", "tree": "dc55007d51df0b246003e3177f937215fd3a1a44", "parents": [ "0723204a4762d9e579136514db5067138003c99e" ], "author": { "name": "Mandy Chen", "email": "mandy.chen@microsoft.com", "time": "Tue Oct 08 17:47:21 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 17:47:21 2019" }, "message": "DevTools: Only log error stack to avoid duplicate error messages\n\nThe localization parser currently logs the error stack and error message\nwhen running without the --autofix flag. Since the stack includes the error\nmessage, this CL takes out the call to log the error message to avoid\nduplicate error messages.\n\nBug: 941561\nChange-Id: If8c5f05148be6e2eb666eb17cefe649715006209\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820088\nReviewed-by: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nCommit-Queue: Mandy Chen \u003cmandy.chen@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703813}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c9ef1c432008114038aade7d70fe815a036e7068\n" }, { "commit": "0723204a4762d9e579136514db5067138003c99e", "tree": "5e3df0c67c4280872d5f0a8f178e9ca81800da19", "parents": [ "e7ab01594c89f9730f26bbaff267be1bcaf5a70a" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Tue Oct 08 15:58:07 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 15:58:07 2019" }, "message": "Migrate bindings/ to ESM\n\nBug: 1006759\nChange-Id: Iaf9bc50583ed4936998f73c29c915d9c6f086195\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847286\nCommit-Queue: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703749}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 476a2598349667b31c75170c3912dc75867883a9\n" }, { "commit": "e7ab01594c89f9730f26bbaff267be1bcaf5a70a", "tree": "667a9933e3414b477c9d50fb612c2eff116b08c0", "parents": [ "4d703237a94e6f9a160a2bc321c82b498e245eac" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Tue Oct 08 14:43:09 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 14:43:09 2019" }, "message": "Migrate workspaces/ to ESM\n\n- Rename Workspace.js to WorkspaceImpl.js to not name clash with\nworkspace.js in the Grit localization generation.\n\nBug: 1006759\nChange-Id: I56a496d866e4a453cd3ef84a24c29f8baa296876\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847280\nCommit-Queue: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703716}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8b92ab942a8ec5717450a27e95ca7a7494ba5f44\n" }, { "commit": "4d703237a94e6f9a160a2bc321c82b498e245eac", "tree": "ed33f3056d219161cbab1c32a1b7d9d9834097f8", "parents": [ "1b0e57d3d20eb78319f908e010fb18943e549b8b" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Tue Oct 08 14:28:24 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 14:28:24 2019" }, "message": "Migrate services/ to ESM\n\nBug: 1006759\nChange-Id: I17818dd46ad42882388a145cdd49400f2f2e5a7b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845711\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703691}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e92249105abf8f8572a5ab5acd3fc6fa3f6c18f7\n" }, { "commit": "1b0e57d3d20eb78319f908e010fb18943e549b8b", "tree": "2237c6346b6e20314b53dd70839950eb15b6f358", "parents": [ "935d0618ff7255c0ca9213ac89240c4c42b939b9" ], "author": { "name": "Yang Guo", "email": "yangguo@chromium.org", "time": "Tue Oct 08 10:56:03 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 10:56:03 2019" }, "message": "DevTools: add more OWNERS\n\nChange-Id: I87d875c4ddc9fe23a7b9c200165443f84818623a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838193\nReviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703655}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ca20c5f635df67838d738ef466788455b3d4d0fc\n" }, { "commit": "935d0618ff7255c0ca9213ac89240c4c42b939b9", "tree": "0d1ec6aa8edc250c004b3c58d88eb821268d191d", "parents": [ "8d5a4665d34ac0ee5d107d10daf4009c2625047f" ], "author": { "name": "Benedikt Meurer", "email": "bmeurer@chromium.org", "time": "Tue Oct 08 10:29:31 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Oct 08 10:29:31 2019" }, "message": "[devtools] Cleanup return type of Timeline.TimelineUIUtils.eventStyle().\n\nIn `Timeline.TimelineUIUtils.eventStyle()` we used to return either a\n`Timeline.TimelineUIUtils` instance or a custom object literal, we even\nput a custom type annotation here to make that pass Closure type\nchecking. But it\u0027s better to just use `Timeline.TimelineRecordStyle`\nconsistently here, and also faster.\n\nChange-Id: Ie8834b7a4f8862fde3d2d7c6d6c5ee04dec76b53\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845752\nAuto-Submit: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703649}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b7212aff43e999b711a3a708914b5850b831a1e4\n" }, { "commit": "8d5a4665d34ac0ee5d107d10daf4009c2625047f", "tree": "590b45510d5d87b88e46c25c37666c4876969cff", "parents": [ "042827fcdd9a6b8e44d15d6286ae0bdf88ed8b86" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Mon Oct 07 21:20:34 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 21:20:34 2019" }, "message": "DevTools: Remove extra tab in Settings Throttling Pane\n\nWithout this change when user navigates back by pressing SHIFT TAB from inputs in throttling settings pane.\nTab stops at whole throttling settings pane. Again, pressing SHIFT TAB it takes to \u0027Throttling\u0027 in Settings then, pressing TAB it lands in Throttling Pane content section instead of landing on first control \u0027Add custom profile button\u0027.\nThis change removes that extra TAB so that, when user presses TAB it lands only in interactive controls and satisfies below given rule:\n- Don\u0027t allow users to tab to text elements (such as labels) or other static content.\nMore info: https://accessibilityinsights.io/docs/en/windows/reference/tabstops\n\nBug: 963183\nChange-Id: I100ccc0b541f2eb8a077a7fdb63c6f594dbc6c4d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817412\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703472}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4bf85dbc7308e5769364eaa68924dad764c77843\n" }, { "commit": "042827fcdd9a6b8e44d15d6286ae0bdf88ed8b86", "tree": "b168d87744e9f37164f4a7881b5287f84972478c", "parents": [ "723f5c7c695658d236fc177d1668a785bc88a6c9" ], "author": { "name": "James Lissiak", "email": "jalissia@microsoft.com", "time": "Mon Oct 07 20:46:20 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 20:46:20 2019" }, "message": "DevTools: Fix Console Live Expression CSS\n\nThis patch updates the css for the console pin pane so that it never\nexceeds 50% of the outer window.\n\nIssue 884137 shows that when the console window height is small, the\nlive expression pane can overflow the console input pane making it\nimpossible to type into the console. This is due to the pin pane css\nsetting a max-height of 200px regardless of the height of the outer\nwindow.\n\nThe fix is to update the css so that pane has a max height of 50% but\nthe inner container uses 200px so that it will have a height of the\nsmaller of the two. Allowing users to always see the input area.\n\nSee: https://imgur.com/a/GS8yA8h\n\n\nBug: 884137\nChange-Id: I85337f7391a882ca107a30be2bf5c2a12f261787\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837527\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: James Lissiak \u003cjalissia@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703449}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7df70dbd0f8d39c40d3347f592666bb3e3ab98d2\n" }, { "commit": "723f5c7c695658d236fc177d1668a785bc88a6c9", "tree": "452db2df9784d8c0cee36a2b7053a075337360bf", "parents": [ "c938fe6f189e237678fdbb563989a9c5dcb2c6ff" ], "author": { "name": "Paul Lewis", "email": "aerotwist@chromium.org", "time": "Mon Oct 07 20:35:17 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 20:35:17 2019" }, "message": "[DevTools] Fixes keyboard shortcuts for Mac\n\nBug: 1011638\nChange-Id: I4930f3a0b5fd3de08bcfd52f6f68777bdb28ed80\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845224\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Paul Lewis \u003caerotwist@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703438}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c03263ee66271418d0ab19a2e92eb3b98f09b4cc\n" }, { "commit": "c938fe6f189e237678fdbb563989a9c5dcb2c6ff", "tree": "7c897bb0ffd34336c0fbbf135485a75299e40833", "parents": [ "cc1302c8ffd86167f7ca60f4a9f8302765fbf917" ], "author": { "name": "Lorne Mitchell", "email": "lomitch@microsoft.com", "time": "Mon Oct 07 19:48:35 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 19:48:35 2019" }, "message": "DevTools: Modified Security.securityStateChanged to use types and data instead of pre-processed English strings\n\nThis change modifies the shape of the Security.securityStateChanged (https://chromedevtools.github.io/devtools-protocol/tot/Security#event-securityStateChanged) CDP event to include the type of state that has changed along with the data needed to generate the details that are shown in the Security tool.\n\nThe strings that are currently present in security_state_strings.grdp will be moved to the DevTools frontend. security_state_strings.grdp will remain in place, so that we don\u0027t break backwards compat with Security.securityStateChanged. This will come in a separate CL.\n\nBug: 946860\nChange-Id: I18a2ff879bf201d36cf02af88963dcb996c4811f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646792\nCommit-Queue: Lorne Mitchell \u003clomitch@microsoft.com\u003e\nReviewed-by: Andrey Kosyakov \u003ccaseq@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703417}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e300b6ba7c0045148cffd3ba4e0cb110276f2d77\n" }, { "commit": "cc1302c8ffd86167f7ca60f4a9f8302765fbf917", "tree": "4198b7df939aec1563fd17f814cb9de4d76f752b", "parents": [ "c647113d408a8f015543300804ba6a7b5d91f91f" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Mon Oct 07 19:39:14 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 19:39:14 2019" }, "message": "DevTools: Make copy color in color picker keyboard accessible\n\nThis change makes Copy color in colorPicker keyboard accessible. Earlier, this was working only with mouseclick.\n\nThis was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1686452 which has been broken down as below\nMake copy color in color picker keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817416\nMake copy color in color picker screen-reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1818297\n\nGif showing color picker with this change https://imgur.com/9YxCQpc\n\nBug: 963183\nChange-Id: I03e1e1481ba74e816d86c100783d732329dc4e7d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817416\nReviewed-by: Mathias Bynens \u003cmathias@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703411}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8025f5c02886f7fc72b8e1e145b2dc04dd8ec659\n" }, { "commit": "c647113d408a8f015543300804ba6a7b5d91f91f", "tree": "ee69abe6cb59bd92cca689af3cd4a1cda17d4666", "parents": [ "7245dcfe0910013bc40a3e13a7ce23ff2e0389f3" ], "author": { "name": "Chandani Shrestha", "email": "chshrest@microsoft.com", "time": "Mon Oct 07 19:36:01 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 19:36:01 2019" }, "message": "DevTools: Add heading level 1 in Settings Throttle Pane\n\nThis change adds h1 because page must contain level one heading to make it accessible.\nMore info https://dequeuniversity.com/rules/axe/3.0/page-has-heading-one\n\nThis change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1648916 which has been split into small changes.\n\nBug: 963183\nChange-Id: I107b87ed3bc4e182daba7c85f8af12bf68b84311\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817415\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: John Emau \u003cJohn.Emau@microsoft.com\u003e\nCommit-Queue: Chandani Shrestha \u003cchshrest@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703409}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5e328a3131bf1928233ee46ea344b7050fa33a48\n" }, { "commit": "7245dcfe0910013bc40a3e13a7ce23ff2e0389f3", "tree": "2273d7014d7ad61322fe4ccd7e67a5b0a4498873", "parents": [ "ad060fc2aac96e466e8cbb59ddd5f010bd2a3e1d" ], "author": { "name": "Brian Cui", "email": "brcui@microsoft.com", "time": "Mon Oct 07 19:29:34 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 19:29:34 2019" }, "message": "DevTools: Fix input box placeholder color dark text on dark background\n\nThis PR fixes an issue with placeholder text in input fields showing as\nblack against black when the dark theme is enabled, making them\nimpossible to read.\n\nThe fix simply assigns the ::placeholder CSS pseudo-element to all\ninput fields so the placeholder text is always a shade of gray,\ncompatible with both themes. The color value `rgba(0, 0, 0, 0.54)` was\ncopied from the stylesSidebarPane rule that specified ::placeholder\ncolor (and hence, the sidebar was not affected by this bug).\n\nBefore: https://i.imgur.com/iwiKvrU.png\nAfter: https://i.imgur.com/labeZzz.png\n\nThe light theme appearance is unchanged.\n\nBefore (Light): https://i.imgur.com/x8sXkWU.png\nAfter (Light): https://i.imgur.com/qp3zzzc.png\n\n\nBug: 1011477\nChange-Id: Ia418ce346defb134a7a4db57b83bc666f7f49056\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841665\nAuto-Submit: Brian Cui \u003cbrcui@microsoft.com\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Brian Cui \u003cbrcui@microsoft.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703406}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 388f07058828618f9d5d61b3cdcfcd210c6ade3d\n" }, { "commit": "ad060fc2aac96e466e8cbb59ddd5f010bd2a3e1d", "tree": "d4c9b6376020082600e65e7b71d904c6d457a95c", "parents": [ "9b7d21d126543a7b70988ac9a848689830e9201d" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Mon Oct 07 19:19:25 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 19:19:25 2019" }, "message": "Fix access on undefined script object\n\nI saw the following stacktrace while running Chromium locally:\n\n[205430:205430:1007/182130.681774:ERROR:CONSOLE(61)] \"TypeError: Cannot read property \u0027originStackTrace\u0027 of null TypeError: Cannot read property \u0027originStackTrace\u0027 of null\n at Function._script (devtools://devtools/bundled/sources/sources_module.js:1469:197)\n at Sources.ScriptOriginPlugin.rightToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1467:41)\n at Sources.UISourceCodeFrame.syncToolbarItems (devtools://devtools/bundled/sources/sources_module.js:335:215)\n at Sources.SourcesView._updateScriptViewToolbarItems (devtools://devtools/bundled/sources/sources_module.js:1215:168)\n at Sources.SourcesView._editorClosed (devtools://devtools/bundled/sources/sources_module.js:1226:43)\n at Sources.TabbedEditorContainer.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173)\n at Sources.TabbedEditorContainer._tabClosed (devtools://devtools/bundled/sources/sources_module.js:1012:114)\n at TabbedPane.dispatchEventToListeners (devtools://devtools/bundled/common/Object.js:12:173)\n at TabbedPane._innerCloseTab (devtools://devtools/bundled/ui/TabbedPane.js:30:73)\n at TabbedPane.closeTabs (devtools://devtools/bundled/ui/TabbedPane.js:23:93)\", source: devtools://devtools/bundled/host/InspectorFrontendHost.js (61)\n\nIt appears that the code in this file already assumes that script can be\nundefined, but forgot this particular case.\n\nChange-Id: I7b0c0d34b4d16a1d29656cd8d86e3f290f8bb227\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845751\nCommit-Queue: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nCommit-Queue: Yang Guo \u003cyangguo@chromium.org\u003e\nAuto-Submit: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703397}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c69e1b709eb6fae315ae8138cc4f4a05fcc0f83b\n" }, { "commit": "9b7d21d126543a7b70988ac9a848689830e9201d", "tree": "97a0ce81b70bb1cd1488fbaa48df8cc140f09498", "parents": [ "f8d2e3ac0da666cf6f090b49fac4aab67b1624a7" ], "author": { "name": "Tim van der Lippe", "email": "tvanderlippe@chromium.org", "time": "Mon Oct 07 18:48:07 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 18:48:07 2019" }, "message": "Migrate sdk/ to ESM\n\nBug: 1006759\nChange-Id: I3f5917ab3f5b3fb823ca460c395301ba19eed2df\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841792\nCommit-Queue: Tim Van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703381}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5a7c8d13f806d781e8edb96a9b1f152d4fe1258a\n" }, { "commit": "f8d2e3ac0da666cf6f090b49fac4aab67b1624a7", "tree": "96d4e069ecca59e64d77cc2cd6ef1f381db78865", "parents": [ "8b8408eb2518b8005267bdc82c4178b370946872" ], "author": { "name": "Jan Scheffler", "email": "janscheffler@chromium.org", "time": "Mon Oct 07 13:52:19 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 13:52:19 2019" }, "message": "[devtools] Add filter for type to coverage\n\nThis patch adds a filter to the coverage pane\nto allow filtering to report only css or js files.\n\nBug: chromium:1004185\nChange-Id: Ia8b4ba1e8265a6c20f8a9ebdeb7db0622c4b4b51\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806733\nCommit-Queue: Jan Scheffler \u003cjanscheffler@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703287}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 59cca2c8f5fcd709360d4ba111fd2a9fca4e78f7\n" }, { "commit": "8b8408eb2518b8005267bdc82c4178b370946872", "tree": "724934bd8253af937b3b70e4dfdef4cd7e1531ad", "parents": [ "e3c9301bfee5280e3450b8fbea86d3ec34b59f3c" ], "author": { "name": "Benedikt Meurer", "email": "bmeurer@chromium.org", "time": "Mon Oct 07 10:50:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 10:50:15 2019" }, "message": "[devtools] Label background compiles with \"Streaming Compile Script\".\n\nPreviously background parsing and compilation was always labeled \"Parse\nScript\" whereas foreground parsing and compilation was always labeled\n\"Compile Script\". But in either case the engine might parse and/or\ncompile, so we should be consistent here. Also for developers it doesn\u0027t\nreally matter whether V8 is parsing or compiling to bytecode.\n\nBug: chromium:940958\nChange-Id: I320095e10613d7cc1405069345e0dd0613a7130a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844993\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nReviewed-by: Leszek Swirski \u003cleszeks@chromium.org\u003e\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703258}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ff2e189eb4e805b8690e1e3ff75ffc98d80bf19f\n" }, { "commit": "e3c9301bfee5280e3450b8fbea86d3ec34b59f3c", "tree": "43cace57b15f63ea6ba3d6d1571faa8560ecd720", "parents": [ "d3cabc7836160f5d665f871e7ff1b4d39d3f49f0" ], "author": { "name": "Mathias Bynens", "email": "mathias@chromium.org", "time": "Mon Oct 07 10:39:27 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 10:39:27 2019" }, "message": "[DevTools] Use empty string `defaultValue`s for CSS media features\n\nExplicitly passing `\u0027no-preference\u0027` as a CSS media feature value has\ndifferent semantics than passing the empty string (which clears the\nemulation override), causing difficult-to-debug issues.\n\nBug: chromium:1011722, chromium:1004246\nChange-Id: I371681ba646306d4f5e8bff10e8c502329a87093\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844816\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCommit-Queue: Mathias Bynens \u003cmathias@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703255}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9b553f7aad0883dc8f1cbe7d37d69babed395ad9\n" }, { "commit": "d3cabc7836160f5d665f871e7ff1b4d39d3f49f0", "tree": "355170a13abba24becf9127008abf76ccc28d5cf", "parents": [ "236072bf48402966f65d73f36c3ffc150ed5bb3c" ], "author": { "name": "Benedikt Meurer", "email": "bmeurer@chromium.org", "time": "Mon Oct 07 09:50:36 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Oct 07 09:50:36 2019" }, "message": "[devtools] Only strip //# sourceURL\u003d lines at the end of the source.\n\nPreviously the DevTools UI would strip out //# sourceURL\u003d... and\n//@ sourceURL\u003d... lines from the script in the frontend no matter\nwhere they showed up in the source code, which means that all the\npositions after this line will be off by 1 between frontend\nand backend. It\u0027s generally also very confusing to developers that\nwe\u0027re removing code from the script before showing it.\n\nIn general, we should just display exactly the code that the developer\nwrote (similar to Firefox DevTools and Safari WebInspector), however\nthere\u0027s quite a bit of internal logic relying on the special handling\nof sourceURL comments (at the end), for example when it comes to\nsnippets. So meanwhile we only remove the comments when they are found\nat the end of the source code, which is where tools put them.\n\nBug: chromium:1003497\nChange-Id: I4404e2f7b6b61d50f85e44bbd9e0ae56675670af\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840512\nCommit-Queue: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\nReviewed-by: Yang Guo \u003cyangguo@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#703244}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 41700f354fcb17636b6d8a280a5f291423e22813\n" } ], "next": "236072bf48402966f65d73f36c3ffc150ed5bb3c" }