)]}' { "log": [ { "commit": "457f560b5ca3156a537b7df14d4a14f864e8283a", "tree": "fb74c91072e1b2986cb78693ed412c2ba72b47c9", "parents": [ "733b75aa7d12de246f4f5eae2b4e1b1279e87a38" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Thu Sep 10 20:56:12 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 10 21:00:57 2026" }, "message": "Add a basic //third_party/ipcz/SECURITY.md\n\nChange-Id: I8ecf7954b3320430be11a465d0196b29f500ab9d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8381242\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Elly \u003cellyjones@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1695643}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9fc2c402e1ad102e7662d89e90b440c6e144eaae\n" }, { "commit": "733b75aa7d12de246f4f5eae2b4e1b1279e87a38", "tree": "08f0304d06702d7880adf0f2603fa66a33197037", "parents": [ "48e77097048739d68cbeb10dcbdb197c05de5ed3" ], "author": { "name": "Alex Ovsienko", "email": "ovsienko@google.com", "time": "Thu Sep 10 10:32:28 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 10 10:41:13 2026" }, "message": "VPython: migrate legacy vpython to UV across subdirectories\n\nConvert remaining legacy .vpython3 files and embedded script specs to\nvpython.toml and PEP 723 inline metadata with companion .uv.lock\nlockfiles across subdirectories (agents/, chrome/, infra/, ios/,\nthird_party/, tools/).\n\nUpdated references from .vpython3 to vpython.toml in build files,\nscripts, and documentation. Removed redundant CheckVPythonSpec from\nbuild/PRESUBMIT.py as it is already run repository-wide in root\nPRESUBMIT.py.\n\nLegacy Python 2 spec (third_party/agility-sdk/3pp/.vpython) and specs\nwith unresolvable CIPD binaries or upstream constraints\n(chrome/test/enterprise/e2e/.vpython3, tools/clang/scripts/get_tensorflow.py)\nare retained as legacy specs. Upstream-rolled repositories\n(third_party/crashpad/crashpad) are excluded to be updated and rolled\nfrom upstream.\n\nLSC: go/vpython-uv-config-lsc\nR\u003djwata@google.com\nBug: 491263752\nChange-Id: I069123a2e9a03134f238bb04b4f577266a6a6964\nTAG\u003dagy\nCONV\u003db53bdf70-37e7-4696-be50-8ee6fc19b1f8\n\nChange-Id: I069123a2e9a03134f238bb04b4f577266a6a6964\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8384839\nOwners-Override: Alex Ovsienko \u003covsienko@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Alex Ovsienko \u003covsienko@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1695324}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f21d858a43c65504e733ef87b8e1b5ced1142943\n" }, { "commit": "48e77097048739d68cbeb10dcbdb197c05de5ed3", "tree": "f717b2bf8e8116c3ce01bacdb06178b04b53446e", "parents": [ "8bf059575a26092b18f14386d295a2734e21e345" ], "author": { "name": "Will Harris", "email": "wfh@chromium.org", "time": "Thu Sep 03 15:19:36 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 03 15:41:36 2026" }, "message": "[Mojo] Limit peer trust for isolated connections\n\nNodeLink::OnAcceptIntroduction now rejects introductions that would\nintroduce a broker to another broker; broker-to-broker links are only\never established directly via ConnectNode, and HandleIntroductionRequest\nalready declines to introduce two brokers, so this case is never reached\nby a well-behaved sender.\n\nNodeLink::OnRelayMessage now also requires the sender to be a\nnon-broker, matching the only legitimate caller (NodeLink::Transmit via\nGetBrokerLink()).\n\nIn the mojo ipcz driver, Transport::Deserialize no longer treats the\nsource as trusted purely because the destination is a broker when the\nsource is itself a broker: a non-broker still implicitly trusts its\nbroker, but two brokers connected to one another must explicitly mark\nthe peer as trusted before either will accept an embedded transport that\nclaims a broker destination or a trusted peer. The mojo-ipcz test driver\nis updated so cooperating broker test nodes mark each other as trusted,\nand a new TransportFromUntrustedBroker test covers the untrusted-broker\ncase directly.\n\nBug: 516780835\nChange-Id: I54ca58feb080a4478acd68e12bce3af9f29ba561\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8340888\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Will Harris \u003cwfh@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1691601}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7858f67868ff8416db134d4f9e1a38731df6504b\n" }, { "commit": "8bf059575a26092b18f14386d295a2734e21e345", "tree": "bff093c8558e30afbe137a9ae8028d6376588811", "parents": [ "aeeaa6f4325e1c0ae0f2dd40eb1ff19d19a4af37" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Aug 27 14:09:32 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 27 14:14:43 2026" }, "message": "ipcz: Add per-size histograms for block allocation in buffer pool\n\nAdd two histograms:\n Mojo.Ipcz.BufferPoolAllocateBlock{Success,Failure}Size\n\nOne histogram for successful allocations, another for failed ones. Each\nsuccess/failure updates the bucket in the histogram corresponding to the\nbucket allocation sizes. Initially support only these sizes: 64..4096,\nand all powers of 2.\n\nBug: 332719403\nChange-Id: Ib496af49e4a8e1ed0b3980ce855cc699ce7a4338\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8277970\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Christian Dullweber \u003cdullweber@chromium.org\u003e\nReviewed-by: Nafis Abedin \u003cnafisabedin@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1687187}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 52c63d8b87653053b284b891652834d0965d8117\n" }, { "commit": "aeeaa6f4325e1c0ae0f2dd40eb1ff19d19a4af37", "tree": "ca385f734ddaf21e16dc4e3702281d10de9f73fd", "parents": [ "75c9ec5d70bac6e26b29cc303de28b10da80aeff" ], "author": { "name": "Mahmoud Rashad", "email": "mmrashad@google.com", "time": "Tue Aug 25 08:15:10 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 25 08:18:27 2026" }, "message": "Fix unsafe buffer usage in ipcz/remote_router_link.cc\n\nReplaced unsafe memcpy and memset calls with safe loops and\nstd::ranges::fill to fix unsafe buffer operations.\n\nInitial patchet generated by headless gemini-cli using:\n//agents/prompts/projects/spanification/run.py\n\nFixed: 455561164\nChange-Id: Ia464ce3dd0ad0b7e08203f50e4a597804b8bfdcc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7079364\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1685353}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3b979124d65bfe96d97a522e4219ccae3922c07a\n" }, { "commit": "75c9ec5d70bac6e26b29cc303de28b10da80aeff", "tree": "576910f066f004b193f825a4230e1f2937727289", "parents": [ "d05be771d585941e01153ead0371e9d765dceaf9" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Mon Aug 24 19:15:20 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Aug 24 19:20:12 2026" }, "message": "ipcz: Add Mojo.Ipcz.BufferPoolAllocateBlockResult\n\nThis would be the lowest level histogram to count shared memory \u0027block\u0027\nallocation successes/failures in common code.\n\nLater we would probably want to separately record such counts for each\npopular block size. Then we would also likely want to know which failed\non serious matters (router serialization, sending a parcel, no memory\nfor data pipe) and which ones are more tolerable (ipcz bypass\nmechanics).\n\nBug: 332719403\nChange-Id: I7dd7d58338c4575c78deafdff722a2a47561f31e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8282755\nReviewed-by: Calder Kitagawa \u003cckitagawa@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Nafis Abedin \u003cnafisabedin@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1684908}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 009b2d5a5785d9738356cb888d78713f6c0ba108\n" }, { "commit": "d05be771d585941e01153ead0371e9d765dceaf9", "tree": "6c79f8696f1e69bd716d25692d49d701c4515259", "parents": [ "aa891fdc69df0876c945570866076045924713a1" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Wed Aug 19 21:19:40 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Aug 19 21:23:55 2026" }, "message": "ipcz: Remove IPCZ_ALIGN from IpczAPI\n\nAlignment of structs like IpczCreateNodeOptions is no longer necessary\nafter the ABI promise is dropped. Remove all IPCZ_ALIGN annotations for\nstructs passed into IpczAPI methods.\n\nKeep IPCZ_ALIGN in other files. Those annotations maintain the wire\nformat stability.\n\nBug: 526596517\nChange-Id: If13bb448ba03bff79b1e5d556caa5c7d9dc2483f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8141439\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1682626}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0cf49964aab0714a04f59357deee14b535b07e60\n" }, { "commit": "aa891fdc69df0876c945570866076045924713a1", "tree": "9dc3562108804dbcc001e307bc2c188343722290", "parents": [ "c746459cbf8bbc7605a30f5125eb3235205f38fd" ], "author": { "name": "Arthur Sonzogni", "email": "arthursonzogni@chromium.org", "time": "Fri Jul 24 16:31:54 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jul 24 16:35:50 2026" }, "message": "ipcz: Remove allow_unsafe_buffers and allow_unsafe_libc_calls pragmas\n\nI am getting rid of the last few file-level exclusions for\nspanification. This removes the ones for ipcz.\n\nBug: 351564777, 501112808\nDoc: go/complete_unsafe_todo_migration\nChange-Id: I3a12ccfae19b707277bfde5ad95ac70398cf10be\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8137704\nCommit-Queue: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1667915}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9f79989f5ba1982cf81300abc4e56c8a97e0909c\n" }, { "commit": "c746459cbf8bbc7605a30f5125eb3235205f38fd", "tree": "bfbf11cd4bd0f7ddd916ca17c8fa13913bf44d67", "parents": [ "4bc8b97206572a883492b15bae99bc6b5fa2560f" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Jul 23 15:14:33 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 23 15:31:42 2026" }, "message": "ipcz: Allow //base. Part 4: Make IpczAPI cpp class\n\nNo functional changes. Pure refactoring. This is Part 4 of the patch\nseries to allow using //base in //third_party/ipcz.\n\nThe IpczAPI is a C struct with function pointers. Replace it with an\nabstract class having the same name. Provide a stateless implementation\nIpczAPIImpl. Remove the global struct kCurrentAPI. The IpczAPIImpl is a\nstraight copy of the same functions that existed in the same file and in\nthe same order. I had to rename some arguments trivially, so the\nfunction/method bodies are slightly different. No other changes in those\nbodies.\n\nBug: 526596517\nChange-Id: If89b09f316652683ee3a3af4be8ba320dd937f1b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8057124\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1667110}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 79c79633dfecda26baee23e440f13a4c6df72b11\n" }, { "commit": "4bc8b97206572a883492b15bae99bc6b5fa2560f", "tree": "1cb2b765227ae968a8fc063be85b2f105d72701b", "parents": [ "2bb23997632099f9153f345fc811ae387864de85" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Wed Jul 22 22:14:20 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jul 22 22:18:49 2026" }, "message": "ipcz: Allow //base. Part 3: Make IpczDriver cpp class\n\nNo functional changes. Pure refactoring. This is Part 3 of the patch\nseries to allow using //base in //third_party/ipcz.\n\nCurrently IpczDriver is a C struct with function pointers. Transform it\nmechanically into an abstract C++ class with pure virtual methods. All\nimplementations of struct IpczDriver move into stateless classes,\npreserving the original inheritance relationships.\n\nHere is the resulting tree:\n Inherit from IpczDriver:\n DriverImpl\n MockDriverImpl\n SingleProcessReferenceDriverBase\n MultiprocessReferenceDriverImpl\n FuzzerDriverImpl\n Inherit from SingleProcessReferenceDriverBase\n SyncReferenceDriverImpl\n AsyncReferenceDriverImpl\n\nManual function pointer mapping is no longer necessary.\n\nThe syntax for calling IpczDriver methods is the same as for object\nreferences. Example:\n\n GetFuzzerDriver().Close()\n\nNot updating the callsites/uses of IpczDriver.\n\nRemove compile_c_test.c. The interface is no longer pure C.\n\nWe will migrate struct IpczAPI to C++ class similarly later in the patch\nseries. For now it remains a C struct.\n\nBug: 526596517\nChange-Id: I00c6dabeeff29cee958463321915c8a10dba3b9b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8054049\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1666655}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 295b16dbb3d3d45cb06803616ed0b1b4b07f655f\n" }, { "commit": "2bb23997632099f9153f345fc811ae387864de85", "tree": "a05d1382d9b4238be5d39e218ea8db56ed48bfa3", "parents": [ "5e268809b192a89e027e888c8e8948fca5903503" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Jul 16 22:26:22 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 16 22:29:42 2026" }, "message": "ipcz: Allow //base. Part 2: From IpczDriver constants to functions\n\nNo functional changes. Pure refactoring. This is Part 2 of the patch\nseries to allow using //base in //third_party/ipcz.\n\nThis is a preparation to convert C struct IpczDriver into an equivalent\nC++ class hierarchy. These classes will remain stateless, with 1:1\nmapping between function pointers in the struct IpczDriver instances and\nvirtual methods of the classes.\n\nHere, mechanically replace IpczDriver constants (like kMockDriver) with\ncorresponding function calls (like GetMockDriver()) returning `const\nIpczDriver\u0026` from each. The class instances remain singletons as previously.\n\nThis allows creating the objects more lazily via C++ static locals.\nPotentially it will later allow stateful classes. Also, generally\ngetters are preferred over static globals.\n\nAs the next step we will replace the implementations of these getters\nwithout touching the callers. The new code will refer to method calls\ninstead of function pointer calls, with exactly the same C++ syntax at\nthe callsite.\n\nRemove tests that check possible nullability situations in the function\npointer members. These are not going to be interesting tests with the\ntransition to vtable. Remove them earlier because they do not compile\nfor const reference to IpczDriver. Removing these tests:\n* APITest.CreateNodeMissingDriverField\n* APITest.IpczGetAPIInvalid\n* APITest.IpczGetAPI\n\nBug: 526596517\nChange-Id: I5720f95f65adcb4cff964630727012566d8147d5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8027449\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1663542}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7954a67d58b7ce36de8c77ba52605a97c2060c31\n" }, { "commit": "5e268809b192a89e027e888c8e8948fca5903503", "tree": "0dd090c52481abd0b6bad0c596794acf2edee583", "parents": [ "22f515a4ab0ad24640b5594b46873900a26bf632" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Jul 16 17:35:27 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jul 16 17:39:46 2026" }, "message": "ipcz: Allow //base. Part 1: Remove standalone build\n\nThis is Part 1 of a series of changes to allow using //base in\n//third_party/ipcz. See the bug for background and motivation.\n\nRemove //third_party/ipcz/src/standalone. This includes removing\npolyfills for logging.h, stack_trace.h, unsafe_buffers.h.\n\nRemove GN arg build_ipcz_standalone and macro IPCZ_STANDALONE.\n\nCleanup in GN:\n* Remove the template needed for target suffixes \"_standalone\"\n and \"_chromium\". The new targets will not have these suffixes.\n Replace GN targets like \"something_chromium\" to \"something\".\n* Remove ipcz target \"ipcz_tests\" - these tests run as part of\n \"//ipc:ipc_tests\". Preserving test coverage.\n\nRetain the C compilation test (compile_c_test.c) for now as the C\ninterface is still there.\n\nBug: 526596517\nChange-Id: I2ccb79dcf1a8117d0bdb1ce7f21495a641ba2a59\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8005116\nReviewed-by: Henrique Nakashima \u003chnakashima@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nReviewed-by: Michael Thiessen \u003cmthiesse@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1663283}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0d1c9fbf990090a3d85f367010f3f77bb56931f6\n" }, { "commit": "22f515a4ab0ad24640b5594b46873900a26bf632", "tree": "3c993226789724df0b728a3f98d9f11e33a315f2", "parents": [ "ec66f73421e9ce835d80c1fe705ec6562ab27951" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Wed Jun 03 12:39:00 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 03 12:41:47 2026" }, "message": "ipcz: Improve consistency in ipcz.h function parameter comments\n\nFunctions in IpczDriver and IpczAPI document which parameters are \u0027in\u0027\nand which ones are \u0027out\u0027. Fix a few tiny inconsistencies in those\ndeclarations and mark ignored parameters as \u0027ignored\u0027 for further\nclarity.\n\nBug: None\nChange-Id: Ie6acca62f3f8850d7a931f0b39ca0f2689029ae2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7894442\nAuto-Submit: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1640867}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2870c2804ed512c13af111efef0ba82b1589e207\n" }, { "commit": "ec66f73421e9ce835d80c1fe705ec6562ab27951", "tree": "059302513e65b66399b58eec3133dc6456d8d223", "parents": [ "d60c476d7b999e69621ec96b1aed1d8f6c69ec9f" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed May 06 20:14:27 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 06 20:17:25 2026" }, "message": "[ipcz] Clarify C++ standard in .clang-format\n\n\"Cpp11\" is not C++11, it\u0027s the same as \"Latest\".\nhttps://github.com/llvm/llvm-project/blob/d4c0c7b38f83fee7d992a2d07dde17cce5fdb9e4/clang/lib/Format/Format.cpp#L546-L547\n\nChange-Id: Ic7d17d6a57f2b7a1deda43c6dadca708aa883b25\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7816287\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1626407}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 71a612db0060eb235db027ff4c808349ae8eddce\n" }, { "commit": "d60c476d7b999e69621ec96b1aed1d8f6c69ec9f", "tree": "6a5074674a5d680f0946c493f539b9d4ebff49e6", "parents": [ "f25a0168ba5602681ccc13bf9daae8b1c86fa14f" ], "author": { "name": "gate kibr", "email": "gkvjwa@gmail.com", "time": "Sat Apr 04 22:22:54 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Apr 04 22:25:00 2026" }, "message": "Fix memory ordering in NodeName::LoadAcquire\n\nLoadAcquire used acquire on high_ while StoreRelease used release on\nlow_, Fix by loading low_ with acquire first\n\nChange-Id: I603cd32f146d9af1aa7eabe92ffe0e2ddd5b980e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7728349\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1610148}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1dfe4d5d69f439755485209027040c9c793859e9\n" }, { "commit": "f25a0168ba5602681ccc13bf9daae8b1c86fa14f", "tree": "ee7f154eab6c4a0f9c898d74e487257709f3e2aa", "parents": [ "4f8bc03f13d1e4138ed1624ab1e13d3f532e7d68" ], "author": { "name": "Andrea Orru", "email": "andreaorru@chromium.org", "time": "Tue Mar 24 01:32:14 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 24 01:34:21 2026" }, "message": "ipcz: Fix assertion failure on redundant router messages\n\nAn issue was discovered by the ipcz_fuzzer where a sequence of mutated\nor duplicate messages (such as receiving multiple StopProxying or\nProxyWillStop messages) can cause a proxying router to attempt to\nestablish sequence length on its decaying links more than once.\n\nBecause RouteEdge::set_length_to_decaying_link() and\nset_length_from_decaying_link() strictly assert that their respective\nlengths must be unset before being populated, double-setting these\nproperties due to redundant ipcz messages triggers an assertion failure.\n\nThis change adds checks to verify whether the proxy\u0027s decaying link\nlengths are already populated prior to setting them. If they are already\nset (indicating a duplicate request from a misbehaving peer) the\noperation is safely aborted by returning false. This allows ipcz to\ngracefully disconnect the offending connection without crashing.\n\nFixed: 486341715\nChange-Id: Id0907d609ec640fd271e1c633814065cdca073c7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7666961\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1603834}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7643f2b864f3ed9bbd5b6f5f8b73ea1b7623374\n" }, { "commit": "4f8bc03f13d1e4138ed1624ab1e13d3f532e7d68", "tree": "0e118e7cb1df42bf4c6d85e9c48275af5745def0", "parents": [ "9ecaff08b73d9adb4493a223b58c2e52479ed714" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Fri Mar 20 00:13:56 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 20 00:15:30 2026" }, "message": "Fix asserts in Message::GetArrayView() and add clarifying comments\n\nChecking if the array is in bounds needs to take offset into account as\nwell. These invariants are checked by callers, but the asserts should\nstill be accurate.\n\nChange-Id: Ifaef2e6635f9dbc049ee299f499e6bdea6d91bad\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7686105\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1602339}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c131f2c6d44a37b7bb365290a0e5a7a19102321c\n" }, { "commit": "9ecaff08b73d9adb4493a223b58c2e52479ed714", "tree": "cd1e1cc42d53be1d28ea41f6f8ab82c23287aaa1", "parents": [ "5a6f8f39b73f87ae81d810978009ffdfa5d4cd1c" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Thu Mar 19 23:51:33 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 19 23:53:57 2026" }, "message": "Reland \"Gracefully handle overlapping driver handle ranges\"\n\nThis is a reland of commit 94b006154082f83ff8f3ca493311d19d6e8e11bc\nThis fixes the test to allocate the data storage for handles as an array\nof uint8_t, since that\u0027s what the mock deserialization routine expects.\nThis was missed in the initial review since `DCHECK`-enabled builds do\nnot include `ABSL_ASSERT()`.\n\ngemini-cli provided the diagnosis and initial fix. However, upon further\ninvestigation, the author discovered that `Message::GetArrayView\u003cT\u003e`\ndoes not behave per the author\u0027s expectations: the returned span always\ncontains `ArrayHeader::num_elements`, not `ArrayHeader::num_bytes /\nsizeof(T)` elements.\n\nThis has several implications:\n\n1. Allocating an array with `AllocateArray\u003cuint16_t\u003e(1)`, and then\n reading it back with `GetArrayView\u003cuint8_t\u003e(...)` will produce a span\n of **one** element.\n\n2. Similarly, changing:\n uint32_t first_object_bytes \u003d in.AllocateArray\u003c16_t\u003e(1);\n in.GetArrayView\u003cuint16_t\u003e(first_object_bytes)[0] \u003d 0x90ab;\n\n to:\n uint32_t first_object_bytes \u003d in.AllocateArray\u003cuint8_t\u003e(2);\n in.GetArrayView\u003cuint16_t\u003e(first_object_bytes)[0] \u003d 0x90ab;\n\n as suggested by gemini-cli produces an invalid fix. The returned\n span from `GetArrayView\u003cuint16_t\u003e()` has **two** elements, even\n though it only has logical storage for a single uint16_t element.\n\n The various asserts in `GetArrayView()` do not catch these issues\n today, for various reasons. This will be separately addressed.\n\nThe proper way to do this is to allocate the array as a `uint8_t` and\nalso read it back as a `uint8_t`. Unfortunately, this means sprinkling\n`reinterpret_cast\u003cuint16_t\u003e` in various places but there\u0027s no real\nalternative in ipcz.\n\nOriginal change\u0027s description:\n\u003e Gracefully handle overlapping driver handle ranges\n\u003e\n\u003e Test originally authored by gemini-cli; substantially rewritten\n\u003e afterwards to interoperate better with MockDriver.\n\u003e\n\u003e Bug: 483956252\n\u003e Change-Id: I6e45c05114986853bdc78f2f48b7c37350f11086\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7677890\n\u003e Commit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Reviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1601577}\n\nBug: 483956252\nChange-Id: I3f307483a7a00008bfd5f7cafe973ded0bb1c662\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7685275\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1602329}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3d1b1ed55f6106412a19ed64d3524172b8358351\n" }, { "commit": "5a6f8f39b73f87ae81d810978009ffdfa5d4cd1c", "tree": "649c23b4371fa09f4c9ac5b6958bed42643ff869", "parents": [ "d7bfeeaebd2baad1e0cec0288dd061155d628847" ], "author": { "name": "Kay Lin", "email": "kaiyilin@google.com", "time": "Thu Mar 19 04:21:17 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Mar 19 04:23:13 2026" }, "message": "Revert \"Gracefully handle overlapping driver handle ranges\"\n\nThis reverts commit 94b006154082f83ff8f3ca493311d19d6e8e11bc.\n\nReason for revert: Test #OverlappingDriverHandles introduced in this CL failed on android-16-x64-dbg-tests. Check https://ci.chromium.org/ui/p/chromium/builders/ci/android-16-x64-dbg-tests/5465/overview for more detailed information.\n\nOriginal change\u0027s description:\n\u003e Gracefully handle overlapping driver handle ranges\n\u003e\n\u003e Test originally authored by gemini-cli; substantially rewritten\n\u003e afterwards to interoperate better with MockDriver.\n\u003e\n\u003e Bug: 483956252\n\u003e Change-Id: I6e45c05114986853bdc78f2f48b7c37350f11086\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7677890\n\u003e Commit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Reviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1601577}\n\nBug: 483956252\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nChange-Id: I3bc90c34be20d705b2e428702cde3ae6a60107e4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7683331\nCommit-Queue: Kay Lin \u003ckaiyilin@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nOwners-Override: Kay Lin \u003ckaiyilin@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1601747}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e09735eb306986659552e043836fa2d5d10eefbc\n" }, { "commit": "d7bfeeaebd2baad1e0cec0288dd061155d628847", "tree": "d34c8048be3a722305d3cabba0ebe5952df98134", "parents": [ "0c6974dd5bf13c7f373bae13108263e051539a91" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Wed Mar 18 22:20:21 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 18 22:23:04 2026" }, "message": "Gracefully handle overlapping driver handle ranges\n\nTest originally authored by gemini-cli; substantially rewritten\nafterwards to interoperate better with MockDriver.\n\nBug: 483956252\nChange-Id: I6e45c05114986853bdc78f2f48b7c37350f11086\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7677890\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1601577}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 94b006154082f83ff8f3ca493311d19d6e8e11bc\n" }, { "commit": "0c6974dd5bf13c7f373bae13108263e051539a91", "tree": "649c23b4371fa09f4c9ac5b6958bed42643ff869", "parents": [ "3475fbe1371cfc47e4786d058d95ac3c7ab1b74a" ], "author": { "name": "Klaus", "email": "Vampirelightsss@gmail.com", "time": "Wed Mar 18 10:05:39 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 18 10:09:03 2026" }, "message": "[ipcz] Compact SequencedQueue storage before reallocation\n\nSequencedQueue::Push() can grow `entries_` while retaining consumed\nprefix slots below `front_index_`. In long-lived queues this dead\nprefix can accumulate and increase reallocation overhead.\n\nTeach `GrowWithCompaction()` to reclaim front slack when growth would\nexceed capacity and `front_index_ \u003e 0`. It compacts active entries to\nindex 0 (in-place when capacity permits, otherwise into a new buffer),\nthen grows to the required size.\n\nWhen allocating a new buffer, preserve a doubling-style growth policy\nbased on effective capacity to avoid frequent reallocations.\n\nBug: 487357831\nChange-Id: I5528f6447c752878728e7ef7776425ec033e9988\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7606181\nAuto-Submit: Klaus Vampirelights \u003cvampirelightsss@gmail.com\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Joe Mason \u003cjoenotcharles@google.com\u003e\nCommit-Queue: Klaus Vampirelights \u003cvampirelightsss@gmail.com\u003e\nCr-Commit-Position: refs/heads/main@{#1601145}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7a86f4f57fa0f760cb9b56466384505f3f120e08\n" }, { "commit": "3475fbe1371cfc47e4786d058d95ac3c7ab1b74a", "tree": "9af4f74362cc3c7d2752fc50b4ecf2b8f4ef5f69", "parents": [ "49d9a0c913e6a4ce3e146eaa2e4fedccd45d3bbe" ], "author": { "name": "George Burgess IV", "email": "gbiv@google.com", "time": "Thu Feb 26 01:22:44 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Feb 26 01:30:29 2026" }, "message": "src: optimize ipcz_chromium for speed\n\nPer go/cr-os, this target should be optimized for speed, since it\u0027s\nconsuming a significant percentage of fleet cycles in Chrome (currently\n~1%).\n\nTwo notes:\n\n1. I made this CL non-specific-to-ChromeOS though, since I expect the\n rest of Chromium may prefer this setting.\n2. I am not sure where the _standalone_ target is used, so did not apply\n this there. More than happy to also apply this there if people want.\n\nBug: 482944671\nChange-Id: I01c4e9ad6a7827dcc476635bf738f2c2c76d2fa8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7576361\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1590548}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 12fe26e1b019c01289f7480c4ff5ec5a7aeb5e53\n" }, { "commit": "49d9a0c913e6a4ce3e146eaa2e4fedccd45d3bbe", "tree": "54323afee899f15a20429ec6c48ddbd2a1f296ff", "parents": [ "1c85ac90e110603daf65fa00c1efbab58acd1344" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Fri Feb 13 02:25:13 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 13 02:31:06 2026" }, "message": "[ipcz] Roll third_party/catapult/ 6fd8bbe72..8ce759d4b (71 commits)\n\nhttps://chromium.googlesource.com/catapult.git/+log/6fd8bbe72367..8ce759d4b71f\n\n$ git log 6fd8bbe72..8ce759d4b --date\u003dshort --no-merges --format\u003d\u0027%ad %ae %s\u0027\n2026-02-13 eduardoyap Update sheriff_config tests to match service changes\n2026-02-12 eduardoyap log path for 404 match failures\n2026-02-12 victorvianna Pull webpagereplay via DEPS instead of maintaining a copy\n2026-02-12 wenbinzhang [chromeperf] add gemini client for Pinpoint\n2026-02-11 johnchen Add ARM Windows version of clear_system_cache.exe\n2026-02-12 eduardoyap change sheriff-config:version\n2026-02-12 eduardoyap fix sheriff-config deployment in Cloud Build\n2026-02-11 wenbinzhang [chromeperf] update pinpoint traffic\n2026-02-10 wenbinzhang [chromeperf] add flag to control whether to use token to access results2\n2026-02-05 omerkatz Remove MinorMS benchmark variants\n2026-02-05 wenbinzhang [chromeperf] add cabe result in gerrit comment\n2026-02-05 wenbinzhang [chromeperf] adding cabe client for Pinpoint to get CABE results\n2026-02-05 wenbinzhang [chromeperf] UI update for Pinpoint summary\n2026-02-05 eduardoyap Add master names \"fuchsia.try\" and \"turquoise-internal.integration.global.try\" to skia pipeline.\n2026-02-03 wenbinzhang [chromeperf] use token to authorize access to buckets\n2026-02-03 wenbinzhang [chromeperf] fix const being re-declared issue\n2026-02-03 wenbinzhang [chromeperf] suppress excessive popup for authorization\n2026-01-30 wenbinzhang [chromeperf] use Pinpoint service account to access cloudstorage\n2026-01-29 wenbinzhang [sheriffconfig] comprehensive fix for cloud build\n2026-01-29 bjoyce Set disable_persitent_shell arg in AvdArgs\n2026-01-29 maximsheshukov Make sure extra_args is a list\n2026-01-28 wenbinzhang [sheriffconfig] update docker-compose for cloud build\n2026-01-28 wenbinzhang [sheriffconfig] add logs for debugging 404 in prod\n2026-01-27 hao.x.li Deduplicate consolidated browser flag values\n2026-01-26 bjoyce Add support for disabling persistent shell\n2026-01-23 maximsheshukov Fix --enable-feature wrapping with --extra-browser-flags\n2026-01-20 elkurin WaaP: Ignore WebUI toolbar in DevToolsClientBackendTest\n2026-01-21 bershanskyi [Extensions] Migrate tests to MV3\n2026-01-16 bjoyce Turn persistent_shell on by default\n2026-01-16 johnchen [chromeperf] update pinpoint traffic\n2026-01-16 johnchen [Pinpoint] Fix naming of loadline2 benchmark\n2026-01-13 elkurin WaaP: Ignore unclosesable tabs from the tab list\n2026-01-09 behamilton Use full host for chrome://webui-toolbar.top-chrome\n2025-05-20 mordeckimarcin [dashboard] Switch buganizer comments to use markdown formatting\n2026-01-12 lwinston Adjust inspector_runtime_unittest to ignore undefined contexts.\n2026-01-12 wenbinzhang [chromeperf] Pinpoint fails when Gerrit change is not found\n2026-01-12 kylixrd [telemetry] Expose certain APIs necessary to access non-Tab based web contents.\n2026-01-06 wenbinzhang [chromeperf] update pinpoint traffic\n2026-01-04 elkurin WaaP: Ignore chrome://reload-button in TabTestCase setup\n2025-12-23 kylechar Disable HangWatcher in Chrome GPU process\n2025-12-23 wenbinzhang [chromeperf] Pinpoint cancel all swarming builds if a try job fails\n2025-12-18 bjoyce Allow environment variable to set a module scheme for resultdb upload\n2025-12-17 martinkong Add a function GetIsDebuggable() to BaseApkHelper class\n2025-12-11 cher-di Use private var self._extra_browser_args in ConsolidateValuesForArg\n2025-12-11 eduardoyap change pinpoint version\n2025-12-11 bsheedy Surface websocket connection loss as a crash\n2025-12-11 eduardoyap Add loadline_phone2.crossbench to Pinpoint UI and quest\n2025-12-10 maximsheshukov Improve the notes message for the old pinpoint command line tool\n2025-12-04 eduardoyap Re-enable dataflow pipeline for widevine instances\n2025-12-05 agrieve DeviceUtils: Make cache\u003dTrue default for GetCurrentUser()\n2025-12-03 victorvianna Fix panic in RecordHost{Certificate,NegotiatedProtocol}\n2025-12-02 wnwen dashboard: Switch Android Go bots to Trichrome\n2025-12-02 jonathanjlee [devil] Fix `UnboundLocalError` in `Forwarder.Map()`\n2025-12-01 jonathanjlee Revert \"[typ] Report v2 status and failure reason\"\n2025-11-20 jonathanjlee [typ] Report v2 status and failure reason\n2025-11-27 wnwen telemetry: Remove Monochrome support\n2025-11-25 linyuh BaseApkHelper: add GetActivityNamesWithCategory()\n2025-11-24 seblalancette Display Proxy Override Rules in Netlog Viewer\n2025-11-25 wnwen telemetry: Switch Monochrome to Chrome \u0026 Webview\n2025-11-24 victorvianna Change fetch_telemetry_binary_dependencies interpreter from py to vpy\n2025-11-24 victorvianna Delete unused legacyformatconvertor.go\n2025-11-21 wenbinzhang [chromeperf] update pinpoint traffic for using hash before merge\n2025-11-21 wenbinzhang [chromeperf] Update GerritChange section in buildbucket request\n2025-11-21 wenbinzhang [chromeperf] add new tags for mac models\n2025-11-20 jonathanjlee [telemetry] Port `--do-not-store-tombstones`\n2025-11-20 wenbinzhang [chromeperf] move Pinpoint traffic to cherry-pick landed CL\n2025-11-19 wenbinzhang [chromeperf] Pinpoint use the patchset before rebase if the CL has landed\n2025-11-20 wenbinzhang [chromeperf] use decode() to convert bytes to str\n2025-11-20 wenbinzhang Revert \"[web-tests] modify result sink to include skip reason\"\n2025-11-19 wenbinzhang [perf] get chip name for mac devices as expectation tag\n2025-11-19 jiameil [web-tests] modify result sink to include skip reason\n\nCreated with:\n roll-dep third_party/catapult\n\nChange-Id: I5e123c39553c3ed627f2731bbab4b8a9e111f361\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7572309\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1584387}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 09890a060cd6fce6bf192760effb9ed28473b1ba\n" }, { "commit": "1c85ac90e110603daf65fa00c1efbab58acd1344", "tree": "67600c5bde2666c24a15ad2d28360c5970882339", "parents": [ "d6ae5c4a2e41aa21130654e153992230a79c6687" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Tue Feb 03 21:03:13 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Feb 03 21:10:47 2026" }, "message": "Add tests of boxed IPCZ ApplicationObject destructor funcs\n\nR\u003dajgo\n\nBug: 467695562\nChange-Id: Iba3af92f224ec327a5a131467335f084e6bd38af\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526871\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Joe Mason \u003cjoenotcharles@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1579009}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4f1dc20db72e1fce2281e13f44014a1dbea912d4\n" }, { "commit": "d6ae5c4a2e41aa21130654e153992230a79c6687", "tree": "1977e830caf5808b260498be1f36a192657e3e88", "parents": [ "2ad872753ded52aba56c95b5bac86044836e8fa7" ], "author": { "name": "Joe Mason", "email": "joenotcharles@google.com", "time": "Wed Jan 28 01:43:47 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 28 02:06:57 2026" }, "message": "IPCZ API correctness tests, fix missing ReportBadTransportActivity check\n\nAdds more invalid parameter tests to IPCZ functions that take a sized\nstruct:\n\n* CreateNode\n* Box\n* Unbox\n* IpczGetAPI\n\nAlso adds a missing check for `driver-\u003eReportBadTransportActivity` in\nCreateNode that the new test uncovered.\n\nBug: 467695562\nChange-Id: Ib794e6835dfd8db99c3c55352aba9c6e18e24f7b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7523471\nCommit-Queue: Joe Mason \u003cjoenotcharles@google.com\u003e\nAuto-Submit: Joe Mason \u003cjoenotcharles@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1575634}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 610a34cb0ad86210bbc7bc6f6d5713f93f314996\n" }, { "commit": "2ad872753ded52aba56c95b5bac86044836e8fa7", "tree": "b431a5dfbab72c683a2809b2523331e3f0434d6a", "parents": [ "142e3dbda72522cc792d59a164bf36348f33c265" ], "author": { "name": "Weidong Liu", "email": "weidongliu@chromium.org", "time": "Mon Jan 26 10:51:23 2026" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jan 26 10:57:28 2026" }, "message": "spanification: Remove DriverMemoryMapping::address* API.\n\nBug: 393091624\nChange-Id: I7fbfea1f40d546e960f7852df149c120795dacff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7496851\nCommit-Queue: Weidong Liu \u003cweidongliu@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1574419}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4a214d2bdd2cdabf9f9e26711cd66311c3aa7581\n" }, { "commit": "142e3dbda72522cc792d59a164bf36348f33c265", "tree": "6b743f2ff7eb093f68c59508328aed5e6e091f40", "parents": [ "d108762f145ae40f35f54440585bd9a526381458" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Thu Dec 04 20:57:47 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 04 21:03:45 2025" }, "message": "[ipcz] Roll build/ 0347b4909..3c58005ad (60 commits)\n\nhttps://chromium.googlesource.com/chromium/src/build.git/+log/0347b49096ca..3c58005adf6e\n\n$ git log 0347b4909..3c58005ad --date\u003dshort --no-merges --format\u003d\u0027%ad %ae %s\u0027\n2025-12-04 drott Update FreeType comment in freetype.gni\n2025-12-04 victorvianna [build] Set use_cxx23 to true by default (new features not allowed yet!)\n2025-12-04 victorvianna Revert \"[build] Allow other repos to control use_cxx23 with build_overrides\"\n2025-12-04 anandrv [base/android] Attribute source code location for AsyncTask\n2025-12-04 ziegltrum Revert \"Enable BTI for Linux on Arm targets\"\n2025-12-04 tarcisio.fischer Enable BTI for Linux on Arm targets\n2025-12-03 zijiehe [Fuchsia] Disable size optimization for perf-optimized builder\n2025-12-03 chromium-internal-autoroll Roll Fuchsia Internal Images from 30.20251125.103.1 to 30.20251203.101.1\n2025-12-03 agrieve Android: Mention siso_failed_commands.sh in the deps suggester failure hint\n2025-12-03 ashleynewson Revert \"Reland \"Make test APK the default browser app if it has APP_BROWSER category\"\"\n2025-12-03 kubo ios_app_bundle: Allow intents_target to work with testonly\u003dtrue\n2025-12-02 msta Prefix disable-diagnostic-validation with -Xclang.\n2025-12-02 linyuh Reland \"Make test APK the default browser app if it has APP_BROWSER category\"\n2025-12-02 bsheedy Reland \"Run GPU TSAN tests on SwiftShader\"\n2025-12-02 ayumiohno PA: Restrict use_sized_deallocation’s assertion to Clang\n2025-12-02 bungeman Remove FreeType dependency from Fuchsia builds\n2025-12-02 bjoyce Add module scheme support for components_perftests\n2025-12-01 tasak Reland \"[1/4] Implement AsanRawPtrService V2\"\n2025-12-01 nya Revert \"[1/4] Implement AsanRawPtrService V2\"\n2025-12-01 clhager Revert \"Make test APK the default browser app if it has APP_BROWSER category\"\n2025-12-01 tasak [1/4] Implement AsanRawPtrService V2\n2025-12-01 linyuh Make test APK the default browser app if it has APP_BROWSER category\n2025-12-01 jwata bench: List up .json.N trace files in build/bench/ftime.py\n2025-11-30 ayumiohno PA: Enable use_sized_deallocation if not optimize_for_size\n2025-11-27 lehoangquyen Revert \"[Android] Configure GBoard in Android 15 to disable stylus\"\n2025-11-27 hnakashima [Android] Configure GBoard in Android 15 to disable stylus\n2025-11-26 ukai use msan instrumented libs if host_toolchain_is_msan\n2025-11-26 ukai Revert \"mitigate codesearch-gen-chromium-fuchsia\"\n2025-11-26 wnwen android: Update docs to use ChromePublic/Trichrome\n2025-11-26 zijiehe [fuchsia] Move permission control to web_engine_config\n2025-11-26 tikuta build: Do not include buildtools directory in clang modules build\n2025-11-25 chromium-internal-autoroll Roll Fuchsia Internal Images from 30.20251118.102.1 to 30.20251125.103.1\n2025-11-25 msta Write a script to analyze the amount of time spent #including each file.\n2025-11-25 ajgo Delayload iphlpapi \u0026 dhcpcsvc\n2025-11-25 justincohen ios: Enforce EarlyMallocZoneRegistration load order in Chrome\n2025-11-21 gulfem [build] Balanced partitioning for section ordering\n2025-11-21 agrieve Revert \"build: Speed up JUnit test listing\"\n2025-11-21 victorvianna [build] Remove use_cxx17 support\n2025-11-21 victorvianna [build] Allow other repos to control use_cxx23 with build_overrides\n2025-11-21 pkaplan wrap the privileged helper executable identifier string in quotes\n2025-11-21 jmarc Enable checking system_headers for windows compile.\n2025-11-21 zequanwu Reland \"Roll clang+rust llvmorg-22-init-12326-g8a5f1533-2 : llvmorg-22-init-14273-gea10026b-1 / ab925646fae038b02bd462cd328ae9eef1639236-1 : 11339a0ef5ed586bb7ea4f85a9b7287880caac3a-1\"\n2025-11-21 luci-bisection Revert \"Roll clang+rust llvmorg-22-init-12326-g8a5f1533-2 : llvmorg-22-init-14273-gea10026b-1 / ab925646fae038b02bd462cd328ae9eef1639236-1 : 11339a0ef5ed586bb7ea4f85a9b7287880caac3a-1\"\n2025-11-20 ukai mitigate codesearch-gen-chromium-fuchsia\n2025-11-20 msta Write a script to generate a database of performance metrics.\n2025-11-20 wnwen build: Speed up JUnit test listing\n2025-11-20 ollel Disable sanitizer in gn instead of passing around an ignorelist\n2025-11-20 thestig Include \u003cfeatures.h\u003e directly in build_config.h on Linux\n2025-11-20 agrieve Android: Suppress androidx roll tracereferences failure\n2025-11-20 wnwen android: Use merged manifest for lint targets\n2025-11-19 msta Fix some minor issues with the run_action benchmark.\n2025-11-19 victorvianna Add autoconf to install-build-deps.py\n2025-11-19 drubery Fix line-ending in build/config/fuchsia/gn_configs.gni\n2025-11-19 beainsa [TDR] Remove TODOs linked to issue 40616187.\n2025-11-19 wnwen build: Move Android lint target from bundle to apk\n2025-11-19 zbikowski Remove old-style Android ARM64 PGO profile roller artifacts\n2025-11-18 jwata build: forward configs to compiled_action_foreach\n2025-11-18 jmarc Fix the hardcoded -MMD compile command on Mac.\n2025-11-18 msta Add a tool to benchmark the speed of building a specific file locally.\n2025-11-18 zijiehe [fuchsia] Update default Fuchsia target API level to 29\n\nCreated with:\n roll-dep build\n\nChange-Id: I9ed42ec0e497be3eae1803fdd725e2107c289d17\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7227681\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1554239}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: cf1b673e69889fd57965a84d11569d8a49f0142b\n" }, { "commit": "d108762f145ae40f35f54440585bd9a526381458", "tree": "f87b8495769cd0d6cf69acb57d6c1ae019ff04f7", "parents": [ "15e49a3ec5e5c31fd6425316b4b21aa1a3ed1b98" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed Nov 19 18:24:49 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 19 18:48:15 2025" }, "message": "ipcz: Add missing BUILD.gn files\n\nFollow-up to crrev.com/c/7170538. I forgot to `git add` these :/.\n\nBug: 388070065\nChange-Id: Ibbb0b41ad81e937c2d5acc09d9c0dd50d5684378\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7170450\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1547325}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f6c8dfcbdd0509b6fcd0c33d6cb9468a1944d392\n" }, { "commit": "15e49a3ec5e5c31fd6425316b4b21aa1a3ed1b98", "tree": "79a6e9281a448327f330f6e1e950530045130f19", "parents": [ "e48d4eb5bf7e7158ec34a63c151e5326e4b90021" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed Nov 19 17:08:34 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 19 17:33:44 2025" }, "message": "Roll build deps in standalone ipcz\n\ncrrev.com/c/7171198 adds `fetch ipcz` to depot_tools, which is helpful\nto test this CL. Blamelists below. Note that building ipcz_shared\nwith standalone ipcz was broken before this change, for more than\none reason. Among them, api.cc was compiled without defining\nIPCZ_STANDALONE, causing the compiler to complain that\n//base/compiler_specific.h doesn\u0027t exist [1][2].\n\nhttps://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cc230bcfdbc1814256376e30b84be7b2f0d1335f..c54e50d9f14471146af9f1f357b3c525c2ff5bb7\n\nhttps://chromium.googlesource.com/chromium/src/build/+log/10bd27f7de8a48c05205b92ccdaf782ae6f2fe17..0347b49096ca873f595c8e285c9bb3e256131f42\n\nhttps://chromium.googlesource.com/chromium/src/buildtools/+log/571c37f17dd4d1de37cc2efb6b32ff1032e47be2..5df641722f2e50623646d702e0046fb68c0f5ce1\n\nhttps://chromium.googlesource.com/catapult/+log/e939ac77bb9471acc10f49e82cfe65790068c3d1..6fd8bbe723677254ff1130a1a416988b8b3e285e\n\nhttps://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c5396f931a1319b98da4915f090d00c4d9900601..91e8a4cf5607164178e0455bbea40845c9b0d93c\n\nhttps://chromium.googlesource.com/chromium/src/third_party/re2/+log/716d20b6550107ddeba09ed39f2f8185cd6a4aab..581c1f779dffb7d5ffd4296b79736c9ce961caae\n\nhttps://chromium.googlesource.com/chromium/src/testing/+log/870c20f1d8079296b7cf86b85b0e9a0b9b252342..6bf7e8e674b4552e12d140378e4394e7970e3fbc\n\nhttps://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format/+log/3c0acd2d4e73dd911309d9e970ba09d58bf23a62..c2725e0622e1a86d55f14514f2177a39efea4a0e\n\nhttps://chromium.googlesource.com/chromium/src/tools/clang/+log/bca0c9f60a365ef2294c42e216420c561093f06f..f0aeeca2d4eea4ade7308a31bc4023fc52614332\n\nhttps://chromium.googlesource.com/chromium/tools/depot_tools/+log/6ba67afd6fb7718743af91b847ddf1907f3ee9a6..8e49ae5de847360974fb5352cd23ca2794d57222\n\nhttps://chromium.googlesource.com/external/github.com/google/googletest/+log/5a37b517ad4ab6738556f0284c256cae1466c5b4..4fe3307fb2d9f86d19777c7eb0e4809e9694dde7\n\nhttps://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/e3b94d0e5b86883fd77696bf10dc33ba250ba99b..454a561737fb62e75ba82bfae9fb07ee64acdd68\n\nhttps://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/51fe3584464d29067c8f0663f6e6dec84cc86868..de02e5d57052b3b6d5fcd76dccde9380bca39360\n\nhttps://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/51fe3584464d29067c8f0663f6e6dec84cc86868..de02e5d57052b3b6d5fcd76dccde9380bca39360\n\nhttps://chromium.googlesource.com/external/github.com/google/re2/+log/b84e3ff189980a33d4a0c6fa1201aa0b3b8bab4a..e7aec5985072c1dbe735add802653ef4b36c231a\n\n[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/ipcz/src/api.cc;l\u003d22;drc\u003d85367953f49a13062c803e1a9ecd3278f0cc34ce\n[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/ipcz/src/util/unsafe_buffers.h;l\u003d10-13;drc\u003d78bd63326c0a2489e6b016140aa4d84014af077a\n\nBug: 388070065\nChange-Id: I716daa68431bd21554de56a3274d01cb0bc1f5c1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7170538\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1547252}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 049d21240efdafbf02fdfce44f02d95187f589b6\n" }, { "commit": "e48d4eb5bf7e7158ec34a63c151e5326e4b90021", "tree": "0669d849a0fda49da99c1d0c31db887e15f5cc9f", "parents": [ "ac65d3c3b3b9dbc4f1098abb085535eb34fcfece" ], "author": { "name": "Andrea Orru", "email": "andreaorru@chromium.org", "time": "Wed Oct 29 22:25:11 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 29 22:30:52 2025" }, "message": "ipcz: Update license from BSD to BSD-3-Clause\n\nFixed: 451724154\nChange-Id: I8a44db47ac0c03a0690342332e30326cd21dd2aa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097267\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1537582}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 742d3f54cb1eda6d56f174b254623c6b54a36d3e\n" }, { "commit": "ac65d3c3b3b9dbc4f1098abb085535eb34fcfece", "tree": "439aa2ff913c63e6565bb5b971d3e4ef435bfe03", "parents": [ "010dbcc393342a887938a705720773dfaea45192" ], "author": { "name": "Andrea Orru", "email": "andreaorru@chromium.org", "time": "Tue Oct 07 19:52:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 07 19:57:20 2025" }, "message": "ipcz: Fix a lock order inversion in Router::Deserialize\n\nabsl::Mutex\u0027s deadlock detector identified a lock order inversion\nbetween `Router::mutex_` and `BufferPool::mutex_`. In debug builds,\nabsl::Mutex remembers the order in which every pair of locks has been\nacquired. If it sees an order that violates a previously established\none, it flags a potential deadlock.\n\nThe BufferPool \u003d\u003e Router order is established when handling arriving\nbuffers: `BufferPool::AddBlockBuffer` acquires the BufferPool lock,\nretrieves pending callbacks, releases the lock, and executes the\ncallbacks. These callbacks may resume parcel processing (e.g.,\n`Router::AcceptInboundParcel`), which subsequently acquires the\ndestination Router lock.\n\nThe violation (Router \u003d\u003e BufferPool) can occur in `Router::Deserialize`.\nThis function acquires the new Router\u0027s `mutex_` and, while holding it,\ncalls `NodeLinkMemory::AdoptFragmentRefIfValid` to resolve the link\nstate fragment. This internal call acquires the BufferPool lock via\n`BufferPool::GetFragment`.\n\nThis change resolves the inversion by refactoring `Router::Deserialize`\nto resolve and validate the RouterLinkState fragment before acquiring\nthe `Router::mutex_`.\n\nBug: b:443193042, 420710333\nChange-Id: Ic012c936b039664123a45ed80114e4cb88080c59\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7008801\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1526480}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 4e77116847624e45614e74253bde16cb5ece6084\n" }, { "commit": "010dbcc393342a887938a705720773dfaea45192", "tree": "1261d8c1ca59d27515fb487b7f9c1095607587cf", "parents": [ "56625d9cf0d83e04960e917d4d5ecab5d66d5f53" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Wed Oct 01 10:49:52 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 01 10:55:16 2025" }, "message": "ipcz: Rename node sequence number\n\nRename sequence_number to node_sequence_number message header to make it\nobvious that this field is currently unused. At the moment the name\nclashes with another sequence_number baked into ipcz::Parcel, which is\nenumerated separately.\n\nBug: 410594534, 388531132\nChange-Id: Iccb4fa732093c3229f992b94bd7c38411f4e83b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7000094\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1523451}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ce6bf3155f2ca40d6441f14cd24801efed68c8cf\n" }, { "commit": "56625d9cf0d83e04960e917d4d5ecab5d66d5f53", "tree": "a409fac759dff413cf6f624253a7082b2a6d066c", "parents": [ "1b97ef34dacf27681d33ca0e7fdc5121b43cb50d" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Tue Sep 30 18:33:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 30 18:41:13 2025" }, "message": "ipcz: doc: Fix a few typos in comments\n\nI asked Gemini-CLI to fix all typos in code comments in\nthird_party/ipcz/src/ipcz. This change is what remains after a few OOMs,\n500s, hitting quota, and passing my human filter. No kittens were hurt.\n\nBug: None\nChange-Id: I1af7f64a9bf68c4d5d9f10d14b4473444ae77a56\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7000119\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nAuto-Submit: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1523036}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: b673003c0f26a2302115086b4b298003b7cc80aa\n" }, { "commit": "1b97ef34dacf27681d33ca0e7fdc5121b43cb50d", "tree": "d8060d7b6e6166427f19f5ba4e1bcfc042f51e56", "parents": [ "309d9b928b3b9a6475d656c9f3a9fe1cd423c978" ], "author": { "name": "Isaac J. Manjarres", "email": "isaacmanjarres@google.com", "time": "Mon Sep 29 12:59:14 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 29 13:05:41 2025" }, "message": "Move ashmem code from third_party/ashmem to base/android/linker\n\nMake necessary adjustments to existing references as well. No\nfunctional impact.\n\nBug: 433478402\nBypass-Check-License: Moving files\nNo-Try: true\nChange-Id: Ia6477c0b5d6100e943de49b685376aa22778d681\nSigned-off-by: Isaac J. Manjarres \u003cisaacmanjarres@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6977886\nReviewed-by: Stefano Duo \u003cstefanoduo@google.com\u003e\nReviewed-by: Francois Pierre Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1522146}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3da5f52534bdc5c3571064f32e1c52c2bea1fcc8\n" }, { "commit": "309d9b928b3b9a6475d656c9f3a9fe1cd423c978", "tree": "960f4f81a5da23a05d0300a7ad07d91ac54ce271", "parents": [ "5ca869b8910e2919c04d62e28d633f12c9e0c94c" ], "author": { "name": "Jordan", "email": "rop@google.com", "time": "Wed Sep 17 00:42:12 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 17 00:47:30 2025" }, "message": "Add \u0027Update Mechanism: Manual\u0027 to README.chromium files\n\nBug: 445311061\nChange-Id: I2b756ad5795b793be54855c8e1883a2a2d8bbefd\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6953660\nReviewed-by: Jiewei Qian \u003cqjw@chromium.org\u003e\nAuto-Submit: Jordan Brown \u003crop@google.com\u003e\nReviewed-by: Rachael Newitt \u003crenewitt@google.com\u003e\nCommit-Queue: Jordan Brown \u003crop@google.com\u003e\nOwners-Override: Jordan Brown \u003crop@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1516347}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 305b2fe1fa7a2c66e0ffee71ff6cdab160c570a8\n" }, { "commit": "5ca869b8910e2919c04d62e28d633f12c9e0c94c", "tree": "48320bcb03ef333f2f7678e16100387b756bbe5b", "parents": [ "41d8ccbdd94e24dbe6015a75d30972e64b3ca6f0" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed Sep 03 18:12:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Sep 03 18:19:10 2025" }, "message": "[ipcz] Bump vpython from 3.8 to 3.11\n\nBug: 40249958\nChange-Id: I8c77ad0f8aa339ffe1567c686492b01436dde9fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909713\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1510412}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 893fd25a629d2d88cd865ed75ce054b7fec848c1\n" }, { "commit": "41d8ccbdd94e24dbe6015a75d30972e64b3ca6f0", "tree": "65785a4bf4f73e8b66f1fecf52c556cfb182d60c", "parents": [ "d49962a51b2e6ef70d9c72201b24ae339fb258df" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Tue Sep 02 12:18:37 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Sep 02 12:25:47 2025" }, "message": "ipcz: Add log messages in router and node_link\n\nRouter is a central abstraction in ipcz. It is important to know about\nall these objects when investigating ipcz bugs. Lifetime of Router is\nalso closely related to lifetime of Sublink.\n\nAdd a few log messages to make it easier to track lifetimes of Router\nand RemoteRouterLink.\n\nBug: None\nChange-Id: If2a9a7eca7dec553480905156c083f25008b26f4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6905431\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1509482}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 41d18ff643fd0b54a6e87c6f3864ea49a6088ae8\n" }, { "commit": "d49962a51b2e6ef70d9c72201b24ae339fb258df", "tree": "31c7ff8eae3206f0748030503f6075ad9be2c0d3", "parents": [ "5ecda9c90011eed56156091f1887b31615112eeb" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Fri Aug 22 17:57:48 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Aug 22 18:06:12 2025" }, "message": "ipcz: Do not store early parcels when late\n\nIn the crrev.com/1473094 we introduced the concept of \u0027early parcels\u0027.\nIt accumulates parcels on the Node that have nowhere to go. In other\nwords, they are not associated with any Router. Doing so helps in some\nrare and involved scenarios where a DataPipe sends some metadata, but\nthe Route for it is not ready yet.\n\nQueuing such parcels (without a route) brings unexpected consequences.\nSome parcels may reference a mojo handle, so dropping them is important\nto run the corresponding disconnect handler on the other side. Such\nparcels may appear without a route because the corresponding Router was\nexplicitly deactivated/closed.\n\nFor example, parcel with pipe B is sent over pipe A, but the pipe A gets\nconcurrently closed on the receiving side (pending receiver is destroyed\nand not bound). There is a racy window where pipe A is alive on the\nsender side, but already dead on the receiver side. So the parcel\n(carrying the pipe B) arrives and needs to be immediately destroyed.\nOtherwise the disconnect handler for pipe B would not run.\n\nThe new workaround is to track all closed sublinks (via\ndeleted_sublinks_). Whenever a parcel arrives at a sublink without a\nrouter, now it can distinguish the two cases (Router did not arrive yet\nand Router was already closed).\n\nDeleting sublinks is pretty common. To limit memory use, periodically\nclear old sublink ids.\n\nDetermining when to clear a certain \u0027deleted sublink\u0027 is not trivial.\nIdeally it should be removed when the Router on the other side of the\nNode cannot send parcels any more (Router is closed on the peer) _and_\nall parcels in the socket queues are processed since that Router on the\nother side had been closed.\n\nAs a \u0027quick fix\u0027 clear deleted_sublinks_ that are older than 5 minutes.\nHere we assume that in 5 minutes the current Node would be capable of\nclosing the peer and processing all incoming messages from the queues.\nThis assumption can be violated if one of the processes is frozen or is\nstarved of CPU resources for a long time (both of which can happen on\nAndroid).\n\nA more reliable heuristic could clear deleted_sublinks_ based on \u0027thread\ntime\u0027 in the current Node (duration of occupying a CPU core by the\ncurrent thread). However, thread time is more expensive and\ndifficult to read portably, and it still does not cover the state of the\npeer Node, which could very well have all the same freezing and CPU\nproblems. So, it is probably not worth going with thread time.\n\nFor the Actually Reliable clearing signal from The Future we will\nintroduce a new Node feature+message that would allow to synchronize the\ndeleted state across two nodes. Another idea is to introduce reference\ncounting for sublink ids in shared memory (parcels in flight would\nAcquire).\n\nSkip-Clang-Tidy-Checks: modernize-use-equals-default\nBug: 410594534, 424438875, 425759818\nChange-Id: I1ab00e9eddcfea8cd0db530746760145db0f049e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6813649\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1505186}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f2d40c44cc1382cd1a33f9f942ddad5ea300e107\n" }, { "commit": "5ecda9c90011eed56156091f1887b31615112eeb", "tree": "e184c2622cde12661dc5007fe07a338ff88c9292", "parents": [ "cfe62498a4acdb2f33ee7273ab546b8ac6821cee" ], "author": { "name": "Claudio DeSouza", "email": "cdesouza@chromium.org", "time": "Thu Aug 07 19:32:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 07 19:39:25 2025" }, "message": "[exit-time-destructors] Exclude target with warnings\n\nThis CL is part of number of CLs disabling `-Wexit-time-destructors`in\nplaces where this warning is going off. This will allow having this\nwarning enabled-by-default across the codebase, whilst documenting the\nplaces where corrections for this warning are necessary.\n\nBug: 40031409, 430332953\nChange-Id: I21326a8441055de80e0dc71171750ce76626e2e8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6823064\nReviewed-by: David Benjamin \u003cdavidben@chromium.org\u003e\nCommit-Queue: Claudio DeSouza \u003ccdesouza@chromium.org\u003e\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1498407}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 16107a74b3c300bf459976dafac4d3b54c47b54f\n" }, { "commit": "cfe62498a4acdb2f33ee7273ab546b8ac6821cee", "tree": "e96c44afb704dad7ec105081a0fa3029878f2eaf", "parents": [ "316fd7c1607a44685002e1a8eecd660d8ef03064" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Aug 05 22:20:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 05 22:27:41 2025" }, "message": "Rework file-wide unsafe buffers in ipcz/\n\nAutomated CL via tools/clang/unsafe_pragma_rewriter, followed by sed\nto rename into IPCZ-specifics.\n\nChange-Id: I169fc05377cd1cd58cc486fc8a06a7ba412b7ce5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821995\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1497224}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 85367953f49a13062c803e1a9ecd3278f0cc34ce\n" }, { "commit": "316fd7c1607a44685002e1a8eecd660d8ef03064", "tree": "7b4e0de259eb545e6467ce18be55bf1394130adb", "parents": [ "917e9d3c13d218a28724e55684c3e6cd281ee3aa" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Tue Aug 05 21:00:00 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 05 21:07:22 2025" }, "message": "Add UNSAFE_BUFFER macro equivalents for third_party/ipcz\n\nDo this as a small CL prior to using it. Maintain the chromium /\nstandalone split by using chromium\u0027s defines when present.\n\nChange-Id: Idf49fc62fd70cd7a855d0cd56e536e4af7f9dc45\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6819873\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1497165}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3206ba83cfe780a659932803a020de0583d45328\n" }, { "commit": "917e9d3c13d218a28724e55684c3e6cd281ee3aa", "tree": "2af9950044fc393d665dc674c80b1692ff63d00d", "parents": [ "bffe5e52fabc3470fa9fb6bcb17c0a9eab0fc271" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Mon Jul 14 19:57:46 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jul 14 20:05:10 2025" }, "message": "Remove remaining BUILDFLAG(IS_NACL)s\n\nBug: 40511454\nChange-Id: I4d40dc582088ea9aebf67ab9ed0756c582071f31\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6731481\nReviewed-by: Petr Cermak \u003cpetrcermak@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Dale Curtis \u003cdalecurtis@chromium.org\u003e\nOwners-Override: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1486512}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ccdde84d12de656e23b2fdda505db600f0101966\n" }, { "commit": "bffe5e52fabc3470fa9fb6bcb17c0a9eab0fc271", "tree": "33b675de273b0c761ccc0b22c7ee40fa0154848c", "parents": [ "be871fdaab832a959619be2a0f3ab1be10b292a9" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Fri Jun 13 12:38:28 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 13 12:44:54 2025" }, "message": "doc: ipcz: Tiny spelling/wording fixes in router/router_link\n\nI changed these locally long ago when reading for the first time. Got\nreminded about them when merging my branch with updated \u0027main\u0027.\n\nBug: None\nChange-Id: I9d5c3b0f4be1ddb0dc4e6597cd87a787562a5dca\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633608\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1473498}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7d0eed84551285fb462d47c3d9552e586205f5f0\n" }, { "commit": "be871fdaab832a959619be2a0f3ab1be10b292a9", "tree": "5d090db8aac85c280213655ad15d571bacde1148", "parents": [ "f7dbfe15b605289c5c61c3233dfc20bb29c1063a" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Jun 12 16:15:08 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 12 16:21:29 2025" }, "message": "ipcz: Store early parcels until their sublink is available\n\nRarely an ipcz parcel can arrive to the NodeLink before the\ncorresponding Router is deserialized. Currently in such scenario the\nNodeLink does not know what to do with this parcel and drops it.\n\nInstead queue such \"early parcels\" and accept them after the Router\narrives.\n\nI was not yet able to find a concise test to reproduce the problem.\nLanding this now (without a test) would help focus on remaining race\nconditions in tests.\n\nReproducing the problem is currently possible by applying\ncrrev.com/c/6316751 (OfferChannelUpgrade() in ChannelLinux with ipcz),\nwhich would cause a large number of failures on CQ. One example test\nfailure is in content_browsertests (on Linux):\n\nAll/NavigationControllerBrowserTest.LoadCrossSiteSubframe/RDAllFrames_BFCacheEnabled\n\nThis change fixes the problem with the test above.\n\nThe ChannelLinux change is WIP and should land separately.\n\nBug: 410594534\nChange-Id: I0be85fc82bc59a5044e374fb8442036cfdfacff5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6495328\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1473094}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9c4cf3f4595ac2833e238ba2fd87d0250f0f9a7f\n" }, { "commit": "f7dbfe15b605289c5c61c3233dfc20bb29c1063a", "tree": "10c89f00b38aa65395c43c0b97264073c73ca284", "parents": [ "182f69fac70c078c11ebf9dc6be3aaedfe89b58b" ], "author": { "name": "Ho Cheung", "email": "hocheung@chromium.org", "time": "Tue Jun 10 21:18:36 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Jun 10 21:25:59 2025" }, "message": "[ipcz] Replace Overloaded with absl::Overload\n\nWe are allowing absl::Overload; we should replace Overloaded with it and\nremove.\n\nBug: 392929829\nChange-Id: I067cc30bc840538fcf52150cb0583bac8a048b34\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632827\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Ho Cheung \u003chocheung@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1472062}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9af7427f93d24c91e5e55def5d23c77a739bb57a\n" }, { "commit": "182f69fac70c078c11ebf9dc6be3aaedfe89b58b", "tree": "4d61b8c31452707a4a2e457135b3d7a3874075f9", "parents": [ "c6a1552c55149acb7b6ae85d8745d4b63aa5d12b" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Fri Jun 06 18:21:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 06 18:28:56 2025" }, "message": "Fix invalid escape sequences in ipcz node message generator\n\nAlso use the raw description formatter to preserve intentional newlines.\n\nChange-Id: Ifbd39cfd8d8476a2a6b4de08241c7e67d8682d0b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626260\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1470675}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7a66549e2e82fc1e8c3ff48dc14358d0c2ea48c6\n" }, { "commit": "c6a1552c55149acb7b6ae85d8745d4b63aa5d12b", "tree": "1492d9f672f9b953649af770ac7ee9355948a698", "parents": [ "86f2e0fc6c6e5eae6741f0e411323a7fc494ed7a" ], "author": { "name": "Egor Pasko", "email": "pasko@chromium.org", "time": "Thu Jun 05 12:31:31 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 05 12:38:30 2025" }, "message": "ipcz: Synchronize Router::pending_puts_ like other members\n\nWhy is |pending_puts_| not protected by |mutex_| like all other members\nof Router?\n\nThe member moved from Portal into Router when the two classes merged in\ncrrev.com/1163202. The commit looks almost purely mechanical, so it\nlikely did not grab any thread safety attention during review. However,\nthe class Portal at the time already advertised itself as \"thread-safe\nand manipulated directly by public ipcz API calls\" while not\nsynchronizing access to |pending_puts_|.\n\nEarlier synchronization was _removed_ from Portal in crrev.com/1161995\nwith this justification:\n\n```\n Remove unnecessary Mutex from Portal. We don\u0027t need to synchronize\n on callers\u0027 behalf. (-8 bytes)\n```\n\nAt the time it saved 8 bytes per Portal, but now with Router the lack of\nsynchronization does not save any memory. Router also claims being\nthread safe. So, let\u0027s add this synchronization for consistency.\n\nThe new locking is short lived, and used only in BeginPut/EndPut, which\nI believe is not called at a very high rate. This is good news because\nwe are unlikely to observe contention in real-world scenarios. But it is\nalso bad in a sense that this is unlikely to be a reason for flakiness\n(see the bug).\n\nA microbenchmark covering this would be good to have. I did not find\none.\n\nBug: 410594534\nChange-Id: I1d91b5bf60561246b15ec57829c091d71470ad3a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6619834\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Egor Pasko \u003cpasko@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1469894}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a7a35e37b251765f777ee9391d1096360526ea8a\n" }, { "commit": "86f2e0fc6c6e5eae6741f0e411323a7fc494ed7a", "tree": "b466500b36565bb14151632737b12bfa0fb41145", "parents": [ "d6df0baa1bb73b92c3f728e675558cf5c4d1ce0c" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Wed Jun 04 20:57:38 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 04 21:03:02 2025" }, "message": "Validate enum fields in ipcz messages\n\nSome ipcz messages include enum fields that might not be correctly\nvalidated when the messages are processed in their OnXyzMessage()\nhandlers.\n\nThis CL adds up-front validation for these enum fields. Enums gain\na kMinValue and kMaxValue field. Generated code stores this information\nin the data structure used to validate incoming messages.\nValidation happens in message.cc on an appropriately sized value from\nthe raw message.\n\nOnly size 1 and size 4 enums are supported, with static asserts to\nprevent new sizes without adding additional processing code.\n\nA following CL will add validation for enums embedded in arrays.\n\nBug: 419853202\nChange-Id: Ie82865038946067fbe5b29f449a600b913b56be3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582584\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1469605}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6e0bbc8ae6fe67c01f404e671213faf52a4e222a\n" }, { "commit": "d6df0baa1bb73b92c3f728e675558cf5c4d1ce0c", "tree": "f039bd627f261998b2c51046efa6a3069d7a443b", "parents": [ "84838f1a4090908c473f7ac545378bdc0138490a" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Wed Jun 04 17:38:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jun 04 17:45:08 2025" }, "message": "Remove unused forward struct declaration\n\nBug: 419853202\nChange-Id: I7eeff9022406020b013e35b1e9da524043cf0ca3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582583\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1469443}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ef1885001858e424f202957dffc41483413a6f70\n" }, { "commit": "84838f1a4090908c473f7ac545378bdc0138490a", "tree": "cff0582f75d18ef68c40bfd6ef28138f83fe5c4e", "parents": [ "8272ad9f2585153eae35506a27414345315a67b3" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Thu May 29 00:39:38 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu May 29 00:45:26 2025" }, "message": "Generate ipcz message code with jinja\n\nIPCZ message on-wire structs were generated using multiply included\nheaders and macros that had different meanings depending on the context\nin which they were included. This works fine but presents difficulty\nwhen debugging low-level message handling (as the macros elide line\ninformation and don\u0027t uniquely present code for the debugger to step\nthrough), and makes it difficult to change low-level message handling as\nthe macros are fragile and difficult to read.\n\nThis CL changes how the node_messages.h and node_messages.cc are\ngenerated by introducing a parser for the current\nnode_messages_generator.h message definition file, and jinja templates\nto write out the same classes, structs and types as the previous macros\ndid.\n\nThese files are now generated and checked in, with a PRESUBMIT.py added\nto ensure that the files are updated if the source files or generating\ncode is changed. This allows ipcz to be built outside of its repository\nof record without requiring people run python/jinja during their builds.\n\nRegenerate the files by running:\n\n python3 .\\third_party\\ipcz\\src\\ipcz\\node_messages.py --dir\u003d.\\third_party\\ipcz\\src\\ipcz\\\n\nand validate the currently checked-in files by running:\n\n python3 .\\third_party\\ipcz\\src\\ipcz\\node_messages.py --dir\u003d.\\third_party\\ipcz\\src\\ipcz\\ --check\n\nMessage generation is tested by the existing test facilities that were\nwritten to validate the macro code generation.\n\nThe generated code is laid out in the same way as the macro generation\napproach but formatted to be as close to `git cl format` output as\npossible (given that some lines will wrap and some will not). A gist of\nthe previous macro generated code is available at\nhttps://paste.googleplex.com/5069333698707456 for comparison.\n\nBug: 419853202\nChange-Id: Ib436961f497bf6857b8fc85238c1d3adf61564fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6566903\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1466819}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d61686cc5d1b5d63749b7f7f740d176533f93c2b\n" }, { "commit": "8272ad9f2585153eae35506a27414345315a67b3", "tree": "b97b87c6bc904052feffff844ae852e22de2dc59", "parents": [ "9e42a1c7847cc5e9b080001a2db5d1c28adda061" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Wed May 28 21:57:54 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 28 22:04:51 2025" }, "message": "Golden messages tests for ipcz\n\nAdds some serialized messages that should be deserializable\nif different versions of ipcz are talking to each other. Uses\ntest messages as these are simpler and exercise the generation\ninfrastructure in the same way as node_messages but can use\nmock drivers and transports in the tests.\n\nBug: 419853202\nChange-Id: I2fadb98b6f6efa9b5b6dece3abb5e1c7133641db\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6598076\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1466740}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d11ac8b0274f0693b6406a6aaed3a624215b24ff\n" }, { "commit": "9e42a1c7847cc5e9b080001a2db5d1c28adda061", "tree": "ccf2e59a18a39df34a1923a22923f35a9c6c1dc4", "parents": [ "29d041d5493d0291d6b7596ce1f67f5539cb6661" ], "author": { "name": "Alex Gough", "email": "ajgo@chromium.org", "time": "Mon Apr 21 19:18:45 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 21 19:24:01 2025" }, "message": "Propagate failure when relaying messages\n\nFailure to dispatch a relayed message should bubble up\nbut did not.\n\nBug: 406022419\nChange-Id: I1150fbeb1141f298804e0a1cd2dfc5c1b05ae68d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6469078\nReviewed-by: Oksana Zhuravlova \u003coksamyt@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1449556}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2a21691931195ef82104573fc1234aed8261f522\n" }, { "commit": "29d041d5493d0291d6b7596ce1f67f5539cb6661", "tree": "3e7cf97ebd434efb499d9f8dd6a280d4e6214a6e", "parents": [ "461bf5ab9b47d9d41d51c3411e920347c54f8ef6" ], "author": { "name": "Chenlin Fan", "email": "fancl@chromium.org", "time": "Tue Apr 15 23:33:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 15 23:40:35 2025" }, "message": "Add configs to avoid formatting code under third-party\n\nThere are \u003e300 projects under third_party but only 3 maintained in\nchromium/src which require formatting. Add language specific formatter\nconfigs listed in git_cl.py except java, python, mojom and lucicfg. This\nhelps us mesure the scale vendored code diverged from upstream. Also\nincludes overrides for 3 projects are known to be maintained in\nchromium/src under third_party.\n\nThere is no easy way to ignore java and python files so we will leave it\nfor now until we get the data. mojom and lucicfg aren\u0027t considered an\nissue.\n\nBug: 397081590\nChange-Id: I32917804f079848782dbe21a9b4fe45aecc9d063\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441671\nReviewed-by: Rachael Newitt \u003crenewitt@google.com\u003e\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nCommit-Queue: Chenlin Fan \u003cfancl@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1447455}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c822490a82cdb6ad479159683a92858f7c6f0a58\n" }, { "commit": "461bf5ab9b47d9d41d51c3411e920347c54f8ef6", "tree": "ef1589987df01cd28f8a9ecfe21bdaf67edc2785", "parents": [ "1c592e133100a0b3d798bce965eb82f8e77cc0b3" ], "author": { "name": "Dirk Pranke", "email": "dpranke@google.com", "time": "Thu Apr 03 17:44:51 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 03 18:03:20 2025" }, "message": "Use exec_script_allowlist in //third_party/ipcz/.gn.\n\nWe\u0027re moving all references to exec_script_whitelist in GN\nto use exec_script_allowlist instead.\n\nBug: 389986807\nChange-Id: I8e079379d052e4c577956a8b854ca3476f3998e3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427151\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1442274}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a18d0d46584cfc459d8e2364b73eababeada045f\n" }, { "commit": "1c592e133100a0b3d798bce965eb82f8e77cc0b3", "tree": "03663a46325173e25163fb08cc03bea565bda376", "parents": [ "44e42231428120dd1a0c08b1cad0edfcce221a30" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Wed Mar 19 19:39:22 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Mar 19 19:50:14 2025" }, "message": "Migrate absl variant.h and utility.h in third_party/ipcz/src\n\nSince https://crrev.com/c/6330348, some utils in\nthird_party/abseil-cpp/absl/types/variant.h and\nand third_party/abseil-cpp/absl/utility/utility.h are only aliases for\ntheir std counterparts. This CL migrates code to use std:: directly.\n\nBug: 40242126\nChange-Id: Icea384f6923b11c691869d4259c7d07beb9bb230\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368817\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1435025}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 9b72fe3dd44b696912e9047fc8f1aa03a9af6a09\n" }, { "commit": "44e42231428120dd1a0c08b1cad0edfcce221a30", "tree": "752f3acb2701f6729fbb38e3a88233425a9609d8", "parents": [ "8ca58b514c48c0c3abebeec3353430fca3f2c743" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Tue Mar 18 23:30:55 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 18 23:41:42 2025" }, "message": "[standalone ipcz] Roll third_party/abseil-cpp/ a64dd87ce..cc230bcfd (100 commits)\n\nIn particular this causes absl::variant to start deferring to\nstd::variant for standalone ipcz builds. It seems there\u0027s no CQ\ncoverage for standalone ipcz, so I tested this change manually as\ndescribed below.\nhttps://chromium-review.googlesource.com/c/chromium/src/+/6368644/comment/afa44745_f698cb01/\n\nhttps://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git/+log/a64dd87cec79..cc230bcfdbc1\n\n$ git log a64dd87ce..cc230bcfd --date\u003dshort --no-merges --format\u003d\u0027%ad %ae %s\u0027\n2025-03-17 danilchap@chromium.org Roll abseil_revision 0898cd30e3..310e6f4f0f\n2025-03-12 danilchap@chromium.org Roll abseil_revision 70ba73e6b1..0898cd30e3\n2025-03-11 victorvianna@google.com Roll abseil_revision 52fa46a977..70ba73e6b1\n2025-03-10 victorvianna@google.com Make absl::variant a typedef for std::variant\n2025-03-10 danilchap@chromium.org Remove unused include of str_cat.h from absl/status.h\n2025-03-07 danilchap@chromium.org Delete absl internal if_constexpr\n2025-03-05 hans@chromium.org Roll libc++ from ac66645101e6 to 7c3087b8a756 (5 revisions)\n2025-02-24 danilchap@chromium.org Roll abseil_revision 05e72a3285..52fa46a977\n2025-02-12 danilchap@chromium.org Roll abseil_revision 69b58f9227..05e72a3285\n2025-02-11 hans@chromium.org Roll libc++ from 12150825ca73 to 492ff432ef34 (56 revisions)\n2025-02-10 hans@chromium.org Reland \"Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)\"\n2025-02-07 estade@google.com Reland \"Reapply \"Roll protobuf to 29.3\"\"\n2025-02-06 grt@chromium.org Revert \"Reapply \"Roll protobuf to 29.3\"\"\n2025-02-06 estade@google.com Reapply \"Roll protobuf to 29.3\"\n2025-02-06 danilchap@chromium.org Resolve and remove some TODOs in absl BUILD.gn files\n2025-02-05 mbonadei@chromium.org Roll abseil_revision da2b12d7c9..69b58f9227\n2025-02-03 bashi@chromium.org Revert \"Roll protobuf to 29.3\"\n2025-02-03 estade@google.com Roll protobuf to 29.3\n2025-01-29 danilchap@chromium.org Roll abseil_revision 5a0e2cb5e3..da2b12d7c9\n2025-01-29 ust@google.com Revert \"Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)\"\n2025-01-28 hans@chromium.org Roll libc++ from 2e25154d49c2 to 12150825ca73 (42 revisions)\n2025-01-23 mbonadei@chromium.org Roll abseil_revision fd8b35b9aa..5a0e2cb5e3\n2025-01-22 mbonadei@chromium.org Roll abseil_revision 513583421a..fd8b35b9aa\n2025-01-19 tikuta@chromium.org Roll abseil_revision a1de53ddde..513583421a\n2025-01-16 danilchap@chromium.org Merge extra dependencies from absl_full_deps to absl_deps\n2025-01-15 danilchap@chromium.org Roll abseil_revision 65b7da13bf..a1de53ddde\n2025-01-08 mbonadei@chromium.org Roll abseil_revision f623b01435..65b7da13bf\n2024-12-20 ynovikov@chromium.org Update abseil DEF files\n2024-12-18 danilchap@chromium.org Roll abseil_revision 3de434ab4c..f623b01435\n2024-12-16 mbonadei@chromium.org Roll abseil_revision c7cf999bda..3de434ab4c\n2024-12-15 mbonadei@chromium.org Temporarily remove patches\n2024-12-14 mbonadei@chromium.org Reland \"Roll abseil_revision b67caffec1..c7cf999bda\"\n2024-12-12 mbonadei@chromium.org Temporary patch to fit -Wundef issues in absl/hash/internal/hash.h.\n2024-12-02 thakis@chromium.org Roll libc++ from cc33f56af94c to 0f824eb44ac8 (81 revisions)\n2024-11-29 nsatragno@chromium.org Revert \"Roll abseil_revision b67caffec1..c7cf999bda\"\n2024-11-29 mbonadei@chromium.org Roll abseil_revision b67caffec1..c7cf999bda\n2024-11-28 danilchap@chromium.org Re-enable abseil leak check for ios and win\n2024-11-26 thakis@chromium.org Roll src/third_party/libc++/src/ 2f906ff5d..76cb1e3b4 (47 commits)\n2024-11-26 tikuta@chromium.org Reland \"Roll src/third_party/libc++/src/ 291ce60cc..2f906ff5d (6 commits)\"\n2024-11-25 ffred@chromium.org Revert \"Roll src/third_party/libc++/src/ 291ce60cc..2f906ff5d (6 commits)\"\n2024-11-25 tikuta@chromium.org Roll src/third_party/libc++/src/ 291ce60cc..2f906ff5d (6 commits)\n2024-11-21 rop@google.com LSC updating dependencies with Apache-2.0 license to use spdx identifier\n2024-11-20 danilchap@chromium.org Roll abseil_revision 4794821d8b..b67caffec1\n2024-11-20 tikuta@chromium.org abseil-cpp: make generate_def_files.py run only on Linux\n2024-11-14 tikuta@chromium.org abseil-cpp: fix SyntaxWarning in generate_def_files.py\n2024-11-06 danilchap@chromium.org Roll abseil_revision fa588813c4..4794821d8b\n2024-10-30 danilchap@chromium.org Roll abseil_revision 878313658e..fa588813c4\n2024-10-23 danilchap@chromium.org Roll abseil_revision 202a8f40cf..878313658e\n2024-10-16 mbonadei@chromium.org Roll abseil_revision 8634e35f17..202a8f40cf\n2024-10-14 hans@chromium.org Roll clang+rust llvmorg-20-init-3847-g69c43468-28 : llvmorg-20-init-6794-g3dbd929e-1 / 009e73825af0e59ad4fc603562e038b3dbd6593a-23 : f5cd2c5888011d4d80311e5b771c6da507d860dd-2\n2024-10-11 danilchap@chromium.org Remove absl visibility exception for WebRTC\n2024-10-09 danilchap@chromium.org Change condition when to restricit visibility to absl targets\n2024-10-09 danilchap@chromium.org Roll abseil_revision c6b27359c3..8634e35f17\n2024-10-02 danilchap@chromium.org Update reference in abseil patches to more accurate issues\n2024-10-02 mbonadei@chromium.org Roll abseil_revision ba5fd0979b..c6b27359c3\n2024-09-25 danilchap@chromium.org Roll abseil_revision 0df5674003..ba5fd0979b\n2024-09-20 hans@chromium.org Reland \"Roll libc++ from 50ab693ecb61 to 1fe5dc4dbb07 (5 revisions)\"\n2024-09-18 thakis@chromium.org Revert \"Roll libc++ from 50ab693ecb61 to 1fe5dc4dbb07 (5 revisions)\"\n2024-09-18 mbonadei@chromium.org Roll abseil_revision 67d126083c..0df5674003\n2024-09-17 thestig@chromium.org Revert \"Disable abseil warnings for non-chromium builds.\"\n2024-09-16 danilchap@chromium.org Remove absl visibility exception for optimization_guide\n2024-09-16 hans@chromium.org Roll libc++ from 50ab693ecb61 to 1fe5dc4dbb07 (5 revisions)\n2024-09-09 danilchap@chromium.org Roll abseil_revision b014bff59d..67d126083c\n2024-09-04 mbonadei@chromium.org Roll abseil_revision 40a975ff1e..b014bff59d\n2024-08-29 hans@chromium.org Reland \"Roll libc++ from d8d9de41d764 to 11b839dc7fee (22 revisions)\"\n2024-08-29 hans@chromium.org Roll clang+rust llvmorg-20-init-1009-g7088a5ed-10 : llvmorg-20-init-3847-g69c43468-1 / [skipping Rust]\n2024-08-28 danilchap@chromium.org Roll abseil_revision 5a01d0f77e..40a975ff1e\n2024-08-21 mbonadei@chromium.org Roll abseil_revision 69c4683962..5a01d0f77e\n2024-08-20 danilchap@chromium.org Reduce usage of public_deps in abseil build files\n2024-08-14 danilchap@chromium.org Reland \"Roll abseil_revision 3848ed7f1b..69c4683962\"\n2024-08-14 osamafathy@google.com Revert \"Roll abseil_revision 3848ed7f1b..69c4683962\"\n2024-08-14 danilchap@chromium.org Roll abseil_revision 3848ed7f1b..69c4683962\n2024-08-07 mbonadei@chromium.org Roll abseil_revision 6b8ebb35c0..3848ed7f1b\n2024-08-07 danilchap@chromium.org Delete absl patch accepted upstream\n2024-08-06 dpranke@google.com Add internal optimization_guide targets to absl_full visibility.\n2024-08-06 danilchap@chromium.org Add public absl log subtargets to absl components\n2024-08-01 danilchap@chromium.org Roll abseil_revision 5ea745c2ae..6b8ebb35c0\n2024-07-29 mbonadei@chromium.org Roll abseil_revision eb85220775..5ea745c2ae\n2024-07-25 thakis@chromium.org Roll libc++ from 437475caeeb6 to 1ac8f1a391d9 (6 revisions)\n2024-07-24 thakis@chromium.org Update absl def files after libc++ roll\n2024-07-18 danilchap@chromium.org Include windows.h in absl/poison.cc regardless of asan/msan configuration\n2024-07-17 danilchap@chromium.org Roll abseil_revision af4c589ed6..eb85220775\n2024-07-15 ynovikov@chromium.org Update abseil DEF files.\n2024-07-11 mbonadei@chromium.org Roll abseil_revision 9957f27686..af4c589ed6\n2024-06-28 mbonadei@chromium.org Roll abseil_revision 69195d5bd2..9957f27686\n2024-06-26 ahmedmoussa@google.com Revert \"Add \u0027leak_check\u0027 source set to \u0027absl_component_deps\u0027\"\n2024-06-26 ahmedmoussa@google.com Add \u0027leak_check\u0027 source set to \u0027absl_component_deps\u0027\n2024-06-21 ynovikov@chromium.org Regenerate abseil DEF files\n2024-06-19 danilchap@chromium.org Roll abseil_revision 29bd16cb92..69195d5bd2\n2024-06-13 thakis@chromium.org Roll libc++ from 852bc6746f45 to 1e843f837077 (178 revisions)\n2024-06-13 iwells@chromium.org Revert \"Roll abseil_revision 29bd16cb92..17137c084a\"\n2024-06-12 mbonadei@chromium.org Roll abseil_revision 29bd16cb92..17137c084a\n2024-06-05 danilchap@chromium.org Roll abseil_revision 457fdbf960..29bd16cb92\n2024-05-29 mbonadei@chromium.org Roll abseil_revision e7f1a950e9..457fdbf960\n2024-05-22 danilchap@chromium.org Roll abseil_revision eba8db7baf..e7f1a950e9\n2024-05-15 mbonadei@chromium.org Roll abseil_revision e444af7ccc..eba8db7baf\n2024-05-08 danilchap@chromium.org Roll abseil_revision f638e34270..e444af7ccc\n2024-05-01 mbonadei@chromium.org Roll abseil_revision e022c806b0..f638e34270\n2024-04-24 danilchap@chromium.org Roll abseil_revision 8f9e5f0203..e022c806b0\n2024-04-23 danakj@chromium.org absl def generation: Have the output directory be below the source root\n\nCreated manually.\n\nBug: 40242126\nChange-Id: Ie4008ebddc5edf3e06fcbda79497afff60451e5b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368644\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1434509}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 260a7634b149ecf63e6394629fc9c678cda25698\n" }, { "commit": "8ca58b514c48c0c3abebeec3353430fca3f2c743", "tree": "a9515427a81388662b4e8cf4354c8c48e3deea46", "parents": [ "09a4de28ebf244add46c143ea40af5d218770dd5" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Wed Feb 05 02:56:20 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 05 03:06:12 2025" }, "message": "Add next batch of unsafe_libc_calls suppressions\n\nAnother step in the iterative process of finding unsafe files\nbefore enabling warnings themseleves.\n\nBug: 390223051\nChange-Id: I1777894aba21d0b63c5397948deeb7391a9e6c36\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6230971\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nOwners-Override: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1415965}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f49acfefd313bbe3b14a485a1db8d54363dbb6b\n" }, { "commit": "09a4de28ebf244add46c143ea40af5d218770dd5", "tree": "3683dd8a3ac918927bfb2f38feb2318c42a67050", "parents": [ "c0971da77aeca738b554b42e3765c34d2e3e22da" ], "author": { "name": "Tom Sepez", "email": "tsepez@chromium.org", "time": "Fri Jan 31 00:00:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jan 31 00:12:12 2025" }, "message": "Enforce unsafe_buffer_usage on ipcz files.\n\nSuppress exceptions with the #pragma since ipcz/ should not depend\nupon base/ and its UNSAFE_BUFFERS() macro.\n\nBug: 393091624\nChange-Id: I44da1d3c0dcd801c729a604600f756ffc867afc4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6215491\nReviewed-by: Arthur Sonzogni \u003carthursonzogni@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Tom Sepez \u003ctsepez@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1413827}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 80bec3858fa399e40e800dd3cdc7edf9d093f39b\n" }, { "commit": "c0971da77aeca738b554b42e3765c34d2e3e22da", "tree": "d10fdba24fb6e794528332333a0220328154382e", "parents": [ "dca8383b61ad7311c28523a9c2a6e2dfe1dca6cf" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Dec 16 07:42:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Dec 16 07:49:33 2024" }, "message": "third_party/ipcz: add missing includes for the build with use_libcxx_modules\n\nThis is to fix build error when we set use_libcxx_modules\u003dtrue in\nchromium build.\n\nBug: 40263312\nChange-Id: I5a10b292da08c8a3a93f417beef270619224ca61\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090604\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1396594}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 317606c127a88d374b787cbe3cf1b172d5d59710\n" }, { "commit": "dca8383b61ad7311c28523a9c2a6e2dfe1dca6cf", "tree": "70fec58f8bf24075ce88f83814add72adbb13e13", "parents": [ "62c335a645add717009aca1657952c81dade921b" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Dec 12 03:33:43 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Dec 12 03:43:43 2024" }, "message": "third_party/ipcz: add missing includes for the build with use_libcxx_modules\n\nThis is to fix build error when we set use_libcxx_modules\u003dtrue in\nchromium build.\n\nBug: 40440396\nChange-Id: Iec9c845ea8cac9c8b6f0716c1fdc4e8e81b3a70a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090373\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCommit-Queue: Andrea Orru \u003candreaorru@chromium.org\u003e\nReviewed-by: Andrea Orru \u003candreaorru@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1395236}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 85fae7d644d4ba7182cb8052d9c375a470004725\n" }, { "commit": "62c335a645add717009aca1657952c81dade921b", "tree": "d0efbe30976a2a0bd4b2d11a19989564d05d9b3f", "parents": [ "948fb200d4f9513c2064c5878a480bd97f4a45ea" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Thu Nov 28 19:26:41 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 28 19:34:35 2024" }, "message": "ipcz: Validate new router sublinks\n\nThis fixes a bug where it was possible to craft a parcel which routes\nitself to one of its own attached routers, thus creating an unreachable\ncircular Router reference and leaking memory.\n\nFixed: 380927241\nChange-Id: I5263f9cf808028aa31fd7bcad6cc140fc2d865c3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055325\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1389513}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 45f8235319dfbe42eddbf363526e5a9e7e240afb\n" }, { "commit": "948fb200d4f9513c2064c5878a480bd97f4a45ea", "tree": "1b223368ed1cf98169b9c80101934fa0c00897bb", "parents": [ "49164b5f7d3e44c23aed4bcb4b9c9e543f71e7b1" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 27 18:02:19 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 27 18:08:42 2024" }, "message": "Remove rockot@ from mojo+ipcz OWNERS\n\nAlso add andreaorru@ to ipcz OWNERS\n\nBug: None\nChange-Id: I47d6f7e91419e2478a5ed9c07b5e8b6393d0a56d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055660\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1388923}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3c72ccb31b802e507ea330d8120fabe85ce19c3b\n" }, { "commit": "49164b5f7d3e44c23aed4bcb4b9c9e543f71e7b1", "tree": "bec53d905660eecd2a2c91534e474467d3def497", "parents": [ "1897607d6ec5371dbd7a1c4bcc845a5af2e74e0b" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 27 00:36:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 27 00:44:30 2024" }, "message": "ipcz: Fix nullptr deref on Router deserialization\n\nIn general when deserializing a router, if we can\u0027t bind the encoded\noutward link, that means the remote node is already disconnected and\nwe can immediately signal disconnection to the new router.\n\nFor some reason we were suppressing this behavior when the new router\nalso knows that it\u0027s peer is already closed. There doesn\u0027t appear to be\na good reason to do this, and in fact it can cause leaks.\n\nBut more to the point here, in the branch where we have an invalid link\nAND know the peer is closed, we always attempt to dereference the\ninvalid (null) RouterLink.\n\nThis fixes the bug with a simplification: if we reach this point and the\nlink is null, we always treat it as a disconnection.\n\nFixed: 380938365\nChange-Id: I1a952691b6e37692ab471c8945507abebfede6c2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6051175\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1388558}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e728226e55ca5805980de942de16a1819239f0e7\n" }, { "commit": "1897607d6ec5371dbd7a1c4bcc845a5af2e74e0b", "tree": "4c66d512a165016059099df832e70fde6b8041b0", "parents": [ "833d90eab1879c58bfb0f7cc3383b7a58b5da0d9" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Nov 26 21:43:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 26 21:53:54 2024" }, "message": "ipcz: Fix bad assertion on DriverMemory adoption\n\nAttempting to adopt a non-memory DriverObject in the DriverMemory\nconstructor can trigger an assertion, as we assert that a driver call\nto GetSharedMemoryInfo() will succeed.\n\nThe net result in release mode is uninteresting: we\u0027ll have a\nDriverMemory that appears to be valid, but which can\u0027t be mapped.\n\nBut this case also triggers a debug assertion in the DriverMemory\nconstructor, which trips up the fuzzer. This CL replaces the assertion\nwith a regular branch to leave the DriverMemory in the\ndefault-initialized state (i.e. not a valid memory object.)\n\nFixed: 380922990\nChange-Id: I0e053182e8734ca6168b2b4ad5ff46f119a5e6b1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6052221\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1388470}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a5dfd07b04d2f71931922378680e2e35134b534d\n" }, { "commit": "833d90eab1879c58bfb0f7cc3383b7a58b5da0d9", "tree": "e0591d4030f39a4ed54956638c1befb83e3c1c91", "parents": [ "04f1c4b027c74529eec7c292ef4c3da4dbf5c29e" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Nov 26 20:12:54 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 26 20:20:56 2024" }, "message": "ipcz: Fix potential leak on disconnect\n\nCorrects an issue where a Router could get wedged with an inward edge\nthat never observes disconnection because its intended link was\ndisconnected before it could be assigned to the router. The net result\nof this is that the Router (and potentially its local peer) can leak.\n\nThe bug would be difficult to trigger in production, but it affects our\nfuzzer.\n\nFixed: 379776585\nChange-Id: If0f3200e453b7341fb42bd0ac8e2246090cd03fa\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050862\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1388421}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f3b3856817686c032ab8c4704c5dc3230cfb9974\n" }, { "commit": "04f1c4b027c74529eec7c292ef4c3da4dbf5c29e", "tree": "422abf0348b2d621b6db3d71578c333cc9bbae26", "parents": [ "2c70ab493a03906bc48ed598dc834e273749f7c0" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Nov 25 21:44:14 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 25 21:53:56 2024" }, "message": "ipcz: Fix deadlock on disconnect\n\nCorrects an edge case where we could destroy Parcels while still holding\na Router\u0027s lock, risking deadlock if any attached Routers need to be\nreentered.\n\nFixed: 380327158\nChange-Id: Ifa8c224dfec706c0e68795156cbe2c7ae0d0fceb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049340\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1387820}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ea018430a5dbf3293d7322d626a5526699245c50\n" }, { "commit": "2c70ab493a03906bc48ed598dc834e273749f7c0", "tree": "f666f3792bf2aa070a2a727811ffdb9891cfb70f", "parents": [ "788ab60e8461c559b74a0ca010da98a42324c5f2" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Sat Nov 23 02:33:12 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 23 02:39:32 2024" }, "message": "ipcz: Fix data race / crash on ConnectNode failure\n\nWhen ConnectNode() fails today, it releases the provided driver\ntransport to allow the caller to retain ownership.\n\nThis behavior is incorrect though: no caller expects to retain ownership\nof the transport on failure, and ConnectNode() documentation in ipcz.h\nexplicitly states that ownership is relinquished in all cases.\n\nBesides being incorrect, it\u0027s also unsafe: the driver may have already\nstarted manipulating the transport on another thread by this point. This\ncan therefore cause data races and bad pointer dereferences.\n\nThe right fix here is simply to remove the Release() call.\n\nFixed: 337540328\nChange-Id: Ic1f0c2f7270e225072ab94db37d65c446d9b18e5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039467\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1387202}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f7fa9b12edcd7ad8920a714ae0d06d002a8ca4c2\n" }, { "commit": "788ab60e8461c559b74a0ca010da98a42324c5f2", "tree": "a9f102fe1a9b9ddb626c01d2800a5dca8e66b64b", "parents": [ "a159df0fff6340d0787d0bebdf05cc6084d0d9a0" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Fri Nov 22 05:41:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 22 05:47:12 2024" }, "message": "ipcz: Validate shared memory request size\n\nWe assert that we don\u0027t try to create new memory objects of zero bytes,\nbut we don\u0027t validate that a node requests \u003e 0 bytes.\n\nFixed: 379418966\nChange-Id: Ice5c899481eee70de33ad5c8254a069945b0e58f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042644\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1386626}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a01f87b43258c93d985095fa28e55b898e9165b9\n" }, { "commit": "a159df0fff6340d0787d0bebdf05cc6084d0d9a0", "tree": "3195d442567ff348e9f8c7b6194e7a1f89f85a19", "parents": [ "ce0492adf4ece1238758b2071d27e0c23d810d6f" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Thu Nov 21 19:10:43 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 21 19:16:53 2024" }, "message": "Reland \"ipcz: Fix various potential driver object leaks\"\n\nThis is a reland of commit 200eab2fa0a0a74b6472b709a1e6677c1b969fb6\n\nThe fix is for broker connection failure to only blow up the\nworld when it happens to a non-broker.\n\nOriginal change\u0027s description:\n\u003e ipcz: Fix various potential driver object leaks\n\u003e\n\u003e This introduces a bit of extra caution in cleaning up dangling object\n\u003e references (e.g. through retained callbacks) which could lead to leaks\n\u003e when internal communications are tampered with.\n\u003e\n\u003e Also corrects a few bits of code which could assert in debug builds\n\u003e (but which were effectively safe in production) under such conditions.\n\u003e\n\u003e This is a precursor to landing a fuzzer for ipcz.\n\u003e\n\u003e Bug: 370880241\n\u003e Change-Id: I03455475adf3401ada6fb81ba192fa709156f83f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019406\n\u003e Commit-Queue: Ken Rockot \u003crockot@google.com\u003e\n\u003e Reviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1383331}\n\nBug: 370880241\nChange-Id: Id6a920c09b358b2d36747b5b1dba8bda5becec5d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040507\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1386360}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a3b9f8a72bc3dd9099e47d3d8386583cc4a47b16\n" }, { "commit": "ce0492adf4ece1238758b2071d27e0c23d810d6f", "tree": "636cad96578f60f4f3b8f214139288a3c16091d2", "parents": [ "6164b42c57947eeac0b7c79960c4c7c545538760" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 23:25:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 23:35:59 2024" }, "message": "ipcz: Validate introduction transport\n\nGracefully handle (reject) an introduction containing an invalid\ntransport object.\n\nThis is not really an issue in production since these messages are only\naccepted from brokers; but the fuzzer can trip over this.\n\nBug: 378917565\nChange-Id: I8237bc1ae1da4318fa007bea3c6e6f21a6912b3e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6037431\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1385948}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 50d500404645c62a96fd6fe5d0ef5111e7fe5f4e\n" }, { "commit": "6164b42c57947eeac0b7c79960c4c7c545538760", "tree": "b7090b66a8ffa9991f88e94719a73c77c3db5ac4", "parents": [ "adf443062701ebe0db1a043b0298bddd9564e6c4" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 23:24:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 23:35:27 2024" }, "message": "ipcz: Remove invalid assertion\n\nWhen block buffer addition fails we assert that there are no callbacks\nawaiting a new buffer. This is neither correct nor useful to assert.\n\nFixed: 379207977\nChange-Id: Ie3afd19fdac2f22314bb7531a2282dcaac9991df\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033674\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1385947}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 155b891fae7e78ff9f9c3a43e7696f4605ccf975\n" }, { "commit": "adf443062701ebe0db1a043b0298bddd9564e6c4", "tree": "63c67a9943ad2e9271216ce4319ced8a160c6a2a", "parents": [ "c46cfa20415de17004efdc0fc61571b62f6b1d76" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 23:22:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 23:34:53 2024" }, "message": "ipcz: Validate consistent subparcel counts\n\nIf a parcel is decomposed into subparcels for piecemeal transmission,\neach subparcel must agree on the number of subparcels which comprise the\nfull parcel. This agreement was not being validated properly.\n\nFixed: 379207974\nChange-Id: I2b1d1193effd59043ef1b1af3bd41ebceb907b99\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6035939\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1385945}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f9d943a1d925d079a0b66ff017c2fe374e9e5c93\n" }, { "commit": "c46cfa20415de17004efdc0fc61571b62f6b1d76", "tree": "7d55c6eff5d9d80cbcabac6c6cac9266cb616508", "parents": [ "4430fc65b2f133e6216e99111be6017fddf58cbb" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 23:22:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 23:34:26 2024" }, "message": "ipcz: Stronger validation for block buffers\n\nBuffers can no longer be registered which:\n\n- Use an invalid BufferId\n- Have a block size below the minimum allowed (64 bytes)\n- Have a block size which is not 8-byte aligned\n- Contain less than the minimum allowed block count (8)\n\nFixed: 379418965\nFixed: 377942358\nChange-Id: Ia49a27344bec97305c7fddf91677fbc1a6b6f9e0\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036317\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1385944}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 30945ab2006bab53e82ab67e4f4d817251272b6d\n" }, { "commit": "4430fc65b2f133e6216e99111be6017fddf58cbb", "tree": "d1382f54d3cb2cf49d984e0d2dd957658b8e8a89", "parents": [ "4ee2be95438ce50254588a8942730efe29ec507b" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 23:18:37 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 23:26:57 2024" }, "message": "ipcz: Fix assertions in link state adoption\n\nFragment resolution can fail even with an apparently valid descriptor,\ne.g. when the fragment would overflow the resolved buffer\u0027s bounds.\nThere were some code paths that incorrectly assumed valid descriptor\nmeant valid fragment, ultimately then passing a null fragment to places\nthat would assert fragment validity in some form or another.\n\nThis fixes that.\n\nFixed: 378866775\nChange-Id: Ief3f2e25b55839b4a54427fe4a771dff03f67250\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036433\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1385942}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: f8da0714ebfe8a2a2772958b05a484539d2ab742\n" }, { "commit": "4ee2be95438ce50254588a8942730efe29ec507b", "tree": "dbce73d8233e0c051108c9c51a1e8e37a5e7e3af", "parents": [ "8c8386ad760a9fe3bfdc7be36ee2cabd0a1753d2" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 20 21:33:25 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 20 21:52:10 2024" }, "message": "Revert \"ipcz: Fix various potential driver object leaks\"\n\nThis reverts commit 200eab2fa0a0a74b6472b709a1e6677c1b969fb6.\n\nReason for revert: crbug.com/380095271\n\nOriginal change\u0027s description:\n\u003e ipcz: Fix various potential driver object leaks\n\u003e\n\u003e This introduces a bit of extra caution in cleaning up dangling object\n\u003e references (e.g. through retained callbacks) which could lead to leaks\n\u003e when internal communications are tampered with.\n\u003e\n\u003e Also corrects a few bits of code which could assert in debug builds\n\u003e (but which were effectively safe in production) under such conditions.\n\u003e\n\u003e This is a precursor to landing a fuzzer for ipcz.\n\u003e\n\u003e Bug: 370880241\n\u003e Change-Id: I03455475adf3401ada6fb81ba192fa709156f83f\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019406\n\u003e Commit-Queue: Ken Rockot \u003crockot@google.com\u003e\n\u003e Reviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1383331}\n\nBug: 370880241\nChange-Id: I076b93481cc5ec324e56f48f1547c2c8bd0c7f33\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6040019\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Noah Rose Ledesma \u003cnoahrose@google.com\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nReviewed-by: Noah Rose Ledesma \u003cnoahrose@google.com\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nAuto-Submit: Ken Rockot \u003crockot@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCommit-Queue: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1385890}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 092af757c2f4c4b187b144ada9372c4bfc37a10a\n" }, { "commit": "8c8386ad760a9fe3bfdc7be36ee2cabd0a1753d2", "tree": "c40d2dc152c386c294a61dddc20dc6c946e0efe7", "parents": [ "c11be5dddd0f6d002d12cfb37cc5cf640a88b6b0" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Nov 19 23:49:01 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Nov 19 23:58:53 2024" }, "message": "Fix deadlock in ipcz\n\nThis fixes potential Router reentrancy and deadlock during Router\ndeserialization. The root cause is RemoteRouterLink flushing its Router\nwhen setting its link state; but link state may sometimes be set while\nholding a lock on the same Router.\n\nThe fix is to factor the flush further out along the only two code\npaths that can set a link\u0027s state object.\n\nFixed: 379122768\nChange-Id: Ia4b1cc48ecef20cbcb255a5f75ee738d8c834dc4\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032775\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1385328}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: da46cd0027b5ff5c87686ae990e9c628bf448752\n" }, { "commit": "c11be5dddd0f6d002d12cfb37cc5cf640a88b6b0", "tree": "2a02bb6203b0059c4ecba462e508d9a07d5fd930", "parents": [ "41d9f27b50849b7d855825a3ebe4325b531c3064" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Sat Nov 16 01:48:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Nov 16 01:58:58 2024" }, "message": "Introduce ipcz fuzzer\n\nAdds a new ipcz_fuzzer binary which runs a test case to\ndeterministically cover most interesting ipcz code, injecting\nfuzz data during a single internode transmission. Specific\ninjection timing and location are selected by interpreting the\nleading bytes of fuzz data as a configuration.\n\nBug: 370880241\nChange-Id: I3585a7e1e204e85ebdbcd326df238327b20d6622\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004442\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1383929}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 69cf7eefc9685cc200fe704273ed1148522e3640\n" }, { "commit": "41d9f27b50849b7d855825a3ebe4325b531c3064", "tree": "0ea218883c535540e835b5dde19690d8dd56ce11", "parents": [ "7d51cf4f5b9523496aa5ecc5f472a745d7fff76d" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Fri Nov 15 00:01:03 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Nov 15 00:07:27 2024" }, "message": "ipcz: Fix various potential driver object leaks\n\nThis introduces a bit of extra caution in cleaning up dangling object\nreferences (e.g. through retained callbacks) which could lead to leaks\nwhen internal communications are tampered with.\n\nAlso corrects a few bits of code which could assert in debug builds\n(but which were effectively safe in production) under such conditions.\n\nThis is a precursor to landing a fuzzer for ipcz.\n\nBug: 370880241\nChange-Id: I03455475adf3401ada6fb81ba192fa709156f83f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019406\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1383331}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 200eab2fa0a0a74b6472b709a1e6677c1b969fb6\n" }, { "commit": "7d51cf4f5b9523496aa5ecc5f472a745d7fff76d", "tree": "6966f9d29c21ce1e4ae9e6e8609b83c1eee29601", "parents": [ "4621fb452fadb74de29ccff9952ef92712eb179e" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Wed Nov 13 23:47:10 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Nov 13 23:56:04 2024" }, "message": "ipcz: Fix OOB access in message validation\n\nFixed: 378917565\nChange-Id: I6dee5e1bd8ea9a43532c88fb7db7ae7578123992\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019209\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1382671}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 131ddffcec0908c0daaea0ca68b8ef23e24a2039\n" }, { "commit": "4621fb452fadb74de29ccff9952ef92712eb179e", "tree": "d987b62c5c614271e8f90904a4fec4161537fc6a", "parents": [ "f0932a393430ad318a6afc30ee40fcd3b17df840" ], "author": { "name": "Scott Violet", "email": "sky@chromium.org", "time": "Wed Oct 16 21:15:14 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 16 21:23:01 2024" }, "message": "mojo: keeps mach voucher alive until message dispatched\n\nMach vouchers are used to temporarily boost thread/process\npriorities. This patch extracts the voucher when a message is\nreceived and wires it through mojo so that the voucher is kept\nalive until the message is dispatched. The voucher isn\u0027t needed\nduring processing, rather it just needs to be kept alive.\n\nRobert detailed this here:\nhttps://robert.sesek.com/2023/6/mach_vouchers.html\nThis patch is based on an early patch from Robert.\n\nKen suggested this route here:\nhttps://docs.google.com/document/d/1JbLIAwTDB6iyEz5-fa1ycmZ_9Di9w1Dicld4rLiCBF0/edit?tab\u003dt.0\n\nBug: 40270257\n\nChange-Id: I418e4313c9f0fbe6776af8e48b32f0f712fbb41a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925658\nReviewed-by: Mark Rowe \u003cmarkrowe@chromium.org\u003e\nCommit-Queue: Scott Violet \u003csky@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1369638}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dd480bc4ba0e1b21392f4b5365f77e0182dd3eef\n" }, { "commit": "f0932a393430ad318a6afc30ee40fcd3b17df840", "tree": "d5d00ab6637ce239930bacf42e90ac536d8644ac", "parents": [ "dba88b918f8420367a2f5a16e3cf32af1fcd5ee6" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue Oct 08 05:41:23 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Oct 08 05:48:03 2024" }, "message": "ipcz: remove unnecessary include\n\nThis is to reduce included size e.g.\nhttps://commondatastorage.googleapis.com/chromium-browser-clang/chrome_includes_2024-10-07_014308.html#view\u003dedges\u0026filter\u003d%5Ethird_party%2Fipcz%2Fsrc%2Futil%2Fref_counted%5C.h%24\u0026sort\u003dasize\u0026reverse\u003d\u0026includer\u003d%5Ethird_party%2Fipcz%2Fsrc%2Futil%2Fref_counted%5C.h%24\u0026included\u003d\u0026limit\u003d1000\n\nChange-Id: I7e1288150ab412b97b93974ea864edd300cf5ba5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908961\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nAuto-Submit: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1365341}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c40e3f02bcf2d1a8e68a7da967a5a6dece41c45d\n" }, { "commit": "dba88b918f8420367a2f5a16e3cf32af1fcd5ee6", "tree": "0d96d79c8d817c3a2b01060d2ff91488d251d337", "parents": [ "ca21f0d870130a97bd7a1e2a8249f914434ca0b3" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Sep 23 19:26:24 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Sep 23 20:02:20 2024" }, "message": "ipcz: Validate link state fragment before adoption\n\nFixed: 368208152\nChange-Id: I0e2ece4b0857b225d229134b2e55abc3e08348ee\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5876623\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1358968}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: c333ed99544992f66e6e03621fa938d75ad01f70\n" }, { "commit": "ca21f0d870130a97bd7a1e2a8249f914434ca0b3", "tree": "15e31708db92e34fe39051386eea961fbc7a5b0a", "parents": [ "91ebfad54571e98f3ec1039d468d51382f9c98c0" ], "author": { "name": "Jiewei Qian", "email": "qjw@chromium.org", "time": "Thu Aug 08 04:11:20 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Aug 08 04:20:29 2024" }, "message": "ssci: fill in URL and Version for third_party/ipcz\n\nipcz is authored and maintained by Chromium, but placed in third_party\nto conveniently restrict its dependency on the rest of Chromium.\n\nChange-Id: I08ca6e358ff40ec1a23264cc1f455ada80eccffb\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5772191\nReviewed-by: Rachael Newitt \u003crenewitt@google.com\u003e\nCommit-Queue: Jiewei Qian \u003cqjw@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1338862}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d063ebeea746b0469baa432162e498453bee6748\n" }, { "commit": "91ebfad54571e98f3ec1039d468d51382f9c98c0", "tree": "5464e78495a9baa21ca1b028fb51edda4dda0c6f", "parents": [ "3a70cd146c4bf8f7698ec132a3baf928ab528a09" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Thu Jun 27 15:56:11 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Jun 27 16:04:34 2024" }, "message": "ipcz: Track API call context across reentrancy\n\nTrap events set IPCZ_TRAP_WITHIN_API_CALL when triggered by an immediate\nAPI call, but if an API call triggers reentrancy indirectly via a\nsynchronous driver transport before generating an event, the context of\nthe outer API call is lost and the flag won\u0027t be set.\n\nSince the purpose of this flag is to allow consumers to detect\nreentrancy, it\u0027s more useful when it means there\u0027s an API call anywhere\non the stack, not just the innermost ipcz entry point.\n\nThis makes the flag behave like that.\n\nBug: 345459108\nChange-Id: Id99e446084cad0768add47efa6b4d6a4c1ef2883\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5661976\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1320403}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 84e65c63b9b3b79bb7a1f64ba57dd8641c4b5599\n" }, { "commit": "3a70cd146c4bf8f7698ec132a3baf928ab528a09", "tree": "6e11cf2cdf46a3a0e791056e87c637e3cdedf5f8", "parents": [ "2e42db10f49fba6ae3efd8f5a67cb869ee3641d4" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Mon Jun 24 21:52:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Jun 24 22:04:05 2024" }, "message": "Don\u0027t mark ipcz wire structures as 8-byte aligned\n\nOn macOS, we don\u0027t actually achieve the specified alignment. I suspect\nthis is because mach messages only give you 4-byte alignment, not 8.\n\nSample failures:\nhttps://ci.chromium.org/ui/labs/p/chromium/inv/build-8744363917858885313/test/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FAutofillInteractiveFormSubmissionTest.ProbableSubmission/variant/c986399db6573e01?resultIndex\u003d0\nhttps://ci.chromium.org/ui/labs/p/chromium/inv/build-8744316879698860305/test/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FAboutFlagsBrowserTest.ExpiryHidesFlag%2FAll.1/variant/c986399db6573e01\n\nJust remove the alignment markers, which causes the unaligned pragma\npack expectations to go through. (Strictly speaking, the casts are\nstill questionably allowed because of C++\u0027s strict aliasing\nrequirements, but we build with -fno-strict-aliasing.)\n\nBug: 40248746\nChange-Id: I6c4e8df9c8c56658fb6a9732bf28f76702296a18\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649953\nAuto-Submit: David Benjamin \u003cdavidben@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1318810}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 851477c6a5e68a414d66fce5fab3bbb70a941692\n" }, { "commit": "2e42db10f49fba6ae3efd8f5a67cb869ee3641d4", "tree": "ee54c8a8d0ed59c8acc6216cc9b1217508c12f35", "parents": [ "a6dc491d55cf8b84a11187d4ce8512c3e8c487ee" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Apr 23 14:35:48 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 23 14:45:16 2024" }, "message": "ipcz: Update standalone checkout deps\n\nThis rolls a bunch of DEPS for standalone ipcz checkouts to sync them up\nwith current Chromium deps.\n\nNo effect on Chrome builds.\n\nBug: None\nChange-Id: Ic12fb82676a46904c488704fd4a97709dfe59759\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5474868\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1291259}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 6f90fe5f79d3e44f07b59526326c9009aefbea7b\n" }, { "commit": "a6dc491d55cf8b84a11187d4ce8512c3e8c487ee", "tree": "4e8c4e15df6d4bc42017651537349bb8ed5b2c44", "parents": [ "592f3a5ab58e167479d0aea557cbd556076cc165" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Mon Apr 15 22:31:56 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 22:38:00 2024" }, "message": "Reduce allocations in ipcz Parcel::SetObjects()\n\nAccording to local benchmarks, this allocation represents 8.937% of all allocations in Chrome.\nPrevious experiment shows that reducing # allocations (even if on fast path) has positive impact on cpu time.\n\nhttps://pprofng.corp.google.com/?id\u003d5d0b603579a2b4b2af4b8701cb51335f\u0026filter\u003dhide:%255Emalloc%255C%252B43%2524,hide:%255Eoperator%2520new%255C%255B%255C%255D%255C(unsigned%2520long%255C)%255C%252B31%2524\u0026pivot\u003d%5Eallocator_shim::internal::PartitionMalloc%5C(allocator_shim::AllocatorDispatch%20const%5C*%5C,%20unsigned%20long%5C,%20void%5C*%5C)%5C%2B0$\u0026path\u003d0nejlyo\n\nBug: b/40287434\nChange-Id: I2dbafa0d8e4613b60cfb9d1e44430d4dcfc38e2e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402464\nCommit-Queue: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1287683}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 2b90d1c456bcce0f4b9668b4552ebb2c8b7355c0\n" }, { "commit": "592f3a5ab58e167479d0aea557cbd556076cc165", "tree": "8653b63d0e6e7dbd19d70c39fa6e74d27aee20f0", "parents": [ "d161c7e165e2c96a8c44119890ec9846d1d3c900" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Apr 15 17:17:31 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 17:25:05 2024" }, "message": "ipcz: Implement ID generation for memv2\n\nThis is a minimal initial change for memv2.\n\nWhen the feature is enabled, buffer and sublink ID generation will\nnow use private (node-local) atomics instead of shared atomics.\n\nBug: 332719403\nChange-Id: Ic3855c8fa339d27596a3197bddeea4c6f5bc1038\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5421914\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1287430}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: be4c38b9a2ba935f92e2e355a3d2b75f95c5e5c3\n" }, { "commit": "d161c7e165e2c96a8c44119890ec9846d1d3c900", "tree": "77ca4ac9d5920dbd7a1d6693a64b2e742baba91a", "parents": [ "0565a177a5de91f3c789b61070505264fda1ebf9" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Apr 15 16:16:40 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 15 16:25:33 2024" }, "message": "ipcz: Parameterize tests over feature sets\n\nThis change introduces an additional layer of parameterization for\nipcz multinode unit tests, allowing tests to provide coverage over\nmultiple distinct feature sets in the same test suite execution so\nthat new features can have coverage while under development.\n\nGenerated test names now follow the convention:\n\n TestSuite.TestName/Driver_FeatureSet\n\nTwo initial feature sets are defined: \"Default\" and \"MemV2\", the\nlatter of which enables (currently no-op) IPCZ_FEATURE_MEM_V2.\n\nBug: 332719403\nChange-Id: Ia59ae2c0d9c6afeeb3f56e01209551ce487de6ef\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444219\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1287394}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dacdd816ec41db1d392dcd697d0148e64883ca3f\n" }, { "commit": "0565a177a5de91f3c789b61070505264fda1ebf9", "tree": "8d751e54d85b82706d039880c7006bf14f078ee1", "parents": [ "effde8c25fab042ad4b211678b6b0b55ca335e49" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Apr 09 20:58:02 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 09 21:06:39 2024" }, "message": "Reland \"ipcz: Support dynamic runtime features\"\n\nThis is a reland of commit 662e73f5705cdd9b089c8785e42096abf3ea9587\n\nPS1-\u003ePS2 is the diff from the original, fixing an\nuninitialized field in Features.\n\nOriginal change\u0027s description:\n\u003e ipcz: Support dynamic runtime features\n\u003e\n\u003e Runtime features have generic integer identifiers to be defined in\n\u003e ipcz.h. Applications can enable or disable features through CreateNode()\n\u003e options, effectively allowing Chrome feature flags to influence internal\n\u003e ipcz features.\n\u003e\n\u003e Features enabled on a node are automatically shared with any connected\n\u003e nodes, allowing nodes to agree up-front about which features\n\u003e (e.g. protocol additions) to use in each others\u0027 presence to avoid any\n\u003e risk of wire incompatibility at runtime.\n\u003e\n\u003e This is a precursor to supporting alternative shared memory management\n\u003e and usage, among other future improvements. An initial\n\u003e IPCZ_FEATURE_MEM_V2 feature is added as a no-op for now.\n\u003e\n\u003e Bug: 332719403\n\u003e Change-Id: I01bfc2c7aab73912c3495d25c8373ae33610ad38\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420430\n\u003e Commit-Queue: Ken Rockot \u003crockot@google.com\u003e\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1284291}\n\nBug: 332719403\nChange-Id: I45fdd27324fedf1b7f1cf7249dec9d140b4b3e37\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5440934\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1284688}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1029519f8d366e201d9e9feb5b7c25d5a087ac07\n" }, { "commit": "effde8c25fab042ad4b211678b6b0b55ca335e49", "tree": "2d9061102ca07473b4c0adb1575e9862cc444189", "parents": [ "0c3a311ed7cea80941a47688a96a20cea64513a4" ], "author": { "name": "luci-bisection@appspot.gserviceaccount.com", "email": "luci-bisection@appspot.gserviceaccount.com", "time": "Tue Apr 09 11:15:04 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 09 11:24:44 2024" }, "message": "Revert \"ipcz: Support dynamic runtime features\"\n\nThis reverts commit 662e73f5705cdd9b089c8785e42096abf3ea9587.\n\nReason for revert:\nLUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5200924853141504\n\nSample build with failed test: https://ci.chromium.org/b/8751158003263844609\nAffected test(s):\n[ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/adoption-agency-crash-01.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fadoption-agency-crash-01.html?q\u003dVHash%3Ad656188f56ce4659)\n[ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/badurl-base-preloader-crash.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbadurl-base-preloader-crash.html?q\u003dVHash%3Ad656188f56ce4659)\n[ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/body-should-exist-after-open-close.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbody-should-exist-after-open-close.html?q\u003dVHash%3Ad656188f56ce4659)\n[ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/broken-comments-vs-parsing-mode.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fbroken-comments-vs-parsing-mode.html?q\u003dVHash%3Ad656188f56ce4659)\n[ninja://:blink_web_tests/virtual/dom-parts-disabled/fast/parser/changing-attrbutes-crash.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Fvirtual%2Fdom-parts-disabled%2Ffast%2Fparser%2Fchanging-attrbutes-crash.html?q\u003dVHash%3Ad656188f56ce4659)\nand 85 more ...\n\nIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component\u003d1199205\u0026description\u003dAnalysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5200924853141504\u0026format\u003dPLAIN\u0026priority\u003dP3\u0026title\u003dWrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5420430\u0026type\u003dBUG\n\nOriginal change\u0027s description:\n\u003e ipcz: Support dynamic runtime features\n\u003e\n\u003e Runtime features have generic integer identifiers to be defined in\n\u003e ipcz.h. Applications can enable or disable features through CreateNode()\n\u003e options, effectively allowing Chrome feature flags to influence internal\n\u003e ipcz features.\n\u003e\n\u003e Features enabled on a node are automatically shared with any connected\n\u003e nodes, allowing nodes to agree up-front about which features\n\u003e (e.g. protocol additions) to use in each others\u0027 presence to avoid any\n\u003e risk of wire incompatibility at runtime.\n\u003e\n\u003e This is a precursor to supporting alternative shared memory management\n\u003e and usage, among other future improvements. An initial\n\u003e IPCZ_FEATURE_MEM_V2 feature is added as a no-op for now.\n\u003e\n\u003e Bug: 332719403\n\u003e Change-Id: I01bfc2c7aab73912c3495d25c8373ae33610ad38\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420430\n\u003e Commit-Queue: Ken Rockot \u003crockot@google.com\u003e\n\u003e Reviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#1284291}\n\u003e\n\nBug: 332719403\nChange-Id: I532dae7ad4342b89a3b44ae8c0c55a0de5b85d5d\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5437569\nOwners-Override: Mohamed Amir Yosef \u003cmamir@chromium.org\u003e\nReviewed-by: Mohamed Amir Yosef \u003cmamir@chromium.org\u003e\nCommit-Queue: Mohamed Amir Yosef \u003cmamir@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1284390}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: ac35e7a550a515f3a095742d3c8bb0adfa7f69fc\n" }, { "commit": "0c3a311ed7cea80941a47688a96a20cea64513a4", "tree": "79cf6974fd2dff06ec1461df3a5d21b238339702", "parents": [ "60fea1eb4bca1f0b31ba4ee923b564742c8d90ee" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Apr 09 05:19:50 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 09 05:26:11 2024" }, "message": "ipcz: Support dynamic runtime features\n\nRuntime features have generic integer identifiers to be defined in\nipcz.h. Applications can enable or disable features through CreateNode()\noptions, effectively allowing Chrome feature flags to influence internal\nipcz features.\n\nFeatures enabled on a node are automatically shared with any connected\nnodes, allowing nodes to agree up-front about which features\n(e.g. protocol additions) to use in each others\u0027 presence to avoid any\nrisk of wire incompatibility at runtime.\n\nThis is a precursor to supporting alternative shared memory management\nand usage, among other future improvements. An initial\nIPCZ_FEATURE_MEM_V2 feature is added as a no-op for now.\n\nBug: 332719403\nChange-Id: I01bfc2c7aab73912c3495d25c8373ae33610ad38\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420430\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1284291}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 662e73f5705cdd9b089c8785e42096abf3ea9587\n" }, { "commit": "60fea1eb4bca1f0b31ba4ee923b564742c8d90ee", "tree": "2d9061102ca07473b4c0adb1575e9862cc444189", "parents": [ "c0994428514f0fa71aa57a71f54960ed871e8921" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Apr 08 22:32:47 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 08 22:38:47 2024" }, "message": "ipcz: Support addition of new message versions\n\nWe\u0027re apparently already locked-in to the current internal node message\nprotocol (!) due to some macOS Chrome Updater usage requiring support\nfor version skew. We need to add new fields to some common messages.\nThis means it\u0027s time to make versioning usable.\n\nOlder ipcz versions could already tolerate messages from hypothetical\nnewer versions, but newer versions did not yet tolerate receiving\nmessages from older versions. This fixes that.\n\nMessage parameters are now accessed through explicit v0, v1, etc\naccessors; which may be null for one or more versions above 0 if the\nunderlying message has insufficient parameter data.\n\nThis does not change the wire format of v0 for any messages, and once\nthis lands it will be possible to safely introduce new message versions\nto extend existing node messages.\n\nBug: 332719403\nChange-Id: I842e94e1cf29f4d5748bf465eed11f7c64206a04\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5428157\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1284139}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 400cb3b5b3e32a94d666789b984b203b9ce52030\n" }, { "commit": "c0994428514f0fa71aa57a71f54960ed871e8921", "tree": "1e7f45bef8d861e4bdb29c2af11ae199fa2a398c", "parents": [ "3e51f57679cbddc408c4b2aee5a1c633d4ef1c7a" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Mon Apr 08 18:04:58 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Apr 08 18:12:22 2024" }, "message": "ipcz: Prepare for message versioning support\n\nNOTE: This is a purely cosmetic change. No behavioral changes.\n\nIn order to support safe message versioning for internal ipcz node\nmessages, some message definition and usage syntax will change. To\nwit:\n\n1. All parameter blocks in a message definition must now be\n encapsulated by IPCZ_MSG_BEGIN_VERSION() and IPCZ_MSG_END_VERSION().\n This CL introduces and uses those macros, dropping the old\n IPCZ_MSG_VERSION() macro.\n\n2. Parameters on a message are now accessed by a `v0` accessor rather\n than `params`. `v0` is never null but is still a pointer for\n consistency with future version syntax; i.e. when `v1`, `v2`, etc\n are generated, they may be null and callers will be responsible for\n accessing them safely.\n\nThe bulk of this CL is adapting `params()` call sites to `v0()`, and\nrestructuring the message generators. Minimal changes are made to the\nmessage macros themselves to support migrating code to the new syntax.\n\nBug: 332719403\nChange-Id: I00d07f3484444dff4f6cc2dd3ba6e06b1332ab7d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5428852\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1283953}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: a8a9bf22cde576139944d460b4d44110f4d30105\n" }, { "commit": "3e51f57679cbddc408c4b2aee5a1c633d4ef1c7a", "tree": "397ffe12acbbf7b937c7e453d5a5b5fce3aeb737", "parents": [ "078cfba9e6c2913ff184f0b6384ff18198a4934d" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Thu Apr 04 23:25:44 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Apr 04 23:32:12 2024" }, "message": "ipcz: Disable unreliable test on Android\n\nConnectTest.FailedNonBrokerReferral spawns a child process from within\nanother child process when used with the MojoIpcz multiprocess driver.\n\nThis behavior does not seem to be well supported on Android (it\u0027s also\nnever used in production on Android). It\u0027s unclear why the test does\npass sometimes and not others, but adding more tests to the GTest suite\ninexplicably causes this test to fail consistently due to bad\nChildProcessLauncher behavior.\n\nBug: None\nChange-Id: Ifdf9e52436f582f51c0e553642ed9e43ab36e44b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425384\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1282825}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: d7432655360d90bdd55ae4245e6cf7fd37070503\n" }, { "commit": "078cfba9e6c2913ff184f0b6384ff18198a4934d", "tree": "7961ce4c7f64163d83f528205175d7b5621d8da0", "parents": [ "002ec8674cbfe830029aa79b9649236d43e0e0b2" ], "author": { "name": "Ken Rockot", "email": "rockot@google.com", "time": "Tue Apr 02 17:52:21 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Apr 02 18:01:21 2024" }, "message": "ipcz: Safe memory allocation failure for Node intros\n\nNote::IntroduceRemoteNodes does not properly check the result of a\ndriver memory allocation before cloning to share with another node,\nresulting in a CHECK failure within DriverMemory::Clone().\n\nThis change instead gracefully aborts the introduction.\n\nFixed: 324097410\nChange-Id: I07dafb48bd8729fb9d9629059cfb81271b389758\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410733\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1281294}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e8cfffb6de5579ddff1872b5fdd016744fc01bd8\n" }, { "commit": "002ec8674cbfe830029aa79b9649236d43e0e0b2", "tree": "05453efed942c70e515fab73fa6a7416a8db6a79", "parents": [ "65b83a543c0dfe20791196468c830ef0c9fd1f68" ], "author": { "name": "Jeff Yoon", "email": "jeffyoon@google.com", "time": "Mon Feb 12 22:03:33 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 12 22:12:13 2024" }, "message": "[buganizer] Migrate DIR_METADATA in third_party/f*-m*\n\nMigrate all DIR_METADATA in third_party with folders\nfrom f-m.\n\nVerify components with http://b/components/{id} or at\ngo/chrome-on-buganizer-prod-components.\n\nBug: chromium:1518875\nChange-Id: I9d313b9af2ce9b72146f62281627eb0e7132c94d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287876\nReviewed-by: Rick Byers \u003crbyers@chromium.org\u003e\nCommit-Queue: Jeff Yoon \u003cjeffyoon@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1259472}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 61e7ddbbdec6cdc614bce0942805613eda622bc6\n" }, { "commit": "65b83a543c0dfe20791196468c830ef0c9fd1f68", "tree": "b77653bcd2b499e61cc429447139bcc3a2dda68c", "parents": [ "2b908ffdaa77be8dc9a7f515eb1fccd7013ca691" ], "author": { "name": "Owners Cleanup", "email": "swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com", "time": "Sun Feb 11 23:03:46 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Feb 12 00:08:24 2024" }, "message": "Remove rsesek@chromium.org from third_party/ipcz/OWNERS\n\nThis suggested change is automatically generated based on group\nmemberships and affiliations.\nIf this change is unnecessary or in error, vote CR -1 and the bot\nwill abandon it. Vote CR +1/2 to approve this change.\n\nSee the owner\u0027s recent activity for context:\nhttps://chromium-review.googlesource.com/q/rsesek@chromium.org\n\nTo report an issue, file a bug in the Infra\u003eCodereview component.\n\nChange-Id: I3c9c00a7eb0f6ff181ae5395ff40a802bdfabf43\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5284344\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCommit-Queue: Alex Gough \u003cajgo@chromium.org\u003e\nAuto-Submit: Owners Cleanup \u003cswarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com\u003e\nCr-Commit-Position: refs/heads/main@{#1258978}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 3162aed088dca88b68acadc7df2db66cb42b1d62\n" }, { "commit": "2b908ffdaa77be8dc9a7f515eb1fccd7013ca691", "tree": "902778f672cc0307840c1a41ee04e8ee37fa2111", "parents": [ "ca976d89e231b9f6a415a867850266dedab420d7" ], "author": { "name": "Daniel Cheng", "email": "dcheng@chromium.org", "time": "Wed Feb 07 23:01:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 07 23:08:07 2024" }, "message": "Use std::in_place instead of absl::in_place in ipcz multinode_test.cc.\n\nstd::in_place should be used for std::optional. Discovered by building\nwithout GTEST_HAS_ABSL.\n\nBug: 1409870\nChange-Id: I179cddd3bacf2689cedf71cdc9a49f028f5c2bbf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5276445\nCommit-Queue: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Alex Gough \u003cajgo@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1257636}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: babb2a146782d410b17dede32495c0c977472ba6\n" }, { "commit": "ca976d89e231b9f6a415a867850266dedab420d7", "tree": "2631edd19604e0a8de903f125c5020513ae6685e", "parents": [ "e8513e9065283914abc60567d1f6b808a37bacc0" ], "author": { "name": "Peter Boström", "email": "pbos@chromium.org", "time": "Wed Jan 31 20:09:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Jan 31 20:20:10 2024" }, "message": "Fix racy iterator use in Node::AddConnection\n\nBefore this fix an iterator to `connections_` which requires a lock\nwould be dereferenced outside an unlock operation because the `it` taken\nfrom the map isn\u0027t understood as guarded by the same lock.\n\nThis takes a Ref\u003cNodeLink\u003e before unlocking which\u0027ll keep the link\nreference alive even if `connections_` is concurrently modified and the\nentry removed (or replaced).\n\nBug: 1523704\nChange-Id: I6f6fe4e34ec2c8268d4e7f33965a13e3b10f9f92\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254025\nCommit-Queue: Peter Boström \u003cpbos@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@google.com\u003e\nCommit-Queue: Ken Rockot \u003crockot@google.com\u003e\nAuto-Submit: Peter Boström \u003cpbos@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1254709}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 1f2cbf5833d7f00d3fcbfd1f3ef0c1aff10c04cd\n" } ], "next": "e8513e9065283914abc60567d1f6b808a37bacc0" }