)]}' { "log": [ { "commit": "333fcafb91bd3830c5ef814c071ff73df9cdc976", "tree": "4fa7e01be891bb921ea295b6515f2139e0dc20d6", "parents": [ "0928ad0d25e4af07c8be5ab06d0ca584f9f4ceb5" ], "author": { "name": "Jordan", "email": "rop@google.com", "time": "Tue Jan 27 06:24:08 2026" }, "committer": { "name": "Rachael Newitt", "email": "renewitt@google.com", "time": "Tue Jan 27 23:35:21 2026" }, "message": "libunwindstack: Set update mechanism\n\nThis CL sets the Update Mechanism to Manual.\n\nR\u003dqjw@chromium.org\n\nBug: 445311061\nChange-Id: I3b5cce4ced8d01b91c8bc3ede826325d384e86df\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/7509829\nReviewed-by: Jiewei Qian \u003cqjw@chromium.org\u003e\nOwners-Override: Jordan Brown \u003crop@google.com\u003e\nReviewed-by: Patrick Meiring \u003cmeiring@google.com\u003e\n" }, { "commit": "0928ad0d25e4af07c8be5ab06d0ca584f9f4ceb5", "tree": "879576ee603ac579bac0cfc4c9fdbb7f87c4e655", "parents": [ "7b58f22f323600b060d035d985ffe6241b5d7a50" ], "author": { "name": "Matt Stark", "email": "msta@google.com", "time": "Fri Jul 18 05:44:29 2025" }, "committer": { "name": "Thiabaud Engelbrecht", "email": "thiabaud@google.com", "time": "Mon Jul 28 13:16:02 2025" }, "message": "Fix missing include.\n\nBug: 40263312\nChange-Id: Ib5ec860394ddb6d30602eccc61e3a2aa20479060\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6768563\nReviewed-by: Thiabaud Engelbrecht \u003cthiabaud@google.com\u003e\n" }, { "commit": "7b58f22f323600b060d035d985ffe6241b5d7a50", "tree": "74ca9d8d844b164e34220d33a929f40d685eebdf", "parents": [ "68973d9d4690b905cab27a553a0892868b697e4a" ], "author": { "name": "Matt Stark", "email": "msta@google.com", "time": "Tue Jul 08 04:54:53 2025" }, "committer": { "name": "Thiabaud Engelbrecht", "email": "thiabaud@google.com", "time": "Mon Jul 21 13:39:08 2025" }, "message": "Fix a type error when compiling libunwindstack with clang modules.\n\nundef doesn\u0027t work with clang modules, since the macros have been\nprecompiled.\n\nBUG\u003d425527533\n\nChange-Id: Ie985d67a4af833efec301dfa764f7afcbd651d07\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6712955\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Thiabaud Engelbrecht \u003cthiabaud@google.com\u003e\n" }, { "commit": "68973d9d4690b905cab27a553a0892868b697e4a", "tree": "1acd0d01f5739a00d5ffafd6ed56bdfd4557e1d1", "parents": [ "430fc15184ffbb5b22d06009f3b66b525b372c41" ], "author": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Mon Jul 14 14:56:35 2025" }, "committer": { "name": "Devon Loehr", "email": "dloehr@google.com", "time": "Mon Jul 14 15:00:01 2025" }, "message": "Suppress unused thread analysis\n\nThe newest libc++ enables this analysis more broadly if the flag is\npassed. However, it requires annotations to function, which this library\ndoesn\u0027t have. To avoid spurious warnings, just don\u0027t pass the flag.\n\nBug: 430317494\nChange-Id: I8bb6a594234213bf46e85140518c5d532fde6633\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6735002\nReviewed-by: Thiabaud Engelbrecht \u003cthiabaud@google.com\u003e\n" }, { "commit": "430fc15184ffbb5b22d06009f3b66b525b372c41", "tree": "86160972e191080c1a2afe115b9563de4d669d7c", "parents": [ "dcd4e94a65700c4e7e59c365eb98420e2485a9fd" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Jun 30 18:23:13 2025" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Jun 30 18:23:48 2025" }, "message": "Update to new OWNERS\n\nChange-Id: I793f0c12a61194344f385026d4170bb04d217672\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6691217\nReviewed-by: Thiabaud Engelbrecht \u003cthiabaud@google.com\u003e\n" }, { "commit": "dcd4e94a65700c4e7e59c365eb98420e2485a9fd", "tree": "3cbb8375a80970a094d6b22cfe56527d12304d5f", "parents": [ "0d758dd57f42564acecdd7a1e7ac5c8521c1b01a" ], "author": { "name": "Matt Stark", "email": "msta@google.com", "time": "Mon Jun 30 03:08:13 2025" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Jun 30 18:05:34 2025" }, "message": "Add missing includes for system headers\n\nBUG\u003d40263312\n\nChange-Id: Iadaf4c041b4288d48d20c5253b798c05e5adb8a1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6688110\nReviewed-by: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "0d758dd57f42564acecdd7a1e7ac5c8521c1b01a", "tree": "021fb8edfef297bcf47c1b35188c33ed2d9d84c3", "parents": [ "e5061bbda4c2ba6438020669ed06b122032433dd" ], "author": { "name": "Lukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Tue Apr 01 13:44:04 2025" }, "committer": { "name": "Łukasz Anforowicz", "email": "lukasza@chromium.org", "time": "Tue Apr 01 17:39:42 2025" }, "message": "[rust] Use epoch-based path for vendored `rustc-demangle-capi`.\n\nBug: chromium:396397336\nChange-Id: Id93cd16c378c23f55cab8e86f9cb41843a831787\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6421499\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "e5061bbda4c2ba6438020669ed06b122032433dd", "tree": "1ce82afa28c6f7f5c1cd28846f241ff7a99c338b", "parents": [ "c8ff202d9233cc0781715cb87f354045bb0dbee9" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Jan 09 23:53:18 2025" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Jan 10 18:07:53 2025" }, "message": "Fix date format in README.chromium\n\nBug: 365320791\nChange-Id: Ifa99b2142b4a5e66535a9318431f14c30b990aea\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6165687\nReviewed-by: Rodney Ding \u003crodneyding@google.com\u003e\n" }, { "commit": "c8ff202d9233cc0781715cb87f354045bb0dbee9", "tree": "b48a26d4a0d3b0a294362aad67e34592ce7063d1", "parents": [ "215bddfd8eecb7dd990494854a31b70a96d71b3c" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Jan 03 19:04:07 2025" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Jan 03 21:30:46 2025" }, "message": "Add Shipped field to libunwindstack README.chromium\n\nBug: 365320791\nChange-Id: I02566f39f3378f7e521f9b6e74190549f46614e1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6143093\nReviewed-by: Rodney Ding \u003crodneyding@google.com\u003e\n" }, { "commit": "215bddfd8eecb7dd990494854a31b70a96d71b3c", "tree": "78d68f8b9537161fdccbdaf7db9dc4428e64e0b1", "parents": [ "8f9ed31b7d17409b459576245e9ab7ef25223cb9" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Thu Nov 14 05:20:08 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Nov 14 06:14:34 2024" }, "message": "libunwindstack: add missing header for abort()\n\nThis is to fix build error like\nhttps://ci.chromium.org/ui/p/chromium/builders/try/android-x86-rel/465071/overview\n\nBug: 376278210\nChange-Id: Ie6097d655739e64dcd0609c540975d1fea86a5b2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6022039\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "8f9ed31b7d17409b459576245e9ab7ef25223cb9", "tree": "9985fd67ca0611969022201acc1d064507574ca4", "parents": [ "0c3e395835b0f6cb7a77eba94e23e5d8b9659f71" ], "author": { "name": "Mathijs Affourtit", "email": "maffourtit@google.com", "time": "Fri Nov 08 23:05:05 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Nov 11 21:36:53 2024" }, "message": "Handle process_vm_readv availability\n\nHandle the case where process_vm_readv in not availability, given it is gated\non __ANDROID_API__ \u003e\u003d 23 in\nthird_party/android_toolchain/ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/sys/uio.h\n\nBug: 375463618\nChange-Id: I22764d0d934a6e1e4de5d09def2d51cc16cbed04\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/6006275\nReviewed-by: Rodney Ding \u003crodneyding@google.com\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "0c3e395835b0f6cb7a77eba94e23e5d8b9659f71", "tree": "1b40e6a89475834e88b95563bb309da8ce95f48b", "parents": [ "d1e3895ac2af855039873c96dde7688a53cdda69" ], "author": { "name": "Mathijs Affourtit", "email": "maffourtit@google.com", "time": "Tue Nov 05 23:34:19 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Nov 07 17:52:00 2024" }, "message": "Add type cast and fix increment\n\nAdding type cast and fixing index increment, to enable building outside\nof the stack_unwinder DFM, where these are currently causing build\nfailures.\n\nBug:375463618\nChange-Id: I9a2fde1f6d69dea1a47b31875939ed65b40f886c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5994571\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Rodney Ding \u003crodneyding@google.com\u003e\n" }, { "commit": "d1e3895ac2af855039873c96dde7688a53cdda69", "tree": "f3283f88af3cbd487882ac6c99f545cfa8bd5811", "parents": [ "3306808071a2d25b647d944676622bdd9743033e" ], "author": { "name": "Mathijs Affourtit", "email": "maffourtit@google.com", "time": "Thu Oct 31 23:23:30 2024" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Fri Nov 01 09:44:55 2024" }, "message": "Remove static initializers\n\nRemove static initializers, which were added in previous updates, but prevent rolling dependencies into Chromium through a test failure in android-binary-size, which flags a change in static initializers.\n\nBug: 375463618\nChange-Id: I8cafab545469de25b1a28c84eedf335ac06d85e9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5979690\nReviewed-by: Tushar Agarwal \u003cagarwaltushar@google.com\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "3306808071a2d25b647d944676622bdd9743033e", "tree": "14eae2fab3562bdbf5f1d3c0caa122564f1c3bad", "parents": [ "238d2a1dc153aa3bfdf0d9366993349fdb16b45b" ], "author": { "name": "Mathijs Affourtit", "email": "maffourtit@google.com", "time": "Thu Oct 17 20:50:26 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Oct 28 20:21:40 2024" }, "message": "Removing the visibility declaration of libunwindstack\n\nRemoving the visibility declaration of libunwindstack in support of including libunwindstack directly in Chrome rather than through the stack_unwinder DFM.\n\nChange-Id: Id8b2c2cb1d6c91ea1c052ba6df754ba290b52c16\n\nBug: 375463618\nChange-Id: Id8b2c2cb1d6c91ea1c052ba6df754ba290b52c16\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5938542\nReviewed-by: Rodney Ding \u003crodneyding@google.com\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "238d2a1dc153aa3bfdf0d9366993349fdb16b45b", "tree": "e691f5633a989d3333bb8a2c78ae14b434402038", "parents": [ "8ebba220da2a8c4d4fecc18b00d8ac68ce313bed" ], "author": { "name": "Jiewei Qian", "email": "qjw@chromium.org", "time": "Wed Oct 09 05:41:45 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Wed Oct 09 15:30:46 2024" }, "message": "ssci: mark \"Version: N/A\" because this is managed by Revision\n\nVersion field is required, but should be set to N/A if the package\ndoesn\u0027t have a version number based release process.\n\nChange-Id: I1e8e1e0f5ed8469b41a250d141237d604081c806\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5918948\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "8ebba220da2a8c4d4fecc18b00d8ac68ce313bed", "tree": "523c019cc5148e599a1c5d7cb40fc9b40c6a1ddd", "parents": [ "d2089088078afca176d27661631b336bd631e901" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed Jun 05 05:45:33 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Wed Jun 05 15:20:11 2024" }, "message": "remove references to goma\n\ngoma is not maintained anymore.\n\nBug: 41489832\nChange-Id: I3e287cd9ac547fe1df93dc21e39db8b8f1f56eff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5599420\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "d2089088078afca176d27661631b336bd631e901", "tree": "09455e2e0d6693ad5e998224c56ea6a037b9a60f", "parents": [ "9d89db43ee7fbbde27cc893c6b3e4c3610930d0f" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Mon Apr 08 09:59:38 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Apr 08 17:00:47 2024" }, "message": "Add two more patches for `third_party/libunwindstack`.\n\nThese patches are required to build successfully with Chromium.\n\nBug: b/322755603\nChange-Id: Ib3663810752bb4c740d93d3424cffedda47ef117\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5431956\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "9d89db43ee7fbbde27cc893c6b3e4c3610930d0f", "tree": "f62a32dae4fd5006c765bd613a367559cf868131", "parents": [ "897158be4c1730b261e92f9af11103db929df33e" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Thu Apr 04 10:01:48 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Apr 04 17:17:46 2024" }, "message": "Remove `MIPS`-related headers that are no longer a part of the updated\nversion of `libunwindstack`.\n\nBug: b/322755603\nChange-Id: I25e4d4fa0b9659d268bcaa0c2ffc0b2b8bfeaaef\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5419131\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "897158be4c1730b261e92f9af11103db929df33e", "tree": "f5a0b057834d77c8ed5ac1fef5ab3b7250e61c9c", "parents": [ "8d7130512499b7326da6106d089c741b3e7a5d83" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Wed Apr 03 13:48:56 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Wed Apr 03 17:47:01 2024" }, "message": "Update dependencies in `third_party/libunwindstack`.\n\nThis is a bug-fix follow-up to https://crrev.com/c/5290878.\n\nBug: b/322755603\nChange-Id: Idb7ad735a8e8700e7fc1462cb54a63d171b0edb1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5419436\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "8d7130512499b7326da6106d089c741b3e7a5d83", "tree": "cefd710d5ffa3e291894d66e76287f31f45e168a", "parents": [ "656435f8a8d91358d5396b57153d3c0a88a5bcde" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Wed Feb 14 19:12:41 2024" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Wed Feb 14 19:18:52 2024" }, "message": "Update `third_party/libunwindstack` to cleanly build with Chromium.\n\nTo do this, various patches have been updated, and new patches have been\nadded. The code changes in this CL can be reproduced solely by applying\nall the patches in `patches/` in turn.\n\nAlso updates `README.chromium` file with details about these new\npatches, and minor formatting changes/typo fixes.\n\nBug: b/322755603\nChange-Id: I70e687f4fd8f92cefc395f04f4303a138515974c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5290879\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "656435f8a8d91358d5396b57153d3c0a88a5bcde", "tree": "b3128b1169b9616a70af33215ea789aa63b34f87", "parents": [ "369f6e12026f707bc75d9dacdfa45561f29d393f" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Wed Feb 14 11:27:13 2024" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Wed Feb 14 18:05:37 2024" }, "message": "Update dependencies in `third_party/libunwindstack`.\n\nThis is a follow-up to https://crrev.com/c/5286276, and a precursor to\nfuture CLs which will update patches and libunwindstack in Chromium to\nmake it build and run successfully.\n\nBug: b/322755603\nChange-Id: Ic034ffc74b17d1fa031a208549ba515c302d6f0f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5290878\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "369f6e12026f707bc75d9dacdfa45561f29d393f", "tree": "93e9f48e95848f1ab8aa1a78fe724469e6d77e66", "parents": [ "a3bb4cd02e0e984a235069f812cbef2b37c389e5" ], "author": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Mon Feb 12 15:15:27 2024" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Tue Feb 13 09:22:09 2024" }, "message": "Update `third_party/libunwindstack` from Android ToT.\n\nThis (most likely) leaves libunwindstack in a non-buildable state in\nChromium. Future CLs will update patches and libunwindstack in Chromium\nto make it build and run successfully.\n\nAlso make a couple of updates/minor fixes to the README file.\n\nBug: 322755603\nChange-Id: I5454151d63bdb138ef984520784759ac3822eff5\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5286276\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "a3bb4cd02e0e984a235069f812cbef2b37c389e5", "tree": "01b7834ee05a0efef09d5e0dfec1a59032d873b7", "parents": [ "4dbfa0e8c844c8e243b297bc185e54a99ff94f9e" ], "author": { "name": "Hans Wennborg", "email": "hans@chromium.org", "time": "Fri Jan 19 15:08:18 2024" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Jan 19 16:46:21 2024" }, "message": "Fix \u0027Filter\u0027 function shadowing its own template parameter\n\nRecent Clang versions will error about this, see\nhttps://github.com/llvm/llvm-project/pull/78274\n\nBug: chromium:1519481\nChange-Id: I6482153027a519d5765b9249a262cded3dcae09e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/5217531\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "4dbfa0e8c844c8e243b297bc185e54a99ff94f9e", "tree": "a73ff8b6a4825d28d6e41c8dbe9d58dc3ce9e7ae", "parents": [ "8740b09bd1f8b81bdba92766afcb9df1d6a1f14e" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 14 21:09:39 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Oct 14 21:20:22 2022" }, "message": "Fix compile in C++20 mode.\n\nBug: chromium:1284275\nChange-Id: I9455b0f874475af83e8f8aca3404e8c84b8c51d7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3957615\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "8740b09bd1f8b81bdba92766afcb9df1d6a1f14e", "tree": "daf4cec579161ed505231182285c655f5dba14e9", "parents": [ "6c228114e73500a6f319e6a5b6559c754e05a10b" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Tue Oct 11 09:48:10 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue Oct 11 13:46:34 2022" }, "message": "Do not redefine ADDRESS_SANITIZER macro\n\nThe roll of libdexfile changes into Chromium was revereted due\nto compiler error - https://crrev.com/c/3944051\nChromium asan build already defines the macro.\n\nTest:\n - Build `chrome_modern_public_bundle` with `is_asan\u003dtrue`\n\nBug: 1365904\nChange-Id: I24ce801ebf33431e2d400e902b142382ff4a74f8\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3945029\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "6c228114e73500a6f319e6a5b6559c754e05a10b", "tree": "1ed2866a1249106f1ae5c905596ec88ebd937a5c", "parents": [ "1ac11f3cff728a7aca0de06edbebf1f2efff9771" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Mon Oct 10 19:12:16 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Oct 10 19:19:14 2022" }, "message": "Move class static variables to function static\n\nChrome bans use of static initializers. As a result we can\u0027t roll\nlibdexfile changes into Chromium.\nThis CL moves static class members DexFile::g_lock and\nDexFile::g_mapped_dex_files into the static function\nDexFile::CreateFromDisk(the only user of those\nstatic class members).\n\nTest:\n - Build `chrome/android:monochrome_static_initializers` successfully\n https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/static_initializers.md#step-1-use-objdump-to-report-them\n\nBug: 1365904\nChange-Id: Ibfe96c18e1747c2483db0b2f0a39b4918c809298\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3942065\nReviewed-by: Tushar Agarwal \u003cagarwaltushar@google.com\u003e\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "1ac11f3cff728a7aca0de06edbebf1f2efff9771", "tree": "b2a305f0514f2cdc93fb2e8dae94a2f072f0132a", "parents": [ "1dc40342f68b757e8c4dfb062f8378ab3c72f8ed" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Thu Sep 29 22:02:52 2022" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Fri Sep 30 09:41:32 2022" }, "message": "Add patches to build libunwindstack with libdexfile\n\nThe parent CL pulls in libdexfile and its dependencies into Chromium.\nThis CL adds patches required to make libdexfile compile in Chromium.\n\nBug: 1365904\nChange-Id: I216e978e4906b42ad06205c7d75aec5032180555\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3913230\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "1dc40342f68b757e8c4dfb062f8378ab3c72f8ed", "tree": "257f95be51da577862bcdbc6c474289de4f00930", "parents": [ "e184bd94bf23148bf5f3a983f9d740ddb86fd46e" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Thu Sep 29 21:47:38 2022" }, "committer": { "name": "Tushar Agarwal", "email": "agarwaltushar@google.com", "time": "Fri Sep 30 09:40:04 2022" }, "message": "Pull libdexfile in chromium\n\nPull in libdexfile from Android. It is used by libunwindstack to get\nfunction names for interpreted java names.\nDefines two compile flags required to compile libunwindstack with libdexfile.\n`DEXFILE_SUPPORT` - To use libdexfile apis in libunwindstack.\n`STATIC_LIB` - To compile libunwindstack statically with libdexfile.\n In Android libdexfile is a shared library provided by platform and\n libunwindstack in Android is built without this flag.\n\nBug: 1365904\nChange-Id: Ia01ea81ae877c39e12f17cae71b9255c31eaf981\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3913229\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "e184bd94bf23148bf5f3a983f9d740ddb86fd46e", "tree": "4fe76b7c8fb3e661483543c4bfc8ef126f024f0a", "parents": [ "3796f6e5adc4593bc55ddde19ab2c8fb404e362d" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Fri Sep 23 18:30:43 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Sep 23 18:50:51 2022" }, "message": "Add posix_strerror_r.cpp to libbase\n\nandroid_compile_dbg try build bot is failing with linker error.\n```\nld.lld: error: undefined symbol: posix_strerror_r\n\u003e\u003e\u003e referenced by strings.cpp\n```\nAdd posix_strerror_r.cpp which contains definition for symbol.\n\nBug: 1140633\nChange-Id: Icdf5b6b513d9dc68a13e0bac53513ff75c574e61\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3904551\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "3796f6e5adc4593bc55ddde19ab2c8fb404e362d", "tree": "bdaa320edc7485fd88ff2b6651e214abfaf0ba2f", "parents": [ "53d2d81d7c4261b565661677563943e40635fac2" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Mon Sep 19 16:14:11 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Sep 19 18:18:20 2022" }, "message": "Remove redundant semicolon\n\nAdd and apply patch to remove redundant semicolon. Chrome builds with\n`-Wextra-semi`, redundant semicolons need to be removed to build it\nsuccessfully.\n\nBug: 1140633\nChange-Id: I77caa49f920c8ff15af5f17b065f6bd97e5e8c5e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3904325\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "53d2d81d7c4261b565661677563943e40635fac2", "tree": "9fcfbd91faf76f0c8f76a2b91d130bae93970b77", "parents": [ "986a754183a73600a8638fc1c83d308059a9f835" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Fri Sep 16 19:40:29 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Sep 16 21:06:49 2022" }, "message": "Update and apply patches to compile libunwindstack\n\nThis CL adds new patches required to make the latest libunwindstack\ncompile and applies all the patches on top of latest libunwindstack pull\nin parent change.\n\nBug: 1140633\nChange-Id: Ia94fb408c1827663295242b8483fad1bd5a78172\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3879628\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "986a754183a73600a8638fc1c83d308059a9f835", "tree": "1373781aca53acd25a92354f5d0421067b74d92d", "parents": [ "6d27bc9cc93081b7dac78c7ff63a5c151ecab3ae" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Thu Sep 15 20:37:40 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Sep 16 21:06:06 2022" }, "message": "Pull upstream platform/system/unwinding e9e82f6218611da15f4fc3023dacb5f6ce57f9f8\n\nThis CL pulls in latest libunwindstack from upstream. We would just have\nvanilla libunwindstack after this and hence the code is not expected to\ncompile. A follow up change updates and applies the patches required to\nmake it compile.\nSince the last pull upstream has changed(a lot):\n- libunwindstack moved from system/core to system/libunwindstack.\n- Dependencies come from multiple AOSP upstream repositories, instead of\n coming from just system/core.\n - libprocinfo: system/libprocinfo\n - libbase: system/libbase\nJust the required files are kept rest are deleted as per update steps\nmentioned in README.chromium\n\nBug: 1140633\nChange-Id: I8ad4513bf463b959f31085f20a0a83d310cbb350\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3879627\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "6d27bc9cc93081b7dac78c7ff63a5c151ecab3ae", "tree": "4e027b876fae8a21372a7c3621d4e5f5c01d83e5", "parents": [ "3c86843ae0f8d560ae0d15b92e34ce88cf83057a" ], "author": { "name": "Kartar Singh", "email": "kartarsingh@google.com", "time": "Thu Sep 08 13:41:09 2022" }, "committer": { "name": "Stephen Nusko", "email": "nuskos@chromium.org", "time": "Tue Sep 13 10:26:09 2022" }, "message": "Remove obsolete patches after NDK updated to r23\n\nSome of the patches are not required as currently we are using Android\nNDK 23 in Chromium.\n\nTest(compilation):\n 1) Reverse apply the obsolete patches\n patch -R -p1 \u003c patches/0002-disable-ftw.patch\n patch -R -p1 \u003c patches/0004-gnu-basename.patch\n patch -R -p1 \u003c patches/0006-memory-process-vm-readv.patch\n 2) Build `chrome_modern_public_bundle` successfully\n\nBug: 1140633\nChange-Id: I24f0205c7e8fdfd2e0dc2e7db8297ea2560f3e1e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3876186\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "3c86843ae0f8d560ae0d15b92e34ce88cf83057a", "tree": "df8ee22422556728b8c2e3ae077634ddef593b38", "parents": [ "6868358481bb1e5e20d155c1084dc436c88b5e6b" ], "author": { "name": "Alan Zhao", "email": "ayzhao@google.com", "time": "Wed May 11 03:01:06 2022" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Wed May 11 18:06:50 2022" }, "message": "Remove usages of std::iterator in libunwindstack\n\nstd::iterator is deprecated in C++17, and it\u0027s presence in\nlibunwindstack is blocking upgrading libc++ in Chrome (since Chrome\nbuilds with -Wdeprecated and -Werror).\n\nBug: chromium:1273285\nChange-Id: I0e3ec4dcc109262b0ed95467d426441a6903e801\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3638767\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "6868358481bb1e5e20d155c1084dc436c88b5e6b", "tree": "783089ea39cc34a3e601f8e6a529e1e6a806af75", "parents": [ "c3bcafd9fcec4203a4217a0ea390123656c85fbc" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 08 19:57:01 2021" }, "committer": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 08 20:16:25 2021" }, "message": "Fix syntax error :(\n\nBug: 1243777\nChange-Id: I38ade8427645e484c4df2ec489b1ee017b305a70\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3214697\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "c3bcafd9fcec4203a4217a0ea390123656c85fbc", "tree": "94b27c9b3012dd7de7d9e3caa0816f4f83a82321", "parents": [ "730e1560b9c5ce7173e77bb9818269179e83ce47" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 08 15:28:12 2021" }, "committer": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Fri Oct 08 18:27:18 2021" }, "message": "Switch warnings to a config in hopes it will override chromium_code.\n\nBug: chromium:794619, chromium:1203071\nChange-Id: Ia223679c75c1dd1bed3c1f547fd8f8ab91c74397\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3213959\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "730e1560b9c5ce7173e77bb9818269179e83ce47", "tree": "d340157255a3ddac20c38f042a49d7381d9a1344", "parents": [ "b34a0059a648f179ef05da2c0927f564bdaea2b3" ], "author": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Tue Oct 05 17:43:42 2021" }, "committer": { "name": "Peter Kasting", "email": "pkasting@chromium.org", "time": "Tue Oct 05 18:36:31 2021" }, "message": "Disable various warnings.\n\nBug: chromium:794619, chromium:1203071\nChange-Id: Ifc45a0759c8728d50943551c231ecd74fbe5f1dc\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3206283\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "b34a0059a648f179ef05da2c0927f564bdaea2b3", "tree": "42010d49b8f5aa9a53ef8bdee3db4ae500ef3775", "parents": [ "8c06e391ab8ee01828a55477f09e7cff26182174" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Fri Jul 02 09:23:04 2021" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Fri Jul 02 16:08:52 2021" }, "message": "Revert to the upstream\u0027s ElfInterface.cpp.\n\nThis file previously needed local modifications to compile in Chromium\non account of Chromium using lzma_sdk 15.14. Chromium now uses 19.00 as\nof r898074, so these modifications are no longer needed.\n\nBug: 1224596\nChange-Id: Ie76f6365fe51d457d8be593dd9725ef380213765\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/3000749\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "8c06e391ab8ee01828a55477f09e7cff26182174", "tree": "58b4692e658f0cfa0c9f0d8e2644697acd70f653", "parents": [ "aab2c874731396232739889ebe8d9e122b9bc448" ], "author": { "name": "Greg Thompson", "email": "grt@chromium.org", "time": "Wed Jun 30 12:48:05 2021" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Jul 01 19:27:18 2021" }, "message": "Make LZMA SDK compatibility shims conditional on the version of the SDK.\n\nShims were previously introduced because Chromium\u0027s LZMA SDK is behind\nAndroid\u0027s. In this CL, we revise the shims so that they are conditional\nbased on the LZMA SDK version in use. This should allow us to update\nChromium\u0027s LZMA SDK. Ideally, these shims can be removed after Chromium\nis updated.\n\nBug: 1224596\nChange-Id: I4a28edb0033be4c0f2db5b9c00dcb65f7694b9be\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2996428\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nBot-Commit: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "aab2c874731396232739889ebe8d9e122b9bc448", "tree": "cb7b0a22a3cec8c859f322f63d9f9f90eace5ee9", "parents": [ "6f76f0c79efb71671c3b30fea04bca2b91a50a4e" ], "author": { "name": "Gabor Kertesz", "email": "gabor.kertesz@arm.com", "time": "Wed Mar 10 10:30:08 2021" }, "committer": { "name": "Richard Townsend", "email": "richard.townsend@arm.com", "time": "Wed Mar 17 11:39:23 2021" }, "message": "Change to user header inclusion\n\nBuild system uses \u0027-MMD\u0027 flag which creates depfiles\ncontaining user headers only.\nMarking libunwindstack\u0027s header files as system headers results\nthat depfiles are missing libunwindstacks include files.\nThis is the root cause of failing and inconsistent incremental builds.\n\nAs an example DwarfEhFrameWithHdr.o was checked by \u0027ninja -t deps\u0027\nUsing \u0027-isystem\u0027 -\u003e 4 deps\nUsing \u0027-I\u0027 -\u003e 11 deps\n\nChange-Id: Ib9ee49899b44b4012e2e5335e8c85b5f919ad31f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2749594\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "6f76f0c79efb71671c3b30fea04bca2b91a50a4e", "tree": "13cd9e2d05f4584bbd981b81bc2636bb4f908360", "parents": [ "f27360abdc494c8a8a713c25f49f055b248e4bce" ], "author": { "name": "Gabor Kertesz", "email": "gabor.kertesz@arm.com", "time": "Tue Mar 16 09:03:09 2021" }, "committer": { "name": "Richard Townsend", "email": "richard.townsend@arm.com", "time": "Tue Mar 16 10:34:11 2021" }, "message": "Revert \"Include DwarfSection.h header for GN\"\n\nThis reverts commit f27360abdc494c8a8a713c25f49f055b248e4bce.\n\nReason for revert: This change is a work-around, proper fix will be submitted.\n\nOriginal change\u0027s description:\n\u003e Include DwarfSection.h header for GN\n\u003e\n\u003e The following files were changed by\n\u003e 640c1c67586da8eff72cf62fa64cad2f1d1cbc1e:\n\u003e\n\u003e src/libunwindstack/DwarfCfa.h\n\u003e src/libunwindstack/DwarfCfa.cpp\n\u003e src/libunwindstack/DwarfSection.cpp\n\u003e src/libunwindstack/include/unwindstack/DwarfLocation.h\n\u003e src/libunwindstack/include/unwindstack/DwarfSection.h\n\u003e src/libunwindstack/include/unwindstack/MachineArm64.h\n\u003e src/libunwindstack/include/unwindstack/Regs.h\n\u003e src/libunwindstack/include/unwindstack/RegsArm64.h\n\u003e src/libunwindstack/RegsArm64.cpp\n\u003e\n\u003e DwarfEhFrameWithHdr.h includes \u003cunwindstack/DwarfSection.h\u003e and that\n\u003e header is changed, but DwarfEhFrameWithHdr.o is not regenerated during\n\u003e an incremental rebuild and can result in an incremental build error.\n\u003e Manually updating DwarfEhFrameWithHdr\u0027s modification time via touch\n\u003e results in a successful incremental build.\n\u003e\n\u003e This change triggers GN to resolve that dependency.\n\u003e\n\u003e Change-Id: I530b8e7a337ec8b80be27dc5d53972d0ff3aa23d\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2732393\n\u003e Reviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n\nChange-Id: I8f56d395c2d019d99e09188cb50995cfb286e6c3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2762925\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n" }, { "commit": "f27360abdc494c8a8a713c25f49f055b248e4bce", "tree": "5c075a9cdc08b0d23ec4be2edfac594eb6037a4c", "parents": [ "640c1c67586da8eff72cf62fa64cad2f1d1cbc1e" ], "author": { "name": "Gabor Kertesz", "email": "gabor.kertesz@arm.com", "time": "Wed Mar 03 19:03:05 2021" }, "committer": { "name": "Richard Townsend", "email": "richard.townsend@arm.com", "time": "Thu Mar 04 22:51:13 2021" }, "message": "Include DwarfSection.h header for GN\n\nThe following files were changed by\n640c1c67586da8eff72cf62fa64cad2f1d1cbc1e:\n\nsrc/libunwindstack/DwarfCfa.h\nsrc/libunwindstack/DwarfCfa.cpp\nsrc/libunwindstack/DwarfSection.cpp\nsrc/libunwindstack/include/unwindstack/DwarfLocation.h\nsrc/libunwindstack/include/unwindstack/DwarfSection.h\nsrc/libunwindstack/include/unwindstack/MachineArm64.h\nsrc/libunwindstack/include/unwindstack/Regs.h\nsrc/libunwindstack/include/unwindstack/RegsArm64.h\nsrc/libunwindstack/RegsArm64.cpp\n\nDwarfEhFrameWithHdr.h includes \u003cunwindstack/DwarfSection.h\u003e and that\nheader is changed, but DwarfEhFrameWithHdr.o is not regenerated during\nan incremental rebuild and can result in an incremental build error.\nManually updating DwarfEhFrameWithHdr\u0027s modification time via touch\nresults in a successful incremental build.\n\nThis change triggers GN to resolve that dependency.\n\nChange-Id: I530b8e7a337ec8b80be27dc5d53972d0ff3aa23d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2732393\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "640c1c67586da8eff72cf62fa64cad2f1d1cbc1e", "tree": "13cd9e2d05f4584bbd981b81bc2636bb4f908360", "parents": [ "4122878323de0f8464fdb9a0eb79d4e931da9812" ], "author": { "name": "Gabor Kertesz", "email": "gabor.kertesz@arm.com", "time": "Tue Feb 16 15:51:29 2021" }, "committer": { "name": "Richard Townsend", "email": "richard.townsend@arm.com", "time": "Tue Mar 02 14:27:59 2021" }, "message": "Add support for Armv8.3-A Pointer Authentication\n\nThis patch cherry-picks the following patches for Armv8.3 PAC\nextension compatibility.\n\nThese have been merged to Android\u0027s libunwindstack:\nhttps://android-review.googlesource.com/c/platform/system/core/+/1215022\nhttps://android-review.googlesource.com/c/platform/system/core/+/1403667\n\nChange-Id: I31bfa9219c2d05e8d2e176a02688afa693b69260\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2727280\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "4122878323de0f8464fdb9a0eb79d4e931da9812", "tree": "2c31aa3d39a86a9cd7040e9ebc28c4144bfc5e45", "parents": [ "11659d420a71e7323b379ea8781f07c6f384bc7e" ], "author": { "name": "Josip Sokcevic", "email": "sokcevic@google.com", "time": "Wed Feb 03 22:41:01 2021" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Thu Feb 04 21:51:12 2021" }, "message": "Move metadata in OWNERS files to DIR_METADATA files\n\nBug: 1113033\nChange-Id: I3bbd39fb930a7fe279fd5c1a0e80aed46d0dd42d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2674077\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "11659d420a71e7323b379ea8781f07c6f384bc7e", "tree": "d0912a8de1d44deeee81d5cd63ec5fa90affe0df", "parents": [ "66f6d83ffb4e7d67322c6cbdfbd0ab358f6f9a36" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Jun 15 17:33:23 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue Jun 16 21:37:05 2020" }, "message": "Make new upstream version build with Chrome\n\nUpdates patches to apply cleanly and reworks patches to file.cpp to reduce\nthe chance of conflicts. Adds a patch to expose a creation function for\nMemoryLocal since this type has moved into a private header.\n\nBug: 1004855\nChange-Id: Ibb5fc5858bbd0e8f31fd3a723abd94a24847e72b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2246326\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "66f6d83ffb4e7d67322c6cbdfbd0ab358f6f9a36", "tree": "5aca8d10651e6795de49f40b1949dfa00eb61e39", "parents": [ "85b685129f83b1e81751f5a3cf8d81a3974719a3" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Mon Jun 15 17:32:48 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue Jun 16 21:36:03 2020" }, "message": "Update to upstream a7b4c5d25aeb\n\nUpdates to pick up a build id off-by-one bug fix upstream. Previously\nthe build ids returned by libunwindstack were missing the final byte.\n\nWe update to the commit with the bug fix rather than latest to defer\npicking up an upstream change that moves android-base into a separate\nrepository. That will require additional tooling changes beyond the ones\nwe\u0027ve already had to make to for this update.\n\nThis CL contains upstream changes for just the files required to build\nlibunwindstack within Chrome.\n\nBug: 1004855\nChange-Id: Ic4a6d2d3efefd7c9fd2a264b95eb2cf29358336d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2246325\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "85b685129f83b1e81751f5a3cf8d81a3974719a3", "tree": "7d0f211f795962f7c7c8d0daa771cd33d7b58295", "parents": [ "046920fc491aba67c6f6a750b4be7b835cff4e5b" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue Jun 16 21:33:57 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue Jun 16 21:35:24 2020" }, "message": "Streamline update process\n\nHalves the number of steps required to update libunwindstack and\nexplicitly describes how to do the update at the command level.\n\nUpdates tools/copy_libunwindstack_sources.py to allow a commit to be\nspecified in addition to a tag.\n\nRemoves tools/apply_patches.py since the patches need to be applied\nmanually to account for conflicts.\n\nReplaces tools/sources.py with tools/get_required_sources.sh. The shell\nversion is more concise, easier to tweak to account for upstream\nchanges, and accounts for dependencies resulting from angle bracket\nincludes.\n\nBug: 1004855\nChange-Id: I6eb5e6eb2e683d6d48622d3effb13891ddcf5637\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2246324\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "046920fc491aba67c6f6a750b4be7b835cff4e5b", "tree": "c75ce7de84d5696ee5192e859645487a6abc6c84", "parents": [ "de5bb5ebd6d792a622646abde269608fd7e44179" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue May 26 16:24:52 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue May 26 20:38:28 2020" }, "message": "[Sampling profiler] Fix AsmRegs build logic for cross-compilation\n\nmonochrome_32_public_bundle cross-compiles libunwindstack for x86, so we\nneed to check current_cpu rather than target_cpu in the build, per\nhttps://gn.googlesource.com/gn/+/master/docs/cross_compiles.md#as-a-build_gn-author\n\nBug: 1004855\nChange-Id: I2abdcc17084a37128e4146c9288546f233a66128\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2213215\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "de5bb5ebd6d792a622646abde269608fd7e44179", "tree": "8daa6c6427bba6b3f477772229cce9f4337f8444", "parents": [ "dfd3f3d84cfc222af93bc86b276414fc690977da" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue May 19 22:38:26 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Wed May 20 16:13:44 2020" }, "message": "[Sampling profiler] Include AsmGetRegs asm functions on x86/x64\n\nThe AsmGetRegsX86.S/AsmGetRegsX86_64.S files are required to link\nlibunwindstack on x86/x64. These are pulled from android-q-preview-6,\nthe tag referenced in the README.chromium.\n\nBug: 1004855\nChange-Id: Idd578ae49eab808fef575f5d270b67e2888c4174\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2209311\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "dfd3f3d84cfc222af93bc86b276414fc690977da", "tree": "02650e286c6c51f779275ff5ee02202e19a0ca8c", "parents": [ "acf93761dc00ac67bd7534c4040699abed4f8d94" ], "author": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Sat May 16 00:14:17 2020" }, "committer": { "name": "Mike Wittman", "email": "wittman@chromium.org", "time": "Tue May 19 17:03:13 2020" }, "message": "[Sampling profiler] Add include dir to public config\n\nUsers of the target need to include its headers, and those headers\ntransitively include other headers within the target using angle\nbrackets. So it\u0027s necessary to provide a public config that adds the\ninclude dir to the system include path. This is modeled after Perfetto\u0027s\nconfig in //third_party/perfetto/buildtools/BUILD.gn, but without the\nparts we don\u0027t need.\n\nThis change also moves the NO_LIBDEXFILE_SUPPORT into the public config.\nThis is required for ODR compliance since the define is used to\nconditionally include code/declarations across both headers and cc\nfiles.\n\nBug: 1083530\nChange-Id: I6700324fdae4909dd1df7eb6a99d3adeba99ecd1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2204482\nReviewed-by: Etienne Pierre-Doray \u003cetiennep@chromium.org\u003e\n" }, { "commit": "acf93761dc00ac67bd7534c4040699abed4f8d94", "tree": "6a0856b742614ccacd27bc56ce07c3ee5c876e63", "parents": [ "e9a333406ef5b520d85bac5267c799de29233a84" ], "author": { "name": "Etienne Pierre-doray", "email": "etiennep@chromium.org", "time": "Wed Feb 19 21:38:02 2020" }, "committer": { "name": "Etienne Pierre-Doray", "email": "etiennep@chromium.org", "time": "Wed Feb 19 21:39:42 2020" }, "message": "[Clank SSM]: Update BUILD visibility and cflags.\n\nThis CL adds visibility for base:base_stack_unwinder_feature\nand cflags -Wno-c99-designator.\nNecessary for https://chromium-review.googlesource.com/c/chromium/src/+/2055743\nto compile.\n\nBug: 989103\nChange-Id: Ied071ca69be1015ac6ef6347df2c1f91e9055ba3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/2063864\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "e9a333406ef5b520d85bac5267c799de29233a84", "tree": "e2844c91598b54c49551afb177b95572cdf8ed38", "parents": [ "e5f2cb938311770a52e9ee9898a7f0963dfcef78" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Nov 05 18:39:52 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Nov 05 18:41:17 2019" }, "message": "Add sources.py `prune` subcommand to prune unrequired sources\n\nThis command should make it easier to prune unrequired sources after\ncopying a new version of libunwindstack and required subfolders into the\nsrc/ directory.\n\nAfter writing this command, I then ran it, which removed parseint.h.\nThis file was required by logging.cpp, which was in my original local\ncompiling version of libunwindstack but was later removed from the\nlibrary via a patch.\n\nBug: 991960\nChange-Id: I422caf2c386aadbd046caced3d1dfef6a389e74d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1900012\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "e5f2cb938311770a52e9ee9898a7f0963dfcef78", "tree": "15e57c1710d47761182a04b3a813fd2d78d385da", "parents": [ "af8812bc17cba3f3f57ef4a0a158508cfb8f3997" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Nov 05 17:23:24 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Nov 05 17:29:38 2019" }, "message": "Fixes a bug causing sources to appear multiple times in sources.py\n\nThis bug occurred because we were:\n\n1) Concatenating all of the .o.d Makefiles together that were required\n to compile libunwindstack.\n2) Finding unique lines among those files\n3) Extracting the source file path from each of those lines.\n\nThe problem was with the format of each build rule in the .o.d file:\n\nout/DefaultMobile/my_target.o:\n a.cpp \\\n b.cpp \\\n c.cpp\n\nIf a source file was the last file for one build rule but not the last\nfor another, then both would make it through our unique filter because\none of those lines would have a trailing backslash but the other\nwouldn\u0027t.\n\nThis fixes that bug by extracting the source file path before\nidentifying unique sources.\n\nBug: 991960\nChange-Id: I417d2c0682891dd86fc5f7fd13c544d971af653d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1900008\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "af8812bc17cba3f3f57ef4a0a158508cfb8f3997", "tree": "5434040cc301faf9d069bfbf1c44645817dc9596", "parents": [ "42c8c62f292a4f43f2dfa17626cc857a1eea29ef" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Fri Nov 01 19:11:33 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Fri Nov 01 20:02:45 2019" }, "message": "Create a tool to list source file dependencies for libunwindstack\n\nThe output format of this tool is the same as the \"sources \u003d [ ... ]\"\nformat used by GN. The tool is helpful because otherwise it\u0027s very\ndifficult to determine the full list of header files needed by\nlibunwindstack to compile: the compilation will succeed even if those\nheader files aren\u0027t listed in the sources list.\n\nIn a follow-up CL, I\u0027m planning to split this tool out into two\nsubcommands: `print` (which is the tool implemented in this CL) and\n`prune`, which deletes source files in the src/ directory that aren\u0027t\nrequired to compile.\n\nBug: 991960\nChange-Id: Ibdcfbc10dc7f37908139658dc8c90b6b71cd2d1b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1893329\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "42c8c62f292a4f43f2dfa17626cc857a1eea29ef", "tree": "4fc7d306a07311f5d6950b952c88faea84f59e62", "parents": [ "cbfc3dfaf7204086ae0b96bf7693aa858377480b" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 21:05:40 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 21:10:51 2019" }, "message": "Uses syscall() to call process_vm_readv in Memory.cpp\n\nThe process_vm_readv() function isn\u0027t available in Android NDK 16 (it\nwas first made available in 23, as per https://bit.ly/3412rb7). The\nsyscall() version was already available, as per https://bit.ly/32Tnyvy.\n\nAfter this CL, third_party/libunwindstack:libunwindstack compiles! \\o/\n\nBug: 991960\nChange-Id: I87bde60511ab15934d7b4d3cdf054e1a4484500b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1876906\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "cbfc3dfaf7204086ae0b96bf7693aa858377480b", "tree": "9af172f4aad7a2faffd373fec7d32908d1865333", "parents": [ "5e7475fb0c2e2529017e4f5dc3dd43caf048415b" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 20:59:16 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 21:01:25 2019" }, "message": "Change src/compat/ \u003d\u003e src/compat/compat/ in BUILD.gn file\n\nI compiled before submitting, but my checkout must have somehow (?)\ngotten into a bad state where the compilation didn\u0027t fail because of\nthis. I did notice it after syncing a few CLs down the line, though.\n\nBug: 991960\nChange-Id: Ica4e2bcf1973ada598a9dde1bea3be6181eea1a9\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1876902\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "5e7475fb0c2e2529017e4f5dc3dd43caf048415b", "tree": "2946c96d03f54de92d1f64b32688eea46197cd98", "parents": [ "da85bacd752bada4cfb3f028a1ce6bc04367fede" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 20:48:45 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 20:49:24 2019" }, "message": "Disable fdsan in android-base/unique_fd.h\n\nfdsan isn\u0027t available in Android NDK version 16 (it was first made\navailable in 29, as per https://bit.ly/2W4II7E).\n\nBug: 991960\nChange-Id: I83f96fb9f0ceadc93b728b907e7e3b7427973991\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1876892\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "da85bacd752bada4cfb3f028a1ce6bc04367fede", "tree": "607b96d29012fe889766f7c8e46875f275d486e2", "parents": [ "72ad10fb3dd1f01300c7a1018704c66e82621707" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 20:40:48 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 23 20:42:09 2019" }, "message": "Implements a non-modifying GNU basename() function for libunwindstack\n\nThis function is added in compat.h, which provides functions that are\navailable within libunwindstack\u0027s normal build environment but\nunavailable within its Chromium build environment. We call the\nfunction \"compat_basename\".\n\nThis function isn\u0027t available in Android NDK version 16 (it was first\nmade available in 23, as per https://bit.ly/31Gkyl9). Although there\u0027s a\nPOSIX basename() available via \u003clibgen.h\u003e, this function has different\nbehavior with regards to trailing slashes and can also modify its\nargument under some circumstances.\n\nBug: 991960\nChange-Id: I876d13d8e3c1797705c34c6d85ad663e2848f410\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1875324\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "72ad10fb3dd1f01300c7a1018704c66e82621707", "tree": "c34ae34acaba74d7168d8656823c0532ffd82f5f", "parents": [ "dbd29d6e2d1d961b09d664b299bf2cbe3d3ccbb3" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Mon Oct 21 21:11:16 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Oct 22 14:14:22 2019" }, "message": "Removes all instances of PLOG() from android-base/file.cpp\n\nThis allows us to remove the dependency on android-base/logging.cpp.\nlogging.cpp is problematic because it attempts to use BSD\u0027s\ngetprogname(), which wasn\u0027t introduced to Android until NDK version 21\n(http://bit.ly/2nX0nBs).\n\nNote that our .patch file doesn\u0027t have to include the removal of\nlogging.cpp and logging.h. The .patch files are required only to perform\nthe necessary modifications on the final set of files required for a\nworking libunwindstack, assuming all other files have already been\ntrimmed out by the to-be-written script that uses ninja -d\nkeepdepfiles. logging.{h,cpp} will therefore be pruned out using this\nscript in the future.\n\nBug: 991960\nChange-Id: I98bac0399fa6e9e1d546e9f42ca43b9dbe32af70\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1869253\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\n" }, { "commit": "dbd29d6e2d1d961b09d664b299bf2cbe3d3ccbb3", "tree": "bed453d0c3d5cfbc09eef94a777c0926177b1da9", "parents": [ "c2a72a05e473b2550875d737cda1a34d061c65e0" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Mon Oct 21 16:36:46 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Mon Oct 21 21:03:49 2019" }, "message": "Removes TemporaryDir from file.{h,cpp}\n\nThe `TemporaryDir` destructor uses the `nftw` function, which isn\u0027t\navailable in Android NDK version 16 (it was first made available in 17,\nas per https://bit.ly/2MSMlt5). `TemporaryDir` is unused by\nlibunwindstack, though, so we safely remove the entire class.\n\nBug: 991960\nChange-Id: Ibf03f740b673b4f3b69c37e34938b027d1833bee\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1869792\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\n" }, { "commit": "c2a72a05e473b2550875d737cda1a34d061c65e0", "tree": "a076a1b9536f45ec411f7aea854f94607220b5e0", "parents": [ "1267e47d3b9e245c5028b22c56f9c7d074ffe79e" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Thu Oct 17 20:51:45 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Thu Oct 17 20:55:51 2019" }, "message": "Patch ElfInterface.cpp to use LZMA 15.14 APIs\n\nChromium uses an older version of LZMA (15.14, released 2015/12/31) than\nplatform/system/core (18.06, released 2018/12/30). libunwindstack uses\nthe 8 parameter XzUnpacker_Code call, which wasn\u0027t available until 18.03\n(http://bit.ly/2Bju4zF).\n\nThe 7 parameter XzUnpacker_Code call is equivalent to the new\nXzUnpacker_CodeFull call (http://bit.ly/2Bju4zF), which is in turn\nequivalent to XzUnpacker_Code with the new `srcFinished` parameter set\nto `true` (http://bit.ly/33IIHsK). Because of this, we can safely delete\nthe `true` `srcFinished` parameter used by libunwindstack and have our\n15.14-compliant code be the same as upstream libunwindstack\u0027s\n18.06-compliant code.\n\n(The above links point to an LZMA mirror rather than LZMA directly\nbecause doesn\u0027t have a public repo, instead opting for direct code drops\nin 7zip archives.)\n\nWe also add a typedef that\u0027s missing in 15.14.\n\nI also add a small amount of machinery required to apply the patch\nin tools/apply_patches.py.\n\nBug: 991960\nChange-Id: I8ac8590f63db97a29afb9a84a60492edd9c6d86c\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1866955\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "1267e47d3b9e245c5028b22c56f9c7d074ffe79e", "tree": "b220991203c906acddc2302d5ce784134ba4aa48", "parents": [ "b1f48e8907d809552639e98f4233835849932701" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Thu Oct 17 16:35:56 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Thu Oct 17 16:37:14 2019" }, "message": "Create the BUILD.gn file for libunwindstack\n\nNote that the target still doesn\u0027t compile because the patches aren\u0027t\napplied to fix use of NDK\u003e20 APIs.\n\nBug: 991960\nChange-Id: Ib58645a74ef9b882d2c95860e2642155d1a05ccf\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1865542\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "b1f48e8907d809552639e98f4233835849932701", "tree": "17fba8b37952cc98e4d13c0d1009f087368d0577", "parents": [ "262ad7bb0b5329a007231e18bc11e2c77fb94b51" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 18:25:47 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 18:27:13 2019" }, "message": "Address pasko@\u0027s cleanup comments from crrev.com/c/1854012\n\nSpecifically:\n\n1) removes the unused sys.argv[1:] that was passed to main()\n2) removes the unnecessary textwrap import\n3) changes double quotes to single quotes\n4) changes function names to CamelCase\n\nBug: 991960\nChange-Id: I0a5968873a18da558781787edd2c5d393c0a3a88\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1865430\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\n" }, { "commit": "262ad7bb0b5329a007231e18bc11e2c77fb94b51", "tree": "af89cadbce074597ebe7a51099df592d2729e8d7", "parents": [ "cdef302cadf85853d186086f967edb7742e6adbd" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 15:03:26 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 15:50:48 2019" }, "message": "Add libunwindstack src/ directory with only files Chrome requires\n\nThe src/ directory itself was generated by:\n\n1) Running tools/copy_libunwindstack_sources.py android-q-preview-6\n to fetch all source files in the needed directories\n2) In a branch with an already-compiling version of libunwindstack,\n finding all of the files that we need with:\n\n $ autoninja -C out/DefaultMobile -d keepdepfiles \\\n third_party/libunwindstack:libunwindstack\n $ find out/DefaultMobile/obj/third_party-libunwindstack \\\n -name \"*.o.d | xargs cat | sort -u \u003e /tmp/whitelist.txt\n\n (a little manual editing to massage that into the same output\n format as find).\n3) Removing all source files not in the whitelist with:\n\n $ comm -2 -3 \u003c(find src/ | sort) \u003c(cat /tmp/whitelist.txt) | \\\n xargs -p rm\n\nI\u0027ll add scripts in tools/ to perform steps 2) and 3) in subsequent CLs.\nI\u0027ll also add a patches/ directory containing the patches required to\nget libunwindstack to compile.\n\nIn the meanwhile, this populated src/ directory will be useful in\nreviewing changes that help us _get_ to a compiling copy of\nlibunwindstack.\n\nThis CL is a little magical because getting libunwindstack to compile\nrequires patches that haven\u0027t yet been reviewed, but reviewing those\npatches is much easier with a populated src/ directory, which requires a\ncompiling version of libunwindstack.\n\nHowever, submitting the src/ directory now instead of when\nlibunwindstack is fully compiling allows us to review patch files\nalongside the changes they make. It also allows us to see the code that\nthe BUILD.gn file compiles. Because of that, handwaving a bit on what\u0027s\nrequired to reach that successful compilation seems justified.\n\nBug: 991960\nChange-Id: I74dac6e0fb2bfb39422f0c8c48e4efb6af55404e\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1864581\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\n" }, { "commit": "cdef302cadf85853d186086f967edb7742e6adbd", "tree": "da22f1d9c54240f59863ff68dbda69d8bfc79587", "parents": [ "d406327485121f4862a55b3d6fec489f38c270da" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 14:59:14 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Wed Oct 16 15:01:49 2019" }, "message": "Add script to copy libunwindstack source files.\n\nI verified locally that this script generates a src/ folder with the\nfollowing directories:\n\nandroid-base demangle liblog libprocinfo libunwindstack\n\nNote that I can\u0027t yet upload the actual src/. Without first removing\nunnecessary files (a later step), we\u0027d add ~85MB of files to this repo\u0027s\ngit history.\n\nBug: 991960\nChange-Id: I8c9c65670b46d925c159bc07ed7f20cec7d3da1a\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1854012\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\n" }, { "commit": "d406327485121f4862a55b3d6fec489f38c270da", "tree": "69d8276e05791dcbbcd40768d72165f52fc86191", "parents": [ "d1b3f4d0a685d76e17b022d9570cd651b82cdf3f" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Oct 08 21:59:06 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Oct 08 22:12:48 2019" }, "message": "Create README.chromium and LICENSE files for libunwindstack\n\nFor the LICENSE file, it seems logical to have it live in the master\nbranch rather than the upstream branch because it\u0027s not a direct copy\nfrom any file in the platform/system/core repo. Instead, the LICENSE\nis inferred from the MODULE_LICENSE_APACHE2 file at\nhttps://source.android.com/setup/start/licenses in conjunction with link\nto the Apache 2.0 License\nat https://source.android.com/setup/start/licenses.\n\nBug: 991960\nChange-Id: Ic8245f5797ec2ed8ac000db130666cf01e975181\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1848494\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "d1b3f4d0a685d76e17b022d9570cd651b82cdf3f", "tree": "c215a459ad282da0d1727eb8c5b1814e650b97cd", "parents": [ "0d0744b9fd9b5865e4b12a27616c38a7bda92f41" ], "author": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Mon Oct 07 14:12:52 2019" }, "committer": { "name": "Charlie Andrews", "email": "charliea@chromium.org", "time": "Tue Oct 08 16:52:09 2019" }, "message": "Add an initial OWNERS file to third_party/libunwindstack\n\nBug: 991960\nChange-Id: Ida1361e5b48789d800b1b942248b3ddda1a9df02\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/third_party/libunwindstack/+/1845175\nReviewed-by: Mike Wittman \u003cwittman@chromium.org\u003e\n" }, { "commit": "0d0744b9fd9b5865e4b12a27616c38a7bda92f41", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [], "author": { "name": "Jason Robbins", "email": "jrobbins+catch-up@google.com", "time": "Fri Sep 20 20:42:19 2019" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Fri Sep 20 20:42:19 2019" }, "message": "Initial empty repository\n" } ] }