tree 5aa7912f3ccad51ce5ac2578eeb7991bf3bfc18f
parent 410a2c01ed65bc6206a130b37b7f2383dd04efd1
author Bruce Dawson <brucedawson@chromium.org> 1511220827 +0000
committer Commit Bot <commit-bot@chromium.org> 1511220827 +0000

Disable incremental linking for some tools

We occasionally get build crashes because binaries (usually protoc.exe,
but others as well) are generated incorrectly. The symptom is that the
incremental linking thunks contain all zeroes instead of a branch
instruction, leading to crashes, usually access violations. This is
presumed to be a bug in the MSVC++ incremental linker.

This turns off incremental linking for four of the binaries that hit
this issue most frequently, and some of their neighbors. These binaries
are all small enough that incremental linking is not important so there
is no real downside to making this change.

Testing over the weekend shows that this error, or something very like
it, can happen even with incremental linking disabled. I hope that this
will reduce the frequency of the failures and there is no downside so
I'm going to proceed and see if it helps.

Bug: 644525
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0a9b33b0ad8335868e8e6f227f9a21e5ddeff6e4
Reviewed-on: https://chromium-review.googlesource.com/777764
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517990}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1942fd8a7fe9fc609f51ef1fbff210ba5f356415