Revert "Disable incremental linking for some tools"

This reverts commit 1942fd8a7fe9fc609f51ef1fbff210ba5f356415.

Reason for revert: This was a hack that attempted to fix random link
failures. This hack ultimately didn't work because the crashes we
were seeing were due to a kernel bug, not a linker bug.

Original change's description:
> Disable incremental linking for some tools
> We occasionally get build crashes because binaries (usually protoc.exe,
> but others as well) are generated incorrectly. The symptom is that the
> incremental linking thunks contain all zeroes instead of a branch
> instruction, leading to crashes, usually access violations. This is
> presumed to be a bug in the MSVC++ incremental linker.
> This turns off incremental linking for four of the binaries that hit
> this issue most frequently, and some of their neighbors. These binaries
> are all small enough that incremental linking is not important so there
> is no real downside to making this change.
> Testing over the weekend shows that this error, or something very like
> it, can happen even with incremental linking disabled. I hope that this
> will reduce the frequency of the failures and there is no downside so
> I'm going to proceed and see if it helps.
> Bug: 644525
> Cq-Include-Trybots:;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I0a9b33b0ad8335868e8e6f227f9a21e5ddeff6e4
> Reviewed-on:
> Commit-Queue: Bruce Dawson <>
> Reviewed-by: John Abd-El-Malek <>
> Cr-Commit-Position: refs/heads/master@{#517990},

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 644525
Change-Id: Ib822f0850cdffe7cdf0112aac5c45a2200b63adf
Reviewed-by: Bruce Dawson <>
Reviewed-by: John Abd-El-Malek <>
Commit-Queue: Bruce Dawson <>
Cr-Original-Commit-Position: refs/heads/master@{#533419}
Cr-Mirrored-Commit: 7f063158562d2516620386721deb1339a3160e19
1 file changed