| commit | 4191ea0675c4c133cb506316b6b974f31e600576 | [log] [tgz] |
|---|---|---|
| author | Max Moroz <mmoroz@chromium.org> | Wed Sep 05 04:08:05 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 05 04:08:05 2018 |
| tree | 88fcb6c7827c1e170c4402b420a6521681235373 | |
| parent | dd392262cb0454ee65d330242c3896ca7fe1c8cb [diff] |
[Code Coverage] Do not resolve symlinks in GetFullPath() helper. Calling os.path.realpath seems to be an overkill, as it is used either: - for various local paths like LLVM binaries dir, output dir, etc which are fine to be symlinks; - for report files produced by llvm-cov tool, which do not seem to ever have symlinks. Leaving os.path.realpath() in there might seem harmless, but apparently there are cases when it causes troubles, e.g.: https://github.com/google/oss-fuzz/pull/1777#issuecomment-417805976 Tested locally with https://crrev.com/c/1184048. Bug: 866943 Change-Id: I4224664ef3bf5b7eb3f1fd3605e9db0fff11833c Reviewed-on: https://chromium-review.googlesource.com/1205594 Reviewed-by: Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588760} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 00b941168480e3414f2e48a4c6088f70720a03c6