)]}' { "log": [ { "commit": "20f625ca19c3b46b4e991763287a537098d0cd1d", "tree": "fa0b5ae6bae3e666d461b5147b4d7d27a80e1cb5", "parents": [ "a6ba20f995948dde1b9904b419df260322eab88c" ], "author": { "name": "Victor Hugo Vianna Silva", "email": "victorvianna@google.com", "time": "Fri Dec 19 11:19:02 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Dec 19 11:26:09 2025" }, "message": "Compile more code with C++23\n\nBug: 388070065\nChange-Id: I4b3c61807e7df8095374436675b594b2378335f7\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7269450\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Victor Vianna \u003cvictorvianna@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1561057}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e6cad244684de1cf3a59df1641489b30acb4b3d1\n" }, { "commit": "a6ba20f995948dde1b9904b419df260322eab88c", "tree": "c1fcbe060e8f5bb32d838aedfd12b6ccd6823c37", "parents": [ "08f6d111476d3bfecca82a0e189767fc65b36f42" ], "author": { "name": "Daniel Richard G.", "email": "iskunk@gmail.com", "time": "Mon Nov 24 15:10:35 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon Nov 24 15:16:01 2025" }, "message": "gn bootstrap: Fix tarball CI build\n\n* Set -D_LIBCPP_HARDENING_MODE_DEFAULT\u003d_LIBCPP_HARDENING_MODE_FAST\n\n* Add third_party/llvm/libc/ to system includes\n\n* Add missing libc++ objects: call_once.o, error_category.o\n\n* Reformat the ../libc++.gn.so link dependencies to one object per\n line, for readability\u0027s sake\n\nBug: None\nChange-Id: Ifb04f20ecd0f3cd9542dfe5739ee5ccc71d8c0ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7193805\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Hans Wennborg \u003chans@chromium.org\u003e\nAuto-Submit: Daniel Richard G. \u003ciskunk@gmail.com\u003e\nCr-Commit-Position: refs/heads/main@{#1549184}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 349135679e1b840bb40c22bbec5996c83d8816a2\n" }, { "commit": "08f6d111476d3bfecca82a0e189767fc65b36f42", "tree": "2efc344901edeb3f5d405e3f324f558d7c21f0bf", "parents": [ "e8504ea281a8ec04280d00160244b5f139ab7ff9" ], "author": { "name": "jj", "email": "jj@imput.net", "time": "Thu Nov 13 20:40:06 2025" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Nov 13 21:04:54 2025" }, "message": "[gn] fix SyntaxWarning in bootstrap.py\n\nFixes the following SyntaxWarning:\n\ntools/gn/bootstrap/bootstrap.py:105: SyntaxWarning: \"\\$\" is an invalid\nescape sequence. Such sequences will not work in the future. Did you\nmean \"\\\\$\"? A raw string is also an option.\n\nChange-Id: Ic6a3abb6892020c3320f142027d21d515a2833f6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7152618\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Jesse McKenna \u003cjessemckenna@google.com\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1544458}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 7cec6bc3b323b403a4cf649585a8a4e29d7fe197\n" }, { "commit": "e8504ea281a8ec04280d00160244b5f139ab7ff9", "tree": "6c8fd035fc50268bc294c0a59f3b732b789790ef", "parents": [ "c983acf0f7146574ec0cd3420cc510d19f358aad" ], "author": { "name": "Max Ihlenfeldt", "email": "max@igalia.com", "time": "Wed May 08 08:44:51 2024" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed May 08 09:00:45 2024" }, "message": "gn bootstrap: Don\u0027t pass removed dupbuild ninja option\n\nNinja removed the `-w dupbuild` option in its v1.12.0 release (the\nexact commit is https://github.com/ninja-build/ninja/commit/8f47d5aa).\nThe behaviour previously achieved by passing `-w dupbuild\u003derr` is now the default.\n\nBug: None\nChange-Id: I95174e15998ba0155a828c5d5cacdde98fcdfb53\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522398\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Max Ihlenfeldt \u003cmax@igalia.com\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1297998}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 93801ea19df27968e3592f3113f195a874f2bc42\n" }, { "commit": "c983acf0f7146574ec0cd3420cc510d19f358aad", "tree": "f0d820afbc7bd85457f13a1636a5a74349b53593", "parents": [ "551ad821bc7bbe70d202a2696c78e75f525db114" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Wed Oct 18 15:09:37 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Oct 18 15:17:13 2023" }, "message": "libc++: Stop adding legacy debug files when enable_iterator_debugging\u003dtrue\n\nThese files have been removed from libc++ in upstream commits\n1886005576 (\"[libc++] Remove dead code in\nlegacy_debug_handler.cpp (#68155)\") and 2a9cfd11a6 (\"[libc++] Remove the\nlegacy debug mode\").\n\nAlso fix GN\u0027s libc++.ninja while at it. This should fix errors such as\nhttps://ci.chromium.org/ui/p/infra/builders/cron/Build%20From%20Tarball/b8766911531941148689/overview\n\nChange-Id: I66440c96747157e63497398e3379856aa731dec1\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4950115\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Raphael Kubo Da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1211506}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: abfd6663cf30fa163fc72880bdac7a20afde6760\n" }, { "commit": "551ad821bc7bbe70d202a2696c78e75f525db114", "tree": "9ea04b44b9aaef26757812db30ae4715154334cc", "parents": [ "cfae9dec62e65beae5f0ce32de2043e68ef57dda" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Tue Aug 22 17:41:40 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 22 18:01:34 2023" }, "message": "gn: Fix bootstrap after https://crrev.com/c/4666325\n\nAdjust paths in the bootstrap script and handwritten libc++.ninja after\nlibc++ and libc++abi were moved from //buildtools to //third_party.\n\n//buildtools/third_party/libc++ is still included because of\n__config_site.\n\nBug: 1458042\nChange-Id: Ica338a6f828f22fa71ce09e737136d2f7bd45aa6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4800457\nAuto-Submit: Raphael Kubo Da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1186656}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 60a4e9d85f652fa4c371a319eb8b45841944ae01\n" }, { "commit": "cfae9dec62e65beae5f0ce32de2043e68ef57dda", "tree": "c6e72c7f281fcd535150b898a2b9e5357d25d036", "parents": [ "08464efd98e98373e6bbff30ef0f1daa0a00513a" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Fri Jun 30 17:06:19 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Jun 30 17:20:08 2023" }, "message": "gn bootstrap: Adjust libc++.ninja after https://crrev.com/c/4654390\n\nAdd a few more files to fix the recent breakage in the Build From\nTarball bot:\n\n ld.lld: error: undefined symbol: std::nothrow\n\n- https://ci.chromium.org/ui/p/infra/builders/cron/Build%20From%20Tarball/b8776898407029116513/overview\n- https://ci.chromium.org/ui/p/infra/builders/cron/Build%20From%20Tarball/b8776896849070773569/overview\n\nChange-Id: I2206b27158e550d6e1618e9942567dae05396fa6\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4660359\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nAuto-Submit: Raphael Kubo Da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nCr-Commit-Position: refs/heads/main@{#1164756}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 96e0f2bed31dc8bfd25781409183af11f525a8f2\n" }, { "commit": "08464efd98e98373e6bbff30ef0f1daa0a00513a", "tree": "1af11bde6f0fe3135cbd390656de7ceeb4bbff48", "parents": [ "67c42e175f4554e4feddfe4b41058cd2bcc3742b" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Mon May 01 16:11:17 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Mon May 01 16:18:24 2023" }, "message": "gn bootstrap: Update libc++.ninja after https://crrev.com/c/4475054\n\nThis change was done manually. It fixes the Build From Tarball bot:\nhttps://cr-buildbucket.appspot.com/build/8782319458264924033\n\nChange-Id: I6c95b9a4daab15b622bb16b7c25a28c2a3ff3a9b\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496305\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nAuto-Submit: Raphael Kubo Da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1137854}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 0029b9ae04131953619df92b9a12015f66f826e3\n" }, { "commit": "67c42e175f4554e4feddfe4b41058cd2bcc3742b", "tree": "cb39e7648656d48cd064d838d95dc6d27c7a66ee", "parents": [ "ffb7a1e6d5bb391222bb01637bddf779d07afe58" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Mar 21 15:40:40 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 21 15:46:46 2023" }, "message": "Update gn bootstrap for latest libc++\n\nBuild and link verbose_abort.cpp.\n\nChange-Id: Ie48b8c75868db8e1e9093b1c81f96a6c5680413f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4354961\nAuto-Submit: Lei Zhang \u003cthestig@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1119941}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: fcd7ed28edd34b812e2b37e895991de226302484\n" }, { "commit": "ffb7a1e6d5bb391222bb01637bddf779d07afe58", "tree": "9eab27a7ac488affcdcf2f1ee7cf9dc6d78fe898", "parents": [ "1ec270186863961f9325093c6c66755c07e90083" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Wed Feb 08 21:12:58 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Wed Feb 08 21:19:10 2023" }, "message": "gn bootstrap: Use python3 in the shebang line.\n\n`python` usually means Python 2, which is deprecated and may not even be\navailable anymore -- that is the case on Build From Tarball builds with\nthe \"luci.buildbucket.omit_python2\" experiment.\n\nSwitch to python3 in the shebang line to avoid errors like\nhttps://ci.chromium.org/ui/p/infra/builders/cron/Build%20From%20Tarball/b8789764407411398865/overview\n\nThe script has also been verified to work with Python 3.\n\nChange-Id: I5624e8b7fb5e55c0eb09f80f0c71c1917b10e12f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4231332\nAuto-Submit: Raphael Kubo Da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#1102861}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: 63d5da046c2d5f44c2bd738f8f0b3199a7323746\n" }, { "commit": "1ec270186863961f9325093c6c66755c07e90083", "tree": "ec329d8bce0990dc077cde6459d94dda7d216fce", "parents": [ "c89e15981a2a86ad1a3bf33d1d75b0fdae7144d5" ], "author": { "name": "Ho Cheung", "email": "uioptt24@gmail.com", "time": "Sat Jan 07 02:49:54 2023" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Sat Jan 07 03:06:24 2023" }, "message": "Introduce \u0027-j\u0027 parameter for bootstrap.py\n\nThe bootstrap.py file currently lacks parameters\nrelated to setting the number of threads and\nparallel compilation.This CL modifies the\nbootstrap.py file for this issue.\n\nBug:1405126\n\nChange-Id: I21abc22b70f713a8c4d89c981d7e93ffe41c1b3f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137674\nAuto-Submit: Ho Cheung \u003cuioptt24@gmail.com\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1090002}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dcad2e56b54792e4ea020d465d38ccd65debab99\n" }, { "commit": "c89e15981a2a86ad1a3bf33d1d75b0fdae7144d5", "tree": "78f624e909fda4ea51aa6f787d63788044777804", "parents": [ "1fd6045ff8e404dadb02fb4bc698bce354739742" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Thu Sep 15 20:11:09 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Thu Sep 15 20:24:38 2022" }, "message": "Update copyright headers in testing/, tools/\n\nThe methodology used to generate this CL is documented in\nhttps://crbug.com/1098010#c95.\n\nNo-Try: true\nNo-Presubmit: true\nBug: 1098010\nChange-Id: I3a8a7b150e7bd64690534727150646081df50439\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900697\nReviewed-by: Mark Mentovai \u003cmark@chromium.org\u003e\nAuto-Submit: Avi Drissman \u003cavi@chromium.org\u003e\nOwners-Override: Avi Drissman \u003cavi@chromium.org\u003e\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1047644}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: dfd88085261b662a5c0a1abea1a3b120b08e8e48\n" }, { "commit": "1fd6045ff8e404dadb02fb4bc698bce354739742", "tree": "188fabc6dc08c1aef668eab01dc5c7d7903f9386", "parents": [ "58a1a87352a9cf226c69492ff9d4dc9001ee6d74" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Tue Aug 09 02:06:48 2022" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Aug 09 02:25:06 2022" }, "message": "Update gn bootstrap for latest libc++\n\nChange-Id: I7a07708c9102ee96f8692670ddd59f9a337261fb\nBug: None\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817228\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Commit-Position: refs/heads/main@{#1032836}\nNOKEYCHECK\u003dTrue\nGitOrigin-RevId: e06f8977feb48d85e117b8ecade6938d6aa1a775\n" }, { "commit": "58a1a87352a9cf226c69492ff9d4dc9001ee6d74", "tree": "614fcd3427eb39dd262fc188736624f9e597cbd4", "parents": [ "47713bd94daa1904bd89c721b7e40198e2628ea8" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Tue Mar 23 19:18:14 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Tue Mar 23 19:31:15 2021" }, "message": "Mostly delete roll_gn.py\n\nNo longer needed, GN is now auto-rolled.\n\nLeave the script around for now and make it print an error message,\nwhich is maybe less confusing for folks used to the script. We can\ncompletely delete it in a few months.\n\nBug: 1177288\nChange-Id: I01fc9be065520445d598717ef592783393a2aa59\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782521\nAuto-Submit: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCr-Commit-Position: refs/heads/master@{#865761}\nGitOrigin-RevId: 5b29c635e42837f2d93b4340e6257466d5d57941\n" }, { "commit": "47713bd94daa1904bd89c721b7e40198e2628ea8", "tree": "fd54765e91d362c4581970a41ed6403b4518f080", "parents": [ "7c0f617245234c1a944c202ed1fa5e28fee5ee86" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Mar 05 19:14:26 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Mar 05 19:25:43 2021" }, "message": "Fix GN bootstrap to build with latest libc++abi changes\n\nBUG\u003d1180836\nR\u003dthakis\n\nChange-Id: Id740dbbfa5db4b77950225f854dcf6c3e440886d\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2740059\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#860311}\nGitOrigin-RevId: 2c2542222912cfa26a8124034f0e01593c5e32c8\n" }, { "commit": "7c0f617245234c1a944c202ed1fa5e28fee5ee86", "tree": "3d7cda2403f027dc3d30dc9ee72057961f90ee3f", "parents": [ "43833c857a328f545ae488a292b97872ac106683" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Feb 26 20:01:25 2021" }, "committer": { "name": "Copybara-Service", "email": "copybara-worker@google.com", "time": "Fri Feb 26 20:13:31 2021" }, "message": "Update gn bootstrap to build with latest libc++ roll\n\nBUG\u003dNone\nR\u003dthakis\n\nChange-Id: I03a73f62d6bf014de829f81864f66db076b3db08\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2723278\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#858235}\nGitOrigin-RevId: 9a6a070f5baf05aa65c0f59cd17f5ca2dc5b6a0a\n" }, { "commit": "43833c857a328f545ae488a292b97872ac106683", "tree": "fd681ce9b709ae631ae4ffdb79d1d3fea377e124", "parents": [ "e3bb9e8e72564f1e919623de9fc87b07b75b7409" ], "author": { "name": "Brett Wilson", "email": "brettw@google.com", "time": "Mon Mar 23 19:29:54 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 18 20:35:25 2020" }, "message": "remove copybara initialization artifacts\n\nGitOrigin-RevId: a162bd77d4a8fff95c6555617aff75da9a92782b\n" }, { "commit": "e3bb9e8e72564f1e919623de9fc87b07b75b7409", "tree": "1e5839bb8909147af77f158e09e692b906aafb3c", "parents": [ "1d7ebc4b4eb88453152e017e13097f75c407492f" ], "author": { "name": "Brett Wilson", "email": "brettw@google.com", "time": "Mon Mar 23 19:29:54 2020" }, "committer": { "name": "Anthony Polito", "email": "apolito@google.com", "time": "Tue Aug 18 20:34:32 2020" }, "message": "Copybara Service Migration Initialization.\n\nGitOrigin-RevId: a162bd77d4a8fff95c6555617aff75da9a92782b\n" }, { "commit": "1d7ebc4b4eb88453152e017e13097f75c407492f", "tree": "fd681ce9b709ae631ae4ffdb79d1d3fea377e124", "parents": [ "d39800026b28c2a65f45ed46a23c89ab1e4a8f20" ], "author": { "name": "Brett Wilson", "email": "brettw@google.com", "time": "Mon Mar 23 19:29:54 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 23 19:29:54 2020" }, "message": "Roll GN from 9499562d..5ed3c9cc\n\nGenerated by //tools/gn/roll_gn.py\n\nhttps://gn.googlesource.com/gn/+log/9499562d..5ed3c9cc\n\n 5ed3c9cc Match all toolchains by default.\n 2a18133d Update the \"getting started\".\n 7943a470 Remove a few unused macros.\n 74397090 Add an \"outputs\" command.\n bee89163 Make CONFIGURATION_BUILD_DIR represent location of binaries\n 818b8851 Add missing header for using with std::move\n\nChange-Id: I5cb02c2e4fbc574e437a43f6cc37a500b65b03ff\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116131\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#752530}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a162bd77d4a8fff95c6555617aff75da9a92782b\n" }, { "commit": "d39800026b28c2a65f45ed46a23c89ab1e4a8f20", "tree": "71bc5eeab1836ac3745e3cfbc91bcf178131cb95", "parents": [ "1404d10e0fb18722109a630825629b841ce24b95" ], "author": { "name": "Andrew Grieve", "email": "agrieve@chromium.org", "time": "Thu Mar 12 21:18:54 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 12 21:18:54 2020" }, "message": "Roll GN from fd3d768b..9499562d\n\nGenerated by //tools/gn/roll_gn.py\n\nhttps://gn.googlesource.com/gn/+log/fd3d768b..9499562d\n\n 9499562d Fix analyze not noticing when BUILD.gn files change\n 91eee9b2 [Xcode] Implement custom sort of the elements in Xcode project\n 32f0f53d Remove flaky StringAtom test.\n aff489a4 Add \"filter_{exclude,include}\" intrinsic functions to GN\n 08bfc84b Include more files in the generated Xcode project\n 07854239 Reduce RAM usage and improve speed of \"gn gen\"\n 992e927e [xcode] Refactor XcodeWriter\n\nBug: 999002, 1018739\nChange-Id: I11f9cf6c5d89ea1246dbceed397c2efcce59a4d2\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099572\nCommit-Queue: Andrew Grieve \u003cagrieve@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#749884}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0f9cf12e620630a2ce1932f0c4e020dca4d984d9\n" }, { "commit": "1404d10e0fb18722109a630825629b841ce24b95", "tree": "330c8a4e4ea2820dc3ae0957d5e98b07b94098c7", "parents": [ "4a8c4ddd3202d75c31323c7eedaff55905ce96cd" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Thu Feb 27 16:29:41 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 27 16:29:41 2020" }, "message": "Add cxa_thread_atexit.cpp to gn bootstrap libc++abi\n\nFixes this error:\nld.lld: error: undefined symbol: __cxa_thread_atexit\n\nBUG\u003d1047860\nR\u003dthakis\n\nChange-Id: I0fc3ddd44b68fcdcc594a3bdc398a6b2924ac15f\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075840\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#745069}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 58726b7f41b896ad134c817cde0492cb3dbe5c8f\n" }, { "commit": "4a8c4ddd3202d75c31323c7eedaff55905ce96cd", "tree": "ef414eeb5eda0e4e93506704bef8deae22df0c47", "parents": [ "d73a30c4d529e28df1b6e6148700c1fcc7ea68d4" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Sat Feb 01 00:03:28 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Feb 01 00:03:28 2020" }, "message": "Fix gn bootstrap build with --use-custom-libcxx\n\nThis is needed to fix the \"Build From Tarball\" bot:\nhttps://ci.chromium.org/p/infra/builders/cron/Build%20From%20Tarball\n\nR\u003dthakis\n\nBug: 1047860\nChange-Id: Id41ebee75dc760580b1d2334dffcbb5fc2004f32\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033904\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#737525}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7f024dbd45cfdff4397aecc6169c83eb23b45704\n" }, { "commit": "d73a30c4d529e28df1b6e6148700c1fcc7ea68d4", "tree": "dadb3414efed53af7e5848b7db30a5450bb5e21d", "parents": [ "32fcd8fdc06ad4c3880fc4a5eeafe07df62b69df" ], "author": { "name": "Michael Forney", "email": "mforney@mforney.org", "time": "Thu Dec 19 22:21:56 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Dec 19 22:21:56 2019" }, "message": "gn bootstrap: Allow specifying ninja binary with $NINJA\n\nThis allows the builder to specify the path of the ninja binary in\ncase they want to use a specific version, or an alternate\nimplementation like samurai[0].\n\nAlso, when calling ninja, make sure build target comes after any\noptions.\n\n[0] https://github.com/michaelforney/samurai\n\nChange-Id: I4295baa9e0e04e61ae092a9b86ea6ddc943b3c92\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975453\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Michael Forney \u003cmforney@mforney.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#726552}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 53b414cba10bc3c38fca88c330d2146722b4e54c\n" }, { "commit": "32fcd8fdc06ad4c3880fc4a5eeafe07df62b69df", "tree": "9760d89acd6d4f13c7a791dc8c057dc3dfa3a417", "parents": [ "9355a7a751f1822545a9d7047f1bda8bc0c54ea8" ], "author": { "name": "Dirk Pranke", "email": "dpranke@chromium.org", "time": "Tue Sep 10 23:43:15 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 10 23:43:15 2019" }, "message": "Add latest GN roll script and update instructions.\n\nThis adds a //tools/gn/roll_gn.py script that can be run to\nroll DEPS to the latest version of GN (or an alternate version of\nyour choosing).\n\nR\u003dthakis@chromium.org\n\nChange-Id: I88c4357e8566bbed2e3f0339b12733fec96430ba\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793632\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#695388}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7d223cc8e3caf6f78af72ad7ca4e369630b24ff4\n" }, { "commit": "9355a7a751f1822545a9d7047f1bda8bc0c54ea8", "tree": "4821232abd0cc23c54c51b1065f3132b88ed760c", "parents": [ "65e2185d4f521005a7148ecaea63eeefa7fc35ed" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Fri Feb 22 14:49:48 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 22 14:49:48 2019" }, "message": "gn bootstrap: Explicitly pass -lpthread when linking with --use-custom-libcxx\n\nhttps://chromium-review.googlesource.com/c/1460187 (\"Fix gn build on \u0027Build\nFrom Tarball\u0027 bot\") together with\nhttps://gn-review.googlesource.com/c/gn/+/4000 (\"Pass -lpthread when linking\ninstead of -pthread\") have caused the GN bootstrap process to fail when\n--use-custom-libcxx is not used.\n\nThe reason is that -nodefaultlibs (passed to the compiler when linking with\n--use-custom-libcxx) causes -pthread to be ignored. To work around that,\nthat GN CL started passing -lpthread so that it was added back to the\ncommand-line. However, if we are _not_ using --use-custom-libcxx, the whole\nprocess fails because -lpthread is specified at the wrong position in the\ncommand-line and the symbols are not resolved correctly.\n\nIn this CL, make the --use-custom-libcxx build explicitly pass -lpthread to\nthe linker so that we can later go back to passing -pthread in the GN build,\nas the compiler then knows where to put the right flags in the command line.\n\nBug: 934793\nChange-Id: Id8bf242bf461fb5146e1ac28d187082c43fdafbb\nReviewed-on: https://chromium-review.googlesource.com/c/1482959\nCommit-Queue: Raphael Kubo da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nAuto-Submit: Raphael Kubo da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#634657}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1ee5a0810dd9d4362e94e91d155548ac53daeb04" }, { "commit": "65e2185d4f521005a7148ecaea63eeefa7fc35ed", "tree": "43522b31a2b6397543b3078ab5cbeab529939926", "parents": [ "0224e05b670c3cac5f24d7332835874fa6b1c621" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Feb 15 03:52:32 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 15 03:52:32 2019" }, "message": "Fix gn bootstrap build with --use-custom-libcxx\n\nThe gn binary gets copied up one directory when bootstrapping. It was failing\nto run since it couldn\u0027t find libc++.so which wasn\u0027t copied. This CL copies\nlibc++.so too and renames it to libc++.gn.so to not conflict with Chromium\u0027s\nlibc++.so.\n\nAlso rename README.md to README.chromium.md to not conflict with gn\u0027s README.md.\n\nBUG\u003d807400\nR\u003dthakis\n\nChange-Id: Idce60c7df7e8aaf134357f39347ee4dafe2a851e\nReviewed-on: https://chromium-review.googlesource.com/c/1474847\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#632494}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2961b634182c52e7785f9b87c203590b5e1f34b1" }, { "commit": "0224e05b670c3cac5f24d7332835874fa6b1c621", "tree": "409d5d6bfc4353086ae071d73d2f1cd24c0def66", "parents": [ "363efd3923b1310abe30edd313f48e95d0ba2a4b" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Feb 08 13:11:56 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 08 13:11:56 2019" }, "message": "Fix gn build on \u0027Build From Tarball\u0027 bot\n\nThis is necessary to green-up the \u0027Build From Tarball\u0027 bot. The bot is running\nTrusty, which has a system libstdc++ that\u0027s too old to support many of the\nfeatures in base that gn relies on.\n\nHere\u0027s the story of why this is now necessary:\n\n1. Chromium\u0027s gn was originally built with libc++ to get around this exact\n issue.\n2. gn was moved into a standalone repo.\n3. The libc++ sources weren\u0027t copied into standalone gn, so their solution to\n fix this issue was to pull Chromium\u0027s debian sysroot that has newer libstdc++\n headers.\n4. For whatever reason, the option to build with the sysroot was removed from\n the public repository and now the bots have a step to pull the sysroot.\n\nThis can be removed once Ubuntu Trusty reaches EOL, or when Chromium\u0027s\ninfrastructure is upgraded from Trusty to Xenial, whichever comes second\nideally.\n\nBUG\u003d807400\nR\u003dthakis\n\nChange-Id: I00901b3df4005f6ac098774822fffe12dd67e561\nReviewed-on: https://chromium-review.googlesource.com/c/1460187\nAuto-Submit: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#630291}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 194fea620e1c1861193d53ff817b313f6a2b0a9a" }, { "commit": "363efd3923b1310abe30edd313f48e95d0ba2a4b", "tree": "a5ec66e41b866bb3ae1a2989be0a5158c172d5dd", "parents": [ "24f048eaf38473c8b6738be058ea7d08ab4d9f03" ], "author": { "name": "Drew Stonebraker", "email": "stonebraker@chromium.org", "time": "Fri Jan 18 21:30:25 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 18 21:30:25 2019" }, "message": "Add tutorial files for gn quick_start guide\n\nAdding tutorial files referenced in\nhttps://gn.googlesource.com/gn/+/master/docs/quick_start.md .\nThis is a temporary fix, as the tutorial files should ideally\nlive in the gn repo, but that repo does not yet have a gn\ntoolchain setup. I will be updating gn/docs/quick_start.md to\nreference the location of these files.\n\nBug: 923492\nChange-Id: I07b6429142a00ab4e3481aa9cbc354fc86694f1d\nReviewed-on: https://chromium-review.googlesource.com/c/1422526\nAuto-Submit: Drew Stonebraker \u003cstonebraker@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nCommit-Queue: Scott Graham \u003cscottmg@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#624291}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6" }, { "commit": "24f048eaf38473c8b6738be058ea7d08ab4d9f03", "tree": "e7ba1cd62e92764966c7d13cae6b06f12932eadb", "parents": [ "6630c2e334d7bc179e95a3d543a8eca3201d6725" ], "author": { "name": "Daniel Bratell", "email": "bratell@opera.com", "time": "Fri Jan 11 16:36:46 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 11 16:36:46 2019" }, "message": "Fix owner email typo in tools/gn/bootstrap/OWNERS\n\nR\u003dthakis@chromium.org\n\nChange-Id: I60faf240e3335bba2a4258c1677b07fb892e9b69\nReviewed-on: https://chromium-review.googlesource.com/c/1407075\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Daniel Bratell \u003cbratell@opera.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#622026}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bbe911b0051fe62e3c266d29532d94fd4d85043e" }, { "commit": "6630c2e334d7bc179e95a3d543a8eca3201d6725", "tree": "a46b4e08678292d2446538fc6469d96f3280a07d", "parents": [ "ac2c1a7947d42f1b1e62a198c09452cd779cbda7" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Tue Nov 13 15:41:11 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Nov 13 15:41:11 2018" }, "message": "gn bootstrap: Remove sysroot-related options\n\nhttps://gn-review.googlesource.com/c/gn/+/3200 removed the --no-sysroot\noption from gen.py and moved to only use a sysroot in the GN bots, so the\noptions here no longer have any effect.\n\nBug: 904350\nChange-Id: Ieddc71a4f8f802c2d050de1c69ca3a9ec788ee88\nReviewed-on: https://chromium-review.googlesource.com/c/1333391\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Raphael Kubo da Costa \u003craphael.kubo.da.costa@intel.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#607596}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4849d9a19f700961e2c25b642bdaaa6514040e60" }, { "commit": "ac2c1a7947d42f1b1e62a198c09452cd779cbda7", "tree": "0ce10e01d002e3d675ffa0991baadc222e326ad6", "parents": [ "b4a27bd163b116a2280e6867687f4602903a0670" ], "author": { "name": "Raphael Kubo da Costa", "email": "raphael.kubo.da.costa@intel.com", "time": "Wed Sep 19 18:16:40 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Sep 19 18:16:40 2018" }, "message": "gn: Add --skip-generate-buildfiles to bootstrap.py\n\nThis restores part of --no-rebuild\u0027s behavior: we only build GN but do not\nrun it afterwards when the option is specified. It\u0027s particularly useful\nwhen GN is built in a different machine or sysroot than the one where\nChromium itself will be built (often with different dependencies installed\non the system).\n\nBug: 885139\nChange-Id: If9f3386db8324b47b52864bccc685578fd40a689\nReviewed-on: https://chromium-review.googlesource.com/1233708\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Raphael Kubo da Costa (CET) \u003craphael.kubo.da.costa@intel.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#592479}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 79c741fd88a1cab596a38afde628c52f21dbe4a2" }, { "commit": "b4a27bd163b116a2280e6867687f4602903a0670", "tree": "3dab9c1d77e00fb5c0bb487ae18a0d2990c6d321", "parents": [ "70544e9a25c000703422ab256441bde912de9156" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Jul 13 22:55:32 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 13 22:55:32 2018" }, "message": "Make gn bootstrap.py forward to gn\u0027s own build/gen.py\n\nBUG\u003d863460\nR\u003dthakis\n\nChange-Id: I658c215071c5dfe9dcc2b7e7bc5a5d21ee57ac18\nReviewed-on: https://chromium-review.googlesource.com/1136495\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#575103}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fcbf5f6262210e3ed7eb30f0265aff9aa615e27b" }, { "commit": "70544e9a25c000703422ab256441bde912de9156", "tree": "757674ff9e057e74859627236217a04cae50abd0", "parents": [ "5a6314f5f26cbb299fa4eaed4e490de0a461718c" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Jul 13 16:59:52 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jul 13 16:59:52 2018" }, "message": "Add tools/gn/bootstrap back\n\nbootstrap.py does not exist in the gn.googlesource.com repo. The script\ngen/build.py is used instead. However, there are some differences to\nbootstrap.py: one obvious one is the name and location. This breaks chromium\npackagers relying on bootstrap.py, so this change adds the script back. In the\nlong-term, it should forward to gen.py.\n\nBUG\u003d859536,863459,863460\n\nChange-Id: I59ff81acb7f409d1975f99bcf0676e6103b2d7b9\nReviewed-on: https://chromium-review.googlesource.com/1136656\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#574952}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 94f73c221e2b754bd7a8109fb2043bffa91e6f1e" }, { "commit": "5a6314f5f26cbb299fa4eaed4e490de0a461718c", "tree": "acd3ff8ca18c1712b7ed2a5cfb5b5f68004bba05", "parents": [ "249a78c23c95d224ea2b73c10ce96f7163040927" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Jul 11 13:34:26 2018" }, "committer": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Wed Jul 11 13:34:26 2018" }, "message": "Take tools/gn behind the barn.\n\ngn now lives at https://gn.googlesource.com/gn/ , so delete\nsrc/tools/gn, and bot configuration to run gn_unittests.\n\nBug: 859536\nChange-Id: I64f4d4fb00349cb8d7143d0a1b96088cc173e27c\nReviewed-on: https://chromium-review.googlesource.com/1129822\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#574140}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 80816b51ed94d0d833543d3453226610518c94b7" }, { "commit": "249a78c23c95d224ea2b73c10ce96f7163040927", "tree": "e79a078d25b1bf3baba2ca780be8079e18028ca6", "parents": [ "8d3d83e8224bf6ad8a23aba754c4d30cb68082a1" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Tue Jul 10 18:48:36 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jul 10 18:48:36 2018" }, "message": "Remove erg@ from OWNERS.\n\nCq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: I7a50645ef2d5a8529eaadeffaff66e589336ce3d\nReviewed-on: https://chromium-review.googlesource.com/1123067\nReviewed-by: Colin Blundell \u003cblundell@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@chromium.org\u003e\nReviewed-by: Scott Violet \u003csky@chromium.org\u003e\nReviewed-by: Leon Scroggins \u003cscroggo@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#573834}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bd7738c827cdbfec16a7c24a2e62ba4cffe2b776" }, { "commit": "8d3d83e8224bf6ad8a23aba754c4d30cb68082a1", "tree": "39764e1cf51e918e0a15a0a1fe2853d0b75fc036", "parents": [ "9d71a3c7e0ddfc3451c26f255e21f5420783642c" ], "author": { "name": "Christopher Grant", "email": "cjgrant@chromium.org", "time": "Tue Jun 26 23:55:45 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 26 23:55:45 2018" }, "message": "Fix typos in the GN reference doc.\n\nBug: None\nChange-Id: I9d7220fe76b0ca5e485dc73ccdb9d09bfb2f53f1\nReviewed-on: https://chromium-review.googlesource.com/1109300\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#570589}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c5d723af5052482663ff2e3df9caceef187e7390" }, { "commit": "9d71a3c7e0ddfc3451c26f255e21f5420783642c", "tree": "9bce9c862373a79bea0deb2a80a0783c649a6ef4", "parents": [ "2652160b2a6e3e20eb312be7581cc52ad03856d2" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Jun 21 08:07:20 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jun 21 08:07:20 2018" }, "message": "Change \"gn check\" to report all incorrect include\n\nFixing \"gn check\" errors can be frustrating after a coding\nsession as it only reports the first #include violation in\neach file.\n\nChange HeaderChecker to instead record all errors that are\nfound when checking a file and report all of them.\n\nBug: none\nChange-Id: I2e077090ad176300c570583acecbf34192a9963e\nReviewed-on: https://chromium-review.googlesource.com/1107992\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#569187}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5321951e5a7d0e7d5f819c3bb2057c52174b849f" }, { "commit": "2652160b2a6e3e20eb312be7581cc52ad03856d2", "tree": "66e77ed59dd7174c4cfc775b4f0b098e367fdb7f", "parents": [ "90cda8e01c9f63c077fa2a9997380dbff3ed5203" ], "author": { "name": "Daniel Bratell", "email": "bratell@opera.com", "time": "Mon Jun 18 17:11:45 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jun 18 17:11:45 2018" }, "message": "[gn] Doc: Fix toochain typo and clarify the toolchain syntax.\n\nChange-Id: Ica4288a6984f296958b7f9b812edb07663cec22e\nReviewed-on: https://chromium-review.googlesource.com/1104159\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Daniel Bratell \u003cbratell@opera.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#568046}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6955d08cace26de86b45ac16388d63c4f640cd52" }, { "commit": "90cda8e01c9f63c077fa2a9997380dbff3ed5203", "tree": "f11d7b3c3e8c2985a3b8cdc30bb8b12d086f21bd", "parents": [ "4c6074c043634580f7c571cd7c280c47641db1bc" ], "author": { "name": "Peter Collingbourne", "email": "pcc@chromium.org", "time": "Wed Jun 13 20:04:56 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jun 13 20:04:56 2018" }, "message": "gn: Swap the order of two declarations.\n\nThis allows compilers targeting the MS ABI to select the correct\ninheritance model for the member function pointer types PrefixFunc\nand InfixFunc using the complete type of Parser. It will allow us to\nenable the new Clang flag -fcomplete-member-pointers globally.\n\nBug: 847724\nChange-Id: I5b3488ce0b64b3ac4884bc499cd355e1651d12b3\nReviewed-on: https://chromium-review.googlesource.com/1098515\nCommit-Queue: Peter Collingbourne \u003cpcc@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#566964}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3105b4b4381a42d4b426e46a0ccd901582b0f921" }, { "commit": "4c6074c043634580f7c571cd7c280c47641db1bc", "tree": "30398206643b915c08c44b51135337c78e2ee2c5", "parents": [ "8a9d3b43c6139026d8a572ebccfe7cdb3121fb2f" ], "author": { "name": "Joey Scarr", "email": "jsca@google.com", "time": "Thu Jun 07 00:23:51 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Jun 07 00:23:51 2018" }, "message": "Fix quoting when writing defines on Windows.\n\nFor the following string-valued define:\n defines \u003d [ \"CR_CLANG_REVISION\u003d\\\"$clang_revision\\\"\" ]\nthis was outputting the following on Windows:\n -D\"CR_CLANG_REVISION\u003d\\\"332838-1\\\"\"\nThe Windows shell can\u0027t handle the extra quotes, and so the following\nmacro was being written:\n #define \"CR_CLANG_REVISION \"332838-1\"\"\nThis change moves the first quote to before the -D, allowing Windows to\ncorrectly handle the define parameter.\n\nR\u003dbrettw@chromium.org\n\nBug: 396230\nChange-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1\nReviewed-on: https://chromium-review.googlesource.com/1071274\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Joey Scarr \u003cjsca@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#565117}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 44054a1e89063bf0063cfc4d72632c2f1589ee8b" }, { "commit": "8a9d3b43c6139026d8a572ebccfe7cdb3121fb2f", "tree": "eda71b1f43cb916b42c652b0f80f1e15c0d7180e", "parents": [ "b7e639d523c09c71ee04c91da58be6bd4d79bdef" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Wed May 30 22:20:37 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 30 22:20:37 2018" }, "message": "Remove references to exe_and_shlib_deps in src\n\nAfter [1], a manual dependency on exe_and_shlib_deps is no longer necessary\nsince it\u0027s automatically added. This CL removes all remaining manual references\nto exe_and_shlib_deps.\n\n[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5\n\nBUG\u003d845700\nR\u003ddpranke\nTBR\u003dsky,mark\n\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: I647442fb09eba4c055697bf26504abc3b3284d94\nReviewed-on: https://chromium-review.googlesource.com/1073613\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#563028}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ce772faa73ab8fa58e848b61b786d449bb988237" }, { "commit": "b7e639d523c09c71ee04c91da58be6bd4d79bdef", "tree": "630b4b6c3bf0697527b7c6fba650db61c224c9f6", "parents": [ "9c674660c3b148edbdb6708ef75c3bc3affc7328" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Wed May 30 16:54:15 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 30 16:54:15 2018" }, "message": "Fix GN bootstrap\n\nR\u003ddpranke\nBUG\u003dNone\n\nChange-Id: I1fc07a52e764a3f8f72360309c04fa70c7ed9d72\nReviewed-on: https://chromium-review.googlesource.com/1076983\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#562869}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8492bbe2ef51c0189b99d0e58e24acea53f31e52" }, { "commit": "9c674660c3b148edbdb6708ef75c3bc3affc7328", "tree": "8182f999168db3b4a28591f7acee0896328ef5e8", "parents": [ "9075b04772e64ab7802a13c9df02642519a5ab02" ], "author": { "name": "erikchen", "email": "erikchen@chromium.org", "time": "Wed May 30 15:36:36 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 30 15:36:36 2018" }, "message": "Remove memory peak detection code.\n\nThis CL removes dead code. It has no intended behavior change.\n\nChange-Id: I5f5cabb2e162da82777a168df191c14fd0f9a295\nBug: 847876\nTBR: dpranke@chromium.org\nReviewed-on: https://chromium-review.googlesource.com/1076506\nCommit-Queue: Erik Chen \u003cerikchen@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Siddhartha S \u003cssid@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#562836}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6b9b0c9cc512ffe6b6dad9f37f32186a44756cb5" }, { "commit": "9075b04772e64ab7802a13c9df02642519a5ab02", "tree": "b2d7cbf113f6f223982403a431c5ad3090c04e57", "parents": [ "b586f0f87ba8a7c9a69ccef88d2279589c990bb9" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri May 25 01:40:23 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 25 01:40:23 2018" }, "message": "Add exe_and_shlib_deps to executable and shared_library configs\n\nCurrently, all executables and shared libraries are expected to add the\nexe_and_shlib_deps dependency manually. However, it is easy to forget to do\nthis. In such cases, the build will likely fail at the link step due to missing\nlibc++ symbols. It may not be obvious how to fix this issue.\n\nThis CL adds exe_and_shlib_deps as an implicit dependency to executable and\nshared_library targets so that developers don\u0027t have to manually add it.\n\nBUG\u003d845700\nR\u003ddpranke\nTBR\u003dtorne\n\nChange-Id: I30edcf0bcd6559b1aaa211a42863b04bc57d4d99\nReviewed-on: https://chromium-review.googlesource.com/1069720\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#561729}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: d7ed1f0a9c28c932fddc834ca5de44f28266c7f5" }, { "commit": "b586f0f87ba8a7c9a69ccef88d2279589c990bb9", "tree": "c2dcadf4c3edfd05137d121992c8060e670e9182", "parents": [ "1c6d34ee5860a66150e698ea77fe17d473c96f33" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Thu May 24 22:39:20 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 24 22:39:20 2018" }, "message": "Fix gn bootstrap\n\nR\u003ddpranke\n\nChange-Id: I469e7e478141e7c389f7a16a5e860122785bab44\nReviewed-on: https://chromium-review.googlesource.com/1072740\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#561663}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8aca6d50942218ba7887b8b41a44e4f1b7d6f091" }, { "commit": "1c6d34ee5860a66150e698ea77fe17d473c96f33", "tree": "7b86e6c271c4eaa7d27faab10d933d65e225d581", "parents": [ "35efb6e89e513a43514507c42cf2117f3c83fdca" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed May 23 10:55:15 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 23 10:55:15 2018" }, "message": "Fix typo in gn documentation\n\nAlso updates an improper usage in a BUILD.gn file.\n\nR\u003ddpranke\nBUG\u003dNone\n\nChange-Id: I2d7d96f29165442e8642991a6db942b17b6c5012\nReviewed-on: https://chromium-review.googlesource.com/1069745\nReviewed-by: David Turner \u003cdigit@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#561031}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 524e60fb52e11d589f3a0cc9010e98080bf98e23" }, { "commit": "35efb6e89e513a43514507c42cf2117f3c83fdca", "tree": "0cf82d5873beab9f058414b1841c312ab0950eb8", "parents": [ "eb795bc7ac28f27cfe9cecb4dbef5b52897d7e42" ], "author": { "name": "erikchen", "email": "erikchen@chromium.org", "time": "Tue May 22 20:28:47 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 22 20:28:47 2018" }, "message": "Remove implementation of legacy heap profiler.\n\nThis CL removes unused code. It has no intended behavior change.\n\nThe out of process heap profiler [see components/heap_profiling and\ncomponents/services/heap_profiling] has replaced the legacy heap profiler.\n\nThis CL removes the implementation and allocator hooks. Future CLs will remove\nthe plumbing to enable/disable legacy heap profiler.\n\nBug: 822843\nChange-Id: I79e320c3f17bacf2414c5d0815b5feb4288de7d7\nReviewed-on: https://chromium-review.googlesource.com/1066576\nCommit-Queue: Erik Chen \u003cerikchen@chromium.org\u003e\nReviewed-by: Daniel Cheng \u003cdcheng@chromium.org\u003e\nReviewed-by: Kentaro Hara \u003charaken@chromium.org\u003e\nReviewed-by: Siddhartha S \u003cssid@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560757}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 37097a9654e57b16126e79849eb01df3366e8fb3" }, { "commit": "eb795bc7ac28f27cfe9cecb4dbef5b52897d7e42", "tree": "39496782c78bcb75a4c7e03c86f3d4d83aabd063", "parents": [ "fa8b337f7da6f5493b99ce948df880ee8ffdcab2" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Tue May 22 09:23:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 22 09:23:29 2018" }, "message": "Reland \"GN: do not make indirect dependency to direct dependency\"\n\nThis is a reland of e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4\n\nFix for breakage crbug.com/843351 is below.\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1065591\n\n\nOriginal change\u0027s description:\n\u003e GN: do not make indirect dependency to direct dependency\n\u003e\n\u003e If a target is hard dep, there is no need to have the action targets\u0027s\n\u003e recursive deps as direct dependency, because such dependency is\n\u003e transitive.\n\u003e\n\u003e This is found by pcc in gn-dev\n\u003e https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E\n\u003e\n\u003e With this change, generated android\u0027s toolchain.ninja size is reduced\n\u003e from 262MB to 31MB. And ninja\u0027s startup time reduced from 4.9~5.1s to\n\u003e 2.6s.\n\u003e I used args.gn same with android_n5x_swarming_rel bot.\n\u003e\n\u003e Also this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s\n\u003e on my machine.\n\u003e\n\u003e Change-Id: I0f0214d3abe74143516b263da839e98b3987fb64\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1041506\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#557365}\n\nBug: 843470\nChange-Id: I4d3662613b21a1e520517d152865529aa05e813f\nReviewed-on: https://chromium-review.googlesource.com/1065690\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560520}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3ae94eab7c33428af8e5dcccf85a90975368fa54" }, { "commit": "fa8b337f7da6f5493b99ce948df880ee8ffdcab2", "tree": "54d3d762077660e3a2dcc7a84669a7449275f664", "parents": [ "516f7dceb92e83167baee6b672ce7fb13c109fad" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Mon May 21 19:15:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 21 19:15:53 2018" }, "message": "Fix gn bootstrap\n\nR\u003ddpranke\n\nChange-Id: I880c2cc2a2702db6ebbbd90120753587971bb2be\nReviewed-on: https://chromium-review.googlesource.com/1067581\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560326}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3685d34110d27fa6264a58bfb8c21e1880d07ad2" }, { "commit": "516f7dceb92e83167baee6b672ce7fb13c109fad", "tree": "673388b28eba83c5514a4286dda51bf2642a017e", "parents": [ "44ff5ab0d46356963874dca367dca7409f79f1cd" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Sun May 20 22:32:54 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sun May 20 22:32:54 2018" }, "message": "GN: Handle deps always in create_bundle target\n\nStop to use explicit dependency for indirect dependency in the CL broke\nMac builder.\nhttps://chromium-review.googlesource.com/1041506\n\nThis CL uses deps/public_deps in create_bundle target always not to\nmiss the dependency.\n\nBug: 843470\nChange-Id: Iae66f2a3aec20f67ea2e880bb5fd33d6c2aa2f91\nReviewed-on: https://chromium-review.googlesource.com/1065591\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560203}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 75dfa0ea1bf5f385a36e4d696bb5afeb9a6637bf" }, { "commit": "44ff5ab0d46356963874dca367dca7409f79f1cd", "tree": "61530340d3c5565463e92394c57331d4ea54edf5", "parents": [ "fd77827ad847e3762870ea35b00490172c4c654a" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Fri May 18 20:05:49 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 18 20:05:49 2018" }, "message": "Reland \"Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\"\n\nThis is a reland of 5a7f3c442684be5eeb244b904bbfc8e6edaf6fda\n\ngoma now supports this compiler and the new warnings were dealt with.\n\nOriginal change\u0027s description:\n\u003e Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\n\u003e\n\u003e This change switches the VS 2017 package to use VS 2017 Update 7.1 while\n\u003e using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR\n\u003e features, and to stop forcing external developers to install an old\n\u003e ([Spring] Creators Update) SDK. This change will also bring in a new\n\u003e linker and other build tools, but the version of clang-cl will be\n\u003e unchanged.\n\u003e\n\u003e Packaging was done on a Windows Server 2016 VM, cleanly created for this\n\u003e purpose.\n\u003e\n\u003e Compiler was packaged up by downloading VS 2017 Update 7.1, from\n\u003e https://www.visualstudio.com/vs/, and then passing these parameters to\n\u003e the installer:\n\u003e\n\u003e --add Microsoft.VisualStudio.Workload.NativeDesktop\n\u003e --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended\n\u003e --passive\n\u003e\n\u003e Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add\n\u003e the Debuggers package.\n\u003e\n\u003e Then the packaging script was run like this:\n\u003e\n\u003e python depot_tools\\win_toolchain\\package_from_installed.py 2017 -w 10.0.17134.0\n\u003e\n\u003e Bug: 773476\n\u003e Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1054027\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#559033}\n\nBug: 773476,834213\nChange-Id: I903158f9dfa604f250010a7047496509f51782e7\nReviewed-on: https://chromium-review.googlesource.com/1066130\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560002}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 82a5f004e0e52897a6e8bac10490a14fc2845625" }, { "commit": "fd77827ad847e3762870ea35b00490172c4c654a", "tree": "9c3aa1e09b245c6698243b1af6b8c4a1acfa684a", "parents": [ "a0aaeba0b5455883ac10272f74eb8aa0d2f9eff8" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri May 18 15:26:34 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 18 15:26:34 2018" }, "message": "Fix gn CHECK()ing on not_needed() when given undefined identifiers\n\nGN now gives an error message that looks like:\n\nERROR at //BUILD.gn:76:23: Undefined identifier\n not_needed([\"deps\", \"deps_____________\"])\n ^------------------\n\nR\u003ddpranke\n\nChange-Id: Ic55afef672a7aefab7934875ceb22aff52b68f94\nReviewed-on: https://chromium-review.googlesource.com/1063118\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#559899}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4497a44f0d8236cb069ed89c013154c1adfc2087" }, { "commit": "a0aaeba0b5455883ac10272f74eb8aa0d2f9eff8", "tree": "00aae479b0c7225afcee30639f1a417fb1e5d02f", "parents": [ "75dc3d8e65eb22474b8ab19bc582b7f66c46d444" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Thu May 17 09:35:36 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 17 09:35:36 2018" }, "message": "Revert \"Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\"\n\nThis reverts commit 5a7f3c442684be5eeb244b904bbfc8e6edaf6fda.\n\nReason for revert: this breaks v8\u0027s VC++ goma builds, reverting until\ngoma is updated to support this compiler\n\nOriginal change\u0027s description:\n\u003e Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\n\u003e \n\u003e This change switches the VS 2017 package to use VS 2017 Update 7.1 while\n\u003e using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR\n\u003e features, and to stop forcing external developers to install an old\n\u003e ([Spring] Creators Update) SDK. This change will also bring in a new\n\u003e linker and other build tools, but the version of clang-cl will be\n\u003e unchanged.\n\u003e \n\u003e Packaging was done on a Windows Server 2016 VM, cleanly created for this\n\u003e purpose.\n\u003e \n\u003e Compiler was packaged up by downloading VS 2017 Update 7.1, from\n\u003e https://www.visualstudio.com/vs/, and then passing these parameters to\n\u003e the installer:\n\u003e \n\u003e --add Microsoft.VisualStudio.Workload.NativeDesktop\n\u003e --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended\n\u003e --passive\n\u003e \n\u003e Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add\n\u003e the Debuggers package.\n\u003e \n\u003e Then the packaging script was run like this:\n\u003e \n\u003e python depot_tools\\win_toolchain\\package_from_installed.py 2017 -w 10.0.17134.0\n\u003e \n\u003e Bug: 773476\n\u003e Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1054027\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#559033}\n\nTBR\u003dthakis@chromium.org,dpranke@chromium.org,hubbe@chromium.org,brucedawson@chromium.org\n\nChange-Id: Ib8e84084a9717dafa6616f132b4824d93cbf39bf\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 773476\nReviewed-on: https://chromium-review.googlesource.com/1063810\nReviewed-by: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#559471}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7ad7e759dd35a114375a671f02669c9a0283bea1" }, { "commit": "75dc3d8e65eb22474b8ab19bc582b7f66c46d444", "tree": "7819a679534d8a50e4a3b9193f34c52288fe031b", "parents": [ "9c35719aaeec7e18a215ce99ed791aebe56ab9ad" ], "author": { "name": "Bruce Dawson", "email": "brucedawson@chromium.org", "time": "Wed May 16 10:55:30 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 16 10:55:30 2018" }, "message": "Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\n\nThis change switches the VS 2017 package to use VS 2017 Update 7.1 while\nusing the 10.0.17134.12 SDK. The new SDK is needed to support new HDR\nfeatures, and to stop forcing external developers to install an old\n([Spring] Creators Update) SDK. This change will also bring in a new\nlinker and other build tools, but the version of clang-cl will be\nunchanged.\n\nPackaging was done on a Windows Server 2016 VM, cleanly created for this\npurpose.\n\nCompiler was packaged up by downloading VS 2017 Update 7.1, from\nhttps://www.visualstudio.com/vs/, and then passing these parameters to\nthe installer:\n\n --add Microsoft.VisualStudio.Workload.NativeDesktop\n --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended\n --passive\n\nThen Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add\nthe Debuggers package.\n\nThen the packaging script was run like this:\n\n python depot_tools\\win_toolchain\\package_from_installed.py 2017 -w 10.0.17134.0\n\nBug: 773476\nChange-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b\nReviewed-on: https://chromium-review.googlesource.com/1054027\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#559033}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5a7f3c442684be5eeb244b904bbfc8e6edaf6fda" }, { "commit": "9c35719aaeec7e18a215ce99ed791aebe56ab9ad", "tree": "00aae479b0c7225afcee30639f1a417fb1e5d02f", "parents": [ "cf0ca01c08a7e8c3c478c8e6325c4436822a3de1" ], "author": { "name": "Dirk Pranke", "email": "dpranke@chromium.org", "time": "Wed May 16 02:58:40 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 16 02:58:40 2018" }, "message": "Revert \"GN: do not make indirect dependency to direct dependency\"\n\nThis reverts commit e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4.\n\nReason for revert: Looks to have broken the mac build; see crbug.com/843351 .\n\nOriginal change\u0027s description:\n\u003e GN: do not make indirect dependency to direct dependency\n\u003e \n\u003e If a target is hard dep, there is no need to have the action targets\u0027s\n\u003e recursive deps as direct dependency, because such dependency is\n\u003e transitive.\n\u003e \n\u003e This is found by pcc in gn-dev\n\u003e https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E\n\u003e \n\u003e With this change, generated android\u0027s toolchain.ninja size is reduced\n\u003e from 262MB to 31MB. And ninja\u0027s startup time reduced from 4.9~5.1s to\n\u003e 2.6s.\n\u003e I used args.gn same with android_n5x_swarming_rel bot.\n\u003e \n\u003e Also this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s\n\u003e on my machine.\n\u003e \n\u003e Change-Id: I0f0214d3abe74143516b263da839e98b3987fb64\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1041506\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#557365}\n\nTBR\u003dbrettw@chromium.org,dpranke@chromium.org,pcc@chromium.org,tikuta@chromium.org\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: Id2bbb6fe1c8a0b10ee4b8d77de6ba83124519b68\nReviewed-on: https://chromium-review.googlesource.com/1060673\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#558946}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: fa3fcf6849130fdeded2358d652faee1873b77b9" }, { "commit": "cf0ca01c08a7e8c3c478c8e6325c4436822a3de1", "tree": "4ff51d156ed421cb46a10c88068415a7fa68148c", "parents": [ "635240b0508e6bed78b43e030b3daee9f02b9e91" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Tue May 15 16:45:47 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 15 16:45:47 2018" }, "message": "Fix GN doc formatting.\n\nThere were some missing newlines in the macro expansions for shared\ndocumentation that made the action and action_foreach docs look\nwrong.\n\nclang-format also changed the way the macros are defined.\n\nChange-Id: Id32ac1f625db86008268c1692eed970f0ae59c10\nReviewed-on: https://chromium-review.googlesource.com/1057890\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#558749}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 443b70dbfef278f675381ca25cc9649a78211968" }, { "commit": "635240b0508e6bed78b43e030b3daee9f02b9e91", "tree": "6fd71152cc5a86da1653917f1f3ffb947c650127", "parents": [ "a957bfdb057498c62408ac11ca569e85d22a8d39" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Wed May 09 23:00:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 09 23:00:12 2018" }, "message": "GN: do not make indirect dependency to direct dependency\n\nIf a target is hard dep, there is no need to have the action targets\u0027s\nrecursive deps as direct dependency, because such dependency is\ntransitive.\n\nThis is found by pcc in gn-dev\nhttps://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E\n\nWith this change, generated android\u0027s toolchain.ninja size is reduced\nfrom 262MB to 31MB. And ninja\u0027s startup time reduced from 4.9~5.1s to\n2.6s.\nI used args.gn same with android_n5x_swarming_rel bot.\n\nAlso this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s\non my machine.\n\nChange-Id: I0f0214d3abe74143516b263da839e98b3987fb64\nReviewed-on: https://chromium-review.googlesource.com/1041506\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#557365}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4" }, { "commit": "a957bfdb057498c62408ac11ca569e85d22a8d39", "tree": "6142c36616b39d85755f84778cf7ba53033e539d", "parents": [ "ed1979534089c005aab6923da37101c9f755bff5" ], "author": { "name": "Avi Drissman", "email": "avi@chromium.org", "time": "Mon May 07 18:55:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 07 18:55:12 2018" }, "message": "Fully move PathService into the base namespace.\n\nBUG\u003d838398\n\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.win:win10_chromium_x64_rel_ng\nChange-Id: Ibb79d0d8090cece52d7a20269153718992c8c2d1\nReviewed-on: https://chromium-review.googlesource.com/1036570\nCommit-Queue: Avi Drissman \u003cavi@chromium.org\u003e\nReviewed-by: Will Harris \u003cwfh@chromium.org\u003e\nReviewed-by: John Abd-El-Malek \u003cjam@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#556512}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ea15ea06b514d9a95af39d7e35235fdf948da0c8" }, { "commit": "ed1979534089c005aab6923da37101c9f755bff5", "tree": "aa40e3ba7200c6a810dc0002eb8d5253ac98f253", "parents": [ "ee9c5643a6eb1f561b6742bd6212d6d19c72dcd9" ], "author": { "name": "Peter Collingbourne", "email": "pcc@chromium.org", "time": "Fri May 04 00:40:31 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 04 00:40:31 2018" }, "message": "GN: Make the linker output file depend on the inputs.\n\nThis is useful for files that are only read by the linker, such as\norderfiles. We were normally getting this right in the case where\nthe target contained at least one source file, as the output file\nwould transitively depend on the inputs via the source files, but if\nthe target only contained dependencies on other targets, the inputs\nwouldn\u0027t be depended on at all.\n\nBug: 835622\nChange-Id: Ic7fb39caeacd4698b7ec6cfb0cb583a429a117dd\nReviewed-on: https://chromium-review.googlesource.com/1041274\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Peter Collingbourne \u003cpcc@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555931}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: ae62ba99a1a71db0758616215a557053d5fcf72a" }, { "commit": "ee9c5643a6eb1f561b6742bd6212d6d19c72dcd9", "tree": "4cd7826410582c7e2a1e46e408d62f1fefdf4616", "parents": [ "5bf21bcc6cc3062c6c1556940110f62990f858bf" ], "author": { "name": "Gabriel Charette", "email": "gab@chromium.org", "time": "Tue May 01 22:53:54 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 01 22:53:54 2018" }, "message": "[MessageLoop] Fix message_loop.h includes\n\nRemoving 622 unnecessary includes and adding 14 missing includes.\n\nScript used @ https://crbug.com/825327#c155 (tweaked from https://crbug.com/825327#c151)\n\nR\u003dfdoray@chromium.org\nTBR\u003djam@chromium.org\n\nBug: 825327\nCq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs\nChange-Id: I943b9cd10d3c4ee7fb096c648a618a9a7032684c\nReviewed-on: https://chromium-review.googlesource.com/1035788\nCommit-Queue: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: Gabriel Charette \u003cgab@chromium.org\u003e\nReviewed-by: François Doray \u003cfdoray@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555209}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 629ba73c96e4d8903ab360a7c14ff314851b584b" }, { "commit": "5bf21bcc6cc3062c6c1556940110f62990f858bf", "tree": "c887be0aaf77eab3dd66be1be29d3ceb0456920c", "parents": [ "47ea1097a9b0abaff89b58f894cab8a30ed07f38" ], "author": { "name": "Eli Ribble", "email": "eliribble@chromium.org", "time": "Tue May 01 21:42:04 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 01 21:42:04 2018" }, "message": "Show error with gn desc when no matches are made\n\nThis tells the user that they input a value that matches nothing\nso that they know they need to correct the input and try again\nrather than showing no output and acting like the command worked\ncorrectly\n\nBug: 646012\nChange-Id: I9e796a4a09216dde8939e4a60b255f8beff0c52b\nReviewed-on: https://chromium-review.googlesource.com/1037910\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Eli Ribble \u003celiribble@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555188}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9e71c94d75e6c6e8fecbb601ddde8d3f35c4fba1" }, { "commit": "47ea1097a9b0abaff89b58f894cab8a30ed07f38", "tree": "f65a92f335a3bd24321946effad0aff8901b4c0b", "parents": [ "32643fb7091989579b8e2c05dfd8ce880345298f" ], "author": { "name": "Dirk Pranke", "email": "dpranke@chromium.org", "time": "Tue May 01 19:17:34 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue May 01 19:17:34 2018" }, "message": "Make `gn refs out/foo //out/foo/gn` work.\n\nIt would be good if we could use `gn refs` to tell us which\ntarget generated a given executable. The docs suggested that\nrefs should do this, but it doesn\u0027t appear to do so.\n\nBug: 837876\nChange-Id: I45f45bb3346ed21ede83fbacdea2207f1322ad69\nReviewed-on: https://chromium-review.googlesource.com/1033506\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#555134}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3d36fd0d000ced51aa0a2848b1df0b2cd36cc4c5" }, { "commit": "32643fb7091989579b8e2c05dfd8ce880345298f", "tree": "20a616a28f20c8e657a7a4754c515ba3e60f2c49", "parents": [ "3200906b11e8548b4cd9bf6d2ef787cbe0073e9c" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@chromium.org", "time": "Mon Apr 30 22:13:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 30 22:13:29 2018" }, "message": "GN: Do not serialize builds on targets with no public deps.\n\nWhen binary target A does not have a public header, a binary target B that\ndepends on A does not need to wait for A\u0027s hard deps to finish. But,\nin current GN, it does.\n\nSuch dependencies unnecessarily serialize the build and sometimes long compile\ntask significantly impact the overall build speed. This CL deserializes\nthe dependencies so that B does not wait on A.\n\nThis is an implementation of\nhttps://groups.google.com/a/chromium.org/d/msg/gn-dev/1DiphV5ZnqU/c85P4ctvAQAJ\n\nWe will use this to optimize the build dependencies, especially for the\ndependencies between v8 and chrome.\n\nBug: 578477\nChange-Id: If3dffc68557a365f034e74033fa88b5b7bbdbd53\nReviewed-on: https://chromium-review.googlesource.com/1032320\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#554896}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 94042177671bb236911fc042b651fa34eb5bd939" }, { "commit": "3200906b11e8548b4cd9bf6d2ef787cbe0073e9c", "tree": "84b12b3bef9e5bd0d912a6038865dba33bcf167d", "parents": [ "0fa417a0d2d8484e9a5a636e3301da322f586601" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Apr 27 18:07:35 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 27 18:07:35 2018" }, "message": "Fix gn bootstrap\n\nBUG\u003d837312\nR\u003ddpranke\n\nChange-Id: Ia5c57f596388a4ba325208c638fac558984202f0\nReviewed-on: https://chromium-review.googlesource.com/1030895\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#554419}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0d3bbfb6b8ba05af199b49f5dd71d842f6acffda" }, { "commit": "0fa417a0d2d8484e9a5a636e3301da322f586601", "tree": "b7340d280a6a3394bd95c43bbd75ad6aff78ff66", "parents": [ "ede20bdacc959b672b8111dff9c133f268217ec9" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Apr 20 18:00:17 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 20 18:00:17 2018" }, "message": "Re-run `gn help --markdown all \u003e tools/gn/docs/reference.md`.\n\nThis should\u0027ve been part of https://chromium-review.googlesource.com/c/chromium/src/+/1020010\n\nBug: 835319\nChange-Id: Ibad6a9b3f686ed8305ffc77c866917124fef9ba5\nReviewed-on: https://chromium-review.googlesource.com/1021597\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#552387}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a8fe0c1bdb12ce92c841d4527b54ae3e023cb590" }, { "commit": "ede20bdacc959b672b8111dff9c133f268217ec9", "tree": "9a65f9b62d1eb369a428b4d4aa0f442ab9b16fb8", "parents": [ "5738843fd74319458ce589d8ff4fe32cf030cd30" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Apr 20 16:25:14 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 20 16:25:14 2018" }, "message": "gn: Don\u0027t write invalid output when pool //:console exists; treat all other pools named \u0027console\u0027 as invalid.\n\nBefore, defining and referencing pool \"//:console\" would make gn write a\nninja file that tries to redeclare ninja\u0027s built-in console pool, causing\nninja to reject the generated manifest file.\n\nDon\u0027t write pools definitions that cause this. This means //:console now represents\nninja\u0027s built-in console pool.\n\nDisallow pools in other scopes or in the non-default toolchain to be called \"console\".\nIf this was allowed but these pools behaved like regular pools instead of like the\nconsole pool, that\u0027d be confusing. If they\u0027d all behave like the console pool,\nthat would be inconsistent with how regular pools work in gn -- the pool depth\nthere is per-toolchain, while it\u0027d always be globally 1 shared among all console pools\nin all toolchains.\n\nWhile here, also improve the source location for the \"pool depths must not be negative\"\ndiagnostic.\n\nBug: 835319\nChange-Id: Idbec9c08f42a0de7b316d8e5e8819c6c8c3c3c45\nReviewed-on: https://chromium-review.googlesource.com/1020010\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#552353}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e9867a58c30f15c66d0b08b5f78050ff127155f9" }, { "commit": "5738843fd74319458ce589d8ff4fe32cf030cd30", "tree": "530b5ce9cf1b6b970e2748118532c0680e3f78f2", "parents": [ "7180232fb9093a92be20ea82abc09d3169f04403" ], "author": { "name": "Mirko Bonadei", "email": "mbonadei@chromium.org", "time": "Fri Apr 20 16:11:10 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 20 16:11:10 2018" }, "message": "Update GN reference page.\n\nAutomatically generated with `gn help --markdown all`.\n\nThis refresh will add documentation for the new \"friends\" feature.\n\nBug: None\nChange-Id: Ie330a2e53be8e8f5b76cab2211aa82bad6b47138\nReviewed-on: https://chromium-review.googlesource.com/1020526\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#552349}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cd02e3d2d629291fda867a4099b4120a6d49902b" }, { "commit": "7180232fb9093a92be20ea82abc09d3169f04403", "tree": "8c109bb0915449b093ed7589376230b9a01bef06", "parents": [ "e56121ac4235dde5c6e74f3b3d50158b7b121384" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Tue Apr 17 15:26:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 17 15:26:29 2018" }, "message": "GN: Fix bootstrap call to setup_toolchain\n\nThe parameters to setup_toolchain changed, adding an OS parameter and a\nfilename for the environment file.\n\nAdditional fixes:\n- Add missing base file to list of files\n- vs_toolchain should output Windows paths properly escaped\n\nChange-Id: I0e05bf34c8b603f16b901e76164e480121ed9d14\nReviewed-on: https://chromium-review.googlesource.com/1013926\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#551341}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 95fe44b3c31cf5e1a668d9ef8853aaf2cf9523a5" }, { "commit": "e56121ac4235dde5c6e74f3b3d50158b7b121384", "tree": "85c9de22ef80d03c4a38c12f07560679a58d56b2", "parents": [ "1d6245d0f94286bbd9536212bc366303c6ac8c27" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Mon Apr 16 21:53:56 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 16 21:53:56 2018" }, "message": "Fix gn bootstrap\n\nBUG\u003d833179\nR\u003ddpranke\n\nChange-Id: Ie9fa320c6d532844f85d34f5d6f8a1195a9eb107\nReviewed-on: https://chromium-review.googlesource.com/1014263\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#551134}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8ff145a7c498f584ad875c877fff95e841db9ed1" }, { "commit": "1d6245d0f94286bbd9536212bc366303c6ac8c27", "tree": "cbb1e59646e8b868ff947f13fa53625708b91003", "parents": [ "d22bd8dd75d7c6d3cd1863142ac8b4151e001f0a" ], "author": { "name": "Michał Pichliński", "email": "mpichlinski@opera.com", "time": "Thu Apr 12 12:45:14 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 12 12:45:14 2018" }, "message": "GN: Allow XCode projects to use ICECC environment variables.\n\nWithout them XCode cannot compile generated projects with ICECC.\n\nBug: 831500\nChange-Id: I3b50c730660c4e8a6a06b9fda340e20edb87e40a\nReviewed-on: https://chromium-review.googlesource.com/1006577\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Michal Pichlinski \u003cmpichlinski@opera.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#550159}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5208b8e8bb6ba0038016d17abac6911f3067b088" }, { "commit": "d22bd8dd75d7c6d3cd1863142ac8b4151e001f0a", "tree": "76191130c971d872ac310090ed576cb45ac91147", "parents": [ "2d31571b90517ffee59486a24810a3dd5870a942" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Tue Apr 10 18:04:03 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 10 18:04:03 2018" }, "message": "Fix gn bootstrap\n\nTBR\u003ddpranke\n\nChange-Id: I72e33bdcd009b62853434507f3096199e921c28d\nReviewed-on: https://chromium-review.googlesource.com/1005446\nReviewed-by: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#549588}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e20ec0676c3adbdb4fb37acc17e692cb397f8ed0" }, { "commit": "2d31571b90517ffee59486a24810a3dd5870a942", "tree": "58c44c913b6832ce82fb07ae169bd560fa0db5e4", "parents": [ "0f35b2eb1f863917dc818a6a858eb3b6d89a2070" ], "author": { "name": "Julie Hockett", "email": "juliehockett@google.com", "time": "Fri Apr 06 23:11:00 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 06 23:11:00 2018" }, "message": "[gn] Updating args --list to make the comment padding optional\n\nUpdating the comment to not be prefixed with three spaces for json\noutput and removing extraneous output.\n\nChange-Id: Iaeee0809ce3cff050a1d3eec5f34f885677802a8\nReviewed-on: https://chromium-review.googlesource.com/1000392\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Julie Hockett \u003cjuliehockett@google.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548956}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 12bd7ed6ad7773920fe303d54ef1be9b4798ccb1" }, { "commit": "0f35b2eb1f863917dc818a6a858eb3b6d89a2070", "tree": "f0a89e2c68c51a74bda99173f7588fc9ae35ed4a", "parents": [ "9b5c68dc6946779f3972f5a2ebcb3adde2a93752" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Apr 06 19:08:45 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 06 19:08:45 2018" }, "message": "Fix grammar-o in gn\u0027s help.\n\nChange-Id: Id6d327ce5631c6078a45760eee7597a3dfc90416\nReviewed-on: https://chromium-review.googlesource.com/1000023\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548882}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 743a7a884c8d1008067f662c003c7e1d31c39d73" }, { "commit": "9b5c68dc6946779f3972f5a2ebcb3adde2a93752", "tree": "79032a844158d5b0415f3ef2da8ad156ca5f8578", "parents": [ "5d1f76814f12e13bbb20a303ab7fc01239c9618c" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Thu Apr 05 01:14:20 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Apr 05 01:14:20 2018" }, "message": "Implement \"friend\" for GN header checking.\n\nThis allows a target to include private headers it wouldn\u0027t otherwise be\nable to include. A target can provide a list of patterns of friend\ntargets that allow dependent targets to bypass public header checking.\n\nA proper dependency path is still required, this applies only to the\nconcept of public/private headers on a target. Without this, it\u0027s\ndifficult to make a target be explicit about its public headers while\nalso allowing that target\u0027s own tests to use internal headers.\n\nBUG\u003d732993\n\nChange-Id: I1cb94c7ac0db6f74cdcd49d08bcabedf70ea3eb0\nReviewed-on: https://chromium-review.googlesource.com/994453\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548279}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 28f3c4987aacf447643a4f36e4553cc830508b0b" }, { "commit": "5d1f76814f12e13bbb20a303ab7fc01239c9618c", "tree": "5d6e74af46824f25520b9cad49680cda4873f32f", "parents": [ "3d65d46f04d0eda6ed68353de2b55982e18e4ff8" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Wed Apr 04 21:49:37 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 04 21:49:37 2018" }, "message": "GN: Use source root as base for gn gen filters\n\nWhen running gn gen with filters for the IDE output from ninja,\nthe gn gen command used the working directory (//out/foo) as the\nbase for resolving the filters, rather than \"//\" as is done when\nrunning gn gen directly.\n\nThis CL fixes that by always using \"//\" as the root_dir. It also\nfixes filter labels that have had the leading \"/\" in \"//\" removed\nby Git Bash.\n\nR\u003ddpranke@chromium.org\n\nChange-Id: I6c6e6f5e720d50b325d8b368f94ee1b3b5931627\nReviewed-on: https://chromium-review.googlesource.com/941209\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#548215}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f7ccdc763eb515b93850db40cc6ea44c02e2015a" }, { "commit": "3d65d46f04d0eda6ed68353de2b55982e18e4ff8", "tree": "254fa8fd820ada22591cf820c25388054114f29e", "parents": [ "fdc290b601d3004457f41f861077cce607af2dcb" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Tue Apr 03 23:35:08 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 03 23:35:08 2018" }, "message": "GN: Improve bootstrap for Windows\n\nImprove bootstrap for Windows and allow bootstrap to work in specified\ntarget directory. Additionally, some fixes made to project generation,\nand for Linux.\n\nR\u003ddpranke@chromium.org\n\nChange-Id: Ied7f99d3cb83559fbde597cb707b46fcb3e98dc4\nReviewed-on: https://chromium-review.googlesource.com/941214\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#547867}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 73b7854e6d4c7a186047809aacb9ce1478277c7a" }, { "commit": "fdc290b601d3004457f41f861077cce607af2dcb", "tree": "7f29b5ecd63a7c62e4cf850fdcdb0cdade3644ed", "parents": [ "8608a073173dd52354da6ff83d0a926f78bbee63" ], "author": { "name": "Julie Hockett", "email": "juliehockett@google.com", "time": "Tue Apr 03 17:54:03 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Apr 03 17:54:03 2018" }, "message": "[gn] Updating args --list to emit json\n\nUpdates the gn args --list command with an additional --json flag, which\nemits the same information as the normal --list command but in json\nformat.\n\nIntended to be used to generate structured documentation for GN build\narguments. The --markdown output is nice, but we want to do more\nprocessing than that to get it into good shape to integrate with our docs.\n\nAlso updates the GetContextForValue function to get the file and the\nline number separately, rather than as one string, and updates the\ncallsites with the new parameters.\n\nChange-Id: Id1240c37f835a18a12a6e4f5be58b9f8c7a663d1\nReviewed-on: https://chromium-review.googlesource.com/978423\nCommit-Queue: Julie Hockett \u003cjuliehockett@google.com\u003e\nReviewed-by: Roland McGrath \u003cmcgrathr@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#547759}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 8ca5c09bb15f1584155c9e295ff0725be5990d9a" }, { "commit": "8608a073173dd52354da6ff83d0a926f78bbee63", "tree": "f57f08c58fe379b716cc164a0291823919a4b45f", "parents": [ "17e1a71f846237388d798bea82b6a0c8cb775c69" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Mon Apr 02 23:29:09 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Apr 02 23:29:09 2018" }, "message": "Fix gn bootstrap\n\nBUG\u003d827899\nR\u003ddpranke\n\nChange-Id: Idb5832232d46ffda9df2d540523031a9edfdad44\nReviewed-on: https://chromium-review.googlesource.com/990959\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#547559}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e65dd61a5fea51751b5be4cdeede0aedc0eb34d6" }, { "commit": "17e1a71f846237388d798bea82b6a0c8cb775c69", "tree": "98f6329eb52e8348e50bdd5b7640fdf0ce69760e", "parents": [ "670c3c5d9362eeb474c5cec2faee1d5ee4390199" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Tue Mar 27 18:02:03 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 27 18:02:03 2018" }, "message": "Fix gn bootstrap\n\nR\u003ddpranke\n\nChange-Id: I9f93686d2bab2d3625363142bb05349817e1c5b5\nReviewed-on: https://chromium-review.googlesource.com/982250\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#546160}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c89b8fabf7a9234c9d073cad1e5931d10fa28a34" }, { "commit": "670c3c5d9362eeb474c5cec2faee1d5ee4390199", "tree": "a32848287d09511fd60bdc766bba2346a4ec2a6c", "parents": [ "697698468acaebebfd4678a8065bb29e1c57b400" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Mon Mar 19 23:36:09 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 19 23:36:09 2018" }, "message": "GN: Don\u0027t crash when mutating the list in a foreach.\n\nAvoid a crash caused by mutation of the list being iterated over from inside\nthe foreach loop. This does a full copy of the the iterated list since the\ncode inside can\u0027t mutate the array via the loop variable anyway. Although\ntheoretically slower, this doesn\u0027t seem to have a measurable performance\nregression in practice (we generally iterate over few large lists).\n\nAdds documentation and tests for iteration while mutating the underlying list\nvariable.\n\nBug: 818525\nChange-Id: I221fa230685b8998f5874154cad8d5c655b8006c\nReviewed-on: https://chromium-review.googlesource.com/959228\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Roland McGrath \u003cmcgrathr@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#544209}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: dcba727e7e8b00cb26c4d797d956d48d2e98371f" }, { "commit": "697698468acaebebfd4678a8065bb29e1c57b400", "tree": "d9b1c2cf1d54dc9d7bd411f7f64446bceab6272d", "parents": [ "73e6abb2b6d291a9d4123626b4968ef400acbb01" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Mon Mar 19 23:18:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 19 23:18:12 2018" }, "message": "GN: Correct Git Bash removal of leading \"/\" of \"//\" labels\n\nGit bash on Windows will remove the leading slash for \"//\" labels,\nchanging absolute labels from //foo to /foo. This CL fixes these labels\nback to //foo, file system absolute labels are not \"fixed\".\n\nThis modification by Git Bash may be a bug, but looking at the source,\nthe removal seems to be intentional.\n\nChange-Id: I16d0ca796ce4c1187717f97ab9c3b1c14a6c6a73\nReviewed-on: https://chromium-review.googlesource.com/957084\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#544203}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3325da9a7b57fc48650ada6839c74f96d22f3a7c" }, { "commit": "73e6abb2b6d291a9d4123626b4968ef400acbb01", "tree": "e1f65ed3a18ac8c3ec4dc4f8cfdba12d893991ae", "parents": [ "02c0061e680f0f217be59fa3f2037d7ea8975688" ], "author": { "name": "Pawel Pluciennik", "email": "ppluciennik@opera.com", "time": "Tue Mar 13 02:00:05 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 13 02:00:05 2018" }, "message": "Improved GN code related to resolving paths.\n\nMoved most of the logic related to resolving paths\nto ResolvePath and ResolveRelative in filesystem_utils.cc.\nImproved SourceDir class to return std::string with resolved path\nfor cases when returning SourceDir or SourceFile wasn\u0027t really needed.\n\nR\u003dbrettw@chromium.org, dpranke@chromium.org\n\nBug: 819720\nChange-Id: Ia59da00e83de45431762ebb19a9153471f7e91e3\nReviewed-on: https://chromium-review.googlesource.com/953422\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#542692}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 36773f30d94495bc81193a52b49504d2e137b9e3" }, { "commit": "02c0061e680f0f217be59fa3f2037d7ea8975688", "tree": "165b5954978a53da45d07082045eb5d205b57ceb", "parents": [ "e981e714d63e80caa6553439f35e9895ae04b5c3" ], "author": { "name": "Peter Collingbourne", "email": "pcc@chromium.org", "time": "Thu Mar 08 17:50:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 08 17:50:12 2018" }, "message": "gn clean: Don\u0027t delete and recreate the build directory.\n\nThis makes the behaviour of \u0027gn clean .\u0027 a little more shell-friendly.\nPreviously gn would delete the shell\u0027s current directory, which would\nput the shell session into a confusing state where many commands\ndon\u0027t work without re-entering the directory.\n\nBug: 810548\nChange-Id: I2f8849a770a394fe4c38ee771d0eb765dcbe1360\nReviewed-on: https://chromium-review.googlesource.com/954703\nCommit-Queue: Peter Collingbourne \u003cpcc@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#541830}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1252d9cdc7a734579d6a6be97314c5cc541a7ccc" }, { "commit": "e981e714d63e80caa6553439f35e9895ae04b5c3", "tree": "91576767bf3a2857484de4cef02660badf862a62", "parents": [ "715cda32344b95d836a8b81ec5b6f7e8f912ba7b" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Tue Mar 06 00:01:06 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Mar 06 00:01:06 2018" }, "message": "Update GN docs.\n\nThe README file is two years out of date. This removes the transition status\nand references to GYP, and just retains the links to related documentation.\n\nFixes a help typo.\n\nChange-Id: Ie783f32e90eb24643ba06698ddc0b3206116c724\nReviewed-on: https://chromium-review.googlesource.com/949769\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#540994}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 2caa6c11ddb31646cabb905abd9b85785058b827" }, { "commit": "715cda32344b95d836a8b81ec5b6f7e8f912ba7b", "tree": "d799039e449b3bfd08221494b5eed18e3a2e3761", "parents": [ "76e05cbb6abff9a3ec785b9d32f7274e2864a34c" ], "author": { "name": "Chris Palmer", "email": "palmer@chromium.org", "time": "Mon Mar 05 23:34:29 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Mar 05 23:34:29 2018" }, "message": "Correct off-by-one in `Tokenizer::CanIncrement`.\n\nIt would return true even if you were actually at the end of the input.\n\nBug: 818844\nChange-Id: I0ba5be52b568e39a087efc1e8114138ac4c18799\nReviewed-on: https://chromium-review.googlesource.com/949963\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Chris Palmer \u003cpalmer@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#540982}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 6783e46fa01a4da9c9b764d1858eb3c3f9b03f9e" }, { "commit": "76e05cbb6abff9a3ec785b9d32f7274e2864a34c", "tree": "113fb82f83861a7cb4f9973c43eccdb9879bc074", "parents": [ "46a2f032c2cb77f9f5258ce2a327ec8fe775d091" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Thu Mar 01 23:42:34 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 01 23:42:34 2018" }, "message": "GN: Force normal subprocess task priority on Windows\n\nIn some cases, at least when starting as a scheduled task, Windows\nsubprocesses are started with a very low priority. Therefore, force\nnormal process priority when starting a subprocess.\n\nR\u003ddpranke@chromium.org\n\nChange-Id: Ib9e8f9bb1f6d06cffeeab3694508df9e755f8a19\nReviewed-on: https://chromium-review.googlesource.com/941229\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#540349}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 1bcad90daf3db51b25155a28140a76bdd69830e2" }, { "commit": "46a2f032c2cb77f9f5258ce2a327ec8fe775d091", "tree": "2249ea482e7e3d48133167af46c5cc42ccd595ac", "parents": [ "fd918f1d1a48f78f7d5f02458bd669f01ef279c4" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Thu Mar 01 23:33:12 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 01 23:33:12 2018" }, "message": "GN: Fix Mac bootstrap compile error\n\nMac C++ compiler is not able to convert a base::ListValue\nunique pointer object to a base::Value unique pointer object.\n\nR\u003ddpranke@chromium.org\n\nChange-Id: I07072578bd432c1a6ea13ca9757c75c3da37107c\nReviewed-on: https://chromium-review.googlesource.com/941208\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#540348}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: a3ec9fb724c02ae006b3c27a9d125b7944d62cc3" }, { "commit": "fd918f1d1a48f78f7d5f02458bd669f01ef279c4", "tree": "2b6ae2cbd7a4f33c099b7f7543dc7d8dab7a6c4c", "parents": [ "a51d79f8ccb200319968740d1ab4f2c31de28594" ], "author": { "name": "Yngve N. Pettersen", "email": "yngve@vivaldi.com", "time": "Thu Mar 01 03:03:51 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Mar 01 03:03:51 2018" }, "message": "GN: Make sure print function flushes stdout to avoid output delays\ncaused by buffered pipes.\n\nR\u003ddpranke@chromium.org\n\nChange-Id: I02d459726488e8aeb126d34bcddd73b885833a98\nReviewed-on: https://chromium-review.googlesource.com/941207\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Yngve Pettersen \u003cyngve@vivaldi.com\u003e\nCr-Original-Commit-Position: refs/heads/master@{#540011}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: bbc17a39656082b3559be1ec6bdbf694b614ceb4" }, { "commit": "a51d79f8ccb200319968740d1ab4f2c31de28594", "tree": "3a8fb02edc0057db5dff94678f60f74ef24a69d7", "parents": [ "bd5a270e1c0aa4c0bcc2fae6e2366213d32ceb0c" ], "author": { "name": "Tim Brown", "email": "timbrown@chromium.org", "time": "Fri Feb 23 20:35:19 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Feb 23 20:35:19 2018" }, "message": "Remove reference to deleted sequenced_worker_pool\n\nBug: 815232\nChange-Id: I7fad2ccc0c63b16839fb4f43b095bbfb41e844fd\nReviewed-on: https://chromium-review.googlesource.com/935156\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Tim Brown \u003ctimbrown@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#538882}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 99637d39f360b06fa4d3692f837637a2203d4c75" }, { "commit": "bd5a270e1c0aa4c0bcc2fae6e2366213d32ceb0c", "tree": "c62daa79b33dc5dc3eb1aa378295ff8ad00fb1b5", "parents": [ "b52620af47af819de680c676aab14707c5834fcb" ], "author": { "name": "Scott Violet", "email": "sky@chromium.org", "time": "Thu Feb 22 02:08:08 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Feb 22 02:08:08 2018" }, "message": "Rename buildflag_header targets in base for consistency\n\nTargets go from foo_features to foo_buildflags\nAnd similarly the header now has buildflags in the name.\n\nBUG\u003d814485\nTEST\u003dcovered by build\n\nChange-Id: Ib936c2840991902fa33c040b381b8ffc98a3c532\nReviewed-on: https://chromium-review.googlesource.com/930033\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nCommit-Queue: Scott Violet \u003csky@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#538310}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 4416579b311cc64b476335b5d46ddbfa6131ed0e" }, { "commit": "b52620af47af819de680c676aab14707c5834fcb", "tree": "390c31ef90df9f0f49bb54a11bd43e0fd3fd0bf6", "parents": [ "ec876d0d90f9faec636592028d2c32745195c31c" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Mon Feb 12 18:19:41 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 12 18:19:41 2018" }, "message": "gn: Write no stamp files for action inputs.\n\nAlso omit input stamp files that are referenced only once in\nother places. Stamp files are apparently somewhat expensive\nto create on Windows (crbug.com/787903)\n\nRemoves 1817 stamp files from the main toolchain.ninja file in\nmy chrome/linux build, and reduces toolchain.ninja size by 3MB.\n\nNo intended behavior change.\n\nBug: 810978\n\nChange-Id: I33ed07bc473b245e4c27414012681f238980e9fa\nReviewed-on: https://chromium-review.googlesource.com/912536\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#536132}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: cf54d20bfce0f557b4d6d5cea5d46ce1c2fc7909" }, { "commit": "ec876d0d90f9faec636592028d2c32745195c31c", "tree": "aa77fe09cb396654c95494f32569c3835600c291", "parents": [ "fe4c8a230e019cbc243d3d3b9164aa8e117850d9" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Sat Feb 10 00:00:31 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Feb 10 00:00:31 2018" }, "message": "Fix gn reference in build.ninja after bootstrapping\n\nAfter bootstrapping gn, build.ninja has a reference that looks something like:\ncommand \u003d ../../../../../../../../../../tmp/tmp9Pn0sv/gn --root\u003d../.. -q gen .\n\nThis reference will be broken when the OS removes the temporary directory. This\nCL regenerates the build files using the gn executable from the build directory.\n\nThis on its own will update the reference to plain \"gn\", however we need the\nreference to be \"./gn\", because \"gn\" might not exist in the PATH, or would point\nto an old one from depot_tools.\n\nBUG\u003d808829\nR\u003ddpranke\n\nChange-Id: I1b156a6af081a35ded152946af13a117563b8c1a\nReviewed-on: https://chromium-review.googlesource.com/905793\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#535892}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 00eba186828272462f318ee7ff4ed2106a6388a7" }, { "commit": "fe4c8a230e019cbc243d3d3b9164aa8e117850d9", "tree": "5eb86bdd7cfe2408d29a1b04c6dc3b7517665a87", "parents": [ "53595badf61855dad9cf059c972e07ad3a2a59d0" ], "author": { "name": "Petr Hosek", "email": "phosek@chromium.org", "time": "Wed Feb 07 18:53:08 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Feb 07 18:53:08 2018" }, "message": "Support for JSON input conversion\n\nThis adds support for reading JSON files in GN and converting them\nto equivalent GN values.\n\nChange-Id: I5bca3abb4668da852774d69c98d4dd6575a42957\nReviewed-on: https://chromium-review.googlesource.com/894857\nCommit-Queue: Petr Hosek \u003cphosek@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#535078}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: c986c354e49a7360b947d3406e8a05ac360b5b1c" }, { "commit": "53595badf61855dad9cf059c972e07ad3a2a59d0", "tree": "de288079d2d4359d19392b4a1288f132b453b909", "parents": [ "ef7f1cd404fa4529bddab4ab608a6b1c2e06be91" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Mon Feb 05 17:54:27 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Feb 05 17:54:27 2018" }, "message": "Only run \"gn check\" on binary targets.\n\nWe ran into a case where a copy step triggered a check failure because the\nsource of a copy had a .h extension. But copy targets should not trigger header\nchecking.\n\nThis change excludes non-binary targets from checking altogether.\n\nWriting a test for this ended up being quite involved. The existing header\nchecker tests all tie in at a lower layer to avoid complicated dependencies on\nreal files. In the end, I decided the benefit of a test for this check is not\nworth the added complexity (and potential flakiness) of adding a new class of\ncheck tests that use actual files.\n\nChange-Id: I819db52d791cf3b4683fca584937f16ec4a14200\nReviewed-on: https://chromium-review.googlesource.com/899930\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#534416}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: b46dd8bef522b08b069db7d42506bc416b555f34" }, { "commit": "ef7f1cd404fa4529bddab4ab608a6b1c2e06be91", "tree": "c6ff5c19b7de78c75505e613118de338b32077ee", "parents": [ "bb444d7de502622f3038ddacd027ef6a418c97ae" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Wed Jan 31 22:45:44 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 31 22:45:44 2018" }, "message": "Fix gn bootstrap on systems with an old libstdc++\n\nRunning GN bootstrap on Trusty (which has libstdc++ 4.8) will result in build\nerrors caused by missing features in the old libstdc++ headers. This CL\nbootstraps gn with libc++ to prevent this type of issue in the future. This is\nneeded to fix the gn bootstrap step of the \"Build From Tarball\" bot.\n\nBUG\u003d800977\nR\u003ddpranke\n\nChange-Id: Icb5415088adf5e757ad082f3a1edc83ec0f77323\nReviewed-on: https://chromium-review.googlesource.com/895394\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533454}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: e93e6df04b6b08ad34060fba69144b2aea0352ba" }, { "commit": "bb444d7de502622f3038ddacd027ef6a418c97ae", "tree": "d2cbb52f894cd040878a0972dfde8eac3720ddc2", "parents": [ "02baa486455b2a516cccb69d7c8e1e33409edacc" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Wed Jan 31 21:05:42 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 31 21:05:42 2018" }, "message": "Fix GN thread sanitizer bug.\n\nTsan reported that Scope::GetValueWithScope was marking a value as \"used\"\non the same Scope from multiple threads. These sets were all to true so we\nhaven\u0027t noticed any stability problems, but we should not be trying to\nwrite to scopes across threads.\n\nWhat happens is that a template is created by BUILDCONFIG or a .gni file and\ncalled from multiple BUILD.gn files in multiple threads. The scope stored by\nthe template was not marked const, so the derived scopes on each thread were\nreferencing this root closure as mutable and marking variables used in it.\n\nThis solution is to mark the Scope const. The derived scopes will reference\nthe parent scope as a const and no changes to the shared scope will occur.\n\nChange-Id: I0a5026bb2f32b476babab63f479a5d377df410e8\nReviewed-on: https://chromium-review.googlesource.com/890230\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533408}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 9a22cda9d33378a3b579b329c1a3c1738d8973c2" }, { "commit": "02baa486455b2a516cccb69d7c8e1e33409edacc", "tree": "57d8d4db6d83325b207bd7677ca376f346971090", "parents": [ "d62f754cdf5aebccb6dd4da214db3215fe7be7da" ], "author": { "name": "Tomas Popela", "email": "tomas.popela@gmail.com", "time": "Wed Jan 31 19:58:46 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Jan 31 19:58:46 2018" }, "message": "Fix misspellings in GN reference\n\nChange-Id: If752363b90772f07b70a16c369583b03948a05a7\nReviewed-on: https://chromium-review.googlesource.com/738094\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#533370}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: f7f761c756aff8bf4b993eb2dc37f934a5775f53" }, { "commit": "d62f754cdf5aebccb6dd4da214db3215fe7be7da", "tree": "23324f5ca67b94cf72f3cf26e5ae7fda399f409a", "parents": [ "04e2846b8ecef240257312bd3ef8fb6d58363dd8" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Tue Jan 30 00:17:34 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jan 30 00:17:34 2018" }, "message": "Fix \u0027gn gen --check\u0027 hanging indefinitely\n\nr531270 refactored HeaderChecker to use an atomic counter to track the number of\nheader-checking tasks. The main thread waits on the task count becoming zero,\nand the task counter is decremented whenever a task completes. However, the\nmain thread didn\u0027t increment the task counter when it created a task, so the\ncounter would count into negative values and never reach zero, hanging gn\nindefinitely. The fix is to increment the counter when posting a task.\n\nR\u003ddpranke\nCC\u003dfdoray\n\nChange-Id: Id55f943cf0e2af3e9e5af5f3dddf8a7b7671eaac\nReviewed-on: https://chromium-review.googlesource.com/889930\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#532684}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 7c742b6ec9b635a42b37df65efb28d30f9cc8fcb" }, { "commit": "04e2846b8ecef240257312bd3ef8fb6d58363dd8", "tree": "8c8cf8167b9f6b5783954c4d856a0e83cea99993", "parents": [ "735bf3c10464e2929ed3cbb7caa88fc9207eab00" ], "author": { "name": "Lei Zhang", "email": "thestig@chromium.org", "time": "Sat Jan 27 07:18:17 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Sat Jan 27 07:18:17 2018" }, "message": "GN: Fix a memory leak found by LSAN.\n\nChange-Id: I27d42d74889d455ac162c5701868fb5f2e837261\nReviewed-on: https://chromium-review.googlesource.com/885863\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#532183}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 31360b70f47bcc18df1501ed665793b693469f34" }, { "commit": "735bf3c10464e2929ed3cbb7caa88fc9207eab00", "tree": "a95773a786865a588a142512898f2e66bf7166cb", "parents": [ "5e6e2a83346515957e241480f4faa1fc085c8572" ], "author": { "name": "Tom Anderson", "email": "thomasanderson@chromium.org", "time": "Fri Jan 26 22:05:17 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 26 22:05:17 2018" }, "message": "Fix gn CHECK()ing when generating Chromium build files\n\nAfter r531270, gn chokes while running exec_script():\n\n[0124/122441.126364:FATAL:thread_restrictions.cc(105)] Check failed:\n!g_base_sync_primitives_disallowed.Get().Get().\n\nGN executes scripts synchronously while loading files, so blocking is necessary.\nThis CL adds a ScopedAllowBaseSyncPrimitives for gn to use while waiting for\nexec_script() to complete.\n\nBUG\u003d805628\nR\u003ddpranke,thestig,fdoray\n\nChange-Id: I7ad539a8dee0230c84d94f1c6b37755a890bfcd7\nReviewed-on: https://chromium-review.googlesource.com/884423\nCommit-Queue: Thomas Anderson \u003cthomasanderson@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nReviewed-by: François Doray \u003cfdoray@chromium.org\u003e\nReviewed-by: Lei Zhang \u003cthestig@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#532069}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 5d2531613139a1c409dfacd28d03b05b2100fcfe" } ], "next": "5e6e2a83346515957e241480f4faa1fc085c8572" }