| commit | c6dcc37c5e2d133c27eae4c908a251dfc5f8f5a8 | [log] [tgz] |
|---|---|---|
| author | Alan Zhao <ayzhao@google.com> | Wed Sep 13 18:00:59 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Sun Oct 22 20:08:43 2023 |
| tree | 1f0c41be26dc165f8f37ee4416365439881bf583 | |
| parent | 9912faa84a59a3ee4d326c11d3e92c06b7c4f22e [diff] |
Revert "Do not emit colors when building rust" This reverts commit 805694d2e43441c86330d496f3d748fc6fbd480d. Reason for revert: breaks *upload_rust bots: https://ci.chromium.org/ui/p/chromium/builders/try/linux_upload_rust/856/overview Original change's description: > Do not emit colors when building rust > > Color codes don't get rendered or escaped in our build logs [0], so we > end up with stuff like: > > [0m[0m[1m[32m Compiling[0m proc-macro2 v1.0.63 > [0m[0m[1m[32m Compiling[0m unicode-ident v1.0.9 > > Removing colors should make our logs much readable. > > [0] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8770257296928065569/+/u/package_rust/stdout > > Change-Id: Idadfa7b52d733dc5ebb47fd91c3838ba5826b9db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4851873 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Alan Zhao <ayzhao@google.com> > Cr-Commit-Position: refs/heads/main@{#1195485} Change-Id: Ide5a5601b8e9eac7eb2091e4ae02150bc6314732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863109 Commit-Queue: Alan Zhao <ayzhao@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1196127} NOKEYCHECK=True GitOrigin-RevId: bdc51626dab5b634f274bb16e84d73e6fe0907f2
diff --git a/build_rust.py b/build_rust.py index c7d1ed7..6965fb2 100755 --- a/build_rust.py +++ b/build_rust.py
@@ -778,7 +778,7 @@ return 0 building_on_host_triple = RustTargetTriple() - xpy_args = ['--build', building_on_host_triple, '--color', 'never'] + xpy_args = ['--build', building_on_host_triple] if args.build_mac_arm: building_for_host_triple = RustTargetTriple(build_mac_arm=True) xpy_args.extend([