avformat/mp3: large id3 tags break concatenated file detection

If the file size is much larger than what is indicated in the XING
header, the demuxer assumes it's a concatenated file, and throws away
the (presumably) incorrect duration information. Unfortunately, this
also triggers if the id3 tags are very large (embedded pictures and
such). Then the half-baked heuristic not only breaks the duration
display, but also gapless audio.

Fix it by subtracting the size of the headers (the check is off by some
bytes, but that doesn't matter at all). Note that there could be an
arbitrary amount of tags _after_ the mp3 data, but hopefully these are
not too large to trigger the heuristic in practice.

Also add a warning when this happens.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
1 file changed
tree: 3aeb01cf561225a8797751cac14df1eecc357a3a
  1. .gitattributes
  2. .gitignore
  3. COPYING.GPLv2
  4. COPYING.GPLv3
  5. COPYING.LGPLv2.1
  6. COPYING.LGPLv3
  7. CREDITS
  8. Changelog
  9. INSTALL.md
  10. LICENSE.md
  11. MAINTAINERS
  12. Makefile
  13. README.md
  14. RELEASE
  15. arch.mak
  16. cmdutils.c
  17. cmdutils.h
  18. cmdutils_common_opts.h
  19. cmdutils_opencl.c
  20. common.mak
  21. compat/
  22. configure
  23. doc/
  24. ffmpeg.c
  25. ffmpeg.h
  26. ffmpeg_dxva2.c
  27. ffmpeg_filter.c
  28. ffmpeg_opt.c
  29. ffmpeg_vda.c
  30. ffmpeg_vdpau.c
  31. ffplay.c
  32. ffprobe.c
  33. ffserver.c
  34. ffserver_config.c
  35. ffserver_config.h
  36. libavcodec/
  37. libavdevice/
  38. libavfilter/
  39. libavformat/
  40. libavresample/
  41. libavutil/
  42. libpostproc/
  43. library.mak
  44. libswresample/
  45. libswscale/
  46. presets/
  47. tests/
  48. tools/
  49. version.sh
README.md

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • ffserver is a multimedia streaming server for live broadcasts.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.