commit | 486b578a852ac7e64136a019c9eb8d8ab6be1452 | [log] [tgz] |
---|---|---|
author | Robert Iannucci <iannucci@chromium.org> | Thu May 28 03:55:04 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 28 03:55:04 2020 |
tree | 5391ac73064577647a7a1e9dc07ee1588c7d9c63 | |
parent | 23a3c39ab2cacb2d449699c117a07e80b2c86e45 [diff] |
Remove use of deprecated infra_paths module. We are finally free of buildbot! For reference, infra_paths was mostly a wrapper for these config tweaks: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/master:recipes/recipe_modules/infra_paths/path_config.py The infra_paths module added things like 'api.path['builder_cache']' as base paths, but only under some environmental contexts (like buildbot). It used to do quite a bit for buildbot and kitchen-on-buildbot but does almost nothing for LUCI. All LUCI builds use the 'generic' path configuration which only made the following substitutions: api.path['builder_cache'] == api.path['cache'].join('builder') api.path['git_cache'] == api.path['cache'].join('git') api.path['goma_cache'] == api.path['cache'].join('goma') Now, instead of relying on these base paths being set indirectly via depot_tools, we prefer to just directly use the 'cache' base path. R=agable@chromium.org, dpranke@chromium.org, machenbach@chromium.org, tikuta@google.com, yiwzhang@google.com Bug: 1015181 Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I91c5a380a28381a4e2771ae31bdbbee3ca5a531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2218694 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format
) to autoformat new code.