| commit | 7f762b20ef498409cd3beb7532ef23a0a837af8a | [log] [tgz] |
|---|---|---|
| author | Michael Achenbach <machenbach@chromium.org> | Thu Jun 05 09:34:56 2025 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 05 09:34:56 2025 |
| tree | 476002e5c5e3438b9114ef75c893bcc8d05fb116 | |
| parent | db73b6eb819311265b392819478a1c8bc91e6088 [diff] |
Reapply "[V8] Remove reclient switch" This reverts commit b45519eff0ff01b5d44bfd56c586b08cce030c47. No changes on this reland. The problem last time was the follow up that removed the properties on infra/config side. For that to land smoothly now, these preparations were committed: https://crrev.com/c/6620982 New led test: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20shared%20-%20builder/22098/overview After every builder switched to SISO, the recipe side switch for remoteexec is obsolete. The builders using MB pass the GN flag on the source side. The official archive builders us GN directly and now explicitly pass the siso and remote_exec flags. The reclient switch passed to chromium.compile() is only having an effect if not on SISO. Bug: 414724525 Change-Id: Ie54d4aedd07680dc0b9496da23d0b7077f92316a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/6622258 Reviewed-by: Liviu Rau <liviurau@chromium.org> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in the recipes directory), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.