| commit | c101696378915618927f0294c4e80bd84ed84ebf | [log] [tgz] |
|---|---|---|
| author | Dean Michael Berris <dberris@google.com> | Mon May 11 16:38:14 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 11 16:38:14 2020 |
| tree | d107174b7afba6c767a6a9294e40ae30ee64f007 | |
| parent | 532d1160a728f33f48013bcbff68dc5c819c8c59 [diff] |
mac-perf: Do not use 'mac_toolchain' in perf Through a process of deduction, I found that none of the builds for mac actually use the 'mac_toolchain' addiitonal config, and that's only used for iOS builders. I suspect including that configuration makes the builder assume that the hermetic toolchain is not used. Removing the special case for the mac should mean that the inheritance defined for `chromium_perf` in this builder config will inherit from all the defaults for `chromium` which should include the downloading/usage of the CIPD package for the SDK. R=agable@chromium.org, gbeaty@chromium.org, thakis@chromium.org Bug: chromium:1077773 Change-Id: I535e4cf441007e074a7179e3a752419ae9b5665e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2193315 Auto-Submit: Dean Berris <dberris@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.