commit | c22b2502b79b31296a4474192a1e1772bb95596e | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Tue Nov 19 20:38:48 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 19 20:38:48 2024 |
tree | 4847e86c4ac16dcfe48e3f67c6328a971ef3337f | |
parent | cda8f0ea0f1194b0ec07f1dda8dc43877e100a35 [diff] |
Enable expose_merge_script_failures globally This experiment has been lingering around for ages and ages. A while ago it was enabled at 100% for all chromium trunk builds. And given how long ago that was done, it's prob propagated to nearly every active release branch at this point. So this CL should have zero effect on chromium builds. For chrome builds, it was enabled at 5% there a similarly long time ago. It wasn't promoted past 5% due purely to negligence. Fortunately, it's been live at 5% for so long, that we should be able to determine the impact of bumping it to 100%: http://scripts/script_63._19b34d_0000_2e39_9074_14223bc07d72 That script exposes a number of builders that have outsized failure rates when under the experiment. These CLs and all their cherry picks should address those failures: https://crrev.com/i/7824159 https://crrev.com/i/7827289 So this _should_ be safe for chromium/chrome. Unclear how unsafe it is for other projects using chrome's recipe code. One way to find out... Bug: 40232671 Change-Id: Ic58a540192f8d47dac717475a189e5998a58b018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/6020322 Reviewed-by: Garrett Beaty <gbeaty@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in the recipes
directory), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.