commit | 183f601e7f32bc6bff04896865e493afe702dfdc | [log] [tgz] |
---|---|---|
author | Yuke Liao <liaoyuke@chromium.org> | Mon Nov 09 21:11:39 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 09 21:11:39 2020 |
tree | 2559b8ce9d8e10371d04d5a93c99afa43c4ebdbf | |
parent | 533a73a1315f7011a28e56125b087450e94dc5f4 [diff] |
Reland "[lacros] Clean up checkout_prebuilt_ash_chrome" This reverts commit c1ca28ea41397cae4dc8cb06b56e8297487b275f. Reason for revert: Root cause has been fixed in http://crrev.com/c/2519833. Original change's description: > Revert "[lacros] Clean up checkout_prebuilt_ash_chrome" > > This reverts commit 852b56a426ad61f983067e0c9f7326bd5291593f. > > Reason for revert: "prebuilt_ash_chrome/for_bots: no such file or directory" failures on linux-lacros-rel > https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel/64963 > https://crbug.com/1145628 > > Original change's description: > > [lacros] Clean up checkout_prebuilt_ash_chrome > > > > This CL cleans up checkotu_presubmit_ash_chrome gclient arg usage > > because all CI/CQ builders have been switched to build ash-chrome > > from ToT. > > > > Bug: 1129223 > > Change-Id: I698af09e563a2181ba0e55a21cabe5e00bce69e7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2518220 > > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > TBR=dpranke@google.com,liaoyuke@chromium.org,svenzheng@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Icbc44863c8d1ea2779ea9dbad45e91a97df7f8d6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1129223, 1145628 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2519803 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> TBR=dpranke@google.com,liaoyuke@chromium.org,bpastene@chromium.org,svenzheng@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1129223 Bug: 1145628 Change-Id: I3002c586a7c37ba07aabc3dfac9ceeb3ae6b821e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2527103 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.