| commit | e567bbae38db527f8bc88107b57346904b31a735 | [log] [tgz] |
|---|---|---|
| author | Simon Que <sque@chromium.org> | Fri May 01 23:39:30 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 01 23:39:30 2020 |
| tree | 9e5422fc2e665ec72c1f456b4a16dc18b182d2d9 | |
| parent | a8b7c77953c9c6c4845d6e849f364410a2423950 [diff] |
Revert "Reland "recipe_modules: Use clang_tot_* configs for non-Goma builders"" This reverts commit 0722e5bd54243b613528160619928de9a7cc24f9. Reason for revert: crbug.com/1073145 Original change's description: > Reland "recipe_modules: Use clang_tot_* configs for non-Goma builders" > > This is a reland of ce83a1f426f6546816138d02ff80a0a242c48b2a > > The original CL was landed with an error: I had made an edit to the > wrong builder's config. I had to revert the CL. > > Original change's description: > > recipe_modules: Use clang_tot_* configs for non-Goma builders > > > > These builders currently have configs that give them steps to ensure, > > start, and stop Goma. However, they don't use the "use_goma=true" GN > > flag. > > - ToTiOS > > - ToTiOSDevice > > > > Bug: 1066318 > > Change-Id: I13258c2c10b324c682fbacfd38b1ae85839c14d9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2131526 > > Commit-Queue: Simon Que <sque@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Bug: 1066318 > Change-Id: I937e7d98971e2796a2372ca368febad3a6b3d401 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2133376 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Simon Que <sque@chromium.org> TBR=sque@chromium.org,thakis@chromium.org,agable@chromium.org,hans@chromium.org,martiniss@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1066318 Change-Id: I6ed9f521b1300e4045859cf5f5561a70dcf0fcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2172843 Reviewed-by: Simon Que <sque@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.