| commit | 376481a599ad2797f585922dd0d68b9601b7c11c | [log] [tgz] |
|---|---|---|
| author | Sergiy Belozorov <sergiyb@chromium.org> | Fri Jul 05 09:27:07 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 05 09:27:07 2019 |
| tree | 1ee63bc7bac37aace5dfb843d02395c4b440202c | |
| parent | 7d3736e799e05fa016f442cb9db41f7d10ce9c0d [diff] |
[V8] Remove ability to customize send_ts_mon_values' parameter --target-type This parameter can only take values 'task' and 'device'. The latter is useful when monitoring physical devices, which is unlikely to be done from recipes, thus we simply hard-code 'task' value. Should such a need arise in the future, the API of this method can be extended to support customizing target_type and/or many other parameters that can be passed to send_ts_mon_values. This also improves argument documentation and renames the send_value method to send_counter_value as there are other types of metrics supported by the underlying script, e.g. float, gauge etc. TBR=tmrts@chromium.org,ddoman@chromium.org,nodir@chromium.org Change-Id: I56e535a82dd681417295effd8db5b0e6a29e56f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1688796 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Hi build contributor! If you do any change in scripts/master/ or touching any master's html/ directories, you must restart master.chromium.fyi first and ensure that it still works before restarting other masters.
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.