| commit | 9d041084284779cdd22b4fff131c9260c83c67c4 | [log] [tgz] |
|---|---|---|
| author | Alexander Schulze <alexschulze@chromium.org> | Thu May 19 10:22:26 2022 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 20 08:11:16 2022 |
| tree | 7860979b170ee73636660d1a57aaee724ebc83e5 | |
| parent | 07042b62ee7acef53bef867f1ef1aacc21a30e1a [diff] |
Remove workaround for pip package extras We add a newly supported environment variable (PIP_NO_DEPS, b/222535110) in app.yaml to restrict the installation of packages to the ones listed in the requirements.txt file. Recursive dependencies are not installed anymore and must be included in the file. This has been the case before already, but due to insufficient extras management within pip (https://github.com/pypa/pip/issues/9644), we needed to add each package for all used extras combinations. The new build flag makes this duplication redundant. See [1] for a cloud build without the workaround and without the env var, and [2] when applying the env var. [1] fails due to an attempt to install packages using pip's extras tag. [1] https://console.cloud.google.com/cloud-build/builds;region=us-central1/a3e2bd4d-e16e-4ec1-b9f3-9f5f604cf70c;step=2 [2] https://console.cloud.google.com/cloud-build/builds;region=us-central1/ce50fe1b-b9f5-4fd6-ae2a-fc9e6bb4101a;step=2 Bug: 1327200 Change-Id: I231538658243e3faefe07e470d7e979b426974d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/chrome-devtools-frontend/+/3655452 Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
This repo contains:
gae_py3)See this README and go/devtools-hosting-app for details.
go/devtools-uploader references to a deprecated version of this app.