commit | 2377b01e6cd32c53402a4dfd08faa4177c276e50 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Fri Jan 12 00:46:49 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 12 01:09:03 2018 |
tree | 91312a2cb64f1e8022bc2e10d1a48c719b6081a5 | |
parent | da669d61230a10f71a13703889a97827db35ffd9 [diff] |
Treat "Bug:" as an empty line in git cl upload The default description in the editor when you invoke "git cl upload" includes recent commit descriptions, some blank lines and comments, and "Bug: ". The upload script properly strips out the comments but was leaving in the "Bug:" line. This leads to CLs with blank Bug: lines, which is sloppy. It also means that if a user changes their mind and closes the upload editor without adding any content... they would still have a CL created. This change removes the "Bug: " line if nothing has been added to it, thus avoiding uploading a change with an empty description, and avoiding having meaningless Bug: lines. Change-Id: I18c2094e5712d31729899c0ebd0a52de97dc4e7f Reviewed-on: https://chromium-review.googlesource.com/861920 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.