| commit | 2d5c673fdb0072bb7b0c7463e6e7e18d0170b288 | [log] [tgz] |
|---|---|---|
| author | Josip Sokcevic <sokcevic@chromium.org> | Mon Aug 21 23:16:18 2023 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 21 23:16:18 2023 |
| tree | c17fa4e5a7fb19ee22a5a86567fc5ead364ebbfb | |
| parent | 8060241ee0dd4645cf21390e3e4167732a0f175f [diff] |
[scm] Fix list all files when filename has space Off by one - we should have 4 parts, so we need maxsplit=3. R=aravindvasudev@google.com, jojwang Fixed: 1474283 Change-Id: I13b568feb8ee2aa307a2267c43765c1749b77c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4799773 Auto-Submit: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.