Google Git
Sign in
chromium / chromium / tools / depot_tools.git / 443f9851a46a45b5caac81a64704cb48f52e961b
commit443f9851a46a45b5caac81a64704cb48f52e961b[log] [tgz]
authorBruce Dawson <brucedawson@chromium.org>Thu Sep 08 17:30:59 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 08 17:30:59 2022
tree71022117beab266774a1d151c5b5d4a01940781f
parent4858aea09800f4ef71b27f6d4e9d80b5f24d8976 [diff]
Improve Python 2 presubmit warning

The warning that a PRESUBMIT.py file was still being run under Python 2
was apparently too polite as one was just added. This change adds
instructions on how to prevent this, which should make it clear that
the behavior is not desirable.

The warning was added in crrev.com/c/3826917.

Bug: 1313804
Change-Id: I81a6ea45907b5ea00e7d945c3131a329708cc377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3878875
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
2 files changed
tree: 71022117beab266774a1d151c5b5d4a01940781f
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. python-bin/
  7. python2-bin/
  8. recipes/
  9. testing_support/
  10. tests/
  11. third_party/
  12. win_toolchain/
  13. zsh-goodies/
  14. cbuildbot ⇨ cros
  15. cros_sdk ⇨ cros
  16. .cipd_impl.ps1
  17. .gitattributes
  18. .gitignore
  19. .isort.cfg
  20. .style.yapf
  21. .vpython
  22. .vpython3
  23. auth.py
  24. autoninja
  25. autoninja.bat
  26. autoninja.py
  27. bb
  28. bb.bat
  29. black
  30. bootstrap_python3
  31. breakpad.py
  32. cipd
  33. cipd.bat
  34. cipd_bin_setup.bat
  35. cipd_bin_setup.sh
  36. cipd_client_version
  37. cipd_client_version.digests
  38. cipd_manifest.txt
  39. cipd_manifest.versions
  40. cit
  41. cit.bat
  42. cit.py
  43. clang-format
  44. clang-format.bat
  45. clang_format.py
  46. clang_format_merge_driver
  47. clang_format_merge_driver.bat
  48. clang_format_merge_driver.py
  49. codereview.settings
  50. compile_single_file
  51. compile_single_file.bat
  52. compile_single_file.py
  53. cpplint.bat
  54. cpplint.py
  55. cpplint_chromium.py
  56. cros
  57. CROS_OWNERS
  58. crosjobs
  59. detect_host_arch.py
  60. DIR_METADATA
  61. dirmd
  62. dirmd.bat
  63. download_from_google_storage
  64. download_from_google_storage.bat
  65. download_from_google_storage.py
  66. ensure_bootstrap
  67. fetch
  68. fetch.bat
  69. fetch.py
  70. fix_encoding.py
  71. gclient
  72. gclient-new-workdir.py
  73. gclient.bat
  74. gclient.py
  75. gclient_completion.sh
  76. gclient_eval.py
  77. gclient_paths.py
  78. gclient_scm.py
  79. gclient_utils.py
  80. gerrit_client.py
  81. gerrit_util.py
  82. git-cache
  83. git-cl
  84. git-crrev-parse
  85. git-drover
  86. git-find-releases
  87. git-footers
  88. git-freeze
  89. git-gs
  90. git-hyper-blame
  91. git-map
  92. git-map-branches
  93. git-mark-merge-base
  94. git-migrate-default-branch
  95. git-nav-downstream
  96. git-nav-upstream
  97. git-new-branch
  98. git-number
  99. git-rebase-update
  100. git-rename-branch
  101. git-reparent-branch
  102. git-retry
  103. git-runhooks
  104. git-squash-branch
  105. git-thaw
  106. git-upstream-diff
  107. git_cache.py
  108. git_cl.py
  109. git_cl_completion.sh
  110. git_common.py
  111. git_dates.py
  112. git_drover.py
  113. git_find_releases.py
  114. git_footers.py
  115. git_freezer.py
  116. git_hyper_blame.py
  117. git_map.py
  118. git_map_branches.py
  119. git_mark_merge_base.py
  120. git_migrate_default_branch.py
  121. git_nav_downstream.py
  122. git_new_branch.py
  123. git_number.py
  124. git_rebase_update.py
  125. git_rename_branch.py
  126. git_reparent_branch.py
  127. git_retry.py
  128. git_squash_branch.py
  129. git_upstream_diff.py
  130. gn
  131. gn.bat
  132. gn.py
  133. goma_auth
  134. goma_auth.bat
  135. goma_ctl
  136. goma_ctl.bat
  137. GOMA_OWNERS
  138. gsutil.py
  139. gsutil.py.bat
  140. gsutil.vpython3
  141. isort
  142. led
  143. led.bat
  144. LICENSE
  145. lockfile.py
  146. luci-auth
  147. luci-auth.bat
  148. LUCI_OWNERS
  149. lucicfg
  150. lucicfg.bat
  151. mac_toolchain
  152. metrics.py
  153. metrics.README.md
  154. metrics_utils.py
  155. my_activity.py
  156. ninja
  157. ninja-linux64
  158. ninja-mac
  159. ninja.exe
  160. ninjalog.README.md
  161. ninjalog_uploader.py
  162. ninjalog_uploader_wrapper.py
  163. OWNERS
  164. owners_client.py
  165. owners_finder.py
  166. pinpoint
  167. pinpoint.bat
  168. post_build_ninja_summary.py
  169. PRESUBMIT.py
  170. presubmit_canned_checks.py
  171. presubmit_canned_checks_test.py
  172. presubmit_canned_checks_test_mocks.py
  173. presubmit_support.py
  174. profile.xml
  175. prpc
  176. prpc.bat
  177. pylint-1.5
  178. pylint-1.5.bat
  179. pylint-2.6
  180. pylint-2.6.bat
  181. pylint-2.7
  182. pylint-2.7.bat
  183. pylint_main.py
  184. pylintrc
  185. python_runner.sh
  186. rdb
  187. rdb.bat
  188. rdb_wrapper.py
  189. README.gclient.md
  190. README.git-cl.md
  191. README.md
  192. repo
  193. repo_launcher
  194. roll-dep
  195. roll-dep.bat
  196. roll_dep.py
  197. rustfmt.py
  198. scm.py
  199. setup_color.py
  200. split_cl.py
  201. subcommand.py
  202. subprocess2.py
  203. swift-format
  204. swift_format.py
  205. update_depot_tools
  206. update_depot_tools.bat
  207. update_depot_tools_toggle.py
  208. upload_metrics.py
  209. upload_to_google_storage.py
  210. utils.py
  211. vpython
  212. vpython.bat
  213. vpython3
  214. vpython3.bat
  215. WATCHLISTS
  216. watchlists.py
  217. weekly
  218. whitespace.txt
  219. win32imports.py
  220. wtf
  221. yapf
  222. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.