| commit | 6833e00918e3a2d30d760e4fa8328295fa30f25c | [log] [tgz] |
|---|---|---|
| author | Robert Iannucci <iannucci@chromium.org> | Thu Jun 20 15:51:46 2024 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 20 15:51:46 2024 |
| tree | 572630ab0f64b350b9160e9a734bafe92dfab3f5 | |
| parent | 1f4f982beb6c427808779bc28093a5474832f2c2 [diff] |
[gerrit_util] Revise comments on SSOAuthenticator. Previous comments on SSOAuthenticator were incorrect (the git-remote-sso process does NOT need to persist). Remove comments which were inconsistent with the code, and add an explainer on why the _launch_sso_helper method is written the way it is. R=ayatane, yiwzhang Bug: b/335483238 Change-Id: I6b318ef36d7c4f757cd0b979fdc90c01c7a5b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5641089 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Tools for working with Chromium development. It requires python 3.8.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.