Google Git
Sign in
chromium / chromium / tools / depot_tools.git / 6daca505974e4efe9df926521daca261f25f1994
commit6daca505974e4efe9df926521daca261f25f1994[log] [tgz]
authorRobert Iannucci <iannucci@chromium.org>Fri Jun 21 23:41:29 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 21 23:41:29 2024
treee5fa44764f0ca87cd27da3fce7801d866077dd65
parent137bb69871a86d3470233c4215f6ff346a22af3d [diff]
[git_cl] Refactor EnsureAuthenticated logic.

This will allow us to implement EnsureAuthenticated for other
Authenticator implementations.

R=ayatane@chromium.org

Bug: 336351842
Change-Id: I5ff4efd45eb5baa6baa048842510ec6e18e1b8fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5588510
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
2 files changed
tree: e5fa44764f0ca87cd27da3fce7801d866077dd65
  1. bootstrap/
  2. fetch_configs/
  3. hooks/
  4. infra/
  5. man/
  6. metadata/
  7. python-bin/
  8. python2-bin/
  9. recipes/
  10. testing_support/
  11. tests/
  12. third_party/
  13. win_toolchain/
  14. zsh-goodies/
  15. bazel ⇨ bazel.py
  16. cbuildbot ⇨ cros
  17. cros_sdk ⇨ cros
  18. gerrit ⇨ cros
  19. .cipd_impl.ps1
  20. .flake8
  21. .gitattributes
  22. .gitignore
  23. .isort.cfg
  24. .style.yapf
  25. .vpython3
  26. auth.py
  27. autoninja
  28. autoninja.bat
  29. autoninja.py
  30. bazel.py
  31. bb
  32. bb.bat
  33. black
  34. bootstrap_python3
  35. breakpad.py
  36. BUILD_OWNERS
  37. cipd
  38. cipd.bat
  39. cipd_bin_setup.bat
  40. cipd_bin_setup.sh
  41. cipd_client_version
  42. cipd_client_version.digests
  43. cipd_manifest.txt
  44. cipd_manifest.versions
  45. cipd_manifest_cros_python2.txt
  46. cipd_manifest_cros_python2.versions
  47. clang-format
  48. clang-format.bat
  49. clang_format.py
  50. codereview.settings
  51. compile_single_file
  52. compile_single_file.bat
  53. compile_single_file.py
  54. cpplint.bat
  55. cpplint.py
  56. cpplint_chromium.py
  57. cros
  58. CROS_OWNERS
  59. cros_python2.vpython
  60. detect_host_arch.py
  61. DIR_METADATA
  62. dirmd
  63. dirmd.bat
  64. download_from_google_storage
  65. download_from_google_storage.bat
  66. download_from_google_storage.py
  67. ensure_bootstrap
  68. fetch
  69. fetch.bat
  70. fetch.py
  71. gclient
  72. gclient-new-workdir.py
  73. gclient.bat
  74. gclient.py
  75. gclient_completion.sh
  76. gclient_eval.py
  77. gclient_paths.py
  78. gclient_scm.py
  79. gclient_utils.py
  80. gerrit_client.py
  81. gerrit_util.py
  82. git-cache
  83. git-cl
  84. git-credential-luci
  85. git-credential-luci.bat
  86. git-crrev-parse
  87. git-drover
  88. git-find-releases
  89. git-footers
  90. git-freeze
  91. git-gs
  92. git-hyper-blame
  93. git-map
  94. git-map-branches
  95. git-mark-merge-base
  96. git-nav-downstream
  97. git-nav-upstream
  98. git-new-branch
  99. git-number
  100. git-rebase-update
  101. git-rename-branch
  102. git-reparent-branch
  103. git-retry
  104. git-runhooks
  105. git-squash-branch
  106. git-thaw
  107. git-upstream-diff
  108. git_cache.py
  109. git_cl.py
  110. git_cl_completion.sh
  111. git_common.py
  112. git_completion.sh
  113. git_dates.py
  114. git_find_releases.py
  115. git_footers.py
  116. git_freezer.py
  117. git_hyper_blame.py
  118. git_map.py
  119. git_map_branches.py
  120. git_mark_merge_base.py
  121. git_nav_downstream.py
  122. git_new_branch.py
  123. git_number.py
  124. git_rebase_update.py
  125. git_rename_branch.py
  126. git_reparent_branch.py
  127. git_retry.py
  128. git_squash_branch.py
  129. git_upstream_diff.py
  130. gn
  131. gn.bat
  132. gn.py
  133. google-java-format
  134. google-java-format.bat
  135. google_java_format.py
  136. gsutil.py
  137. gsutil.py.bat
  138. gsutil.vpython3
  139. isort
  140. led
  141. led.bat
  142. LICENSE
  143. lockfile.py
  144. luci-auth
  145. luci-auth.bat
  146. LUCI_OWNERS
  147. lucicfg
  148. lucicfg.bat
  149. mac_toolchain
  150. metrics.py
  151. metrics.README.md
  152. metrics_utils.py
  153. my_activity.py
  154. newauth.py
  155. ninja
  156. ninja.bat
  157. ninja.py
  158. ninja_reclient.py
  159. ninjalog.README.md
  160. ninjalog_uploader.py
  161. ninjalog_uploader_wrapper.py
  162. OWNERS
  163. owners_client.py
  164. owners_finder.py
  165. pinpoint
  166. pinpoint.bat
  167. post_build_ninja_summary.py
  168. PRESUBMIT.py
  169. presubmit_canned_checks.py
  170. presubmit_diff.py
  171. presubmit_support.py
  172. prpc
  173. prpc.bat
  174. pylint-2.17
  175. pylint-2.17.bat
  176. pylint-2.6
  177. pylint-2.6.bat
  178. pylint-2.7
  179. pylint-2.7.bat
  180. pylint_main.py
  181. pylintrc
  182. pylintrc-2.17
  183. python_runner.sh
  184. rdb
  185. rdb.bat
  186. rdb_wrapper.py
  187. README.gclient.md
  188. README.git-cl.md
  189. README.md
  190. reclient_helper.py
  191. reclient_metrics
  192. reclient_metrics.bat
  193. reclient_metrics.py
  194. reclient_metrics.README.md
  195. RECLIENT_OWNERS
  196. reclientreport
  197. reclientreport.bat
  198. reclientreport.py
  199. repo
  200. repo_launcher
  201. roll-dep
  202. roll-dep.bat
  203. roll_dep.py
  204. rustfmt.py
  205. scm.py
  206. setup_color.py
  207. siso
  208. siso.bat
  209. siso.py
  210. split_cl.py
  211. subcommand.py
  212. subprocess2.py
  213. swift-format
  214. swift_format.py
  215. update_depot_tools
  216. update_depot_tools.bat
  217. update_depot_tools_toggle.py
  218. upload_metrics.py
  219. upload_to_google_storage.py
  220. upload_to_google_storage_first_class.py
  221. utils.py
  222. vpython3
  223. vpython3.bat
  224. WATCHLISTS
  225. watchlists.py
  226. whitespace.txt
  227. win32imports.py
  228. yapf
  229. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.