commit | 76fe1a701b5ede5bd9e282623ede7fa099cc4a6f | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Wed May 25 20:52:21 2022 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 25 20:52:21 2022 |
tree | 94cf3c2509ffc26f38880efa6173dd8848d781e0 | |
parent | 8d2d507a4974d20d4cac8a8486e31a27aca8b562 [diff] |
Print presubmit messages in a consistent order Presubmit message types were printed in an inconsistent order, generally determined by which type was encountered first. This unpredictability can be confusing when comparing runs. This change enforces a consistent order, in increasing order of severity. ERRORS always go last so that they will be the most visible when running presubmits locally. This also adds a "There were Python %d presubmit errors." message to the end to make it easier to tell when there were presubmit errors. This is particularly useful when manually running presubmits. Bug: 1309977 Change-Id: Ib2b73c7625789bad5b21ae12abf238b746cd11e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3668724 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.