Google Git
Sign in
chromium / chromium / tools / depot_tools.git / b19e8dff155d6bb50ddbb8b7ddd12b4b28fec7b4
commitb19e8dff155d6bb50ddbb8b7ddd12b4b28fec7b4[log] [tgz]
authorBruce Dawson <brucedawson@chromium.org>Mon Jan 28 19:11:57 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 28 19:11:57 2019
tree50563592fde37d5838e3dfcb1ebdf7dd5380d0ef
parentbdb1123726a2810c5f3e28f28f4802fa469e6914 [diff]
Add a --nodownload option to get_toolchain_if_necessary.py

The Windows toolchain should be downloaded during gclient runhooks,
however because get_toolchain_if_necessary.py can either configure an
existing toolchain or download a toolchain there have been problems when
the toolchain is downloaded at an unexpected point. In particular, a
toolchain download during gn gen can lead to parallel downloads and
configuration failures.

The --nodownload option will be passed (after a subsequent change) by
build\vs_toolchain.py. A --nodownload option is needed instead of a more
positive --allowdownload option because of backwards compatibility. This
change will have no effect until the build\vs_toolchain.py change is
landed.

Bug: 584393, 662325
Change-Id: I9a0950e066744c0310e49e45d001a9113f1831cf
Reviewed-on: https://chromium-review.googlesource.com/c/1439805
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
1 file changed
tree: 50563592fde37d5838e3dfcb1ebdf7dd5380d0ef
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipes/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ support/chromite_wrapper
  14. chrome_set_ver ⇨ support/chromite_wrapper
  15. cros ⇨ support/chromite_wrapper
  16. cros_sdk ⇨ support/chromite_wrapper
  17. .gitattributes
  18. .gitignore
  19. .style.yapf
  20. annotated_gclient.py
  21. appengine_mapper.py
  22. auth.py
  23. autoninja
  24. autoninja.bat
  25. autoninja.py
  26. breakpad.py
  27. buildbucket.py
  28. checkout.py
  29. cipd
  30. cipd.bat
  31. cipd.ps1
  32. cipd_bin_setup.bat
  33. cipd_bin_setup.sh
  34. cipd_client_version
  35. cipd_client_version.digests
  36. cipd_manifest.txt
  37. cipd_manifest.versions
  38. cit
  39. cit.bat
  40. cit.py
  41. clang-format
  42. clang-format.bat
  43. clang_format.py
  44. clang_format_merge_driver
  45. clang_format_merge_driver.bat
  46. clang_format_merge_driver.py
  47. codereview.settings
  48. compile_single_file
  49. compile_single_file.bat
  50. compile_single_file.py
  51. cpplint.bat
  52. cpplint.py
  53. cpplint_chromium.py
  54. CROS_OWNERS
  55. dart_format.py
  56. depot-tools-auth
  57. depot-tools-auth.bat
  58. depot-tools-auth.py
  59. detect_host_arch.py
  60. download_from_google_storage
  61. download_from_google_storage.bat
  62. download_from_google_storage.py
  63. ensure_bootstrap
  64. fetch
  65. fetch.bat
  66. fetch.py
  67. fix_encoding.py
  68. gclient
  69. gclient-new-workdir.py
  70. gclient.bat
  71. gclient.py
  72. gclient_completion.sh
  73. gclient_eval.py
  74. gclient_scm.py
  75. gclient_utils.py
  76. gerrit_client.py
  77. gerrit_util.py
  78. git-cache
  79. git-cl
  80. git-crrev-parse
  81. git-drover
  82. git-find-releases
  83. git-footers
  84. git-freeze
  85. git-gs
  86. git-hyper-blame
  87. git-map
  88. git-map-branches
  89. git-mark-merge-base
  90. git-nav-downstream
  91. git-nav-upstream
  92. git-new-branch
  93. git-number
  94. git-rebase-update
  95. git-rename-branch
  96. git-reparent-branch
  97. git-retry
  98. git-runhooks
  99. git-squash-branch
  100. git-thaw
  101. git-upstream-diff
  102. git_cache.py
  103. git_cl.py
  104. git_cl_completion.sh
  105. git_common.py
  106. git_dates.py
  107. git_drover.py
  108. git_find_releases.py
  109. git_footers.py
  110. git_freezer.py
  111. git_hyper_blame.py
  112. git_map.py
  113. git_map_branches.py
  114. git_mark_merge_base.py
  115. git_nav_downstream.py
  116. git_new_branch.py
  117. git_number.py
  118. git_rebase_update.py
  119. git_rename_branch.py
  120. git_reparent_branch.py
  121. git_retry.py
  122. git_squash_branch.py
  123. git_upstream_diff.py
  124. gn
  125. gn.bat
  126. gn.py
  127. gsutil.py
  128. gsutil.py.bat
  129. gsutil.vpython
  130. led
  131. led.bat
  132. LICENSE
  133. luci-auth
  134. luci-auth.bat
  135. mac_toolchain
  136. metrics.py
  137. metrics.README.md
  138. metrics_utils.py
  139. my_activity.py
  140. my_reviews.py
  141. ninja
  142. ninja-linux32
  143. ninja-linux64
  144. ninja-mac
  145. ninja.exe
  146. ninjalog.README.md
  147. ninjalog_uploader.py
  148. ninjalog_uploader_wrapper.py
  149. OWNERS
  150. owners.py
  151. owners_finder.py
  152. patch.py
  153. post_build_ninja_summary.py
  154. PRESUBMIT.py
  155. presubmit_canned_checks.py
  156. presubmit_support.py
  157. profile.xml
  158. prpc
  159. prpc.bat
  160. pylint
  161. pylint.py
  162. pylintrc
  163. python_runner.sh
  164. README.gclient.md
  165. README.git-cl.md
  166. README.md
  167. README.testing
  168. repo
  169. rietveld.py
  170. roll-dep
  171. roll-dep-svn
  172. roll-dep-svn.bat
  173. roll-dep.bat
  174. roll_dep.py
  175. roll_dep_svn.py
  176. scm.py
  177. setup_color.py
  178. split_cl.py
  179. subcommand.py
  180. subprocess2.py
  181. update_depot_tools
  182. update_depot_tools.bat
  183. update_depot_tools_toggle.py
  184. upload_metrics.py
  185. upload_to_google_storage.py
  186. vpython
  187. vpython.bat
  188. WATCHLISTS
  189. watchlists.py
  190. weekly
  191. wtf
  192. yapf
  193. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.