Google Git
Sign in
chromium / chromium / tools / depot_tools.git / c0883c509ea30e18e5657552527999734c7bac05
commitc0883c509ea30e18e5657552527999734c7bac05[log] [tgz]
authorAleksey Khoroshilov <akhoroshilov@brave.com>Wed Jun 12 07:02:33 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 12 07:02:33 2024
treea4159ade744ad387e61b502d4f1d1f35ee9a6331
parente757e08663d267e8378d6acfb1df7807512b1f71 [diff]
Fix git diff calls when a lot of files modified in a branch

Running a command line longer that 32k on Windows lead to issues (as
usual). We run git diff in multiple scenarios on a list of changed
files. This list is not partitioned and may lead to a command line
much longer than OS can allow.

This change replaces BuildGitDiffCmd with RunGitDiffCmd that splits
the file list internally and runs git diff multiple times if required.

Change-Id: Icfd8efc7520105b8d98125e90bb96c2bb9bd3a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5613673
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Aleksei Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
1 file changed
tree: a4159ade744ad387e61b502d4f1d1f35ee9a6331
  1. bootstrap/
  2. fetch_configs/
  3. hooks/
  4. infra/
  5. man/
  6. metadata/
  7. python-bin/
  8. python2-bin/
  9. recipes/
  10. testing_support/
  11. tests/
  12. third_party/
  13. win_toolchain/
  14. zsh-goodies/
  15. bazel ⇨ bazel.py
  16. cbuildbot ⇨ cros
  17. cros_sdk ⇨ cros
  18. gerrit ⇨ cros
  19. .cipd_impl.ps1
  20. .flake8
  21. .gitattributes
  22. .gitignore
  23. .isort.cfg
  24. .style.yapf
  25. .vpython3
  26. auth.py
  27. autoninja
  28. autoninja.bat
  29. autoninja.py
  30. bazel.py
  31. bb
  32. bb.bat
  33. black
  34. bootstrap_python3
  35. breakpad.py
  36. BUILD_OWNERS
  37. cipd
  38. cipd.bat
  39. cipd_bin_setup.bat
  40. cipd_bin_setup.sh
  41. cipd_client_version
  42. cipd_client_version.digests
  43. cipd_manifest.txt
  44. cipd_manifest.versions
  45. cipd_manifest_cros_python2.txt
  46. cipd_manifest_cros_python2.versions
  47. clang-format
  48. clang-format.bat
  49. clang_format.py
  50. codereview.settings
  51. compile_single_file
  52. compile_single_file.bat
  53. compile_single_file.py
  54. cpplint.bat
  55. cpplint.py
  56. cpplint_chromium.py
  57. cros
  58. CROS_OWNERS
  59. cros_python2.vpython
  60. detect_host_arch.py
  61. DIR_METADATA
  62. dirmd
  63. dirmd.bat
  64. download_from_google_storage
  65. download_from_google_storage.bat
  66. download_from_google_storage.py
  67. ensure_bootstrap
  68. fetch
  69. fetch.bat
  70. fetch.py
  71. gclient
  72. gclient-new-workdir.py
  73. gclient.bat
  74. gclient.py
  75. gclient_completion.sh
  76. gclient_eval.py
  77. gclient_paths.py
  78. gclient_scm.py
  79. gclient_utils.py
  80. gerrit_client.py
  81. gerrit_util.py
  82. git-cache
  83. git-cl
  84. git-crrev-parse
  85. git-drover
  86. git-find-releases
  87. git-footers
  88. git-freeze
  89. git-gs
  90. git-hyper-blame
  91. git-map
  92. git-map-branches
  93. git-mark-merge-base
  94. git-nav-downstream
  95. git-nav-upstream
  96. git-new-branch
  97. git-number
  98. git-rebase-update
  99. git-rename-branch
  100. git-reparent-branch
  101. git-retry
  102. git-runhooks
  103. git-squash-branch
  104. git-thaw
  105. git-upstream-diff
  106. git_cache.py
  107. git_cl.py
  108. git_cl_completion.sh
  109. git_common.py
  110. git_completion.sh
  111. git_dates.py
  112. git_find_releases.py
  113. git_footers.py
  114. git_freezer.py
  115. git_hyper_blame.py
  116. git_map.py
  117. git_map_branches.py
  118. git_mark_merge_base.py
  119. git_nav_downstream.py
  120. git_new_branch.py
  121. git_number.py
  122. git_rebase_update.py
  123. git_rename_branch.py
  124. git_reparent_branch.py
  125. git_retry.py
  126. git_squash_branch.py
  127. git_upstream_diff.py
  128. gn
  129. gn.bat
  130. gn.py
  131. google-java-format
  132. google-java-format.bat
  133. google_java_format.py
  134. gsutil.py
  135. gsutil.py.bat
  136. gsutil.vpython3
  137. isort
  138. led
  139. led.bat
  140. LICENSE
  141. lockfile.py
  142. luci-auth
  143. luci-auth.bat
  144. LUCI_OWNERS
  145. lucicfg
  146. lucicfg.bat
  147. mac_toolchain
  148. metrics.py
  149. metrics.README.md
  150. metrics_utils.py
  151. my_activity.py
  152. ninja
  153. ninja.bat
  154. ninja.py
  155. ninja_reclient.py
  156. ninjalog.README.md
  157. ninjalog_uploader.py
  158. ninjalog_uploader_wrapper.py
  159. OWNERS
  160. owners_client.py
  161. owners_finder.py
  162. pinpoint
  163. pinpoint.bat
  164. post_build_ninja_summary.py
  165. PRESUBMIT.py
  166. presubmit_canned_checks.py
  167. presubmit_diff.py
  168. presubmit_support.py
  169. prpc
  170. prpc.bat
  171. pylint-2.17
  172. pylint-2.17.bat
  173. pylint-2.6
  174. pylint-2.6.bat
  175. pylint-2.7
  176. pylint-2.7.bat
  177. pylint_main.py
  178. pylintrc
  179. pylintrc-2.17
  180. python_runner.sh
  181. rdb
  182. rdb.bat
  183. rdb_wrapper.py
  184. README.gclient.md
  185. README.git-cl.md
  186. README.md
  187. reclient_helper.py
  188. reclient_metrics
  189. reclient_metrics.bat
  190. reclient_metrics.py
  191. reclient_metrics.README.md
  192. RECLIENT_OWNERS
  193. reclientreport
  194. reclientreport.bat
  195. reclientreport.py
  196. repo
  197. repo_launcher
  198. roll-dep
  199. roll-dep.bat
  200. roll_dep.py
  201. rustfmt.py
  202. scm.py
  203. setup_color.py
  204. siso
  205. siso.bat
  206. siso.py
  207. split_cl.py
  208. subcommand.py
  209. subprocess2.py
  210. swift-format
  211. swift_format.py
  212. update_depot_tools
  213. update_depot_tools.bat
  214. update_depot_tools_toggle.py
  215. upload_metrics.py
  216. upload_to_google_storage.py
  217. upload_to_google_storage_first_class.py
  218. utils.py
  219. vpython3
  220. vpython3.bat
  221. WATCHLISTS
  222. watchlists.py
  223. whitespace.txt
  224. win32imports.py
  225. yapf
  226. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.