| commit | c4c3d5326e05fb339219e2eb2274f82032c293c7 | [log] [tgz] |
|---|---|---|
| author | Robert Iannucci <iannucci@chromium.org> | Fri Jun 21 21:54:38 2024 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 21 21:54:38 2024 |
| tree | 849f0d58c4d0c11c102a9f128ffe76bddb077155 | |
| parent | 47a841a204af658aa82e38479aa1fdd316c38785 [diff] |
[gerrit_util] Add some additional tests and fixes for SSOAuthenticator. Unfortunately, the depot_tools presubmit builders are incredibly slow which make the subprocess based tests fail flakily. I've marked them all as `skip` with an optional way to run them locally. R=ayatane, yiwzhang Bug: b/335483238 Change-Id: I407aed3a1ed01563a0a80973b679aca405b9cde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5641259 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Tools for working with Chromium development. It requires python 3.8.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.