3987: bot_update: only add input commit refs for gclient solution roots.

Bug: 1031805
Tbr: agable@chromium.org
Change-Id: I6edd221900eadd4d621d6190e08b61fdbc2f8621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1958706
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
(cherry picked from commit e9aeaee522332ff7075529cc4bf2c81f5ade3318)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1959693
Reviewed-by: John Budorick <jbudorick@chromium.org>
3 files changed
tree: 91efbd719ad7a087278c40597c23923de323e187
  1. .gitattributes
  2. .gitignore
  3. .style.yapf
  4. .vpython
  5. .vpython3
  6. CROS_OWNERS
  7. LICENSE
  8. OWNERS
  9. PRESUBMIT.py
  10. README.gclient.md
  11. README.git-cl.md
  12. README.md
  13. WATCHLISTS
  14. auth.py
  15. autoninja
  16. autoninja.bat
  17. autoninja.py
  18. bb
  19. bb.bat
  20. bootstrap/
  21. bootstrap_python3
  22. breakpad.py
  23. cipd
  24. cipd.bat
  25. cipd.ps1
  26. cipd_bin_setup.bat
  27. cipd_bin_setup.sh
  28. cipd_client_version
  29. cipd_client_version.digests
  30. cipd_manifest.txt
  31. cipd_manifest.versions
  32. cit
  33. cit.bat
  34. cit.py
  35. clang-format
  36. clang-format.bat
  37. clang_format.py
  38. clang_format_merge_driver
  39. clang_format_merge_driver.bat
  40. clang_format_merge_driver.py
  41. codereview.settings
  42. compile_single_file
  43. compile_single_file.bat
  44. compile_single_file.py
  45. cpplint.bat
  46. cpplint.py
  47. cpplint_chromium.py
  48. cros
  49. crosjobs
  50. dart_format.py
  51. detect_host_arch.py
  52. download_from_google_storage
  53. download_from_google_storage.bat
  54. download_from_google_storage.py
  55. ensure_bootstrap
  56. fetch
  57. fetch.bat
  58. fetch.py
  59. fetch_configs/
  60. fix_encoding.py
  61. gclient
  62. gclient-new-workdir.py
  63. gclient.bat
  64. gclient.py
  65. gclient_completion.sh
  66. gclient_eval.py
  67. gclient_paths.py
  68. gclient_scm.py
  69. gclient_utils.py
  70. gerrit_client.py
  71. gerrit_util.py
  72. git-cache
  73. git-cl
  74. git-crrev-parse
  75. git-drover
  76. git-find-releases
  77. git-footers
  78. git-freeze
  79. git-gs
  80. git-hyper-blame
  81. git-map
  82. git-map-branches
  83. git-mark-merge-base
  84. git-nav-downstream
  85. git-nav-upstream
  86. git-new-branch
  87. git-number
  88. git-rebase-update
  89. git-rename-branch
  90. git-reparent-branch
  91. git-retry
  92. git-runhooks
  93. git-squash-branch
  94. git-templates/
  95. git-thaw
  96. git-upstream-diff
  97. git_cache.py
  98. git_cl.py
  99. git_cl_completion.sh
  100. git_common.py
  101. git_dates.py
  102. git_drover.py
  103. git_find_releases.py
  104. git_footers.py
  105. git_freezer.py
  106. git_hyper_blame.py
  107. git_map.py
  108. git_map_branches.py
  109. git_mark_merge_base.py
  110. git_nav_downstream.py
  111. git_new_branch.py
  112. git_number.py
  113. git_rebase_update.py
  114. git_rename_branch.py
  115. git_reparent_branch.py
  116. git_retry.py
  117. git_squash_branch.py
  118. git_upstream_diff.py
  119. gn
  120. gn.bat
  121. gn.py
  122. goma_auth
  123. goma_auth.bat
  124. goma_ctl
  125. goma_ctl.bat
  126. gsutil.py
  127. gsutil.py.bat
  128. gsutil.vpython
  129. infra/
  130. led
  131. led.bat
  132. luci-auth
  133. luci-auth.bat
  134. lucicfg
  135. lucicfg.bat
  136. mac_toolchain
  137. man/
  138. metrics.README.md
  139. metrics.py
  140. metrics_utils.py
  141. my_activity.py
  142. ninja
  143. ninja-linux32
  144. ninja-linux64
  145. ninja-mac
  146. ninja.exe
  147. ninjalog.README.md
  148. ninjalog_uploader.py
  149. ninjalog_uploader_wrapper.py
  150. owners.py
  151. owners_finder.py
  152. post_build_ninja_summary.py
  153. presubmit_canned_checks.py
  154. presubmit_support.py
  155. profile.xml
  156. prpc
  157. prpc.bat
  158. pylint
  159. pylint-1.5
  160. pylint-1.6
  161. pylint-1.7
  162. pylint-1.8
  163. pylint-1.9
  164. pylint.bat
  165. pylint_main.py
  166. pylintrc
  167. python-bin/
  168. python_runner.sh
  169. recipes/
  170. repo
  171. roll-dep
  172. roll-dep-svn
  173. roll-dep-svn.bat
  174. roll-dep.bat
  175. roll_dep.py
  176. roll_dep_svn.py
  177. scm.py
  178. setup_color.py
  179. split_cl.py
  180. subcommand.py
  181. subprocess2.py
  182. testing_support/
  183. tests/
  184. third_party/
  185. update_depot_tools
  186. update_depot_tools.bat
  187. update_depot_tools_toggle.py
  188. upload_metrics.py
  189. upload_to_google_storage.py
  190. vpython
  191. vpython.bat
  192. vpython3
  193. vpython3.bat
  194. watchlists.py
  195. weekly
  196. win_toolchain/
  197. wtf
  198. yapf
  199. yapf.bat
  200. zsh-goodies/
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.