commit | 0ba2fd429dd6db431fcbee6995c1278d2a3657a0 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Thu Jul 21 13:47:21 2022 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 21 13:47:21 2022 |
tree | 7bf438dad290493be21151b4b782961e10e9f483 | |
parent | 39e33e6eca3fe1aa53a77f8185226f54f1cb2b7c [diff] |
Get full paths in presubmit traceback stacks When investigating presubmits it is sometimes handy to get stacks in order to understand where a presubmit is being called from. In one recent investigation to see why CheckOwners was being called multiple times the traceback just said: File "c:\src\depot_tools\presubmit_support.py", line 1646, in _run_check_function result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "PRESUBMIT.py", line 251, in CheckChangeOnUpload That's not very helpful because Chromium has 288 files named PRESUBMIT.py. This change just uses the actual presubmit path as the filename parameter to compile instead of a hard-coded string, which means that "PRESUBMIT.py" is replaced with the full path in the tracebacks. Bug: 1309977 Change-Id: Icacfae4399444cb24e9cfb07475b90099e2e18d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3776955 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.