| commit | 28a7eef132ebc27663ffbd801844a15bd2ff2856 | [log] [tgz] |
|---|---|---|
| author | Junji Watanabe <jwata@google.com> | Mon Jul 22 04:12:27 2024 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 22 04:12:27 2024 |
| tree | 8403c4719e689b53d4fe16541382b8519f4dec57 | |
| parent | cdcdd6efeec145eb246eeac20c78f2c55c9d393e [diff] |
ninjalog: Store last uploaded .ninja_log mtime The current logic checks if the mtime of .ninja_log is 2s older or not to avoid duplicated uploads. This is problematic if post process takes longer than 2s. e.g. Siso and/or Reclient's post process. This CL changes the logic to store the last uploaded mtime as `.ninja_log.last_upload` file. Bug: 353644846 Fixed: 353644846 Change-Id: I7fb82e43808476174644c50d97e984358a43409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5724768 Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Tools for working with Chromium development. It requires python 3.8.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.