)]}' { "commit": "31a486419e279333146ca1e75fcffd510a863d30", "tree": "43e7cb418240626d121c99c50e527c155809c9f4", "parents": [ "36248fcd635b13c751d11e6722072bed2d57cb8a" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 11 16:10:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Jan 11 16:10:59 2019" }, "message": "Improve no-long-lines check for Python files.\n\nThe previous implementation of CheckLongLines did not\nhandle global pylint disable/enable directives properly,\ni.e. the difference between:\n\n # pylint: disable\u003dline-too-long\n .... checks disabled for all lines here.\n # pylint: enable\u003dline-too-long\n\nversus:\n\n # Check only disabled for the line below\n some python statements # pylint: disable\u003dline-too-long\n\nThis CL changes the implementation to support Python files\nproperly. Note that in order to not disturb the mock-based\nunit-tests, a new function is introduced to be able to\nfilter the list of affected files based on their file\nextension.\n\nBUG\u003d890734\nR\u003dmattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org\n\nChange-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201\nReviewed-on: https://chromium-review.googlesource.com/c/1396094\nReviewed-by: Edward Lesmes \u003cehmaldonado@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "310f8324826de07d24ffdd092fe718b3f20d2d45", "old_mode": 33188, "old_path": "presubmit_canned_checks.py", "new_id": "a442459c152e506ce154dfd24b87948ebe06423d", "new_mode": 33188, "new_path": "presubmit_canned_checks.py" }, { "type": "modify", "old_id": "964720a832b1adf2b4d39cdd5ea82b7e1720e9ec", "old_mode": 33261, "old_path": "tests/presubmit_unittest.py", "new_id": "d535e48abc5de9c2981390430205982f8e2c119d", "new_mode": 33261, "new_path": "tests/presubmit_unittest.py" } ] }