commit | 3b1e64245a0b29d8352d28a3c442482bcb5f2889 | [log] [tgz] |
---|---|---|
author | John Budorick <jbudorick@chromium.org> | Wed Feb 13 22:06:19 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 13 22:06:19 2019 |
tree | e144a6281855809a932c56bd624f77f645ff51bc | |
parent | ae2acf7bf9979c062eff118a60438968406d4ea4 [diff] |
presubmit: use depot_tools.on_path rather than a handrolled equivalent. Noticed this while attempting to debug issues with the src-internal-presubmit builder. Not sure if this is the cause but would like to at least rule it out. Bug: 925774 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: release_scripts Change-Id: I323f49e23d2c8af11b374e22ebfbcf5bcd836ba3 Reviewed-on: https://chromium-review.googlesource.com/c/1464049 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.