commit | 8de3800ce55ba459ffcbedcfa52ef5e6e59caab6 | [log] [tgz] |
---|---|---|
author | Vadim Bendebury <vbendeb@chromium.org> | Tue May 15 02:02:55 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 15 18:55:05 2018 |
tree | cf961336ee69e3db58308b0f352641616a46bb22 | |
parent | cbf0204555fe07fda96d20456e03f105e2922005 [diff] |
print access errors separately When user invoking 'my_activity.py' does not have an account on one or more of the servers the utility queries, access errors are reported interleaving with access progress report printouts, this creates a messy looking output. With this patch access error messages are accumulated in a set and then, if there are any, get printed out separately. TEST=verified that error messages are printed neatly after servers queries finished running: > my_activity.py -u xxxyyzz Loading data................................. Access Errors: Looking up 'pdfium-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'android-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'chrome-internal-review.googlesource.com': Bad Request: User xxxyyzz not found Looking up 'chromium-review.googlesource.com': Bad Request: User xxxyyzz not found Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: Ie9f41110becb67936f49095ff36a8eeaa7a4f114 Reviewed-on: https://chromium-review.googlesource.com/1058722 Reviewed-by: Aaron Gable <agable@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.