commit | 164952a1796bbd2633200894bd91ebd83f1d0197 | [log] [tgz] |
---|---|---|
author | Quinten Yearsley <qyearsley@chromium.org> | Tue Jul 19 23:27:50 2022 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 19 23:27:50 2022 |
tree | 7977ebf12c3e726a0b6dc6ab2485d103ad4913f9 | |
parent | 9585c9379667d354c87b53e63d9c09f13152a3ce [diff] |
Revert "Update lucicfg from version 1.31.5 to 1.31.6" This reverts commit f05fcf7051e12e5b561b8811e299096f332157f7. Reason for revert: Reason for revert: I realized it's not yet safe to support directly specifying only location_filters because legacy CQ still triggers tryjobs and doesn't handle location_filters. Original change's description: > Update lucicfg from version 1.31.5 to 1.31.6 > > Changes: > - Allow direct use of location_filters in luci.cq_tryjob_verifier(...) > > Bug: 1171945 > Change-Id: I0aca6dd01976c66f106906958bc63a81dbd5e6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3770293 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Bug: 1171945 Change-Id: Ic7bea4b2ae73413361f8c239e0d6b823c1e7fd8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3774528 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Quinten Yearsley <qyearsley@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.