subprocess2: cache the string-escape codec at load time.

This is a speculative fix for subprocess being unable to find
string-escape later in execution; the theory being that something
(unclear what) is interfering w/ codecs' lookup logic and that calling
lookup earlier would allow string-escape to be cached before any such
interference. See crbug.com/912292#c2 for more.

Bug: 912292
Change-Id: I0abdd394253c9a4984db7c6c81d044087edc68fd
Reviewed-on: https://chromium-review.googlesource.com/c/1363753
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
1 file changed
tree: 893343800a116772478ebc581267af77f45f893a
  1. .gitattributes
  2. .gitignore
  3. .style.yapf
  4. LICENSE
  5. OWNERS
  6. PRESUBMIT.py
  7. README.gclient.md
  8. README.git-cl.md
  9. README.md
  10. README.testing
  11. WATCHLISTS
  12. annotated_gclient.py
  13. appengine_mapper.py
  14. auth.py
  15. autoninja
  16. autoninja.bat
  17. autoninja.py
  18. bootstrap/
  19. breakpad.py
  20. buildbucket.py
  21. checkout.py
  22. cipd
  23. cipd.bat
  24. cipd.ps1
  25. cipd_bin_setup.bat
  26. cipd_bin_setup.sh
  27. cipd_client_version
  28. cipd_client_version.digests
  29. cipd_manifest.txt
  30. cipd_manifest.versions
  31. cit
  32. cit.bat
  33. cit.py
  34. clang-format
  35. clang-format.bat
  36. clang_format.py
  37. clang_format_merge_driver
  38. clang_format_merge_driver.bat
  39. clang_format_merge_driver.py
  40. codereview.settings
  41. compile_single_file
  42. compile_single_file.bat
  43. compile_single_file.py
  44. cpplint.bat
  45. cpplint.py
  46. cpplint_chromium.py
  47. dart_format.py
  48. depot-tools-auth
  49. depot-tools-auth.bat
  50. depot-tools-auth.py
  51. detect_host_arch.py
  52. download_from_google_storage
  53. download_from_google_storage.bat
  54. download_from_google_storage.py
  55. ensure_bootstrap
  56. fetch
  57. fetch.bat
  58. fetch.py
  59. fetch_configs/
  60. fix_encoding.py
  61. gclient
  62. gclient-new-workdir.py
  63. gclient.bat
  64. gclient.py
  65. gclient_completion.sh
  66. gclient_eval.py
  67. gclient_scm.py
  68. gclient_utils.py
  69. gerrit_client.py
  70. gerrit_util.py
  71. git-cache
  72. git-cl
  73. git-crrev-parse
  74. git-drover
  75. git-find-releases
  76. git-footers
  77. git-freeze
  78. git-gs
  79. git-hyper-blame
  80. git-map
  81. git-map-branches
  82. git-mark-merge-base
  83. git-nav-downstream
  84. git-nav-upstream
  85. git-new-branch
  86. git-number
  87. git-rebase-update
  88. git-rename-branch
  89. git-reparent-branch
  90. git-retry
  91. git-runhooks
  92. git-squash-branch
  93. git-templates/
  94. git-thaw
  95. git-upstream-diff
  96. git_cache.py
  97. git_cl.py
  98. git_cl_completion.sh
  99. git_common.py
  100. git_dates.py
  101. git_drover.py
  102. git_find_releases.py
  103. git_footers.py
  104. git_freezer.py
  105. git_hyper_blame.py
  106. git_map.py
  107. git_map_branches.py
  108. git_mark_merge_base.py
  109. git_nav_downstream.py
  110. git_new_branch.py
  111. git_number.py
  112. git_rebase_update.py
  113. git_rename_branch.py
  114. git_reparent_branch.py
  115. git_retry.py
  116. git_squash_branch.py
  117. git_upstream_diff.py
  118. gn
  119. gn.bat
  120. gn.py
  121. gsutil.py
  122. gsutil.vpython
  123. infra/
  124. led
  125. led.bat
  126. luci-auth
  127. luci-auth.bat
  128. mac_toolchain
  129. man/
  130. metrics.README.md
  131. metrics.py
  132. metrics_utils.py
  133. my_activity.py
  134. my_reviews.py
  135. ninja
  136. ninja-linux32
  137. ninja-linux64
  138. ninja-mac
  139. ninja.exe
  140. ninjalog_uploader.py
  141. ninjalog_uploader_wrapper.py
  142. owners.py
  143. owners_finder.py
  144. patch.py
  145. post_build_ninja_summary.py
  146. presubmit_canned_checks.py
  147. presubmit_support.py
  148. profile.xml
  149. prpc
  150. prpc.bat
  151. pylint
  152. pylint.py
  153. pylintrc
  154. python_runner.sh
  155. recipes/
  156. repo
  157. rietveld.py
  158. roll-dep
  159. roll-dep-svn
  160. roll-dep-svn.bat
  161. roll-dep.bat
  162. roll_dep.py
  163. roll_dep_svn.py
  164. scm.py
  165. setup_color.py
  166. split_cl.py
  167. subcommand.py
  168. subprocess2.py
  169. support/
  170. testing_support/
  171. tests/
  172. third_party/
  173. update_depot_tools
  174. update_depot_tools.bat
  175. update_depot_tools_toggle.py
  176. upload_metrics.py
  177. upload_to_google_storage.py
  178. vpython
  179. vpython.bat
  180. watchlists.py
  181. weekly
  182. win_toolchain/
  183. wtf
  184. yapf
  185. yapf.bat
  186. zsh-goodies/
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.