commit | 9c0620120980e4c247ff8325ee8bbdcd4d9576e0 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Thu May 02 19:20:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 02 19:20:28 2019 |
tree | ed9e0d004f8503703af0423c16b1cb9b5bf477c7 | |
parent | 0647cd502cea650b29b33c0082dcc5c836eb2c39 [diff] |
Fix multiple confusingly escaped regex strings Python (prior to 3.8) treats meaningless string escape sequences as if they were a slash followed by the character. That is, '\w' == '\\w'. Python 3.8 rejects this, and it's confusing. This change fixes seven of these regex strings found in depot_tools (through a regex search, natch). Most of the fixes don't actually change the value of the strings, and this was manually verified: >>> '(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$' == r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$' True >>> '#\s*OWNERS_STATUS\s+=\s+(.+)$' == r'#\s*OWNERS_STATUS\s+=\s+(.+)$' True >>> 'COM\d' == r'COM\d' True >>> '^\s+Change-Id:\s*(\S+)$' == r'^\s+Change-Id:\s*(\S+)$' True >>> 'ETag:\s+([a-z0-9]{32})' == r'ETag:\s+([a-z0-9]{32})' True Two exceptions were the regex expressions in filter_demo_output.py and scm.py. These were turned into raw strings despite this changing the value of the string passed to re. This works because re supports the \x, \d, \w, \t, and other escape sequences needed to make this work. TL;DR - use raw strings for regex to avoid melting your brain. If bulk changing regex strings to raw watch out for double-slashes. Bug: 958138 Change-Id: Ic45264cfc63e8bae9cfcffe2cd88a57c2d3dcdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1590534 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.