Google Git
Sign in
chromium / chromium / tools / depot_tools / c341d58921ab188e4edacce04a221559bce86e8d
commitc341d58921ab188e4edacce04a221559bce86e8d[log] [tgz]
authorJoanna Wang <jojwang@google.com>Mon Jan 22 16:47:55 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 22 16:47:55 2024
tree9ddcd0b2842100a216161bf307bff1f5ae3d66b3
parent46cb7d0aca592cd20ddc2f6cb16ee386b2abbf0d [diff]
Include submodules when looking for PRESUBMIT files.

Bug: 1475770
Change-Id: I3a4b10a8dc68db9f0507bb3cefa62d233df53b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5219691
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
1 file changed
tree: 9ddcd0b2842100a216161bf307bff1f5ae3d66b3
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. hooks/
  5. infra/
  6. man/
  7. metadata/
  8. python-bin/
  9. python2-bin/
  10. recipes/
  11. testing_support/
  12. tests/
  13. third_party/
  14. win_toolchain/
  15. zsh-goodies/
  16. bazel ⇨ bazel.py
  17. cbuildbot ⇨ cros
  18. cros_sdk ⇨ cros
  19. gerrit ⇨ cros
  20. .cipd_impl.ps1
  21. .flake8
  22. .gitattributes
  23. .gitignore
  24. .isort.cfg
  25. .style.yapf
  26. .vpython
  27. .vpython3
  28. auth.py
  29. autoninja
  30. autoninja.bat
  31. autoninja.py
  32. autosiso
  33. autosiso.bat
  34. autosiso.py
  35. bazel.py
  36. bb
  37. bb.bat
  38. black
  39. bootstrap_python3
  40. breakpad.py
  41. BUILD_OWNERS
  42. cipd
  43. cipd.bat
  44. cipd_bin_setup.bat
  45. cipd_bin_setup.sh
  46. cipd_client_version
  47. cipd_client_version.digests
  48. cipd_manifest.txt
  49. cipd_manifest.versions
  50. cipd_manifest_cros_python2.txt
  51. cipd_manifest_cros_python2.versions
  52. clang-format
  53. clang-format.bat
  54. clang_format.py
  55. codereview.settings
  56. compile_single_file
  57. compile_single_file.bat
  58. compile_single_file.py
  59. cpplint.bat
  60. cpplint.py
  61. cpplint_chromium.py
  62. cros
  63. CROS_OWNERS
  64. cros_python2.vpython
  65. crosjobs
  66. detect_host_arch.py
  67. DIR_METADATA
  68. dirmd
  69. dirmd.bat
  70. download_from_google_storage
  71. download_from_google_storage.bat
  72. download_from_google_storage.py
  73. ensure_bootstrap
  74. fetch
  75. fetch.bat
  76. fetch.py
  77. fix_encoding.py
  78. gclient
  79. gclient-new-workdir.py
  80. gclient.bat
  81. gclient.py
  82. gclient_completion.sh
  83. gclient_eval.py
  84. gclient_paths.py
  85. gclient_scm.py
  86. gclient_utils.py
  87. gerrit_client.py
  88. gerrit_util.py
  89. git-cache
  90. git-cl
  91. git-crrev-parse
  92. git-drover
  93. git-find-releases
  94. git-footers
  95. git-freeze
  96. git-gs
  97. git-hyper-blame
  98. git-map
  99. git-map-branches
  100. git-mark-merge-base
  101. git-migrate-default-branch
  102. git-nav-downstream
  103. git-nav-upstream
  104. git-new-branch
  105. git-number
  106. git-rebase-update
  107. git-rename-branch
  108. git-reparent-branch
  109. git-retry
  110. git-runhooks
  111. git-squash-branch
  112. git-thaw
  113. git-upstream-diff
  114. git_cache.py
  115. git_cl.py
  116. git_cl_completion.sh
  117. git_common.py
  118. git_completion.sh
  119. git_dates.py
  120. git_find_releases.py
  121. git_footers.py
  122. git_freezer.py
  123. git_hyper_blame.py
  124. git_map.py
  125. git_map_branches.py
  126. git_mark_merge_base.py
  127. git_migrate_default_branch.py
  128. git_nav_downstream.py
  129. git_new_branch.py
  130. git_number.py
  131. git_rebase_update.py
  132. git_rename_branch.py
  133. git_reparent_branch.py
  134. git_retry.py
  135. git_squash_branch.py
  136. git_upstream_diff.py
  137. gn
  138. gn.bat
  139. gn.py
  140. goma_auth
  141. goma_auth.bat
  142. goma_ctl
  143. goma_ctl.bat
  144. gsutil.py
  145. gsutil.py.bat
  146. gsutil.vpython3
  147. infra_to_superproject
  148. infra_to_superproject.bat
  149. infra_to_superproject.py
  150. isort
  151. led
  152. led.bat
  153. LICENSE
  154. lockfile.py
  155. luci-auth
  156. luci-auth.bat
  157. LUCI_OWNERS
  158. lucicfg
  159. lucicfg.bat
  160. mac_toolchain
  161. metrics.py
  162. metrics.README.md
  163. metrics_utils.py
  164. my_activity.py
  165. ninja
  166. ninja.bat
  167. ninja.py
  168. ninja_reclient.py
  169. ninjalog.README.md
  170. ninjalog_uploader.py
  171. ninjalog_uploader_wrapper.py
  172. OWNERS
  173. owners_client.py
  174. owners_finder.py
  175. pinpoint
  176. pinpoint.bat
  177. post_build_ninja_summary.py
  178. PRESUBMIT.py
  179. presubmit_canned_checks.py
  180. presubmit_support.py
  181. profile.xml
  182. prpc
  183. prpc.bat
  184. pylint-2.17
  185. pylint-2.17.bat
  186. pylint-2.6
  187. pylint-2.6.bat
  188. pylint-2.7
  189. pylint-2.7.bat
  190. pylint_main.py
  191. pylintrc
  192. pylintrc-2.17
  193. python_runner.sh
  194. rdb
  195. rdb.bat
  196. rdb_wrapper.py
  197. README.gclient.md
  198. README.git-cl.md
  199. README.md
  200. reclient_helper.py
  201. reclient_metrics
  202. reclient_metrics.bat
  203. reclient_metrics.py
  204. reclient_metrics.README.md
  205. RECLIENT_OWNERS
  206. reclientreport
  207. reclientreport.bat
  208. reclientreport.py
  209. repo
  210. repo_launcher
  211. roll-dep
  212. roll-dep.bat
  213. roll_dep.py
  214. rustfmt.py
  215. scm.py
  216. setup_color.py
  217. siso
  218. siso.bat
  219. siso.py
  220. split_cl.py
  221. subcommand.py
  222. subprocess2.py
  223. swift-format
  224. swift_format.py
  225. update_depot_tools
  226. update_depot_tools.bat
  227. update_depot_tools_toggle.py
  228. upload_metrics.py
  229. upload_to_google_storage.py
  230. utils.py
  231. vpython
  232. vpython.bat
  233. vpython3
  234. vpython3.bat
  235. WATCHLISTS
  236. watchlists.py
  237. weekly
  238. whitespace.txt
  239. win32imports.py
  240. wtf
  241. yapf
  242. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.