Google Git
Sign in
chromium / chromium / tools / depot_tools / cece8f8061f7f81011707776e82d8e4ced3f3297
commitcece8f8061f7f81011707776e82d8e4ced3f3297[log] [tgz]
authorJacek Dobrowolski <jadobrowolski@google.com>Fri Jul 18 08:44:06 2025
committerJacek Dobrowolski <jadobrowolski@google.com>Fri Jul 18 08:44:06 2025
tree6c0c2432d6d1f444633f9fc5559f4f4e73da4f37
parente1e23c1e27de1b7e7c74986ae35838b5d5c00866 [diff]
Fix setbotcommit comment on ambiguous revision

Add revision number option to gerrit_client.py setbotcommit command. Add
an explicit revision number to a setbotcommit call in the update_files
method.

After creating a new patch-set in the release recipe and verifying it
was created we are adding a comment which could be applied to the
previous patch. Setting `Bot-Commit+1` relied on the default 'current'
revision which may be stale in some Gerrit replicas. This CL applies the
fix suggested in 412739202

Bug: 414681998
Change-Id: I1d380e221864bcf1183c77fa58be4ede9a787ef1
Recipe-Nontrivial-Roll: build_internal
Recipe-Nontrivial-Roll: chrome_release
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6718447
Reviewed-by: Alex Kravchuk <alexanderkr@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
3 files changed
tree: 6c0c2432d6d1f444633f9fc5559f4f4e73da4f37
  1. bootstrap/
  2. fetch_configs/
  3. hooks/
  4. infra/
  5. infra_lib/
  6. man/
  7. metadata/
  8. python-bin/
  9. python2-bin/
  10. recipes/
  11. testing_support/
  12. tests/
  13. third_party/
  14. win_toolchain/
  15. zsh-goodies/
  16. bazel ⇨ bazel.py
  17. cbuildbot ⇨ cros
  18. cros_sdk ⇨ cros
  19. gerrit ⇨ cros
  20. .cipd_impl.ps1
  21. .flake8
  22. .git-blame-ignore-revs
  23. .gitattributes
  24. .gitignore
  25. .isort.cfg
  26. .style.yapf
  27. .vpython3
  28. android_build_server_helper.py
  29. auth.py
  30. autoninja
  31. autoninja.bat
  32. autoninja.py
  33. bazel.py
  34. bb
  35. bb.bat
  36. black
  37. bootstrap_python3
  38. breakpad.py
  39. BUILD_OWNERS
  40. build_telemetry
  41. build_telemetry.bat
  42. build_telemetry.py
  43. caffeinate.py
  44. cipd
  45. cipd.bat
  46. cipd_bin_setup.bat
  47. cipd_bin_setup.sh
  48. cipd_client_version
  49. cipd_client_version.digests
  50. cipd_manifest.txt
  51. cipd_manifest.versions
  52. cipd_manifest_cros_python2.txt
  53. cipd_manifest_cros_python2.versions
  54. clang-format
  55. clang-format.bat
  56. clang_format.py
  57. codereview.settings
  58. compile_single_file
  59. compile_single_file.bat
  60. compile_single_file.py
  61. cpplint.bat
  62. cpplint.py
  63. cpplint_chromium.py
  64. cros
  65. CROS_OWNERS
  66. cros_python2.vpython
  67. detect_host_arch.py
  68. DIR_METADATA
  69. dirmd
  70. dirmd.bat
  71. download_from_google_storage
  72. download_from_google_storage.bat
  73. download_from_google_storage.py
  74. ensure_bootstrap
  75. fetch
  76. fetch.bat
  77. fetch.py
  78. gclient
  79. gclient-new-workdir.py
  80. gclient.bat
  81. gclient.py
  82. gclient_completion.sh
  83. gclient_eval.py
  84. gclient_paths.py
  85. gclient_scm.py
  86. gclient_utils.py
  87. gerrit_client.py
  88. gerrit_util.py
  89. git-cache
  90. git-cl
  91. git-credential-luci
  92. git-credential-luci.bat
  93. git-crrev-parse
  94. git-drover
  95. git-find-releases
  96. git-footers
  97. git-freeze
  98. git-gs
  99. git-hyper-blame
  100. git-map
  101. git-map-branches
  102. git-mark-merge-base
  103. git-nav-downstream
  104. git-nav-upstream
  105. git-new-branch
  106. git-number
  107. git-rebase-update
  108. git-rename-branch
  109. git-reparent-branch
  110. git-retry
  111. git-runhooks
  112. git-squash-branch
  113. git-squash-branch-tree
  114. git-thaw
  115. git-upstream-diff
  116. git_auth.py
  117. git_cache.py
  118. git_cl.py
  119. git_cl_completion.sh
  120. git_common.py
  121. git_completion.sh
  122. git_dates.py
  123. git_find_releases.py
  124. git_footers.py
  125. git_freezer.py
  126. git_hyper_blame.py
  127. git_map.py
  128. git_map_branches.py
  129. git_mark_merge_base.py
  130. git_nav_downstream.py
  131. git_new_branch.py
  132. git_number.py
  133. git_rebase_update.py
  134. git_rename_branch.py
  135. git_reparent_branch.py
  136. git_retry.py
  137. git_squash_branch.py
  138. git_squash_branch_tree.py
  139. git_upstream_diff.py
  140. gn
  141. gn.bat
  142. gn.py
  143. gn_helper.py
  144. google-java-format
  145. google-java-format.bat
  146. google_java_format.py
  147. gsutil.py
  148. gsutil.py.bat
  149. gsutil.vpython3
  150. isort
  151. led
  152. led.bat
  153. LICENSE
  154. lockfile.py
  155. luci-auth
  156. luci-auth.bat
  157. LUCI_OWNERS
  158. lucicfg
  159. lucicfg.bat
  160. mac_toolchain
  161. metrics-xml-format
  162. metrics.py
  163. metrics.README.md
  164. metrics_utils.py
  165. metrics_xml_format.py
  166. my_activity.py
  167. newauth.py
  168. ninja
  169. ninja.bat
  170. ninja.py
  171. ninjalog_uploader.py
  172. OWNERS
  173. owners_client.py
  174. owners_finder.py
  175. pinpoint
  176. pinpoint.bat
  177. post_build_ninja_summary.py
  178. PRESUBMIT.py
  179. presubmit_canned_checks.py
  180. presubmit_diff.py
  181. presubmit_support.py
  182. prpc
  183. prpc.bat
  184. pylint-2.17
  185. pylint-2.17.bat
  186. pylint-2.6
  187. pylint-2.6.bat
  188. pylint-2.7
  189. pylint-2.7.bat
  190. pylint-3.2
  191. pylint-3.2.bat
  192. pylint_main.py
  193. pylintrc-2.17
  194. pylintrc-2.6
  195. pylintrc-2.7
  196. pylintrc-3.2
  197. python_runner.sh
  198. rdb
  199. rdb.bat
  200. rdb_wrapper.py
  201. README.gclient.md
  202. README.git-cl.md
  203. README.google_cloud_storage.md
  204. README.md
  205. reclient_helper.py
  206. RECLIENT_OWNERS
  207. reclientreport
  208. reclientreport.bat
  209. reclientreport.py
  210. repo
  211. repo_launcher
  212. roll-dep
  213. roll-dep.bat
  214. roll_dep.py
  215. roll_downstream_gcs_deps.py
  216. rustfmt.py
  217. scm.py
  218. setup_color.py
  219. siso
  220. siso.bat
  221. siso.py
  222. split_cl.py
  223. subcommand.py
  224. subprocess2.py
  225. swift-format
  226. swift_format.py
  227. update_depot_tools
  228. update_depot_tools.bat
  229. update_depot_tools_toggle.py
  230. upload_metrics.py
  231. upload_to_google_storage.py
  232. upload_to_google_storage_first_class.py
  233. utils.py
  234. vpython3
  235. vpython3.bat
  236. WATCHLISTS
  237. watchlists.py
  238. whitespace.txt
  239. win32imports.py
  240. yapf
  241. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Also, includes shell script/batch file for tools required to build chromium, e.g.

  • gn: a meta-build system that generates build files for Ninja
  • autoninja: a wrapper for siso and ninja.
  • siso: a build tool that aims to significantly speed up Chromium's build.
  • ninja: a small build system with a focus on speed. deprecated by Siso.

These shell script/batch file runs python script with python-bin/python3 that find binaries in chromium checkout, and run with proper setup/check. To use these wrappers, you need to initialize/bootstrap depot_tools (using gclient, update_depot_tools or ensure_bootstrap).

Installing

See set-up documentation.

depot_tools is also available in

These depot_tools would not be initialized/bootstrapped (i.e. no python-bin/python3 binary available), so the build tool wrapper won't work, unless it is explicitly initialized by ensure_bootstrap. Or, directly call the python script instead of using the shell script/batch file.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

Running gclient will install python3 binary.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.