| commit | eb8426e2ac6e8b03837a8d093863008fbec79860 | [log] [tgz] |
|---|---|---|
| author | Bruce Dawson <brucedawson@chromium.org> | Fri Aug 05 23:58:15 2022 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Aug 05 23:58:15 2022 |
| tree | 4514ba17ae4ccf4a3e55536b94eedfea9f6a9a8f | |
| parent | 079e79600cffee6428db78810578611cf36863fc [diff] |
Improve presubmit no-network handling Recent gerrit issues made it obvious that "git cl presubmit" relies on gerrit much more than most people would expect (the expectation is zero for many people). This makes presubmits flaky or much slower under poor network conditions, and it means that the presubmit step may drastically underestimate how long it takes to run because of a cl.FetchDescription() that may occur outside of the timed portion of the presubmits. This change wraps more network-touching steps in try/except blocks, to make them robust. It also gets them to check for the existence of a PRESUBMIT_SKIP_NETWORK environment variable. And, it prints the elapsed time to get the CL description if this is inordinately long. Bug: 1350227 Change-Id: I7954fd50e928fd24975a4f61a316cb280542ebbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3813095 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
The most important tools are:
fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.